devflow-kit 1.5.0 → 1.6.0

package/shared/skills/plan-orchestration/SKILL.md

@@ -0,0 +1,71 @@
+---
+name: plan-orchestration
+description: Agent orchestration for PLAN intent — codebase orientation, design exploration, gap validation
+user-invocable: false
+allowed-tools: Read, Grep, Glob, Bash, Task, AskUserQuestion
+---
+
+# Plan Orchestration
+
+Agent pipeline for PLAN intent in ambient ORCHESTRATED mode. Codebase orientation, targeted exploration, architecture design, and gap validation.
+
+This is a lightweight variant of the Plan phase in `/implement` for ambient ORCHESTRATED mode.
+
+## Iron Law
+
+> **PLANS WITHOUT CODEBASE GROUNDING ARE FANTASIES**
+>
+> Orient before architecting. Every design decision must reference existing patterns,
+> real file structures, and actual integration points. A plan that ignores the codebase
+> will fail on contact with implementation.
+
+---
+
+## Phase 1: Orient
+
+Spawn `Task(subagent_type="Skimmer")` to get codebase overview relevant to the planning question:
+
+- Existing patterns and conventions in the affected area
+- File structure and module boundaries
+- Test patterns and coverage approach
+- Related prior implementations (similar features, analogous patterns)
+
+## Phase 2: Explore
+
+Based on Skimmer findings, spawn 2-3 `Task(subagent_type="Explore")` agents **in a single message** (parallel execution):
+
+- **Integration explorer**: Examine integration points — APIs, shared types, module boundaries the plan must respect
+- **Pattern explorer**: Find existing implementations of similar features to follow as templates
+- **Constraint explorer**: Identify constraints — test infrastructure, build system, CI requirements, deployment concerns
+
+Adjust explorer focus based on the specific planning question.
+
+## Phase 3: Design
+
+Spawn `Task(subagent_type="Plan")` with combined Skimmer + Explore findings:
+
+- Design implementation approach with file-level specificity
+- Reference existing patterns discovered in Phase 1-2
+- Include: architecture decisions, file changes, new files needed, test strategy
+- Flag any areas where existing patterns conflict with the proposed approach
+
+## Phase 4: Validate
+
+Main session reviews the plan for:
+
+- **Gaps**: Missing files, unhandled edge cases, integration points not addressed
+- **Risks**: Areas where the plan deviates from existing patterns, potential regressions
+- **Ambiguities**: Design choices that need user input
+
+Present plan to user with identified risks. Use AskUserQuestion for any ambiguous design choices.
+
+## Output
+
+Structured plan ready to feed into IMPLEMENT/ORCHESTRATED if user proceeds:
+
+- Goal and scope
+- Architecture decisions with rationale
+- File-level change list (create/modify/delete)
+- Test strategy
+- Risks and mitigations
+- Open questions (if any)

package/shared/skills/test-driven-development/SKILL.md

@@ -91,7 +91,7 @@ See `references/rationalization-prevention.md` for extended examples with code.
 
 ## Process Enforcement
 
-When implementing any feature under ambient BUILD/GUIDED:
+When implementing any feature under ambient IMPLEMENT/GUIDED or IMPLEMENT/ORCHESTRATED:
 
 1. **Identify the first behavior** — What is the simplest thing this feature must do?
 2. **Write the test** — Describe that behavior as a failing test
@@ -130,7 +130,8 @@ When skipping TDD, never rationalize. State clearly: "Skipping TDD because: [spe
 
 ## Integration with Ambient Mode
 
-- **BUILD/GUIDED** → TDD enforced. Every new function/method gets test-first treatment.
-- **BUILD/QUICK** → TDD skipped (trivial single-file edit).
-- **BUILD/ELEVATE** → TDD mentioned in nudge toward `/implement`.
-- **DEBUG/GUIDED** → TDD applies to the fix: write a test that reproduces the bug first, then fix.
+- **IMPLEMENT/GUIDED** → TDD enforced in main session. Write the failing test before production code. Skill loaded directly.
+- **IMPLEMENT/ORCHESTRATED** → TDD enforced via Coder agent (skill in Coder frontmatter). Every implementation gets test-first treatment.
+- **IMPLEMENT/QUICK** → TDD skipped (trivial single-file edit).
+- **DEBUG/GUIDED** → TDD applies to the fix in main session: write a test that reproduces the bug first, then fix.
+- **DEBUG/ORCHESTRATED** → TDD applies to the fix: write a test that reproduces the bug first, then fix.

package/plugins/devflow-ambient/commands/ambient.md

@@ -1,110 +0,0 @@
----
-description: Ambient mode — classify intent and auto-load relevant skills for any prompt
----
-
-# Ambient Command
-
-Classify user intent and auto-load relevant skills. No agents spawned — enhances the main session only.
-
-## Usage
-
-```
-/ambient <prompt>           Classify and respond with skill enforcement
-/ambient                    Show usage
-```
-
-## Phases
-
-### Phase 1: Load Router
-
-Read the `ambient-router` skill:
-- `~/.claude/skills/ambient-router/SKILL.md`
-
-### Phase 2: Classify
-
-Apply the ambient-router classification to `$ARGUMENTS`:
-
-1. **Intent:** BUILD | DEBUG | REVIEW | PLAN | EXPLORE | CHAT
-2. **Depth:** QUICK | GUIDED | ELEVATE
-
-If no arguments provided, output:
-
-```
-## Ambient Mode
-
-Classify intent and auto-load relevant skills.
-
-Usage: /ambient <your prompt>
-
-Examples:
-  /ambient add a login form          → BUILD/GUIDED (loads TDD + implementation-patterns)
-  /ambient fix the auth error        → DEBUG/GUIDED (loads test-patterns + core-patterns)
-  /ambient where is the config?      → EXPLORE/QUICK (responds normally)
-  /ambient refactor the auth system  → BUILD/ELEVATE (suggests /implement)
-
-Always-on: devflow ambient --enable
-```
-
-Then stop.
-
-### Phase 3: State Classification
-
-- **QUICK:** Skip this phase entirely. Respond directly in Phase 4.
-- **GUIDED:** Output one line: `Ambient: {INTENT}/{DEPTH}. Loading: {skill1}, {skill2}.`
-- **ELEVATE:** Skip — recommendation happens in Phase 4.
-
-### Phase 4: Apply
-
-**QUICK:**
-Respond to the user's prompt normally. Zero skill loading. Zero overhead.
-
-**GUIDED:**
-Read the selected skills based on the ambient-router's skill selection matrix:
-
-| Intent | Primary Skills | Secondary (conditional) |
-|--------|---------------|------------------------|
-| BUILD | test-driven-development, implementation-patterns | typescript (.ts), react (.tsx), frontend-design (CSS/UI), input-validation (forms/API), security-patterns (auth/crypto) |
-| DEBUG | test-patterns, core-patterns | git-safety (if git ops) |
-| REVIEW | self-review, core-patterns | test-patterns |
-| PLAN | implementation-patterns | core-patterns |
-
-Read up to 3 skills from `~/.claude/skills/{name}/SKILL.md`. Apply their patterns and constraints when responding to the user's prompt.
-
-For BUILD intent: enforce RED-GREEN-REFACTOR from test-driven-development. Write failing tests before production code.
-
-**ELEVATE:**
-Respond to the user's prompt with your best effort, then append:
-
-> This task spans multiple files/systems. Consider `/implement` for full lifecycle management (exploration → planning → implementation → review).
-
-## Architecture
-
-```
-/ambient <prompt> (main session, no agents)
-│
-├─ Phase 1: Load ambient-router skill
-├─ Phase 2: Classify intent + depth
-├─ Phase 3: State classification (GUIDED only)
-└─ Phase 4: Apply
-   ├─ QUICK → respond directly
-   ├─ GUIDED → load 2-3 skills, apply patterns, respond
-   └─ ELEVATE → respond + workflow nudge
-```
-
-## Edge Cases
-
-| Case | Handling |
-|------|----------|
-| No arguments | Show usage and stop |
-| Single word ("help") | Classify — likely CHAT/QUICK |
-| Prompt references `/implement` etc. | Classify as normal — user chose /ambient intentionally |
-| Mixed intent ("fix and add test") | Use higher-overhead intent (BUILD > DEBUG) |
-| User says "no enforcement" | Respect immediately — treat as QUICK |
-
-## Principles
-
-1. **No agents** — Ambient enhances the main session, never spawns subagents
-2. **Proportional** — QUICK gets zero overhead, GUIDED gets 2-3 skills, ELEVATE gets a nudge
-3. **Transparent** — State classification for GUIDED/ELEVATE, silent for QUICK
-4. **Respectful** — Never over-classify; when in doubt, go one tier lower
-5. **TDD for BUILD** — GUIDED depth BUILD tasks enforce test-first workflow