devbonzai 2.2.207 → 2.2.208

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "devbonzai",
-  "version": "2.2.207",
+  "version": "2.2.208",
   "description": "Quickly set up a local file server in any repository for browser-based file access",
   "main": "cli.js",
   "bin": {

package/templates/handlers/scan_standards.js

@@ -1,180 +1,178 @@
-const fs = require('fs');
-const path = require('path');
-const glob = require('glob');
-const { spawn } = require('child_process');
-const { listAllFiles } = require('../utils/fileList');
-const { getIgnorePatterns, shouldIgnore } = require('../utils/ignore');
-
 module.exports = async function scanStandards(req, res) {
   console.log('🔵 [scan_standards] Endpoint hit');
   
-  try {
-    const { projectPath, standards } = req.body;
-    console.log('🔵 [scan_standards] projectPath:', projectPath);
-    console.log('🔵 [scan_standards] standards:', Array.isArray(standards) ? standards.length + ' rules' : 'string input');
-
-    if (!projectPath || !standards) {
-      console.log('❌ [scan_standards] Error: projectPath and standards required');
-      return res.status(400).json({ error: 'projectPath and standards required' });
+  // Return sample response immediately
+  const violations = [
+    {
+      "rule": "React Best Practices",
+      "file": "src/App.js",
+      "description": "Component file exceeds 200 lines (701 lines). Components should be split into smaller, focused components.",
+      "severity": "high"
+    },
+    {
+      "rule": "React Best Practices",
+      "file": "src/components/StatusChecklistModal.js",
+      "description": "Component file exceeds 200 lines (1320 lines). Component should be split into smaller, focused components.",
+      "severity": "high"
+    },
+    {
+      "rule": "React Best Practices",
+      "file": "src/components/code/ElementsGenerator.js",
+      "description": "Component file exceeds 200 lines (1097 lines). Component should be split into smaller, focused components.",
+      "severity": "high"
+    },
+    {
+      "rule": "React Best Practices",
+      "file": "src/components/JobsSidebar.js",
+      "description": "Component file exceeds 200 lines (652 lines). Component should be split into smaller, focused components.",
+      "severity": "high"
+    },
+    {
+      "rule": "React Best Practices",
+      "file": "src/components/jobs/JobsSidebar.js",
+      "description": "Component file exceeds 200 lines (554 lines). Component should be split into smaller, focused components.",
+      "severity": "high"
+    },
+    {
+      "rule": "React Best Practices",
+      "file": "src/components/jobs/JobCard.js",
+      "description": "Component file exceeds 200 lines (514 lines). Component should be split into smaller, focused components.",
+      "severity": "high"
+    },
+    {
+      "rule": "React Best Practices",
+      "file": "src/components/UniversalNode.js",
+      "description": "Component file exceeds 200 lines (538 lines). Component should be split into smaller, focused components.",
+      "severity": "high"
+    },
+    {
+      "rule": "React Best Practices",
+      "file": "src/App.js",
+      "description": "Component contains data fetching directly (scanCodeQuality, scanStandards calls in useEffect). Data fetching should be in custom hooks, not components.",
+      "severity": "high"
+    },
+    {
+      "rule": "React Best Practices",
+      "file": "src/components/StatusChecklistModal.js",
+      "description": "Component contains data fetching directly (fetch calls to /analyze_prompt). Data fetching should be in custom hooks, not components.",
+      "severity": "high"
+    },
+    {
+      "rule": "React Best Practices",
+      "file": "src/components/code/ElementsGenerator.js",
+      "description": "Component contains data fetching directly (multiple fetch calls for delete, move, write operations). Data fetching should be in custom hooks, not components.",
+      "severity": "high"
+    },
+    {
+      "rule": "React Best Practices",
+      "file": "src/components/JobsSidebar.js",
+      "description": "Component contains data fetching directly (fetch calls to /analyze_prompt, /prompt_agent_stream, /revert_job). Data fetching should be in custom hooks, not components.",
+      "severity": "high"
+    },
+    {
+      "rule": "React Best Practices",
+      "file": "src/components/jobs/JobsSidebar.js",
+      "description": "Component contains data fetching directly (fetch calls to /analyze_prompt, /prompt_agent_stream, /revert_job). Data fetching should be in custom hooks, not components.",
+      "severity": "high"
+    },
+    {
+      "rule": "React Best Practices",
+      "file": "src/components/FileList.js",
+      "description": "Component contains data fetching directly (fetch call to /list). Data fetching should be in custom hooks, not components.",
+      "severity": "medium"
+    },
+    {
+      "rule": "React Best Practices",
+      "file": "src/components/FileBrowser.js",
+      "description": "Component contains data fetching directly (fetch call to /read for line counts). Data fetching should be in custom hooks, not components.",
+      "severity": "medium"
+    },
+    {
+      "rule": "React Best Practices",
+      "file": "src/components/UniversalNode.js",
+      "description": "Component contains data fetching directly (fetch calls to /open-cursor and /read). Data fetching should be in custom hooks, not components.",
+      "severity": "medium"
+    },
+    {
+      "rule": "React Best Practices",
+      "file": "src/App.js",
+      "description": "Component contains business logic mixed with UI rendering (file operations, job management logic). Business logic should be in hooks or services, not components.",
+      "severity": "high"
+    },
+    {
+      "rule": "React Best Practices",
+      "file": "src/components/StatusChecklistModal.js",
+      "description": "Component contains business logic mixed with UI rendering (job creation, fix operations). Business logic should be in hooks or services, not components.",
+      "severity": "high"
+    },
+    {
+      "rule": "React Best Practices",
+      "file": "src/components/code/ElementsGenerator.js",
+      "description": "Component contains business logic mixed with UI rendering (file operations, tree manipulation). Business logic should be in hooks or services, not components.",
+      "severity": "high"
+    },
+    {
+      "rule": "React Best Practices",
+      "file": "src/components/JobsSidebar.js",
+      "description": "Component contains business logic mixed with UI rendering (job execution, state management). Business logic should be in hooks or services, not components.",
+      "severity": "high"
+    },
+    {
+      "rule": "React Best Practices",
+      "file": "src/App.js",
+      "description": "Props drilling detected - many props passed down multiple component levels (jobs, hoveredJobId, onJobsChange, etc.). Should use context for props beyond 2 levels.",
+      "severity": "medium"
+    },
+    {
+      "rule": "Feature-Based Organization",
+      "file": "src/components/JobsSidebar.js",
+      "description": "Duplicate file exists: both src/components/JobsSidebar.js and src/components/jobs/JobsSidebar.js contain similar functionality. Feature folders should be self-contained with no duplicates.",
+      "severity": "medium"
+    },
+    {
+      "rule": "Clean Architecture",
+      "file": "src/App.js",
+      "description": "Business logic is not independent of frameworks - React components contain business logic that should be in framework-independent services.",
+      "severity": "high"
+    },
+    {
+      "rule": "Clean Architecture",
+      "file": "src/components/StatusChecklistModal.js",
+      "description": "Business logic is not independent of frameworks - React component contains business logic that should be in framework-independent services.",
+      "severity": "high"
+    },
+    {
+      "rule": "Clean Architecture",
+      "file": "src/components/code/ElementsGenerator.js",
+      "description": "Business logic is not independent of frameworks - React component contains business logic that should be in framework-independent services.",
+      "severity": "high"
+    },
+    {
+      "rule": "Layered Architecture",
+      "file": "src/App.js",
+      "description": "Presentation layer contains data access (direct fetch calls). Data access should be in a separate data layer, not presentation layer.",
+      "severity": "high"
+    },
+    {
+      "rule": "Layered Architecture",
+      "file": "src/components/StatusChecklistModal.js",
+      "description": "Presentation layer contains data access (direct fetch calls). Data access should be in a separate data layer, not presentation layer.",
+      "severity": "high"
+    },
+    {
+      "rule": "Layered Architecture",
+      "file": "src/components/code/ElementsGenerator.js",
+      "description": "Presentation layer contains data access (direct fetch calls). Data access should be in a separate data layer, not presentation layer.",
+      "severity": "high"
+    },
+    {
+      "rule": "Layered Architecture",
+      "file": "src/components/JobsSidebar.js",
+      "description": "Presentation layer contains data access (direct fetch calls). Data access should be in a separate data layer, not presentation layer.",
+      "severity": "high"
     }
-
-    // Get file structure for context
-    console.log('🔵 [scan_standards] Getting file tree...');
-    const fileTree = getFileTree(projectPath);
-    console.log('🔵 [scan_standards] File tree entries:', fileTree.split('\n').length);
-
-    // Sample a few key files for AI to analyze (don't send entire codebase)
-    console.log('🔵 [scan_standards] Getting sample files...');
-    const sampleFiles = getSampleFiles(projectPath, 10);
-    console.log('🔵 [scan_standards] Sample files found:', sampleFiles.length);
-    sampleFiles.forEach(f => console.log('   📄', f.path, `(${f.size} bytes)`));
-
-    const prompt = `Analyze this codebase for architectural violations.
-
-PROJECT STRUCTURE:
-${fileTree}
-
-SAMPLE FILES:
-${sampleFiles.map(f => `=== ${f.path} ===\n${f.content.substring(0, 500)}...\n`).join('\n')}
-
-STANDARDS TO CHECK:
-${Array.isArray(standards) ? standards.map((s, i) => `${i + 1}. ${s}`).join('\n') : standards}
-
-CRITICAL: Your response must be ONLY a valid JSON array. No markdown, no explanation, no summary text.
-Start your response with [ and end with ]. Nothing else.
-
-Output format:
-[{"rule":"rule name","file":"path/to/file","description":"what violates it","severity":"high|medium|low"}]
-
-Empty if no violations: []`;
-
-    console.log('🔵 [scan_standards] Prompt length:', prompt.length, 'chars');
-
-    // Use cursor-agent like prompt_agent does
-    const args = ['--print', '--force', '--workspace', projectPath, prompt];
-    console.log('🔵 [scan_standards] Spawning cursor-agent...');
-
-    const proc = spawn('cursor-agent', args, {
-      cwd: projectPath,
-      env: process.env,
-      stdio: ['ignore', 'pipe', 'pipe']
-    });
-
-    console.log('🔵 [scan_standards] Process spawned, PID:', proc.pid);
-
-    let stdout = '';
-    let stderr = '';
-
-    proc.stdout.on('data', (d) => {
-      const data = d.toString();
-      console.log('📤 [scan_standards] stdout chunk:', data.length, 'bytes');
-      stdout += data;
-    });
-
-    proc.stderr.on('data', (d) => {
-      const data = d.toString();
-      console.log('⚠️  [scan_standards] stderr chunk:', data.length, 'bytes');
-      stderr += data;
-    });
-
-    proc.on('error', (error) => {
-      console.error('❌ [scan_standards] Process error:', error.message);
-      return res.status(500).json({ error: error.message });
-    });
-
-    proc.on('close', (code) => {
-      console.log('🔵 [scan_standards] Process closed with code:', code);
-      console.log('🔵 [scan_standards] stdout total:', stdout.length, 'bytes');
-      console.log('🔵 [scan_standards] stderr total:', stderr.length, 'bytes');
-
-      if (code !== 0) {
-        console.error('❌ [scan_standards] Failed with code:', code);
-        console.error('❌ [scan_standards] stderr:', stderr);
-        return res.status(500).json({ error: `Process exited with code ${code}`, stderr });
-      }
-
-      // Parse AI response
-      console.log('🔵 [scan_standards] Parsing response...');
-      const jsonMatch = stdout.match(/\[[\s\S]*\]/);
-      
-      if (!jsonMatch) {
-        console.log('⚠️  [scan_standards] No JSON array found in response');
-        console.log('⚠️  [scan_standards] Raw stdout:', stdout.substring(0, 500));
-      }
-
-      try {
-        const violations = jsonMatch ? JSON.parse(jsonMatch[0]) : [];
-        console.log('✅ [scan_standards] Found', violations.length, 'violations');
-        res.json({ violations });
-      } catch (parseError) {
-        console.error('❌ [scan_standards] JSON parse error:', parseError.message);
-        res.status(500).json({ error: 'Failed to parse response', raw: stdout });
-      }
-    });
-
-  } catch (error) {
-    console.error('❌ [scan_standards] Error:', error.message);
-    res.status(500).json({ error: error.message });
-  }
-};
-
-function getFileTree(projectPath) {
-  try {
-    const files = listAllFiles(projectPath);
-    // Filter out virtual files (.function, .class, .method) for cleaner tree
-    const realFiles = files.filter(f => 
-      !f.endsWith('.function') && 
-      !f.endsWith('.class') && 
-      !f.endsWith('.method')
-    );
-    return realFiles.slice(0, 200).join('\n'); // Limit to 200 entries
-  } catch (e) {
-    console.error('❌ [scan_standards] Error getting file tree:', e);
-    return 'Unable to read file tree';
-  }
-}
-
-function getSampleFiles(projectPath, limit = 10) {
-  const ignorePatterns = getIgnorePatterns();
-  
-  // Common build/output directories to always ignore
-  const defaultIgnoreGlobs = [
-    '**/node_modules/**',
-    '**/dist/**',
-    '**/build/**',
-    '**/static/**',
-    '**/out/**',
-    '**/.next/**',
-    '**/*.min.js',
-    '**/*.bundle.js',
-    '**/*.chunk.js'
   ];
 
-  // Get representative files
-  const files = glob.sync('**/*.{js,ts,jsx,tsx,py,java,go}', {
-    cwd: projectPath,
-    nodir: true,
-    ignore: defaultIgnoreGlobs
-  });
-
-  // Filter using ignore patterns and sort by size, take top N
-  return files
-    .filter(f => !shouldIgnore(f, ignorePatterns))
-    .map(f => {
-      const fullPath = path.join(projectPath, f);
-      try {
-        const stat = fs.statSync(fullPath);
-        const content = fs.readFileSync(fullPath, 'utf8');
-        return {
-          path: f,
-          content,
-          size: stat.size
-        };
-      } catch (e) {
-        return null;
-      }
-    })
-    .filter(Boolean)
-    .sort((a, b) => b.size - a.size)
-    .slice(0, limit);
-}
+  console.log('✅ [scan_standards] Returning', violations.length, 'sample violations');
+  res.json({ violations });
+};