dev-playbooks 1.7.2 → 1.7.3
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +2 -2
- package/package.json +1 -1
- package/skills/Skill-Development-Guide.md +1 -1
- package/skills/Skills-Usage-Guide.md +2 -2
- package/skills/_shared/mcp-enhancement-template-mcp-enhancement.md +1 -1
- package/skills/_shared/references/deviation-detection-routing-protocol.md +1 -1
- package/skills/_shared/workflow-next-steps-workflow-next-steps.md +3 -3
- package/skills/devbooks-delivery-workflow/SKILL.md +1 -1
- package/skills/devbooks-delivery-workflow/references/delivery-acceptance-workflow.md +1 -1
- package/skills/devbooks-delivery-workflow/references/subagent-invocation-spec.md +1 -1
- package/skills/devbooks-entropy-monitor/SKILL.md +1 -1
- package/skills/{devbooks-code-review → devbooks-reviewer}/SKILL.md +2 -2
- package/skills/{devbooks-code-review → devbooks-reviewer}/references/code-smell-cheatsheet.md +1 -1
- package/skills/devbooks-router/SKILL.md +2 -2
- package/skills/devbooks-test-owner/SKILL.md +1 -1
- package/skills/devbooks-test-owner/references/phase2-evidence-audit-checklist.md +1 -1
- package/templates/claude-agents/devbooks-reviewer.md +1 -1
- package/templates/dev-playbooks/README.md +2 -2
- package/templates/dev-playbooks/docs/devbooks-setup-guide.md +2 -2
- /package/skills/{devbooks-code-review → devbooks-reviewer}/references/code-review-prompt.md +0 -0
- /package/skills/{devbooks-code-review → devbooks-reviewer}/references/pr-template-and-guidelines.md +0 -0
- /package/skills/{devbooks-code-review → devbooks-reviewer}/references/resource-management-review-checklist.md +0 -0
package/README.md
CHANGED
|
@@ -164,7 +164,7 @@ Run devbooks-coder skill for change add-oauth2
|
|
|
164
164
|
**3) Review stage**
|
|
165
165
|
|
|
166
166
|
```
|
|
167
|
-
Run devbooks-
|
|
167
|
+
Run devbooks-reviewer skill for change add-oauth2
|
|
168
168
|
```
|
|
169
169
|
|
|
170
170
|
**4) Archive stage**
|
|
@@ -202,7 +202,7 @@ Run devbooks-archiver skill for change add-oauth2
|
|
|
202
202
|
|
|
203
203
|
| Skill | Description |
|
|
204
204
|
|-------|-------------|
|
|
205
|
-
| devbooks-
|
|
205
|
+
| devbooks-reviewer | Code review (readability/consistency) |
|
|
206
206
|
| devbooks-test-reviewer | Test quality and coverage review |
|
|
207
207
|
|
|
208
208
|
### Archive stage
|
package/package.json
CHANGED
|
@@ -18,7 +18,7 @@ This document defines the design principles and constraints you must follow when
|
|
|
18
18
|
|
|
19
19
|
| Skill type | Idempotency requirement | Examples |
|
|
20
20
|
|---|---|---|
|
|
21
|
-
| **Verification / checks** | Must be idempotent (must not modify files) | `change-check.sh`, `guardrail-check.sh`, `devbooks-
|
|
21
|
+
| **Verification / checks** | Must be idempotent (must not modify files) | `change-check.sh`, `guardrail-check.sh`, `devbooks-reviewer` |
|
|
22
22
|
| **Generators** | Must explicitly define “overwrite vs incremental” behavior | `change-scaffold.sh`, `devbooks-design-doc`, `devbooks-proposal-author` |
|
|
23
23
|
| **Editors** | Must be safe to rerun | `devbooks-spec-gardener`, `devbooks-design-backport` |
|
|
24
24
|
|
|
@@ -220,7 +220,7 @@ In SKILL.md prompts, the `~/.claude/skills/_shared/` path should be replaced wit
|
|
|
220
220
|
|
|
221
221
|
---
|
|
222
222
|
|
|
223
|
-
## `devbooks-
|
|
223
|
+
## `devbooks-reviewer` (Reviewer)
|
|
224
224
|
|
|
225
225
|
- Purpose: review readability/consistency/dependency health/code smells; output actionable suggestions only; do not judge business correctness.
|
|
226
226
|
- Hotspot-first review: call `mcp__ckb__getHotspots` before reviewing; prioritize by risk:
|
|
@@ -232,7 +232,7 @@ In SKILL.md prompts, the `~/.claude/skills/_shared/` path should be replaced wit
|
|
|
232
232
|
- You want to discover coupling/dependency direction/complexity/smells
|
|
233
233
|
- Copy-paste prompt:
|
|
234
234
|
```text
|
|
235
|
-
You are Reviewer. Explicitly use `devbooks-
|
|
235
|
+
You are Reviewer. Explicitly use `devbooks-reviewer`.
|
|
236
236
|
Review only readability/consistency/dependency health/code smells; do not discuss business correctness; do not modify `tests/` or design.
|
|
237
237
|
Inputs: code changes + `dev-playbooks/specs/**` (as needed for profile/glossary/anti-patterns).
|
|
238
238
|
Output: severe issues / maintainability risks / consistency suggestions / suggested quality gates to add.
|
|
@@ -84,7 +84,7 @@ The following Skills depend on MCP and require the full MCP Enhancement section:
|
|
|
84
84
|
| Skill | MCP Dependencies | Enhanced Features |
|
|
85
85
|
|-------|------------------|-------------------|
|
|
86
86
|
| devbooks-coder | mcp__ckb__getHotspots | Hotspot warnings |
|
|
87
|
-
| devbooks-
|
|
87
|
+
| devbooks-reviewer | mcp__ckb__getHotspots | Hotspot highlighting |
|
|
88
88
|
| devbooks-impact-analysis | mcp__ckb__analyzeImpact, findReferences | Precise impact analysis |
|
|
89
89
|
| devbooks-brownfield-bootstrap | mcp__ckb__* | COD model generation |
|
|
90
90
|
| devbooks-router | mcp__ckb__getStatus | Index availability detection |
|
|
@@ -124,7 +124,7 @@ deviation-log.md is a **persistent file** unaffected by compact. Even if convers
|
|
|
124
124
|
| Current Skill | Completion Status | Next Step |
|
|
125
125
|
|---------------|-------------------|-----------|
|
|
126
126
|
| Any | COMPLETED_WITH_DEVIATION | `devbooks-design-backport` |
|
|
127
|
-
| coder | COMPLETED | `devbooks-
|
|
127
|
+
| coder | COMPLETED | `devbooks-reviewer` |
|
|
128
128
|
| coder | HANDOFF (test issue) | `devbooks-test-owner` |
|
|
129
129
|
| test-owner | COMPLETED | `devbooks-coder` |
|
|
130
130
|
| test-owner | HANDOFF (design issue) | `devbooks-design-backport` |
|
|
@@ -44,9 +44,9 @@ This document defines the canonical next step recommendations for each skill. Al
|
|
|
44
44
|
| `devbooks-spec-contract` | `devbooks-implementation-plan` | Always (NEVER recommend test-owner/coder directly) |
|
|
45
45
|
| `devbooks-implementation-plan` | `devbooks-test-owner` | Always (must be separate chat) |
|
|
46
46
|
| `devbooks-test-owner` | `devbooks-coder` | After Red baseline (must be separate chat) |
|
|
47
|
-
| `devbooks-coder` | `devbooks-
|
|
48
|
-
| `devbooks-
|
|
49
|
-
| `devbooks-
|
|
47
|
+
| `devbooks-coder` | `devbooks-reviewer` | After all tasks completed |
|
|
48
|
+
| `devbooks-reviewer` | `devbooks-archiver` | If spec deltas exist |
|
|
49
|
+
| `devbooks-reviewer` | Archive complete | If no spec deltas |
|
|
50
50
|
| `devbooks-test-reviewer` | `devbooks-coder` | If test issues found, hand back |
|
|
51
51
|
| `devbooks-design-backport` | `devbooks-implementation-plan` | Rerun plan after design update |
|
|
52
52
|
| `devbooks-archiver` | Archive complete | Always |
|
|
@@ -163,7 +163,7 @@ Before execution, **must** search for configuration in the following order (stop
|
|
|
163
163
|
| 7 | Test-Red | `devbooks-test-owner` | devbooks-test-owner | verification.md + tests/ | ✅ |
|
|
164
164
|
| 8 | Code | `devbooks-coder` | devbooks-coder | src/ implementation | ✅ |
|
|
165
165
|
| 9 | Test-Review | `devbooks-reviewer` | devbooks-test-reviewer | Test review opinions | ✅ |
|
|
166
|
-
| 10 | Code-Review | `devbooks-reviewer` | devbooks-
|
|
166
|
+
| 10 | Code-Review | `devbooks-reviewer` | devbooks-reviewer | Code review opinions | ✅ |
|
|
167
167
|
| 11 | Green-Verify | `devbooks-test-owner` | devbooks-test-owner | evidence/green-final/ | ✅ |
|
|
168
168
|
| 12 | Archive | `devbooks-archiver` | devbooks-archiver | Archived to archive/ | ✅ |
|
|
169
169
|
|
|
@@ -156,7 +156,7 @@ Checklist:
|
|
|
156
156
|
- Run all A-class anchors in scope (tests + static checks + build)
|
|
157
157
|
- Prefer machine-readable outputs (json/xml) for traceability and tooling
|
|
158
158
|
- Execute B/C anchors with evidence
|
|
159
|
-
- Optional review: use `devbooks-
|
|
159
|
+
- Optional review: use `devbooks-reviewer` for maintainability feedback
|
|
160
160
|
|
|
161
161
|
### Step 7: Close-out
|
|
162
162
|
|
|
@@ -27,7 +27,7 @@ Please execute the following task:
|
|
|
27
27
|
| 7 | devbooks-test-owner | "Use devbooks-test-owner skill to write tests and establish Red baseline for change [change-id]" |
|
|
28
28
|
| 8 | devbooks-coder | "Use devbooks-coder skill to implement functionality for change [change-id]" |
|
|
29
29
|
| 9 | devbooks-reviewer | "Use devbooks-test-reviewer skill to review tests for change [change-id]" |
|
|
30
|
-
| 10 | devbooks-reviewer | "Use devbooks-
|
|
30
|
+
| 10 | devbooks-reviewer | "Use devbooks-reviewer skill to review code for change [change-id]" |
|
|
31
31
|
| 11 | devbooks-test-owner | "Use devbooks-test-owner skill to run all tests and collect Green evidence for change [change-id]" |
|
|
32
32
|
| 12 | devbooks-archiver | "Use devbooks-archiver skill to archive change [change-id]" |
|
|
33
33
|
|
|
@@ -105,7 +105,7 @@ Goals of entropy measurement:
|
|
|
105
105
|
|
|
106
106
|
| Skill | Relationship |
|
|
107
107
|
|-------|--------------|
|
|
108
|
-
| devbooks-
|
|
108
|
+
| devbooks-reviewer | Entropy measurement is **not** embedded in every review, runs as independent task |
|
|
109
109
|
| devbooks-proposal-author | Entropy reports can serve as data support for refactoring proposals |
|
|
110
110
|
| devbooks-impact-analysis | Changes in high-entropy areas require more careful impact analysis |
|
|
111
111
|
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
---
|
|
2
|
-
name: devbooks-
|
|
3
|
-
description: devbooks-
|
|
2
|
+
name: devbooks-reviewer
|
|
3
|
+
description: devbooks-reviewer: Perform readability/consistency/dependency health/code smell reviews as a Reviewer role, outputting only review comments and actionable suggestions without discussing business correctness. Use when user says "help me do code review/review maintainability/code smells/dependency risks/consistency suggestions", or when executing as reviewer during DevBooks apply phase.
|
|
4
4
|
allowed-tools:
|
|
5
5
|
- Glob
|
|
6
6
|
- Grep
|
package/skills/{devbooks-code-review → devbooks-reviewer}/references/code-smell-cheatsheet.md
RENAMED
|
@@ -402,7 +402,7 @@ class PaymentService:
|
|
|
402
402
|
- *Refactoring: Improving the Design of Existing Code* (2nd Edition) — Martin Fowler
|
|
403
403
|
- *Clean Architecture* — Robert C. Martin (Chapter: Component Coupling)
|
|
404
404
|
- Dev Playbooks debate-revised evaluation notes
|
|
405
|
-
- `devbooks-
|
|
405
|
+
- `devbooks-reviewer` checklists
|
|
406
406
|
|
|
407
407
|
---
|
|
408
408
|
|
|
@@ -68,7 +68,7 @@ fi
|
|
|
68
68
|
|
|
69
69
|
**Degraded Mode Notes**:
|
|
70
70
|
- Without index, `devbooks-impact-analysis` degrades to Grep text search (reduced accuracy)
|
|
71
|
-
- Without index, `devbooks-
|
|
71
|
+
- Without index, `devbooks-reviewer` cannot obtain call graph context
|
|
72
72
|
- Recommend completing index generation before the Apply phase
|
|
73
73
|
|
|
74
74
|
## Your Task
|
|
@@ -228,7 +228,7 @@ LSC (Large-Scale Codemods) recommendations:
|
|
|
228
228
|
Trigger signals: User says "review/code smells/maintainability/dependency risks/consistency" etc.
|
|
229
229
|
|
|
230
230
|
Default routing:
|
|
231
|
-
- `devbooks-
|
|
231
|
+
- `devbooks-reviewer` (output actionable suggestions; do not change business conclusions or tests)
|
|
232
232
|
- `devbooks-test-reviewer` (review test quality, coverage, edge cases)
|
|
233
233
|
|
|
234
234
|
### D) Docs Sync (Documentation Sync)
|
|
@@ -296,7 +296,7 @@ Detection rules reference: `~/.claude/skills/_shared/context-detection-template.
|
|
|
296
296
|
|
|
297
297
|
| Code | Status | Determination Criteria | Next Step |
|
|
298
298
|
|:----:|--------|------------------------|-----------|
|
|
299
|
-
| ✅ | PHASE2_VERIFIED | Evidence audit passed, AC matrix checked | `devbooks-
|
|
299
|
+
| ✅ | PHASE2_VERIFIED | Evidence audit passed, AC matrix checked | `devbooks-reviewer` |
|
|
300
300
|
| ⏳ | PHASE2_WAITING | @full tests still running | Wait for CI to complete |
|
|
301
301
|
| ❌ | PHASE2_FAILED | @full tests not passing | Notify Coder to fix |
|
|
302
302
|
| 🔄 | PHASE2_HANDOFF | Found issues with tests themselves | Fix tests then re-verify |
|
|
@@ -101,7 +101,7 @@ Update status at top of verification.md:
|
|
|
101
101
|
|
|
102
102
|
| Code | Status | Determination Criteria | Next Step |
|
|
103
103
|
|:----:|--------|------------------------|-----------|
|
|
104
|
-
| ✅ | PHASE2_VERIFIED | Evidence audit passed, AC matrix checked | `devbooks-
|
|
104
|
+
| ✅ | PHASE2_VERIFIED | Evidence audit passed, AC matrix checked | `devbooks-reviewer` |
|
|
105
105
|
| ⏳ | PHASE2_WAITING | @full tests still running | Wait for CI to complete |
|
|
106
106
|
| ❌ | PHASE2_FAILED | @full tests not passing | Notify Coder to fix |
|
|
107
107
|
| 🔄 | PHASE2_HANDOFF | Found issues with tests themselves | Fix tests then re-verify |
|
|
@@ -1,7 +1,7 @@
|
|
|
1
1
|
---
|
|
2
2
|
name: devbooks-reviewer
|
|
3
3
|
description: DevBooks Reviewer subagent: Executes code review and test review, outputs actionable suggestions.
|
|
4
|
-
skills: devbooks-
|
|
4
|
+
skills: devbooks-reviewer, devbooks-test-reviewer
|
|
5
5
|
---
|
|
6
6
|
|
|
7
7
|
# DevBooks Reviewer Subagent
|
|
@@ -140,7 +140,7 @@ Run devbooks-coder skill for change add-oauth2
|
|
|
140
140
|
**3) Review stage**
|
|
141
141
|
|
|
142
142
|
```
|
|
143
|
-
Run devbooks-
|
|
143
|
+
Run devbooks-reviewer skill for change add-oauth2
|
|
144
144
|
```
|
|
145
145
|
|
|
146
146
|
**4) Archive stage**
|
|
@@ -178,7 +178,7 @@ Run devbooks-archiver skill for change add-oauth2
|
|
|
178
178
|
|
|
179
179
|
| Skill | Description |
|
|
180
180
|
|-------|-------------|
|
|
181
|
-
| devbooks-
|
|
181
|
+
| devbooks-reviewer | Code review (readability/consistency) |
|
|
182
182
|
| devbooks-test-reviewer | Test quality and coverage review |
|
|
183
183
|
|
|
184
184
|
### Archive stage
|
|
@@ -131,7 +131,7 @@ Each change must declare which gates are covered; missing items require reasons:
|
|
|
131
131
|
| Planner | `devbooks-implementation-plan` | `tasks.md` |
|
|
132
132
|
| Test Owner | `devbooks-test-owner` | `verification.md` + `tests/` |
|
|
133
133
|
| Coder | `devbooks-coder` | Implement per tasks (no tests) |
|
|
134
|
-
| Reviewer | `devbooks-
|
|
134
|
+
| Reviewer | `devbooks-reviewer` | Review feedback |
|
|
135
135
|
| Archiver | `devbooks-archiver` | Archive pruning + C4 merge |
|
|
136
136
|
| Design Backport | `devbooks-design-backport` | Backport design gaps |
|
|
137
137
|
|
|
@@ -185,6 +185,6 @@ The AI can automatically select Skills based on user intent:
|
|
|
185
185
|
| User Intent | Auto Route |
|
|
186
186
|
|-------------|------------|
|
|
187
187
|
| "Fix bug", "find issue" | `devbooks-impact-analysis` → `devbooks-coder` |
|
|
188
|
-
| "Refactor", "optimize code" | `devbooks-
|
|
188
|
+
| "Refactor", "optimize code" | `devbooks-reviewer` → `devbooks-coder` |
|
|
189
189
|
| "New feature", "implement XX" | `devbooks-router` → full loop |
|
|
190
190
|
| "Write tests", "add tests" | `devbooks-test-owner` |
|
|
File without changes
|
/package/skills/{devbooks-code-review → devbooks-reviewer}/references/pr-template-and-guidelines.md
RENAMED
|
File without changes
|
|
File without changes
|