dev-playbooks 1.5.2 → 1.5.3
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/package.json
CHANGED
|
@@ -53,6 +53,34 @@ Before execution, you **must** search for configuration in the following order (
|
|
|
53
53
|
- Must compare against `verification.md` to check if tests cover all ACs
|
|
54
54
|
- If missing tests are found, clearly indicate the missing AC-ID
|
|
55
55
|
|
|
56
|
+
### CON-ROLE-004: Only Review Test Code Quality, Not Runtime Results
|
|
57
|
+
> Core principle: Test Reviewer focuses on "**how well tests are written**", not "**whether tests pass**"
|
|
58
|
+
|
|
59
|
+
**Prohibited**:
|
|
60
|
+
- Discussing whether tests Pass/Fail, Red/Green, or Skip
|
|
61
|
+
- Commenting on "functionality not implemented" or "missing dependencies"
|
|
62
|
+
- Providing implementation suggestions to Coder (e.g., "implement xxx command", "add xxx field")
|
|
63
|
+
- Referencing workflow phases (e.g., "Red baseline phase", "this is expected behavior")
|
|
64
|
+
- Judging test quality based on test runtime results
|
|
65
|
+
|
|
66
|
+
**Allowed**:
|
|
67
|
+
- Reviewing correctness and clarity of test assertions
|
|
68
|
+
- Reviewing test structure and organization
|
|
69
|
+
- Reviewing completeness of test scenarios (based on code analysis, not runtime results)
|
|
70
|
+
|
|
71
|
+
### CON-ROLE-005: Coverage = Test Existence, Not Test Pass Status
|
|
72
|
+
|
|
73
|
+
| Coverage Status | Definition | Judgment Criteria |
|
|
74
|
+
|-----------------|------------|-------------------|
|
|
75
|
+
| ✅ Covered | Corresponding test case exists for AC | Test/it block exists in test file |
|
|
76
|
+
| ⚠️ Partially Covered | Test exists but scenarios incomplete | Missing boundary conditions, error paths, etc. |
|
|
77
|
+
| ❌ Missing | No corresponding test case | No matching test code found |
|
|
78
|
+
|
|
79
|
+
**Prohibited** from including the following in coverage assessment:
|
|
80
|
+
- Test Skip status (skipped tests still count as "Covered")
|
|
81
|
+
- Test Fail status (failing tests still count as "Covered")
|
|
82
|
+
- Test runtime or performance
|
|
83
|
+
|
|
56
84
|
---
|
|
57
85
|
|
|
58
86
|
## Review Dimensions
|
|
@@ -104,11 +132,13 @@ Before execution, you **must** search for configuration in the following order (
|
|
|
104
132
|
|
|
105
133
|
## Coverage Analysis
|
|
106
134
|
|
|
135
|
+
> **Note**: Coverage status is based on test code existence, not test runtime results (Pass/Fail/Skip).
|
|
136
|
+
|
|
107
137
|
| AC-ID | Test File | Coverage Status | Notes |
|
|
108
138
|
|-------|-----------|-----------------|-------|
|
|
109
|
-
| AC-001 | test-a.ts | Covered |
|
|
110
|
-
| AC-002 | - | Missing |
|
|
111
|
-
| AC-003 | test-b.ts | Partially Covered |
|
|
139
|
+
| AC-001 | test-a.ts | ✅ Covered | Test case exists |
|
|
140
|
+
| AC-002 | - | ❌ Missing | No corresponding test code |
|
|
141
|
+
| AC-003 | test-b.ts | ⚠️ Partially Covered | Test exists but missing boundary conditions |
|
|
112
142
|
|
|
113
143
|
## Issue List
|
|
114
144
|
|
|
@@ -178,7 +208,7 @@ After completing the review, you **must** provide a clear conclusion:
|
|
|
178
208
|
| Skill Name | devbooks-test-reviewer |
|
|
179
209
|
| Phase | Apply |
|
|
180
210
|
| Artifact | Review report (not written to change package) |
|
|
181
|
-
| Constraints | CON-ROLE-001~
|
|
211
|
+
| Constraints | CON-ROLE-001~005 |
|
|
182
212
|
|
|
183
213
|
---
|
|
184
214
|
|