dev-playbooks 1.5.1 → 1.5.3
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +16 -5
- package/package.json +1 -1
- package/skills/Skills-Usage-Guide.md +48 -0
- package/skills/devbooks-test-reviewer/SKILL.md +34 -4
package/README.md
CHANGED
|
@@ -81,11 +81,21 @@ npx dev-playbooks@latest init
|
|
|
81
81
|
|
|
82
82
|
### Install targets
|
|
83
83
|
|
|
84
|
-
|
|
85
|
-
|
|
86
|
-
|
|
87
|
-
|
|
88
|
-
|
|
84
|
+
During initialization, you can choose the Skills installation scope:
|
|
85
|
+
|
|
86
|
+
| Scope | Description | Path Example |
|
|
87
|
+
|-------|-------------|--------------|
|
|
88
|
+
| **Project** (default) | Available only in this project | `.claude/skills/devbooks-*` |
|
|
89
|
+
| **Global** | Shared across all projects | `~/.claude/skills/devbooks-*` |
|
|
90
|
+
|
|
91
|
+
```bash
|
|
92
|
+
# Interactive selection
|
|
93
|
+
dev-playbooks init
|
|
94
|
+
|
|
95
|
+
# Non-interactive
|
|
96
|
+
dev-playbooks init --tools claude --scope project # Project-level
|
|
97
|
+
dev-playbooks init --tools claude --scope global # Global
|
|
98
|
+
```
|
|
89
99
|
|
|
90
100
|
### Quick integration
|
|
91
101
|
|
|
@@ -194,6 +204,7 @@ Run devbooks-archiver skill for change add-oauth2
|
|
|
194
204
|
|-------|-------------|
|
|
195
205
|
| devbooks-entropy-monitor | System entropy metrics |
|
|
196
206
|
| devbooks-brownfield-bootstrap | Brownfield project bootstrap |
|
|
207
|
+
| devbooks-convergence-audit | Convergence audit (anti-deception design) |
|
|
197
208
|
|
|
198
209
|
---
|
|
199
210
|
|
package/package.json
CHANGED
|
@@ -344,6 +344,54 @@ If you are not using DevBooks, replace `dev-playbooks/specs` / `dev-playbooks/ch
|
|
|
344
344
|
|
|
345
345
|
---
|
|
346
346
|
|
|
347
|
+
## `devbooks-test-reviewer` (Test Reviewer) [New]
|
|
348
|
+
|
|
349
|
+
- Purpose: review test quality in `tests/` (coverage, boundary conditions, readability, maintainability); output review comments only; do not modify code.
|
|
350
|
+
- When to use:
|
|
351
|
+
- After Test Owner completes tests, an independent quality review is needed
|
|
352
|
+
- You want to find coverage gaps, missing boundary conditions, and maintainability issues
|
|
353
|
+
- Copy-paste prompt:
|
|
354
|
+
```text
|
|
355
|
+
You are Test Reviewer. Explicitly use `devbooks-test-reviewer`.
|
|
356
|
+
Review test quality only (coverage/boundary conditions/readability/maintainability); do not modify code.
|
|
357
|
+
Inputs: `tests/**` + `dev-playbooks/changes/<change-id>/verification.md` (if present)
|
|
358
|
+
Output: coverage gaps / missing boundary conditions / maintainability risks / improvement suggestions.
|
|
359
|
+
```
|
|
360
|
+
|
|
361
|
+
---
|
|
362
|
+
|
|
363
|
+
## `devbooks-convergence-audit` (Convergence Auditor) [New]
|
|
364
|
+
|
|
365
|
+
- Purpose: evaluate DevBooks workflow convergence using "evidence-first, distrust declarations" principle; detect "Sisyphus anti-pattern" and "false completion". Actively verify rather than trust document assertions.
|
|
366
|
+
- Anti-confusion design: never trust any assertion in documents (Status: Done, AC checked, etc.); must confirm through verifiable evidence.
|
|
367
|
+
- When to use:
|
|
368
|
+
- You want to evaluate true workflow convergence (not document claims)
|
|
369
|
+
- You suspect a change package is "false completion" or has "stale evidence"
|
|
370
|
+
- You want to detect Sisyphus trap (repeated rework without convergence)
|
|
371
|
+
- Copy-paste prompt:
|
|
372
|
+
```text
|
|
373
|
+
You are Convergence Auditor. Explicitly use `devbooks-convergence-audit`.
|
|
374
|
+
First read: `dev-playbooks/project.md` (if present)
|
|
375
|
+
Goal: perform a convergence audit on a specified change package.
|
|
376
|
+
|
|
377
|
+
Execute with anti-confusion principles:
|
|
378
|
+
1) Read all documents under `dev-playbooks/changes/<change-id>/`
|
|
379
|
+
2) Verify each "declaration" (Status=Done, AC checked, etc.) against evidence
|
|
380
|
+
3) Actually run tests for verification (if possible)
|
|
381
|
+
4) Output: declaration vs evidence comparison table + trustworthiness score + confusion detection results
|
|
382
|
+
|
|
383
|
+
Change package: <change-id>
|
|
384
|
+
truth-root: dev-playbooks/specs
|
|
385
|
+
change-root: dev-playbooks/changes
|
|
386
|
+
```
|
|
387
|
+
- Trustworthiness scoring:
|
|
388
|
+
- 90-100: ✅ Trustworthy convergence, continue current workflow
|
|
389
|
+
- 70-89: ⚠️ Partially trustworthy, needs additional verification
|
|
390
|
+
- 50-69: 🟠 Questionable, parts need rework
|
|
391
|
+
- < 50: 🔴 Untrustworthy (Sisyphus trap), needs full review
|
|
392
|
+
|
|
393
|
+
---
|
|
394
|
+
|
|
347
395
|
## Generating SCIP Index (Manual)
|
|
348
396
|
|
|
349
397
|
If you need graph-based code understanding (call graph, impact analysis, symbol references), you can generate a SCIP index manually:
|
|
@@ -53,6 +53,34 @@ Before execution, you **must** search for configuration in the following order (
|
|
|
53
53
|
- Must compare against `verification.md` to check if tests cover all ACs
|
|
54
54
|
- If missing tests are found, clearly indicate the missing AC-ID
|
|
55
55
|
|
|
56
|
+
### CON-ROLE-004: Only Review Test Code Quality, Not Runtime Results
|
|
57
|
+
> Core principle: Test Reviewer focuses on "**how well tests are written**", not "**whether tests pass**"
|
|
58
|
+
|
|
59
|
+
**Prohibited**:
|
|
60
|
+
- Discussing whether tests Pass/Fail, Red/Green, or Skip
|
|
61
|
+
- Commenting on "functionality not implemented" or "missing dependencies"
|
|
62
|
+
- Providing implementation suggestions to Coder (e.g., "implement xxx command", "add xxx field")
|
|
63
|
+
- Referencing workflow phases (e.g., "Red baseline phase", "this is expected behavior")
|
|
64
|
+
- Judging test quality based on test runtime results
|
|
65
|
+
|
|
66
|
+
**Allowed**:
|
|
67
|
+
- Reviewing correctness and clarity of test assertions
|
|
68
|
+
- Reviewing test structure and organization
|
|
69
|
+
- Reviewing completeness of test scenarios (based on code analysis, not runtime results)
|
|
70
|
+
|
|
71
|
+
### CON-ROLE-005: Coverage = Test Existence, Not Test Pass Status
|
|
72
|
+
|
|
73
|
+
| Coverage Status | Definition | Judgment Criteria |
|
|
74
|
+
|-----------------|------------|-------------------|
|
|
75
|
+
| ✅ Covered | Corresponding test case exists for AC | Test/it block exists in test file |
|
|
76
|
+
| ⚠️ Partially Covered | Test exists but scenarios incomplete | Missing boundary conditions, error paths, etc. |
|
|
77
|
+
| ❌ Missing | No corresponding test case | No matching test code found |
|
|
78
|
+
|
|
79
|
+
**Prohibited** from including the following in coverage assessment:
|
|
80
|
+
- Test Skip status (skipped tests still count as "Covered")
|
|
81
|
+
- Test Fail status (failing tests still count as "Covered")
|
|
82
|
+
- Test runtime or performance
|
|
83
|
+
|
|
56
84
|
---
|
|
57
85
|
|
|
58
86
|
## Review Dimensions
|
|
@@ -104,11 +132,13 @@ Before execution, you **must** search for configuration in the following order (
|
|
|
104
132
|
|
|
105
133
|
## Coverage Analysis
|
|
106
134
|
|
|
135
|
+
> **Note**: Coverage status is based on test code existence, not test runtime results (Pass/Fail/Skip).
|
|
136
|
+
|
|
107
137
|
| AC-ID | Test File | Coverage Status | Notes |
|
|
108
138
|
|-------|-----------|-----------------|-------|
|
|
109
|
-
| AC-001 | test-a.ts | Covered |
|
|
110
|
-
| AC-002 | - | Missing |
|
|
111
|
-
| AC-003 | test-b.ts | Partially Covered |
|
|
139
|
+
| AC-001 | test-a.ts | ✅ Covered | Test case exists |
|
|
140
|
+
| AC-002 | - | ❌ Missing | No corresponding test code |
|
|
141
|
+
| AC-003 | test-b.ts | ⚠️ Partially Covered | Test exists but missing boundary conditions |
|
|
112
142
|
|
|
113
143
|
## Issue List
|
|
114
144
|
|
|
@@ -178,7 +208,7 @@ After completing the review, you **must** provide a clear conclusion:
|
|
|
178
208
|
| Skill Name | devbooks-test-reviewer |
|
|
179
209
|
| Phase | Apply |
|
|
180
210
|
| Artifact | Review report (not written to change package) |
|
|
181
|
-
| Constraints | CON-ROLE-001~
|
|
211
|
+
| Constraints | CON-ROLE-001~005 |
|
|
182
212
|
|
|
183
213
|
---
|
|
184
214
|
|