dev-playbooks 1.2.4 → 1.2.5

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "dev-playbooks",
-  "version": "1.2.4",
+  "version": "1.2.5",
   "description": "AI-powered spec-driven development workflow",
   "keywords": [
     "devbooks",

package/skills/devbooks-code-review/SKILL.md

@@ -148,6 +148,15 @@ After completing code-review, the next step depends on the situation:
 | No spec deltas | Archive complete | No further skills needed |
 | Major issues found | Hand back to `devbooks-coder` | Fix issues before archive |
 
+### Reviewer Exclusive Permission: Set verification.md Status
+
+**Only Reviewer can set `verification.md` Status to `Done`**.
+
+After review passes, Reviewer must:
+1. Open `<change-root>/<change-id>/verification.md`
+2. Change `- Status: Ready` to `- Status: Done`
+3. This is a prerequisite for archive (`change-check.sh --mode archive` will verify)
+
 ### Output Template
 
 After completing code-review, output:

package/skills/devbooks-coder/SKILL.md

@@ -141,6 +141,7 @@ devbooks change-evidence <change-id> --label green-final -- npm test
 ### Role Boundary Constraints
 - **Modifying `tests/**` is prohibited** (changes to tests must be handed back to Test Owner)
 - **Modifying `verification.md` is prohibited** (maintained by Test Owner)
+- **Modifying `verification.md` Status field is prohibited** (only Reviewer can set it to Done)
 - **Modifying `.devbooks/`, `build/`, or engineering configuration files is prohibited** (unless explicitly stated in proposal.md)
 
 ### Code Quality Constraints

package/skills/devbooks-delivery-workflow/scripts/change-check.sh

@@ -411,6 +411,25 @@ check_verification() {
     return 0
   fi
 
+  # ==========================================================================
+  # AC-010: Verification Status Check
+  # Status field controls change package lifecycle: Draft → Ready → Done → Archived
+  # Only Reviewer can set Status to "Done" (Coder/Test Owner prohibited)
+  # ==========================================================================
+  if [[ "$mode" == "archive" || "$mode" == "strict" ]]; then
+    local status_line
+    status_line=$(rg -n "^- Status[:：] *(Draft|Ready|Done|Archived)\b" "$verification_file" -m 1 || true)
+    if [[ -z "$status_line" ]]; then
+      err "verification missing Status line (e.g., '- Status: Done'): ${verification_file}"
+    else
+      local status_value
+      status_value="$(echo "$status_line" | sed -E 's/^[0-9]+:- Status[:：] *//')"
+      if [[ "$status_value" != "Done" && "$status_value" != "Archived" ]]; then
+        err "verification Status must be 'Done' or 'Archived' for ${mode} (current: '${status_value}'). Only Reviewer can set Status to Done: ${verification_file}"
+      fi
+    fi
+  fi
+
   for h in "A\\) Test Plan Instructions" "B\\) Traceability Matrix" "C\\) Deterministic Anchors" "D\\) MANUAL-\\* Checklist"; do
     if ! rg -n "${h}" "$verification_file" >/dev/null; then
       err "verification missing section '${h}': ${verification_file}"

package/skills/devbooks-delivery-workflow/scripts/change-scaffold.sh

@@ -288,7 +288,13 @@ cat <<'EOF' | render_template | write_file "${change_dir}/verification.md"
 ## Metadata
 
 - Change ID: `__CHANGE_ID__`
-- Status: Draft | Ready | Done | Archived
+- Status: Draft
+  > Status lifecycle: Draft → Ready → Done → Archived
+  > - Draft: Initial state
+  > - Ready: Test plan ready (set by Test Owner)
+  > - Done: All tests passed + Review approved (set by **Reviewer only**)
+  > - Archived: Archived (set by Spec Gardener)
+  > **Constraint: Coder is prohibited from modifying Status field**
 - Links:
   - Proposal: `__CHANGE_ROOT__/__CHANGE_ID__/proposal.md`
   - Design: `__CHANGE_ROOT__/__CHANGE_ID__/design.md`

package/skills/devbooks-test-owner/SKILL.md

@@ -40,6 +40,17 @@ Before execution, **must** search for configuration in the following order (stop
 
 Test Owner must produce a structured `verification.md` that serves as both test plan and traceability document.
 
+### Status Field Permissions
+
+| Status | Meaning | Who Can Set |
+|--------|---------|-------------|
+| `Draft` | Initial state | Auto-generated |
+| `Ready` | Test plan ready | **Test Owner** |
+| `Done` | Review passed | Reviewer (Test Owner/Coder prohibited) |
+| `Archived` | Archived | Spec Gardener |
+
+**Constraint**: After completing the test plan, Test Owner should set Status to `Ready`.
+
 ```markdown
 # Verification Plan: <change-id>