dev-loops 0.7.1 → 0.8.0

package/scripts/github/reconcile-draft-gate.mjs

@@ -1,7 +1,7 @@
 #!/usr/bin/env node
 import { parseArgs } from "node:util";
 import { buildParseError, formatCliError, isDirectCliRun, parseJsonText } from "../_core-helpers.mjs";
-import { parsePrNumber, requireTokenValue, runChild } from "../_cli-primitives.mjs";
+import { parsePrNumber, requireTokenValue, runChild as defaultRunChild } from "../_cli-primitives.mjs";
 import { loadDevLoopConfig, resolveGateConfig } from "@dev-loops/core/config";
 import { parseRepoSlug } from "@dev-loops/core/github/repo-slug";
 import { detectCheckpointEvidence } from "./detect-checkpoint-evidence.mjs";
@@ -105,7 +105,7 @@ const PR_ID_QUERY = [
   "  }",
   "}",
 ].join("\n");
-async function resolvePrNodeId({ repo, pr }, { env, ghCommand }) {
+async function resolvePrNodeId({ repo, pr }, { env, ghCommand, runChild = defaultRunChild }) {
   const [owner, name] = repo.split("/");
   const result = await runChild(ghCommand, [
     "api", "graphql",
@@ -128,8 +128,8 @@ async function resolvePrNodeId({ repo, pr }, { env, ghCommand }) {
   }
   return { id: prData.id, isDraft: prData.isDraft };
 }
-export async function convertPrToDraft({ repo, pr }, { env, ghCommand }) {
-  const resolvedPr = await resolvePrNodeId({ repo, pr }, { env, ghCommand });
+export async function convertPrToDraft({ repo, pr }, { env, ghCommand, runChild = defaultRunChild }) {
+  const resolvedPr = await resolvePrNodeId({ repo, pr }, { env, ghCommand, runChild });
   if (resolvedPr.isDraft === true) {
     return {
       ...resolvedPr,
@@ -158,7 +158,7 @@ export async function convertPrToDraft({ repo, pr }, { env, ghCommand }) {
     alreadyDraft: false,
   };
 }
-export async function markPrReady({ repo, pr }, { env, ghCommand }) {
+export async function markPrReady({ repo, pr }, { env, ghCommand, runChild = defaultRunChild }) {
   const result = await runChild(ghCommand, [
     "pr", "ready", String(pr),
     "--repo", repo,
@@ -201,7 +201,7 @@ function summarizeBlockingChecks(blockingChecks) {
     .map((check) => `${check.name || "unnamed-check"}=${check.bucket}`)
     .join(", ");
 }
-async function checkCiStatus({ repo, pr, headSha }, { env, ghCommand }) {
+async function checkCiStatus({ repo, pr, headSha }, { env, ghCommand, runChild = defaultRunChild }) {
   const result = await runChild(ghCommand, [
     "pr", "checks", String(pr),
     "--repo", repo,
@@ -244,12 +244,12 @@ async function checkCiStatus({ repo, pr, headSha }, { env, ghCommand }) {
       : `Blocking CI/check state on head ${headSha.slice(0, 7)}: ${summarizeBlockingChecks(blockingChecks)}.`,
   };
 }
-export async function reconcileDraftGate(options, { env = process.env, ghCommand = "gh", repoRoot = process.cwd() } = {}) {
+export async function reconcileDraftGate(options, { env = process.env, ghCommand = "gh", repoRoot = process.cwd(), runChild = defaultRunChild } = {}) {
   const { config } = await loadDevLoopConfig({ repoRoot });
   const draftGateConfig = resolveGateConfig(config, "draft");
   const initialEvidence = await detectCheckpointEvidence(
     { repo: options.repo, pr: options.pr },
-    { env, ghCommand }
+    { env, ghCommand, runChild }
   );
   const headSha = initialEvidence.currentHeadSha;
   if (!headSha) {
@@ -271,7 +271,7 @@ export async function reconcileDraftGate(options, { env = process.env, ghCommand
   if (draftGateConfig.requireCi) {
     const ciStatus = await checkCiStatus(
       { repo: options.repo, pr: options.pr, headSha },
-      { env, ghCommand }
+      { env, ghCommand, runChild }
     );
     if (ciStatus.status !== "success") {
       throw new Error(
@@ -280,7 +280,7 @@ export async function reconcileDraftGate(options, { env = process.env, ghCommand
       );
     }
   }
-  const draftConversion = await convertPrToDraft({ repo: options.repo, pr: options.pr }, { env, ghCommand });
+  const draftConversion = await convertPrToDraft({ repo: options.repo, pr: options.pr }, { env, ghCommand, runChild });
   let gateResult;
   try {
     gateResult = await upsertCheckpointVerdict({
@@ -294,17 +294,17 @@ export async function reconcileDraftGate(options, { env = process.env, ghCommand
         ? "Reconciled non-draft PR — draft gate auto-reconciled (CI green)."
         : "Reconciled non-draft PR — draft gate auto-reconciled (CI optional by config).",
       nextAction: "Mark ready for review (auto-reconciled).",
-    }, { env, ghCommand, repoRoot });
+    }, { env, ghCommand, repoRoot, runChild });
   } catch (error) {
     if (draftConversion.alreadyDraft !== true) {
       try {
-        await markPrReady({ repo: options.repo, pr: options.pr }, { env, ghCommand });
+        await markPrReady({ repo: options.repo, pr: options.pr }, { env, ghCommand, runChild });
       } catch {
       }
     }
     throw error;
   }
-  await markPrReady({ repo: options.repo, pr: options.pr }, { env, ghCommand });
+  await markPrReady({ repo: options.repo, pr: options.pr }, { env, ghCommand, runChild });
   return {
     ok: true,
     action: "reconciled",

package/scripts/github/request-copilot-review.mjs

@@ -2,6 +2,7 @@
 import { parseArgs } from "node:util";
 import {
   buildParseError,
+  containsBareCopilotSummon,
   formatCliError,
   isCopilotLogin,
   isDirectCliRun,
@@ -10,11 +11,11 @@ import {
   summarizeCopilotReviews,
   summarizeGateReviewComments,
 } from "../_core-helpers.mjs";
-import { parsePrNumber, requireTokenValue, runChild } from "../_cli-primitives.mjs";
+import { parsePrNumber, requireTokenValue, runChild as defaultRunChild } from "../_cli-primitives.mjs";
 import { fetchGithubReviewThreadsPayload } from "./capture-review-threads.mjs";
 import { parseRepoSlug } from "@dev-loops/core/github/repo-slug";
 import { buildSnapshotFromPrFacts, interpretLoopState } from "@dev-loops/core/loop/copilot-loop-state";
-import { loadDevLoopConfig, resolveRefinement } from "@dev-loops/core/config";
+import { loadDevLoopConfig, resolveEffectiveCopilotRoundCap, resolveRefinement } from "@dev-loops/core/config";
 import { JQ_OUTPUT_PARSE_OPTIONS, JQ_OUTPUT_USAGE, emitResult, matchJqOutputToken } from "../lib/jq-output.mjs";
 const BLOCKED_BY_COPILOT_COMMENT_STATUS = "blocked_by_copilot_comment";
 const SUPPRESSED_SAME_HEAD_CLEAN_STATUS = "suppressed_same_head_clean";
@@ -30,13 +31,19 @@ Optional:
   --force-rerequest-review  Bypass the round cap when new commits exist since
                             the last Copilot review. Refused when the PR head
                             has not changed since the last review.
+  --lightweight             This PR is light-dispatched (#1210): enforce the
+                            composed round cap min(localImplementation.lightMode.
+                            maxCopilotRounds ?? 1, refinement.maxCopilotRounds)
+                            instead of refinement.maxCopilotRounds alone.
 Debug:
   DEVLOOPS_DEBUG=1      Emit stderr traces when best-effort same-head clean
                             convergence detection falls back to unsuppressed behavior
 Output (stdout, JSON):
   { "ok": true, "status": "requested"|"already-requested"|"unavailable"|"suppressed_same_head_clean"|"blocked_by_copilot_comment"|"round_cap_reached"|"no_changes_since_last_review"|"suppressed_draft",
     "repo": "...", "pr": N, "reviewer": "Copilot", "detail"?: "...",
-    "sameHeadCleanConverged"?: true, "violationCommentIds"?: [N], "completedRounds"?: N, "maxRounds"?: N }
+    "sameHeadCleanConverged"?: true, "violationCommentIds"?: [N], "completedRounds"?: N, "maxRounds"?: N,
+    "configWarning"?: "..." (present only when --lightweight and dev-loop config failed to load/validate;
+                             the lightweight default cap of 1 was applied instead of the full-PR default) }
 Request statuses:
   requested                     Copilot review was successfully requested
   already-requested             Copilot review was already observably in progress; no new request needed
@@ -52,9 +59,20 @@ Error output (stderr, JSON):
   gh/runtime failures:
     { "ok": false, "error": "..." }
 ${JQ_OUTPUT_USAGE}
+Status contract: "ok": true means the helper ran without error, NOT that a
+review was placed. Callers MUST branch on "status", never on "ok" truthiness
+alone — every non-"requested" status (including blocked_by_copilot_comment)
+is a caller-must-branch outcome, not a silent success.
+--silent exit code: 0 only when status is "requested" (a new request was just
+placed this run); non-zero for every other status, including
+already-requested/suppressed_same_head_clean/unavailable/blocked_by_copilot_comment/
+round_cap_reached/no_changes_since_last_review/suppressed_draft. Without
+--silent the JSON body always prints regardless of status. --jq combined with
+--silent keeps the shared jq-stream truthiness semantics (exit reflects the
+filtered value) and is exempt from the status-based rule above.
 Exit codes:
-  0  Success (including unavailable)
-  1  Argument error or gh failure
+  0  Success (including unavailable); with --silent, only when status is "requested"
+  1  Argument error, gh failure, or (--silent) any non-"requested" status
   2  Invalid --jq filter`.trim();
 const parseError = buildParseError(USAGE);
 export function parseRequestCliArgs(argv) {
@@ -63,6 +81,7 @@ export function parseRequestCliArgs(argv) {
     options: {
       help: { type: "boolean", short: "h" },
       "force-rerequest-review": { type: "boolean" },
+      lightweight: { type: "boolean" },
       repo: { type: "string" },
       pr: { type: "string" },
       ...JQ_OUTPUT_PARSE_OPTIONS,
@@ -76,6 +95,7 @@ export function parseRequestCliArgs(argv) {
     repo: undefined,
     pr: undefined,
     forceRerequestReview: false,
+    lightweight: false,
   };
   for (const token of tokens) {
     if (token.kind === "positional") {
@@ -92,6 +112,10 @@ export function parseRequestCliArgs(argv) {
       options.forceRerequestReview = true;
       continue;
     }
+    if (token.name === "lightweight") {
+      options.lightweight = true;
+      continue;
+    }
     if (token.name === "repo") {
       options.repo = requireTokenValue(token, parseError).trim();
       continue;
@@ -152,7 +176,7 @@ function parseReviewsPayload(text, { draftGateResetAtMs = null } = {}) {
     completedCopilotReviewRounds: reviewSummary.completedCopilotReviewRounds,
   };
 }
-async function fetchRequestedReviewers({ repo, pr }, { env = process.env, ghCommand = "gh" } = {}) {
+async function fetchRequestedReviewers({ repo, pr }, { env = process.env, ghCommand = "gh", runChild = defaultRunChild } = {}) {
   const result = await runChild(
     ghCommand,
     ["api", `repos/${repo}/pulls/${pr}/requested_reviewers`],
@@ -164,7 +188,7 @@ async function fetchRequestedReviewers({ repo, pr }, { env = process.env, ghComm
   }
   return parseRequestedReviewersPayload(result.stdout);
 }
-async function fetchCopilotReviewIds({ repo, pr }, { env = process.env, ghCommand = "gh" } = {}) {
+async function fetchCopilotReviewIds({ repo, pr }, { env = process.env, ghCommand = "gh", runChild = defaultRunChild } = {}) {
   const result = await runChild(
     ghCommand,
     ["pr", "view", String(pr), "--repo", repo, "--json", "headRefOid,isDraft,state,number,reviews,statusCheckRollup"],
@@ -189,7 +213,7 @@ async function fetchCopilotReviewIds({ repo, pr }, { env = process.env, ghComman
 // detector uses for the latest clean draft_gate marker), not the full checkpoint-
 // evidence pipeline, to keep the added surface minimal. Best-effort: a fetch failure
 // falls back to the raw count, so the cap is never silently disabled.
-async function resolveDraftGateAdjustedRounds(options, { env = process.env, ghCommand = "gh" } = {}, before) {
+async function resolveDraftGateAdjustedRounds(options, { env = process.env, ghCommand = "gh", runChild = defaultRunChild } = {}, before) {
   try {
     const currentHeadSha = typeof before?.prData?.headRefOid === "string" && before.prData.headRefOid.trim().length > 0
       ? before.prData.headRefOid.trim()
@@ -362,7 +386,7 @@ function classifyRequestFailure(detail) {
   }
   return undefined;
 }
-async function requestCopilotReview({ repo, pr }, { env = process.env, ghCommand = "gh" } = {}) {
+async function requestCopilotReview({ repo, pr }, { env = process.env, ghCommand = "gh", runChild = defaultRunChild } = {}) {
   const result = await runChild(
     ghCommand,
     ["pr", "edit", String(pr), "--repo", repo, "--add-reviewer", "@copilot"],
@@ -374,7 +398,7 @@ async function requestCopilotReview({ repo, pr }, { env = process.env, ghCommand
     if (classified === "unavailable") {
       let existing;
       try {
-        existing = await fetchCopilotReviewIds({ repo, pr }, { env, ghCommand });
+        existing = await fetchCopilotReviewIds({ repo, pr }, { env, ghCommand, runChild });
       } catch {
         // Best-effort: if gh pr view fails transiently (rate limit, network, auth),
         // return unavailable rather than throwing — the 422 failure is already stable.
@@ -415,7 +439,7 @@ async function requestCopilotReview({ repo, pr }, { env = process.env, ghCommand
     reviewer: "Copilot",
   };
 }
-export async function checkForCopilotComments({ repo, pr }, { env = process.env, ghCommand = "gh" } = {}) {
+export async function checkForCopilotComments({ repo, pr }, { env = process.env, ghCommand = "gh", runChild = defaultRunChild } = {}) {
   const result = await runChild(
     ghCommand,
     ["api", `repos/${repo}/issues/${pr}/comments`, "--paginate", "--jq", ".[]"],
@@ -442,7 +466,9 @@ export async function checkForCopilotComments({ repo, pr }, { env = process.env,
     if (isCopilotLogin(author)) {
       continue;
     }
-    if (/(?:^|\W)(@copilot|\/copilot)(?:$|\W)/i.test(body)) {
+    // Exempt bare-text occurrences inside inline code spans/fenced blocks: a
+    // gate-evidence comment legitimately quotes the anti-summon rule itself.
+    if (containsBareCopilotSummon(body)) {
       violationCommentIds.push(comment.id);
     }
   }
@@ -451,8 +477,9 @@ export async function checkForCopilotComments({ repo, pr }, { env = process.env,
     violationCommentIds,
   };
 }
-export async function performCopilotReviewRequest(options, { env = process.env, ghCommand = "gh" } = {}) {
-  const before = await fetchCopilotReviewState(options, { env, ghCommand });
+export async function performCopilotReviewRequest(options, { env = process.env, ghCommand = "gh", runChild = defaultRunChild } = {}) {
+  const runtime = { env, ghCommand, runChild };
+  const before = await fetchCopilotReviewState(options, runtime);
   if (before.prData?.isDraft) {
     return {
       ok: true,
@@ -464,7 +491,7 @@ export async function performCopilotReviewRequest(options, { env = process.env,
     };
   }
   if (!env.GH_SEQUENCE_PATH) {
-    const copilotCommentCheck = await checkForCopilotComments(options, { env, ghCommand });
+    const copilotCommentCheck = await checkForCopilotComments(options, runtime);
     if (copilotCommentCheck.blocked) {
       return {
         ok: true,
@@ -479,16 +506,47 @@ export async function performCopilotReviewRequest(options, { env = process.env,
   }
   let refinementConfig = { maxCopilotRounds: 5 };
   let maxRounds = 5; // Built-in default; overridden by config when loadable
+  // Lightweight fallback when config is unreadable/invalid: fail toward the
+  // SAFE (smaller) lightweight cap instead of silently inheriting the
+  // full-PR default of 5 above, which would let a light-dispatched PR run
+  // far more review rounds than intended whenever the config can't be read.
+  const LIGHTWEIGHT_DEFAULT_CAP = 1;
+  let configWarning = null;
   try {
     const { config, errors } = await loadDevLoopConfig();
     if (!errors || errors.length === 0) {
       refinementConfig = resolveRefinement(config);
-      if (Number.isFinite(refinementConfig.maxCopilotRounds) && refinementConfig.maxCopilotRounds > 0) {
-        maxRounds = refinementConfig.maxCopilotRounds;
+      // Light-dispatched PRs (#1210) enforce the COMPOSED cap —
+      // min(lightMode.maxCopilotRounds ?? 1, refinement.maxCopilotRounds) — so
+      // this enforcement backstop cannot permit rounds beyond the lightweight cap.
+      const effectiveCap = options.lightweight
+        ? resolveEffectiveCopilotRoundCap(config, { lightweight: true })
+        : refinementConfig.maxCopilotRounds;
+      // >= 0 (not > 0): maxCopilotRounds: 0 is documented as "disable Copilot
+      // rounds"; it must be honored as an immediate refusal, not silently
+      // ignored in favor of the built-in default of 5.
+      if (Number.isFinite(effectiveCap) && effectiveCap >= 0) {
+        maxRounds = effectiveCap;
       }
+      if (options.lightweight) {
+        refinementConfig = { ...refinementConfig, maxCopilotRounds: effectiveCap };
+      }
+    } else if (options.lightweight) {
+      maxRounds = LIGHTWEIGHT_DEFAULT_CAP;
+      refinementConfig = { ...refinementConfig, maxCopilotRounds: LIGHTWEIGHT_DEFAULT_CAP };
+      configWarning = `dev-loop config could not be validated; using the lightweight default cap of ${LIGHTWEIGHT_DEFAULT_CAP} instead of the full-PR default. errors=${JSON.stringify(errors)}`;
+    }
+  } catch (err) {
+    if (options.lightweight) {
+      maxRounds = LIGHTWEIGHT_DEFAULT_CAP;
+      refinementConfig = { ...refinementConfig, maxCopilotRounds: LIGHTWEIGHT_DEFAULT_CAP };
+      configWarning = `dev-loop config could not be loaded; using the lightweight default cap of ${LIGHTWEIGHT_DEFAULT_CAP} instead of the full-PR default. error=${err instanceof Error ? err.message : String(err)}`;
     }
-  } catch {
   }
+  // Every remaining return in this function is config-dependent (round-cap
+  // decisions, the request itself); surface a config-load fallback on all of
+  // them rather than just the path a given test happens to exercise.
+  const withConfigWarning = (result) => (configWarning ? { ...result, configWarning } : result);
   // Reconcile the completed-round count with detect-pr-gate-coordination-state (#896):
   // when the raw count has reached the cap, re-derive it with the draft-gate round
   // reset applied. A clean draft_gate re-pass on an earlier head resets the count, so
@@ -498,7 +556,7 @@ export async function performCopilotReviewRequest(options, { env = process.env,
   if (completedRounds >= maxRounds
       && !before.requested
       && !before.hasPendingReviewOnCurrentHead) {
-    completedRounds = await resolveDraftGateAdjustedRounds(options, { env, ghCommand }, before);
+    completedRounds = await resolveDraftGateAdjustedRounds(options, runtime, before);
   }
   if (completedRounds >= maxRounds
       && !before.requested
@@ -506,12 +564,12 @@ export async function performCopilotReviewRequest(options, { env = process.env,
     if (!options.forceRerequestReview) {
       const roundCapAutoRerequest = await detectRoundCapAutoRerequestEligibility(
         options,
-        { env, ghCommand },
+        runtime,
         before,
         refinementConfig,
       );
       if (!roundCapAutoRerequest.eligible) {
-        return {
+        return withConfigWarning({
           ok: true,
           status: ROUND_CAP_REACHED_STATUS,
           repo: options.repo,
@@ -520,7 +578,7 @@ export async function performCopilotReviewRequest(options, { env = process.env,
           completedRounds,
           maxRounds,
           detail: `Round cap of ${maxRounds} reached with ${completedRounds} completed rounds. No further re-requests will be made.`,
-        };
+        });
       }
     }
     // --force-rerequest-review: only bypass when there are new commits since the last review
@@ -531,7 +589,7 @@ export async function performCopilotReviewRequest(options, { env = process.env,
     const canCompare = currentHeadSha !== null && lastReviewSha !== null;
     const hasNewCommits = canCompare && currentHeadSha !== lastReviewSha;
     if (!canCompare) {
-      return {
+      return withConfigWarning({
         ok: true,
         status: ROUND_CAP_REACHED_STATUS,
         repo: options.repo,
@@ -540,10 +598,10 @@ export async function performCopilotReviewRequest(options, { env = process.env,
         detail: `Round cap of ${maxRounds} reached with ${completedRounds} completed rounds. --force-rerequest-review was supplied but commit SHA data is unavailable, so change-since-last-review could not be evaluated.`,
         completedRounds,
         maxRounds,
-      };
+      });
     }
     if (!hasNewCommits) {
-      return {
+      return withConfigWarning({
         ok: true,
         status: NO_CHANGES_SINCE_LAST_REVIEW_STATUS,
         repo: options.repo,
@@ -552,17 +610,17 @@ export async function performCopilotReviewRequest(options, { env = process.env,
         detail: "No changes since last Copilot review. --force-rerequest-review requires new commits on the PR head.",
         completedRounds,
         maxRounds,
-      };
+      });
     }
     // Has new commits — bypass the round cap and proceed with the request
   }
   const sameHeadCleanConverged = await detectSameHeadCleanConvergence(
     options,
-    { env, ghCommand },
+    runtime,
     before,
   );
   if (sameHeadCleanConverged) {
-    return {
+    return withConfigWarning({
       ok: true,
       status: SUPPRESSED_SAME_HEAD_CLEAN_STATUS,
       repo: options.repo,
@@ -570,45 +628,45 @@ export async function performCopilotReviewRequest(options, { env = process.env,
       reviewer: "Copilot",
       sameHeadCleanConverged: true,
       detail: "Current head already has a clean submitted Copilot review; same-head clean-convergence suppression is always enforced.",
-    };
+    });
   }
   if (before.requested || before.hasPendingReviewOnCurrentHead) {
-    return {
+    return withConfigWarning({
       ok: true,
       status: "already-requested",
       repo: options.repo,
       pr: options.pr,
       reviewer: "Copilot",
-    };
+    });
   }
-  const requestResult = await requestCopilotReview(options, { env, ghCommand });
+  const requestResult = await requestCopilotReview(options, runtime);
   if (requestResult.status === "unavailable") {
-    const after = await fetchCopilotReviewState(options, { env, ghCommand });
+    const after = await fetchCopilotReviewState(options, runtime);
     if (after.requested || after.hasPendingReviewOnCurrentHead || after.hasSubmittedReviewOnCurrentHead) {
-      return {
+      return withConfigWarning({
         ok: true,
         status: "already-requested",
         repo: options.repo,
         pr: options.pr,
         reviewer: "Copilot",
-      };
+      });
     }
-    return {
+    return withConfigWarning({
       ...requestResult,
-    };
+    });
   }
   if (requestResult.status === "already-requested") {
-    return requestResult;
+    return withConfigWarning(requestResult);
   }
-  const after = await fetchCopilotReviewState(options, { env, ghCommand });
+  const after = await fetchCopilotReviewState(options, runtime);
   const reviewCountIncreased = after.copilotReviewIds.length > before.copilotReviewIds.length;
   const reviewNowObservablyInProgress = after.requested || after.hasPendingReviewOnCurrentHead || reviewCountIncreased;
   if (!reviewNowObservablyInProgress) {
     throw new Error("Copilot review request did not appear in requested reviewers or fresh/in-progress Copilot reviews after gh pr edit");
   }
-  return {
+  return withConfigWarning({
     ...requestResult,
-  };
+  });
 }
 export async function runCli(
   argv = process.argv.slice(2),
@@ -625,7 +683,16 @@ export async function runCli(
     return;
   }
   const result = await performCopilotReviewRequest(options, { env, ghCommand });
-  process.exitCode = emitResult(result, { jq: options.jq, silent: options.silent, stdout, stderr });
+  // Honest status under --silent: `ok: true` reports "the helper ran without
+  // error", not "a review was placed" — a caller checking only exit-code
+  // truthiness must NOT read a non-`requested` status (blocked_by_copilot_comment,
+  // round_cap_reached, etc.) as a placed request. --silent therefore answers
+  // "was a request just placed" specifically: exit 0 only for `requested`,
+  // non-zero for every other status. Non-silent output is unaffected — the full
+  // JSON body (with `ok: true`) still prints for every documented status; the
+  // caller MUST branch on `.status`, not `.ok`.
+  const silentOk = options.silent ? result.status === "requested" : undefined;
+  process.exitCode = emitResult(result, { jq: options.jq, silent: options.silent, stdout, stderr, ok: silentOk });
 }
 if (isDirectCliRun(import.meta.url)) {
   runCli().catch((error) => {