detox 20.15.1-prerelease.0 → 20.17.0

package/android/detox/src/testFull/java/com/wix/detox/espresso/scroll/ScrollHelperTest.kt

@@ -0,0 +1,188 @@
+package com.wix.detox.espresso.scroll
+
+import android.graphics.Insets
+import android.view.MotionEvent
+import android.view.View
+import android.view.WindowInsets
+import androidx.test.espresso.UiController
+import androidx.test.platform.app.InstrumentationRegistry
+import com.wix.detox.action.common.MOTION_DIR_DOWN
+import com.wix.detox.action.common.MOTION_DIR_LEFT
+import com.wix.detox.action.common.MOTION_DIR_RIGHT
+import com.wix.detox.action.common.MOTION_DIR_UP
+import com.wix.detox.espresso.DeviceDisplay
+import org.junit.Test
+import org.junit.runner.RunWith
+import org.mockito.kotlin.any
+import org.mockito.kotlin.argumentCaptor
+import org.mockito.kotlin.mock
+import org.mockito.kotlin.verify
+import org.mockito.kotlin.whenever
+import org.robolectric.RobolectricTestRunner
+import org.robolectric.annotation.Config
+import kotlin.test.assertEquals
+
+private const val INSETS_SIZE = 100
+private const val SCROLL_RANGE_SAFE_PERCENT = 0.9f // ScrollHelper.SCROLL_RANGE_SAFE_PERCENT
+
+@Config(
+    qualifiers = "xxxhdpi", // 1280x1880
+    sdk = [33]
+)
+@RunWith(RobolectricTestRunner::class)
+class ScrollHelperTest {
+
+    private val display = DeviceDisplay.getScreenSizeInPX()
+    private val displayWidth = display[0].toInt()
+    private val displayHeight = display[1].toInt()
+    private val touchSlopPx = ScrollHelper.getViewConfiguration().scaledTouchSlop
+    private val safetyMarginPx = DeviceDisplay.convertDpiToPx(2.0)
+
+    private val uiControllerMock = mock<UiController>()
+    private val viewMock = mockViewWithGestureNavigation(displayWidth, displayHeight)
+
+    @Test
+    fun `should scrolling down by 200 when gesture navigation enabled`() {
+        val amountInDp = 200.0
+        val amountInPx = amountInDp * DeviceDisplay.getDensity()
+
+        ScrollHelper.perform(uiControllerMock, viewMock, MOTION_DIR_DOWN, amountInDp, null, null)
+
+        val upEvent = getUpEvent()
+        // Verify that the scroll started at the center of the view
+        assertEquals(displayWidth / 2.0, upEvent.x.toDouble(), 0.0)
+        // Verify that the scroll ended at the center of the view minus the requested amount
+        assertEquals(displayHeight - amountInPx - touchSlopPx - safetyMarginPx - INSETS_SIZE, upEvent.y.toDouble(), 0.0)
+    }
+
+    @Test
+    fun `should scrolling down by 200 when gesture navigation disabled`() {
+        val amountInDp = 200.0
+        val amountInPx = amountInDp * DeviceDisplay.getDensity()
+
+        val viewMock = mockViewWithoutGestureNavigation(displayWidth, displayHeight)
+        ScrollHelper.perform(uiControllerMock, viewMock, MOTION_DIR_DOWN, amountInDp, null, null)
+
+        val upEvent = getUpEvent()
+        // Verify that the scroll started at the center of the view
+        assertEquals(displayWidth / 2.0, upEvent.x.toDouble(), 0.0)
+        // Verify that the scroll ended at the center of the view minus the requested amount
+        assertEquals(displayHeight - amountInPx - touchSlopPx - safetyMarginPx, upEvent.y.toDouble(), 0.0)
+    }
+
+    @Test
+    fun `should scroll down to edge on full screen view when gesture navigation enabled`() {
+        ScrollHelper.performOnce(uiControllerMock, viewMock, MOTION_DIR_DOWN, null, null)
+        val upEvent = getUpEvent()
+        val amountInPx = displayHeight * SCROLL_RANGE_SAFE_PERCENT
+
+        // Calculate where the scroll should end
+        val targetY = displayHeight - amountInPx -
+            touchSlopPx -
+            safetyMarginPx -
+            INSETS_SIZE
+
+        assertEquals(displayWidth / 2.0, upEvent.x.toDouble(), 0.0)
+        assertEquals(targetY, upEvent.y, 0.0f)
+    }
+
+    @Test
+    fun `should scroll left to edge on full screen view when gesture navigation enabled`() {
+        ScrollHelper.performOnce(uiControllerMock, viewMock, MOTION_DIR_LEFT, null, null)
+        val upEvent = getUpEvent()
+        val amountInPx = displayWidth * SCROLL_RANGE_SAFE_PERCENT
+
+        // Calculate where the scroll should end
+        val targetX = amountInPx +
+            touchSlopPx +
+            INSETS_SIZE
+
+        assertEquals(targetX, upEvent.x, 0.0f)
+        assertEquals(displayHeight / 2.0, upEvent.y.toDouble(), 0.0)
+    }
+
+    @Test
+    fun `should scroll up to edge on full screen view when gesture navigation enabled`() {
+        ScrollHelper.performOnce(uiControllerMock, viewMock, MOTION_DIR_UP,null, null)
+        val upEvent = getUpEvent()
+        val amountInPx = displayHeight * SCROLL_RANGE_SAFE_PERCENT
+
+        // Calculate where the scroll should end
+        val targetY = amountInPx +
+            touchSlopPx +
+            INSETS_SIZE
+
+        assertEquals(displayWidth / 2.0, upEvent.x.toDouble(), 0.0)
+        assertEquals(targetY, upEvent.y, 0.0f)
+    }
+
+    @Test
+    fun `should scroll right to edge on full screen view when gesture navigation enabled`() {
+        ScrollHelper.performOnce(uiControllerMock, viewMock, MOTION_DIR_RIGHT,  null, null)
+        val upEvent = getUpEvent()
+        val amountInPx = displayWidth * SCROLL_RANGE_SAFE_PERCENT
+
+        // Calculate where the scroll should end
+        val targetX = displayWidth - amountInPx -
+            touchSlopPx -
+            safetyMarginPx -
+            INSETS_SIZE
+
+        assertEquals(targetX, upEvent.x, 0.0f)
+        assertEquals(displayHeight / 2.0, upEvent.y.toDouble(), 0.0)
+    }
+
+    /**
+     * Get the performed UP event from the ui controller
+     */
+    private fun getUpEvent(): MotionEvent {
+        val capture = argumentCaptor<Iterable<MotionEvent>>()
+        // Capture the events from the ui controller
+        verify(uiControllerMock).injectMotionEventSequence(capture.capture())
+
+        val listOfCapturedEvents = capture.firstValue.toList()
+        // The last event is the UP event with the target coordinates. All of the rest are not interesting
+        return listOfCapturedEvents.last()
+    }
+
+    private fun mockViewWithoutGestureNavigation(displayWidth: Int, displayHeight: Int): View {
+        // This is how we disable gesture navigation
+        val windowInsets = mock<WindowInsets>() {
+            whenever(it.systemGestureInsets).thenReturn(
+                Insets.of(0, 0, 0, 0)
+            )
+        }
+
+        return mockView(displayWidth, displayHeight, windowInsets)
+    }
+
+    /**
+     * Mock a view with gesture navigation enabled
+     */
+    private fun mockViewWithGestureNavigation(displayWidth: Int, displayHeight: Int): View {
+        // This is how we enable gesture navigation
+        val windowInsets = mock<WindowInsets>() {
+            whenever(it.systemGestureInsets).thenReturn(
+                Insets.of(INSETS_SIZE, INSETS_SIZE, INSETS_SIZE, INSETS_SIZE)
+            )
+        }
+
+        return mockView(displayWidth, displayHeight, windowInsets)
+    }
+
+    private fun mockView(
+        displayWidth: Int,
+        displayHeight: Int,
+        windowInsets: WindowInsets
+    ): View {
+        val view = mock<View>() {
+            whenever(it.width).thenReturn(displayWidth)
+            whenever(it.height).thenReturn(displayHeight)
+            whenever(it.canScrollVertically(any())).thenReturn(true) // We allow endless scroll
+            whenever(it.canScrollHorizontally(any())).thenReturn(true) // We allow endless scroll
+            whenever(it.context).thenReturn(InstrumentationRegistry.getInstrumentation().targetContext)
+            whenever(it.rootWindowInsets).thenReturn(windowInsets)
+        }
+        return view
+    }
+}

package/android/rninfo.gradle

@@ -1,25 +1,37 @@
 import groovy.json.JsonSlurper
 
-def rnVersion = getRNVersion(project.rootDir)
-def rnMajorVer = getMajorVersion(rnVersion)
-println "[$project] RNInfo: detected React Native version: $rnVersion (major=$rnMajorVer)"
-
-project.ext.rnInfo = [
-    version: rnVersion,
-    majorVersion: rnMajorVer,
-    isRN69OrHigher: rnMajorVer >= 69,
-    isRN70OrHigher: rnMajorVer >= 70,
-    isRN71OrHigher: rnMajorVer >= 71,
-]
-
-private static def getRNVersion(workingDir) {
+def getRNVersion = { workingDir ->
+    println("RNInfo: workingDir=$workingDir")
     def jsonSlurper = new JsonSlurper()
-    Map<String, Object> packageJSON  = jsonSlurper.parse(new File("$workingDir/../node_modules/react-native/package.json"))
+    def packageFile = "$workingDir/../node_modules/react-native/package.json"
+    println("RNInfo: reading $packageFile")
+    Map<String, Object> packageJSON  = jsonSlurper.parse(new File(packageFile))
     String rnVersion = packageJSON.get('version')
     return rnVersion
 }
 
-private static def getMajorVersion(semanticVersion) {
+def getMajorVersionInternal = { semanticVersion ->
     Integer rnVersionMajor = semanticVersion.split('\\.')[1].toInteger()
     return rnVersionMajor
 }
+
+ext.getRnMajorVersion = { workingDir ->
+    String rnVersion = getRNVersion(workingDir)
+    Integer rnVersionMajor = getMajorVersionInternal(rnVersion)
+    return rnVersionMajor
+}
+
+def rnVersion = getRNVersion(rootDir)
+def rnMajorVer = getMajorVersionInternal(rnVersion)
+if (hasProperty('project')) {
+    println "[$project] RNInfo: detected React Native version: $rnVersion (major=$rnMajorVer)"
+
+    project.ext.rnInfo = [
+        version       : rnVersion,
+        majorVersion  : rnMajorVer,
+        isRN69OrHigher: rnMajorVer >= 69,
+        isRN70OrHigher: rnMajorVer >= 70,
+        isRN71OrHigher: rnMajorVer >= 71,
+        isRN72OrHigher: rnMajorVer >= 72,
+    ]
+}

package/android/settings.gradle

@@ -1,2 +1,14 @@
+apply from: '../android/rninfo.gradle'
 include ':detox'
-includeBuild('../node_modules/react-native-gradle-plugin')
+
+println("RNInfo: rootDir=$rootDir")
+
+def rnMajorVer = getRnMajorVersion(rootDir)
+println "[settings] RNInfo: detected React Native version: (major=$rnMajorVer)"
+
+if (rnMajorVer < 72) {
+    includeBuild('../node_modules/react-native-gradle-plugin')
+} else {
+    includeBuild('../node_modules/@react-native/gradle-plugin')
+}
+

package/detox.d.ts

@@ -214,7 +214,7 @@ declare global {
                  * This flag tells Detox to print messages like these every time the device gets assigned to a specific suite:
                  *
                  * ```plain text
-                 * 18:03:29.869 detox[40125] i starter.test.js is assigned to 4EC84833-C7EA-4CA3-A6E9-5C30A29EA596 (iPhone 12 Pro Max)
+                 * 18:03:29.869 detox[40125] i starter.test.js is assigned to 4EC84833-C7EA-4CA3-A6E9-5C30A29EA596 (iPhone 15)
                  * ```
                  *
                  * @default true
@@ -644,10 +644,11 @@ declare global {
              */
             selectApp(app: string): Promise<void>;
 
+            // TODO: document permissions types.
             /**
              * Launch the app.
              *
-             * <p>For info regarding launch arguments, refer to the [dedicated guide](https://wix.github.io/Detox/docs/api/launch-args).
+             * <p>For info regarding launch arguments, refer to the [dedicated guide](https://wix.github.io/Detox/docs/guide/launch-args).
              *
              * @example
              * // Terminate the app and launch it again. If set to false, the simulator will try to bring app from background,
@@ -1363,10 +1364,13 @@ declare global {
 
             /**
              * Scroll to edge.
-             * @example await element(by.id('scrollView')).scrollTo('bottom');
+             * @param  edge - left|right|top|bottom
+             * @param startPositionX - the X starting scroll position, in percentage; valid input: `[0.0, 1.0]`, `NaN`; default: `NaN`—choose the best value automatically
+             * @param startPositionY - the Y starting scroll position, in percentage; valid input: `[0.0, 1.0]`, `NaN`; default: `NaN`—choose the best value automatically
+             * @example await element(by.id('scrollView')).scrollTo('bottom', NaN, 0.85);
              * @example await element(by.id('scrollView')).scrollTo('top');
              */
-            scrollTo(edge: Direction): Promise<void>;
+            scrollTo(edge: Direction, startPositionX?: number, startPositionY?: number): Promise<void>;
 
             /**
              * Adjust slider to position.
@@ -1621,23 +1625,25 @@ declare global {
             userTracking?: UserTrackingPermission;
         }
 
+        type BasicPermissionState = 'YES' | 'NO' | 'unset';
+        type ExtendedPermissionState = 'YES' | 'NO' | 'unset' | 'limited';
         type LocationPermission = 'always' | 'inuse' | 'never' | 'unset';
-        type PermissionState = 'YES' | 'NO' | 'unset';
-        type CameraPermission = PermissionState;
-        type ContactsPermission = PermissionState;
-        type CalendarPermission = PermissionState;
-        type HealthPermission = PermissionState;
-        type HomekitPermission = PermissionState;
-        type MediaLibraryPermission = PermissionState;
-        type MicrophonePermission = PermissionState;
-        type MotionPermission = PermissionState;
-        type PhotosPermission = PermissionState;
-        type RemindersPermission = PermissionState;
-        type SiriPermission = PermissionState;
-        type SpeechPermission = PermissionState;
-        type NotificationsPermission = PermissionState;
-        type FaceIDPermission = PermissionState;
-        type UserTrackingPermission = PermissionState;
+
+        type CameraPermission = BasicPermissionState;
+        type ContactsPermission = ExtendedPermissionState;
+        type CalendarPermission = BasicPermissionState;
+        type HealthPermission = BasicPermissionState;
+        type HomekitPermission = BasicPermissionState;
+        type MediaLibraryPermission = BasicPermissionState;
+        type MicrophonePermission = BasicPermissionState;
+        type MotionPermission = BasicPermissionState;
+        type PhotosPermission = ExtendedPermissionState;
+        type RemindersPermission = BasicPermissionState;
+        type SiriPermission = BasicPermissionState;
+        type SpeechPermission = BasicPermissionState;
+        type NotificationsPermission = BasicPermissionState;
+        type FaceIDPermission = BasicPermissionState;
+        type UserTrackingPermission = BasicPermissionState;
 
         interface DeviceLaunchAppConfig {
             /**

package/jest.config.js

@@ -74,7 +74,7 @@ module.exports = {
     'runners/jest/testEnvironment',
     'src/DetoxWorker.js',
     'src/logger/utils/streamUtils.js',
-    'src/realms'
+    'src/realms',
   ],
   resetMocks: true,
   resetModules: true,

package/local-cli/init.js

@@ -106,7 +106,7 @@ function createDefaultConfigurations() {
       simulator: {
         type: 'ios.simulator',
         device: {
-          type: 'iPhone 12',
+          type: 'iPhone 15',
         },
       },
       attached: {

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "detox",
   "description": "E2E tests and automation for mobile",
-  "version": "20.15.1-prerelease.0",
+  "version": "20.17.0",
   "bin": {
     "detox": "local-cli/cli.js"
   },
@@ -34,29 +34,32 @@
     "postinstall": "node scripts/postinstall.js"
   },
   "devDependencies": {
+    "@react-native/eslint-config": "^0.72.2",
+    "@react-native/metro-config": "^0.72.11",
+    "@tsconfig/react-native": "^3.0.0",
     "@types/bunyan": "^1.8.8",
     "@types/child-process-promise": "^2.2.1",
-    "@types/fs-extra": "^9.0.13",
-    "@types/jest": "^28.1.8",
+    "@types/fs-extra": "^11.0.4",
+    "@types/jest": "^29.0.0",
     "@types/node": "^14.18.33",
     "@types/node-ipc": "^9.2.0",
     "@types/ws": "^7.4.0",
-    "@typescript-eslint/eslint-plugin": "^5.59.8",
-    "@typescript-eslint/parser": "^5.59.8",
+    "@typescript-eslint/eslint-plugin": "^6.16.0",
+    "@typescript-eslint/parser": "^6.16.0",
     "cross-env": "^7.0.3",
-    "eslint": "^8.41.0",
-    "eslint-plugin-ecmascript-compat": "^3.0.0",
-    "eslint-plugin-import": "^2.27.5",
+    "eslint": "^8.56.0",
+    "eslint-plugin-ecmascript-compat": "^3.1.0",
+    "eslint-plugin-import": "^2.29.1",
     "eslint-plugin-no-only-tests": "^3.1.0",
     "eslint-plugin-node": "^11.1.0",
-    "eslint-plugin-unicorn": "^47.0.0",
-    "jest": "^28.1.3",
-    "jest-allure2-reporter": "2.0.0-alpha.11",
-    "mockdate": "^2.0.1",
-    "prettier": "^2.4.1",
-    "react-native": "0.71.10",
+    "eslint-plugin-unicorn": "^50.0.1",
+    "jest": "^29.0.0",
+    "jest-allure2-reporter": "^2.0.0-beta.4",
+    "metro-react-native-babel-preset": "0.76.8",
+    "prettier": "^3.1.1",
+    "react-native": "0.72.8",
     "react-native-codegen": "^0.0.8",
-    "typescript": "^4.5.2",
+    "typescript": "^5.3.3",
     "wtfnode": "^0.9.1"
   },
   "dependencies": {
@@ -72,6 +75,7 @@
     "funpermaproxy": "^1.1.0",
     "glob": "^8.0.3",
     "ini": "^1.3.4",
+    "jest-environment-emit": "^1.0.5",
     "json-cycle": "^1.3.0",
     "lodash": "^4.17.11",
     "multi-sort-stream": "^1.0.3",
@@ -104,10 +108,10 @@
     }
   },
   "engines": {
-    "node": ">=14.5.0"
+    "node": ">=16"
   },
   "browserslist": [
-    "node 14"
+    "node 16"
   ],
-  "gitHead": "513f6af839bdcce38f0f76c04c3c8c78a05c9803"
+  "gitHead": "7563d08ce984f7091dcd170f539e680cc5d80080"
 }

package/runners/jest/testEnvironment/index.js

@@ -1,5 +1,6 @@
 const path = require('path');
 
+const WithEmitter = require('jest-environment-emit').default;
 const resolveFrom = require('resolve-from');
 const maybeNodeEnvironment = require(resolveFrom(process.cwd(), 'jest-environment-node'));
 /** @type {typeof import('@jest/environment').JestEnvironment} */
@@ -31,7 +32,7 @@ const log = detox.log.child({ cat: 'lifecycle,jest-environment' });
 /**
  * @see https://www.npmjs.com/package/jest-circus#overview
  */
-class DetoxCircusEnvironment extends NodeEnvironment {
+class DetoxCircusEnvironment extends WithEmitter(NodeEnvironment) {
   constructor(config, context) {
     super(assertJestCircus27(config), assertExistingContext(context));
 
@@ -62,6 +63,8 @@ class DetoxCircusEnvironment extends NodeEnvironment {
       SpecReporter,
       WorkerAssignReporter,
     });
+
+    this.testEvents.on('*', this._onTestEvent.bind(this));
   }
 
   /** @override */
@@ -72,19 +75,14 @@ class DetoxCircusEnvironment extends NodeEnvironment {
 
   // @ts-expect-error TS2425
   async handleTestEvent(event, state) {
+    // @ts-expect-error TS2855
+    await super.handleTestEvent(event, state);
+
     if (detox.session.unsafe_earlyTeardown) {
       if (event.name === 'test_fn_start' || event.name === 'hook_start') {
         throw new Error('Detox halted test execution due to an early teardown request');
       }
     }
-
-    this._timer.schedule(state.testTimeout != null ? state.testTimeout : this.setupTimeout);
-
-    if (SYNC_CIRCUS_EVENTS.has(event.name)) {
-      this._handleTestEventSync(event, state);
-    } else {
-      await this._handleTestEventAsync(event, state);
-    }
   }
 
   /** @override */
@@ -147,6 +145,23 @@ class DetoxCircusEnvironment extends NodeEnvironment {
     }
   }
 
+  /** @private */
+  _onTestEvent({ type, event, state }) {
+    const timeout = state && state.testTimeout != null ? state.testTimeout : this.setupTimeout;
+
+    this._timer.schedule(timeout);
+
+    if (event) {
+      if (SYNC_CIRCUS_EVENTS.has(event.name)) {
+        this._handleTestEventSync(event, state);
+      } else {
+        return this._handleTestEventAsync(event, state);
+      }
+    } else {
+      return this._handleTestEventAsync({ name: type }, null);
+    }
+  }
+
   /** @private */
   async _handleTestEventAsync(event, state = null) {
     const description = `handling ${state ? 'jest-circus' : 'jest-environment'} "${event.name}" event`;

package/src/DetoxWorker.js

@@ -132,7 +132,7 @@ class DetoxWorker {
     };
 
     this._artifactsManager = artifactsManagerFactory.createArtifactsManager(this._artifactsConfig, commonDeps);
-    this._deviceCookie = yield this._context[symbols.allocateDevice]();
+    this._deviceCookie = yield this._context[symbols.allocateDevice](this._deviceConfig);
 
     this.device = runtimeDeviceFactory.createRuntimeDevice(
       this._deviceCookie,

package/src/android/actions/native.js

@@ -81,10 +81,10 @@ class ScrollAmountStopAtEdgeAction extends Action {
 }
 
 class ScrollEdgeAction extends Action {
-  constructor(edge) {
+  constructor(edge, startPositionX = -1, startPositionY = -1) {
     super();
 
-    this._call = invoke.callDirectly(DetoxActionApi.scrollToEdge(edge));
+    this._call = invoke.callDirectly(DetoxActionApi.scrollToEdge(edge, startPositionX, startPositionY));
   }
 }
 

package/src/android/core/NativeElement.js

@@ -93,12 +93,12 @@ class NativeElement {
     return await new ActionInteraction(this._invocationManager, this._matcher, action, traceDescription).execute();
   }
 
-  async scrollTo(edge) {
+  async scrollTo(edge, startPositionX, startPositionY) {
     // override the user's element selection with an extended matcher that looks for UIScrollView children
     this._matcher = this._matcher._extendToDescendantScrollViews();
 
-    const action = new actions.ScrollEdgeAction(edge);
-    const traceDescription = actionDescription.scrollTo(edge);
+    const action = new actions.ScrollEdgeAction(edge, startPositionX, startPositionY);
+    const traceDescription = actionDescription.scrollTo(edge, startPositionX, startPositionY);
     return await new ActionInteraction(this._invocationManager, this._matcher, action, traceDescription).execute();
   }
 
@@ -140,7 +140,6 @@ class NativeElement {
   }
 
   async takeScreenshot(screenshotName) {
-    // TODO this should be moved to a lower-layer handler of this use-case
     const action = new actions.TakeElementScreenshot();
     const traceDescription = actionDescription.takeScreenshot(screenshotName);
     const resultBase64 = await new ActionInteraction(this._invocationManager, this._matcher, action, traceDescription).execute();

package/src/android/espressoapi/DetoxAction.js

@@ -68,8 +68,10 @@ class DetoxAction {
     };
   }
 
-  static scrollToEdge(edge) {
+  static scrollToEdge(edge, startOffsetPercentX, startOffsetPercentY) {
     if (typeof edge !== "string") throw new Error("edge should be a string, but got " + (edge + (" (" + (typeof edge + ")"))));
+    if (typeof startOffsetPercentX !== "number") throw new Error("startOffsetPercentX should be a number, but got " + (startOffsetPercentX + (" (" + (typeof startOffsetPercentX + ")"))));
+    if (typeof startOffsetPercentY !== "number") throw new Error("startOffsetPercentY should be a number, but got " + (startOffsetPercentY + (" (" + (typeof startOffsetPercentY + ")"))));
     return {
       target: {
         type: "Class",
@@ -79,6 +81,12 @@ class DetoxAction {
       args: [{
         type: "Integer",
         value: sanitize_android_edge(edge)
+      }, {
+        type: "Double",
+        value: startOffsetPercentX
+      }, {
+        type: "Double",
+        value: startOffsetPercentY
       }]
     };
   }

package/src/android/interactions/native.js

@@ -28,7 +28,7 @@ class ActionInteraction extends Interaction {
   constructor(invocationManager, matcher, action, traceDescription) {
     super(invocationManager, traceDescription);
     this._call = EspressoDetoxApi.perform(matcher, action._call);
-    // TODO: move this.execute() here from the caller
+    // TODO [2024-12-01]: move this.execute() here from the caller
   }
 }
 
@@ -39,7 +39,7 @@ class MatcherAssertionInteraction extends Interaction {
 
     matcher = notCondition ? matcher.not : matcher;
     this._call = DetoxAssertionApi.assertMatcher(call(element._call), matcher._call.value);
-    // TODO: move this.execute() here from the caller
+    // TODO [2024-12-01]: move this.execute() here from the caller
   }
 }
 

package/src/android/matchers/native.js

@@ -76,7 +76,7 @@ class ToggleMatcher extends NativeMatcher {
   }
 }
 
-// TODO: Please be aware, that this is just a dummy matcher
+// NOTE: Please be aware, that this is just a dummy matcher
 class TraitsMatcher extends NativeMatcher {
   constructor(value) {
     super();

package/src/artifacts/providers/index.js

@@ -1,5 +1,5 @@
 class ArtifactPluginsProvider {
-  declareArtifactPlugins({ client }) {} // eslint-disable-line no-unused-vars
+  declareArtifactPlugins({ client }) {} // eslint-disable-line no-unused-vars,@typescript-eslint/no-unused-vars
 }
 
 class AndroidArtifactPluginsProvider extends ArtifactPluginsProvider {

package/src/artifacts/screenshot/SimulatorScreenshotPlugin.js

@@ -1,7 +1,6 @@
 const path = require('path');
 
 const fs = require('../../utils/fsext');
-const log = require('../../utils/logger').child({ cat: 'artifacts-plugin,artifacts' });
 const FileArtifact = require('../templates/artifact/FileArtifact');
 const temporaryPath = require('../utils/temporaryPath');
 

package/src/artifacts/templates/artifact/Artifact.js

@@ -107,7 +107,7 @@ class Artifact {
 
   async doStop() {}
 
-  async doSave(artifactPath) {} // eslint-disable-line no-unused-vars
+  async doSave(_artifactPath) {}
 
   async doDiscard() {}
 }

package/src/client/AsyncWebSocket.js

@@ -134,7 +134,7 @@ class AsyncWebSocket {
     }
   }
 
-  // TODO: handle this leaked abstraction some day
+  // TODO [2024-12-01]: handle this leaked abstraction some day
   hasPendingActions() {
     return _.some(this.inFlightPromises, p => p.message.type !== 'currentStatus');
   }
@@ -168,7 +168,7 @@ class AsyncWebSocket {
       case WebSocket.CONNECTING: return 'opening';
       case WebSocket.OPEN: return 'open';
       /* istanbul ignore next */
-      default: // TODO: [2021-12-01] throw new DetoxInternalError('...'); instead
+      default:
         return undefined;
     }
   }