design-constraint-validator 1.0.0 → 1.1.0

package/core/constraints/monotonic.ts

@@ -1,74 +1,74 @@
-// core/constraints/monotonic.ts
-import type { ConstraintPlugin } from "../engine.js";
-import type { Order } from "../poset.js";
-
-export function MonotonicPlugin(
-  orders: Order[], 
-  parse: (v: unknown) => number | null,
-  ruleId = "monotonic"
-): ConstraintPlugin {
-  return {
-    id: ruleId,
-    evaluate(engine, candidates) {
-      const issues = [];
-      for (const [a, op, b] of orders) {
-        const va = parse(engine.get(a));
-        const vb = parse(engine.get(b));
-        if (va == null || vb == null) continue; // skip unparseable
-        const ok = op === ">=" ? va >= vb : va <= vb;
-        if (!ok && (candidates.has(a) || candidates.has(b))) {
-          issues.push({
-            id: `${a}|${b}`,
-            rule: "monotonic",
-            level: "error" as const,
-            message: `${a} ${op} ${b} violated: ${va} vs ${vb}`
-          });
-        }
-      }
-      return issues;
-    }
-  };
-}
-
-// a minimal parser for "rem"/"px" numbers
-export const parseSize = (v: unknown): number | null => {
-  if (typeof v !== "string") return null;
-  const m = v.trim().match(/^([0-9.]+)(rem|px)?$/i);
-  if (!m) return null;
-  const num = parseFloat(m[1]);
-  const unit = (m[2] || "rem").toLowerCase();
-  return unit === "px" ? num : num * 16; // assume 1rem=16px for comparisons
-};
-
-// Parser for unitless numbers (like scale factors)
-export const parseNumber = (v: unknown): number | null => {
-  if (typeof v === "number") return v;
-  if (typeof v === "string") {
-    const num = parseFloat(v.trim());
-    return isNaN(num) ? null : num;
-  }
-  return null;
-};
-
-// Parser for color lightness (OKLCH L channel)
-export const parseLightness = (v: unknown): number | null => {
-  if (typeof v !== "string") return null;
-  
-  // Match oklch(L C H / A) format
-  const oklchMatch = v.trim().match(/oklch\s*\(\s*([0-9.]+)\s+/i);
-  if (oklchMatch) {
-    return parseFloat(oklchMatch[1]);
-  }
-  
-  // For hex colors, rough approximation (you'd want a proper converter)
-  const hexMatch = v.trim().match(/^#([0-9a-f]{6})$/i);
-  if (hexMatch) {
-    const r = parseInt(hexMatch[1].slice(0, 2), 16) / 255;
-    const g = parseInt(hexMatch[1].slice(2, 4), 16) / 255;
-    const b = parseInt(hexMatch[1].slice(4, 6), 16) / 255;
-    // Simple luminance approximation
-    return 0.299 * r + 0.587 * g + 0.114 * b;
-  }
-  
-  return null;
-};
+// core/constraints/monotonic.ts
+import type { ConstraintPlugin } from "../engine.js";
+import type { Order } from "../poset.js";
+
+export function MonotonicPlugin(
+  orders: Order[], 
+  parse: (v: unknown) => number | null,
+  ruleId = "monotonic"
+): ConstraintPlugin {
+  return {
+    id: ruleId,
+    evaluate(engine, candidates) {
+      const issues = [];
+      for (const [a, op, b] of orders) {
+        const va = parse(engine.get(a));
+        const vb = parse(engine.get(b));
+        if (va == null || vb == null) continue; // skip unparseable
+        const ok = op === ">=" ? va >= vb : va <= vb;
+        if (!ok && (candidates.has(a) || candidates.has(b))) {
+          issues.push({
+            id: `${a}|${b}`,
+            rule: "monotonic",
+            level: "error" as const,
+            message: `${a} ${op} ${b} violated: ${va} vs ${vb}`
+          });
+        }
+      }
+      return issues;
+    }
+  };
+}
+
+// a minimal parser for "rem"/"px" numbers
+export const parseSize = (v: unknown): number | null => {
+  if (typeof v !== "string") return null;
+  const m = v.trim().match(/^([0-9.]+)(rem|px)?$/i);
+  if (!m) return null;
+  const num = parseFloat(m[1]);
+  const unit = (m[2] || "rem").toLowerCase();
+  return unit === "px" ? num : num * 16; // assume 1rem=16px for comparisons
+};
+
+// Parser for unitless numbers (like scale factors)
+export const parseNumber = (v: unknown): number | null => {
+  if (typeof v === "number") return v;
+  if (typeof v === "string") {
+    const num = parseFloat(v.trim());
+    return isNaN(num) ? null : num;
+  }
+  return null;
+};
+
+// Parser for color lightness (OKLCH L channel)
+export const parseLightness = (v: unknown): number | null => {
+  if (typeof v !== "string") return null;
+  
+  // Match oklch(L C H / A) format
+  const oklchMatch = v.trim().match(/oklch\s*\(\s*([0-9.]+)\s+/i);
+  if (oklchMatch) {
+    return parseFloat(oklchMatch[1]);
+  }
+  
+  // For hex colors, rough approximation (you'd want a proper converter)
+  const hexMatch = v.trim().match(/^#([0-9a-f]{6})$/i);
+  if (hexMatch) {
+    const r = parseInt(hexMatch[1].slice(0, 2), 16) / 255;
+    const g = parseInt(hexMatch[1].slice(2, 4), 16) / 255;
+    const b = parseInt(hexMatch[1].slice(4, 6), 16) / 255;
+    // Simple luminance approximation
+    return 0.299 * r + 0.587 * g + 0.114 * b;
+  }
+  
+  return null;
+};

package/core/constraints/threshold.ts

@@ -1,43 +1,43 @@
-import type { ConstraintPlugin } from "../engine.js";
-
-export type ThresholdRule = {
-  id: string;                    // token id to check
-  op: ">=" | "<=";               // comparison
-  valuePx: number;               // threshold in px
-  where?: string;                // optional context label
-  level?: "error" | "warn";      // default error
-};
-
-const parseSizePx = (v: unknown): number | null => {
-  if (typeof v !== "string") return null;
-  const m = v.trim().match(/^([0-9.]+)\s*(px|rem)?$/i);
-  if (!m) return null;
-  const n = parseFloat(m[1]);
-  const unit = (m[2] || "px").toLowerCase();
-  return unit === "rem" ? n * 16 : n;
-};
-
-export function ThresholdPlugin(rules: ThresholdRule[], ruleId = "threshold"): ConstraintPlugin {
-  return {
-    id: ruleId,
-    evaluate(engine, candidates) {
-      const issues = [];
-      for (const r of rules) {
-        if (!candidates.has(r.id)) continue; // incremental
-        const px = parseSizePx(engine.get(r.id));
-        if (px == null) continue;
-        const ok = r.op === ">=" ? px >= r.valuePx : px <= r.valuePx;
-        if (!ok) {
-          issues.push({
-            id: r.id,
-            rule: ruleId,
-            level: r.level ?? "error",
-            where: r.where,
-            message: `${r.id} ${r.op} ${r.valuePx}px violated: ${px}px`
-          });
-        }
-      }
-      return issues;
-    }
-  };
-}
+import type { ConstraintPlugin } from "../engine.js";
+
+export type ThresholdRule = {
+  id: string;                    // token id to check
+  op: ">=" | "<=";               // comparison
+  valuePx: number;               // threshold in px
+  where?: string;                // optional context label
+  level?: "error" | "warn";      // default error
+};
+
+const parseSizePx = (v: unknown): number | null => {
+  if (typeof v !== "string") return null;
+  const m = v.trim().match(/^([0-9.]+)\s*(px|rem)?$/i);
+  if (!m) return null;
+  const n = parseFloat(m[1]);
+  const unit = (m[2] || "px").toLowerCase();
+  return unit === "rem" ? n * 16 : n;
+};
+
+export function ThresholdPlugin(rules: ThresholdRule[], ruleId = "threshold"): ConstraintPlugin {
+  return {
+    id: ruleId,
+    evaluate(engine, candidates) {
+      const issues = [];
+      for (const r of rules) {
+        if (!candidates.has(r.id)) continue; // incremental
+        const px = parseSizePx(engine.get(r.id));
+        if (px == null) continue;
+        const ok = r.op === ">=" ? px >= r.valuePx : px <= r.valuePx;
+        if (!ok) {
+          issues.push({
+            id: r.id,
+            rule: ruleId,
+            level: r.level ?? "error",
+            where: r.where,
+            message: `${r.id} ${r.op} ${r.valuePx}px violated: ${px}px`
+          });
+        }
+      }
+      return issues;
+    }
+  };
+}

package/core/constraints/wcag.ts

@@ -1,70 +1,70 @@
-import type { ConstraintPlugin } from "../engine.js";
-import type { TokenId } from "../flatten.js";
-import { parseCssColor, compositeOver, relativeLuminance, contrastRatio } from "../color.js";
-
-export type ContrastPair = {
-  fg: TokenId;
-  bg: TokenId;
-  min: number;           // e.g., 4.5
-  where?: string;
-  // Optional ultimate backdrop if bg is transparent; token id or literal color.
-  backdrop?: TokenId | string; // default: "#ffffff"
-};
-
-function resolveColor(engineGet: (id: TokenId)=>unknown, x: TokenId | string): string | undefined {
-  if (typeof x !== "string") return undefined;
-  // If it's a CSS color literal, return as is; else treat as token id.
-  const isLiteral = /^#|^rgb|^hsl|^oklch|^oklab|^transparent/i.test(x);
-  return isLiteral ? x : String(engineGet(x) ?? "");
-}
-
-export function WcagContrastPlugin(pairs: ContrastPair[]): ConstraintPlugin {
-  return {
-    id: "wcag-contrast",
-    evaluate(engine, candidates) {
-      const issues = [];
-      for (const p of pairs) {
-        if (!candidates.has(p.fg) && !candidates.has(p.bg)) continue;
-
-        const fgStr = String(engine.get(p.fg) ?? "");
-        const bgStr = String(engine.get(p.bg) ?? "");
-        const fg = parseCssColor(fgStr);
-        const bgRaw = parseCssColor(bgStr);
-
-        const backdropStr = resolveColor(engine.get.bind(engine), p.backdrop ?? "#ffffff");
-        const backdrop = parseCssColor(backdropStr || "#ffffff");
-
-        if (!fg || !bgRaw || !backdrop) {
-          issues.push({
-            id: `${p.fg}|${p.bg}`,
-            rule: "wcag-contrast",
-            level: "warn" as const,
-            where: p.where,
-            message: `Unparseable color(s): fg="${fgStr}" bg="${bgStr}" backdrop="${backdropStr}"`
-          });
-          continue;
-        }
-
-        // Effective background (handle bg alpha)
-        const effBg = bgRaw.a < 1 ? compositeOver(bgRaw, backdrop) : bgRaw;
-        // Effective foreground over effective background
-        const effFg = fg.a < 1 ? compositeOver(fg, effBg) : fg;
-
-        const Lfg = relativeLuminance(effFg);
-        const Lbg = relativeLuminance(effBg);
-        const ratio = contrastRatio(Lfg, Lbg);
-
-        if (ratio < p.min) {
-          issues.push({
-            id: `${p.fg}|${p.bg}`,
-            rule: "wcag-contrast",
-            level: "error" as const,
-            where: p.where,
-            message: `Contrast ${ratio.toFixed(2)}:1 < ${p.min}:1`
-          });
-        }
-      }
-      return issues;
-    }
-  };
-}
+import type { ConstraintPlugin } from "../engine.js";
+import type { TokenId } from "../flatten.js";
+import { parseCssColor, compositeOver, relativeLuminance, contrastRatio } from "../color.js";
+
+export type ContrastPair = {
+  fg: TokenId;
+  bg: TokenId;
+  min: number;           // e.g., 4.5
+  where?: string;
+  // Optional ultimate backdrop if bg is transparent; token id or literal color.
+  backdrop?: TokenId | string; // default: "#ffffff"
+};
+
+function resolveColor(engineGet: (id: TokenId)=>unknown, x: TokenId | string): string | undefined {
+  if (typeof x !== "string") return undefined;
+  // If it's a CSS color literal, return as is; else treat as token id.
+  const isLiteral = /^#|^rgb|^hsl|^oklch|^oklab|^transparent/i.test(x);
+  return isLiteral ? x : String(engineGet(x) ?? "");
+}
+
+export function WcagContrastPlugin(pairs: ContrastPair[]): ConstraintPlugin {
+  return {
+    id: "wcag-contrast",
+    evaluate(engine, candidates) {
+      const issues = [];
+      for (const p of pairs) {
+        if (!candidates.has(p.fg) && !candidates.has(p.bg)) continue;
+
+        const fgStr = String(engine.get(p.fg) ?? "");
+        const bgStr = String(engine.get(p.bg) ?? "");
+        const fg = parseCssColor(fgStr);
+        const bgRaw = parseCssColor(bgStr);
+
+        const backdropStr = resolveColor(engine.get.bind(engine), p.backdrop ?? "#ffffff");
+        const backdrop = parseCssColor(backdropStr || "#ffffff");
+
+        if (!fg || !bgRaw || !backdrop) {
+          issues.push({
+            id: `${p.fg}|${p.bg}`,
+            rule: "wcag-contrast",
+            level: "warn" as const,
+            where: p.where,
+            message: `Unparseable color(s): fg="${fgStr}" bg="${bgStr}" backdrop="${backdropStr}"`
+          });
+          continue;
+        }
+
+        // Effective background (handle bg alpha)
+        const effBg = bgRaw.a < 1 ? compositeOver(bgRaw, backdrop) : bgRaw;
+        // Effective foreground over effective background
+        const effFg = fg.a < 1 ? compositeOver(fg, effBg) : fg;
+
+        const Lfg = relativeLuminance(effFg);
+        const Lbg = relativeLuminance(effBg);
+        const ratio = contrastRatio(Lfg, Lbg);
+
+        if (ratio < p.min) {
+          issues.push({
+            id: `${p.fg}|${p.bg}`,
+            rule: "wcag-contrast",
+            level: "error" as const,
+            where: p.where,
+            message: `Contrast ${ratio.toFixed(2)}:1 < ${p.min}:1`
+          });
+        }
+      }
+      return issues;
+    }
+  };
+}

package/core/cross-axis-config.d.ts

@@ -1,3 +1,32 @@
+/**
+ * @deprecated This module is deprecated. Use cli/cross-axis-loader.ts instead.
+ *
+ * Phase 3B (Filesystem Separation): This file contains filesystem access logic
+ * that has been moved to the CLI layer (cli/cross-axis-loader.ts).
+ *
+ * Core modules should not import from node:fs. Instead:
+ * - CLI code uses cli/cross-axis-loader.ts to read and parse rules
+ * - Core plugin (core/constraints/cross-axis.ts) accepts pre-parsed rules
+ *
+ * Migration:
+ * ```ts
+ * // OLD (core reads filesystem):
+ * import { loadCrossAxisPlugin } from './core/cross-axis-config.js';
+ * engine.use(loadCrossAxisPlugin(path, bp, { knownIds }));
+ *
+ * // NEW (CLI reads, core receives data):
+ * import { loadCrossAxisRules } from './cli/cross-axis-loader.js';
+ * import { CrossAxisPlugin } from './core/constraints/cross-axis.js';
+ * const rules = loadCrossAxisRules(path, { bp, knownIds });
+ * engine.use(CrossAxisPlugin(rules, bp));
+ * ```
+ *
+ * This file will be removed in a future major version.
+ */
+/**
+ * @deprecated Use cli/cross-axis-loader.ts loadCrossAxisRules() + CrossAxisPlugin() instead.
+ * This function will be removed in a future major version.
+ */
 export declare function loadCrossAxisPlugin(path: string, bp?: string, opts?: {
     debug?: boolean;
     knownIds?: Set<string>;

package/core/cross-axis-config.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"cross-axis-config.d.ts","sourceRoot":"","sources":["cross-axis-config.ts"],"names":[],"mappings":"AAQA,wBAAgB,mBAAmB,CACjC,IAAI,EAAE,MAAM,EACZ,EAAE,CAAC,EAAE,MAAM,EACX,IAAI,CAAC,EAAE;IAAE,KAAK,CAAC,EAAE,OAAO,CAAC;IAAC,QAAQ,CAAC,EAAE,GAAG,CAAC,MAAM,CAAC,CAAA;CAAE,0CA2HnD"}
+{"version":3,"file":"cross-axis-config.d.ts","sourceRoot":"","sources":["cross-axis-config.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;;;;GAwBG;AAUH;;;GAGG;AACH,wBAAgB,mBAAmB,CACjC,IAAI,EAAE,MAAM,EACZ,EAAE,CAAC,EAAE,MAAM,EACX,IAAI,CAAC,EAAE;IAAE,KAAK,CAAC,EAAE,OAAO,CAAC;IAAC,QAAQ,CAAC,EAAE,GAAG,CAAC,MAAM,CAAC,CAAA;CAAE,0CA2HnD"}

package/core/cross-axis-config.js

@@ -1,5 +1,34 @@
+/**
+ * @deprecated This module is deprecated. Use cli/cross-axis-loader.ts instead.
+ *
+ * Phase 3B (Filesystem Separation): This file contains filesystem access logic
+ * that has been moved to the CLI layer (cli/cross-axis-loader.ts).
+ *
+ * Core modules should not import from node:fs. Instead:
+ * - CLI code uses cli/cross-axis-loader.ts to read and parse rules
+ * - Core plugin (core/constraints/cross-axis.ts) accepts pre-parsed rules
+ *
+ * Migration:
+ * ```ts
+ * // OLD (core reads filesystem):
+ * import { loadCrossAxisPlugin } from './core/cross-axis-config.js';
+ * engine.use(loadCrossAxisPlugin(path, bp, { knownIds }));
+ *
+ * // NEW (CLI reads, core receives data):
+ * import { loadCrossAxisRules } from './cli/cross-axis-loader.js';
+ * import { CrossAxisPlugin } from './core/constraints/cross-axis.js';
+ * const rules = loadCrossAxisRules(path, { bp, knownIds });
+ * engine.use(CrossAxisPlugin(rules, bp));
+ * ```
+ *
+ * This file will be removed in a future major version.
+ */
 import fs from "node:fs";
 import { CrossAxisPlugin } from "./constraints/cross-axis.js";
+/**
+ * @deprecated Use cli/cross-axis-loader.ts loadCrossAxisRules() + CrossAxisPlugin() instead.
+ * This function will be removed in a future major version.
+ */
 export function loadCrossAxisPlugin(path, bp, opts) {
     const debug = !!opts?.debug;
     const known = opts?.knownIds ?? new Set();