design-comuni-plone-theme 11.24.1 → 11.24.3

package/CHANGELOG.md

@@ -1,5 +1,39 @@
 
 
+## [11.24.3](https://github.com/RedTurtle/design-comuni-plone-theme/compare/v11.24.2...v11.24.3) (2024-10-24)
+
+
+### Features
+
+* show end of recurrence date instead of end date in event ct when set ([#789](https://github.com/RedTurtle/design-comuni-plone-theme/issues/789)) ([23e06c4](https://github.com/RedTurtle/design-comuni-plone-theme/commit/23e06c4c619d41d780f01a67502082d7603e199e))
+
+
+### Bug Fixes
+
+* append / to the end of apiPath because if it hasn't, internal url check for mp4 links fails. ([#794](https://github.com/RedTurtle/design-comuni-plone-theme/issues/794)) ([4f84bc3](https://github.com/RedTurtle/design-comuni-plone-theme/commit/4f84bc31b50b14657d53961ae4e4171e1c68b765))
+
+
+### Maintenance
+
+* added BE info in release.md bc impacts usability ([#791](https://github.com/RedTurtle/design-comuni-plone-theme/issues/791)) ([b608189](https://github.com/RedTurtle/design-comuni-plone-theme/commit/b60818985b4065035cc9b4015890adfe6dbf86db))
+
+
+### Documentation
+
+* updated publiccode and release log ([ffe98a5](https://github.com/RedTurtle/design-comuni-plone-theme/commit/ffe98a5896d6efd05ed63ca64f8a58c7282a0030))
+
+## [11.24.2](https://github.com/RedTurtle/design-comuni-plone-theme/compare/v11.24.1...v11.24.2) (2024-10-16)
+
+
+### Bug Fixes
+
+* do not break LinkView for anonymous users ([#786](https://github.com/RedTurtle/design-comuni-plone-theme/issues/786)) ([a45b7e6](https://github.com/RedTurtle/design-comuni-plone-theme/commit/a45b7e6f9f376526e4e382988371ff46bcb6899e))
+
+
+### Documentation
+
+* updated publiccode ([ade6642](https://github.com/RedTurtle/design-comuni-plone-theme/commit/ade66429389d5632b9071a687e2f8fe25b2b84f1))
+
 ## [11.24.1](https://github.com/RedTurtle/design-comuni-plone-theme/compare/v11.24.0...v11.24.1) (2024-10-09)
 
 

package/RELEASE.md

@@ -41,6 +41,16 @@
 - ...
 -->
 
+## Versione 11.24.3 (24/10/2024)
+
+### Migliorie
+
+- Quando viene impostata una ricorrenza, nel tipo di contenuto Evento viene mostrata la data di fine della ricorrenza invece che del singolo evento
+
+### Fix
+
+- Risolto problema con i video esterni che puntano a degli mp4: ora non vengono più erroneamente visti come link interni.
+
 ## Versione 11.24.0 (03/10/2024)
 
 ### Migliorie
@@ -202,6 +212,10 @@
 
 ## Versione 11.12.5 (30/05/2024)
 
+### Novità
+
+- Per ragioni di conformità alle linee guida Agid, inibito l'inserimento di CT File nella cartella modulistica.
+
 ### Fix
 
 - Sistemato il layout "Card con immagine" dei blocchi elenco quando gli elementi non hanno immagine.

package/package.json

@@ -2,7 +2,7 @@
   "name": "design-comuni-plone-theme",
   "description": "Volto Theme for Italia design guidelines",
   "license": "GPL-v3",
-  "version": "11.24.1",
+  "version": "11.24.3",
   "main": "src/index.js",
   "repository": {
     "type": "git",

package/publiccode.yml

@@ -227,9 +227,9 @@ maintenance:
 name: io-Comune - Il sito AgID per Comuni ed Enti Pubblici
 platforms:
   - web
-releaseDate: '2024-10-03'
+releaseDate: '2024-10-24'
 softwareType: standalone/web
-softwareVersion: 11.24.0
+softwareVersion: 11.24.3
 url: 'https://github.com/italia/design-comuni-plone-theme'
 usedBy:
   - ASP Comuni Modenesi Area Nord

package/src/components/ItaliaTheme/View/Commons/Dates.jsx

@@ -4,7 +4,7 @@ import { rrulei18n } from '@plone/volto/components/manage/Widgets/RecurrenceWidg
 import { injectLazyLibs } from '@plone/volto/helpers/Loadable/Loadable';
 import { Card, CardTitle, CardBody } from 'design-react-kit';
 import PropTypes from 'prop-types';
-import { viewDate } from 'design-comuni-plone-theme/helpers';
+import { viewDate, getRealEventEnd } from 'design-comuni-plone-theme/helpers';
 
 const messages = defineMessages({
   start: {
@@ -46,19 +46,23 @@ const Dates = ({ content, show_image, moment: momentlib, rrule }) => {
 
   const rrulestr = rrule.rrulestr;
 
-  let rruleSet = null;
   let recurrenceText = null;
 
+  const rruleSet = content.recurrence
+    ? rrulestr(content?.recurrence, {
+        compatible: true, //If set to True, the parser will operate in RFC-compatible mode. Right now it means that unfold will be turned on, and if a DTSTART is found, it will be considered the first recurrence instance, as documented in the RFC.
+        forceset: true,
+      })
+    : null;
+
+  const actualEndDate = getRealEventEnd(content, rruleSet);
+
   if (content.recurrence) {
     const isRecurrenceByDay = content.recurrence.includes('BYDAY=+');
     const isWeekdaySunday = content.recurrence
       .split('BYDAY')[1]
       ?.includes('SU');
     const RRULE_LANGUAGE = rrulei18n(intl, moment);
-    rruleSet = rrulestr(content.recurrence, {
-      compatible: true, //If set to True, the parser will operate in RFC-compatible mode. Right now it means that unfold will be turned on, and if a DTSTART is found, it will be considered the first recurrence instance, as documented in the RFC.
-      forceset: true,
-    });
 
     recurrenceText = rruleSet.rrules()[0]?.toText(
       (t) => {
@@ -79,7 +83,8 @@ const Dates = ({ content, show_image, moment: momentlib, rrule }) => {
     );
   }
   const start = viewDate(intl.locale, content.start);
-  const end = viewDate(intl.locale, content.end);
+  // format and save date into new variable depending on recurrence of event
+  const end = viewDate(intl.locale, actualEndDate);
   const openEnd = content?.open_end;
   const wholeDay = content?.whole_day;
   const rdates = rruleSet?.rdates() ?? [];

package/src/components/ItaliaTheme/View/Commons/PageHeader/PageHeaderEventDates.jsx

@@ -4,6 +4,7 @@ import PropTypes from 'prop-types';
 
 import { rrulei18n } from '@plone/volto/components/manage/Widgets/RecurrenceWidget/Utils';
 import { injectLazyLibs } from '@plone/volto/helpers/Loadable/Loadable';
+import { getRealEventEnd } from 'design-comuni-plone-theme/helpers';
 
 const messages = defineMessages({
   dateStart: {
@@ -25,11 +26,23 @@ const PageHeaderEventDates = ({ content, moment, rrule }) => {
   Moment.locale(intl.locale);
 
   const rrulestr = rrule.rrulestr;
+
+  const rruleSet = content.recurrence
+    ? rrulestr(content?.recurrence, {
+        compatible: true, //If set to True, the parser will operate in RFC-compatible mode. Right now it means that unfold will be turned on, and if a DTSTART is found, it will be considered the first recurrence instance, as documented in the RFC.
+        forceset: true,
+      })
+    : null;
+
+  const actualEndDate = getRealEventEnd(content, rruleSet);
+
   const wholeDay = content?.whole_day;
   const openEnd = content?.open_end;
+  // show only start when event starts and ends in same day or if a recurrence is set
+  // because to set a recurrence, the event must have the same date as start and end date
   const renderOnlyStart =
     Moment(content.end).format('DD-MM-Y') ===
-    Moment(content.start).format('DD-MM-Y');
+      Moment(content.start).format('DD-MM-Y') && !content.recurrence;
   let eventRecurrenceText = null;
 
   if (content['@type'] === 'Event') {
@@ -38,10 +51,7 @@ const PageHeaderEventDates = ({ content, moment, rrule }) => {
       const isWeekdaySunday = content.recurrence
         .split('BYDAY')[1]
         ?.includes('SU');
-      const rruleSet = rrulestr(content.recurrence, {
-        compatible: true, //If set to True, the parser will operate in RFC-compatible mode. Right now it means that unfold will be turned on, and if a DTSTART is found, it will be considered the first recurrence instance, as documented in the RFC.
-        forceset: true,
-      });
+
       const RRULE_LANGUAGE = rrulei18n(intl, Moment);
       eventRecurrenceText = rruleSet.rrules()[0]?.toText(
         (t) => {
@@ -55,6 +65,7 @@ const PageHeaderEventDates = ({ content, moment, rrule }) => {
               RRULE_LANGUAGE.strings['on the'] = 'la';
             }
           }
+
           return RRULE_LANGUAGE.strings[t];
         },
         RRULE_LANGUAGE,
@@ -62,15 +73,19 @@ const PageHeaderEventDates = ({ content, moment, rrule }) => {
       );
     }
   }
+
+  // format and save date into new variable depending on recurrence of event
+  const endDate = Moment(actualEndDate).format('DD-MM-Y');
+
   return content['@type'] === 'Event' ? (
     <p className="h4 py-2">
-      {!wholeDay &&
+      {!Moment(content.end).isSame(actualEndDate) &&
         !openEnd &&
         !renderOnlyStart &&
-        `dal ${Moment(content.start).format('DD-MM-Y')} al ${Moment(
-          content.end,
-        ).format('DD-MM-Y')}`}
-      {(wholeDay || renderOnlyStart) &&
+        `dal ${Moment(content.start).format('DD-MM-Y')} al ${endDate}`}
+      {(wholeDay ||
+        renderOnlyStart ||
+        Moment(content.end).isSame(actualEndDate)) &&
         !openEnd &&
         `${Moment(content.start).format('DD-MM-Y')}`}
       {openEnd &&

package/src/customizations/volto/components/manage/Blocks/Video/Body.jsx

@@ -74,6 +74,11 @@ const Body = ({ data, isEditMode }) => {
     ref: ref,
   };
 
+  let apiPath = config.settings.apiPath;
+  if (!apiPath.endsWith('/')) {
+    apiPath += '/';
+  }
+
   return (
     <>
       {data.url && (
@@ -105,10 +110,7 @@ const Body = ({ data, isEditMode }) => {
                       <video
                         src={
                           isInternalURL(
-                            data.url.replace(
-                              getParentUrl(config.settings.apiPath),
-                              '',
-                            ),
+                            data.url.replace(getParentUrl(apiPath), ''),
                           )
                             ? `${data.url}${
                                 data.url.indexOf('@@download/file') < 0

package/src/customizations/volto/components/theme/View/LinkView.jsx

@@ -13,12 +13,12 @@ import config from '@plone/volto/registry';
 
 const LinkView = ({ token, content }) => {
   const history = useHistory();
-  const userIsSpidUser = useSelector(
-    (state) => state.users.user.roles.length === 0,
+  const userWithoutRoles = useSelector((state) =>
+    state.users?.user ? state.users.user?.roles?.length === 0 : true,
   );
 
   useEffect(() => {
-    if (!token || userIsSpidUser) {
+    if (!token || userWithoutRoles) {
       const { remoteUrl } = content;
       if (isInternalURL(remoteUrl)) {
         history.replace(flattenToAppURL(remoteUrl));
@@ -26,7 +26,7 @@ const LinkView = ({ token, content }) => {
         window.location.href = flattenToAppURL(remoteUrl);
       }
     }
-  }, [content, history, token, userIsSpidUser]);
+  }, [content, history, token, userWithoutRoles]);
   const { title, description, remoteUrl } = content;
   const { openExternalLinkInNewTab } = config.settings;
   const Container =

package/src/helpers/dates.js

@@ -11,8 +11,8 @@ export const viewDate = (locale, value, format) => {
         ? // Since we assume UTC everywhere, then transform to local (momentjs default)
           moment(value)
         : value.match(/T(.)/g)
-          ? moment(`${value}Z`) // This might happen in old Plone versions dates
-          : moment(value); //This when date is like '2021-05-05'
+        ? moment(`${value}Z`) // This might happen in old Plone versions dates
+        : moment(value); //This when date is like '2021-05-05'
     } else {
       datetime = moment(value);
     }
@@ -45,3 +45,11 @@ export const getRealStartAndEndWithRecurrence = (
     ),
   };
 };
+
+export const getRealEventEnd = (content, rruleSet) => {
+  let actualEndDate = content.end;
+  if (content.recurrence) {
+    actualEndDate = rruleSet.rrules()[0].options.until;
+  }
+  return actualEndDate;
+};

package/src/helpers/index.js

@@ -21,6 +21,7 @@ export { getItemsByPath } from 'design-comuni-plone-theme/helpers/getItemsByPath
 export {
   viewDate,
   getRealStartAndEndWithRecurrence,
+  getRealEventEnd,
 } from 'design-comuni-plone-theme/helpers/dates';
 export { getSiteProperty } from 'design-comuni-plone-theme/helpers/config';
 export { useDebouncedEffect } from 'design-comuni-plone-theme/helpers/debounce';