dependency-cruiser 17.4.3 → 18.0.0-beta-2

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "dependency-cruiser",
-	"version": "17.4.3",
+	"version": "18.0.0-beta-2",
 	"description": "Validate and visualize dependencies. With your rules. JavaScript, TypeScript, CoffeeScript. ES6, CommonJS, AMD.",
 	"keywords": [
 		"static analysis",
@@ -143,13 +143,13 @@
 		"README.md"
 	],
 	"dependencies": {
-		"acorn": "8.16.0",
+		"acorn": "8.17.0",
 		"acorn-jsx": "5.3.2",
 		"acorn-jsx-walk": "2.0.0",
 		"acorn-loose": "8.5.2",
 		"acorn-walk": "8.3.5",
-		"commander": "14.0.3",
-		"enhanced-resolve": "5.22.1",
+		"commander": "15.0.0",
+		"enhanced-resolve": "5.24.0",
 		"ignore": "7.0.5",
 		"interpret": "3.1.1",
 		"is-installed-globally": "1.0.0",
@@ -158,12 +158,12 @@
 		"prompts": "2.4.2",
 		"rechoir": "0.8.0",
 		"safe-regex": "2.1.1",
-		"semver": "7.8.1",
+		"semver": "7.8.5",
 		"tsconfig-paths-webpack-plugin": "4.2.0",
-		"watskeburt": "5.0.3"
+		"watskeburt": "6.0.0"
 	},
 	"engines": {
-		"node": "^20.12||^22||>=24"
+		"node": "^22||^24||>=26"
 	},
 	"scripts": {
 		"test": "echo see github for test, build and analysis scripts"

package/src/config-utl/extract-babel-config.mjs

@@ -1,7 +1,6 @@
 import { readFile } from "node:fs/promises";
 
 import { extname } from "node:path";
-import json5 from "json5";
 import makeAbsolute from "./make-absolute.mjs";
 import tryImport from "#utl/try-import.mjs";
 import meta from "#meta.cjs";
@@ -36,6 +35,7 @@ async function getJSConfig(pBabelConfigFileName) {
 
 async function getJSON5Config(pBabelConfigFileName) {
 	let lReturnValue = {};
+	const { default: json5 } = await import("json5");
 
 	try {
 		lReturnValue = json5.parse(await readFile(pBabelConfigFileName, "utf8"));
@@ -95,7 +95,7 @@ export default async function extractBabelConfig(pBabelConfigFileName) {
 			filename: pBabelConfigFileName,
 		};
 		lReturnValue = {
-			...babel.loadOptions(lConfig),
+			...babel.loadOptionsSync(lConfig),
 			// according to the babel documentation a config parsed & expanded through
 			// loadOptions can be passed to the parser. With some plugins/ presets
 			// this does not seem to be true anymore, though

package/src/config-utl/extract-depcruise-config/read-config.mjs

@@ -1,6 +1,5 @@
 import { readFile } from "node:fs/promises";
 import { extname } from "node:path";
-import json5 from "json5";
 
 /**
  *
@@ -16,5 +15,6 @@ export default async function readConfig(pAbsolutePathToConfigFile) {
 		);
 		return config;
 	}
+	const { default: json5 } = await import("json5");
 	return json5.parse(await readFile(pAbsolutePathToConfigFile, "utf8"));
 }

package/src/config-utl/extract-known-violations.mjs

@@ -1,5 +1,4 @@
 import { readFile } from "node:fs/promises";
-import json5 from "json5";
 import makeAbsolute from "./make-absolute.mjs";
 
 /**
@@ -53,6 +52,8 @@ function makeForwardCompatible(pKnownViolation) {
 }
 
 export default async function extractKnownViolations(pKnownViolationsFileName) {
+	const { default: json5 } = await import("json5");
+
 	try {
 		const lFileContents = await readFile(
 			makeAbsolute(pKnownViolationsFileName),

package/src/graph-utl/compare.mjs

@@ -1,3 +1,4 @@
+/** @import { IViolation } from "../../types/dependency-cruiser.mjs" */
 /* eslint-disable no-magic-numbers */
 function severity2number(pSeverity) {
 	const lSeverity2Number = new Map([
@@ -16,6 +17,63 @@ export function compareSeverities(pFirstSeverity, pSecondSeverity) {
 	);
 }
 
+/**
+ * Compare two arrays of mini dependencies by their 'name' field.
+ * Used to deterministically order violations that have the same severity/rule/from/to
+ * but differ in their cycle or via paths.
+ *
+ * @param {Array<{name: string}>} pFirstArray - First array (or undefined)
+ * @param {Array<{name: string}>} pSecondArray - Second array (or undefined)
+ * @returns {number} - -1/0/1 following comparison semantics
+ */
+function compareArraysByName(pFirstArray, pSecondArray) {
+	const lFirst = pFirstArray || [];
+	const lSecond = pSecondArray || [];
+	const lMinLength = Math.min(lFirst.length, lSecond.length);
+
+	// eslint-disable-next-line unicorn/prevent-abbreviations, no-plusplus
+	for (let i = 0; i < lMinLength; i++) {
+		// eslint-disable-next-line security/detect-object-injection
+		const lComparison = lFirst[i].name.localeCompare(lSecond[i].name);
+		if (lComparison !== 0) {
+			return lComparison;
+		}
+	}
+
+	return Math.sign(lFirst.length - lSecond.length);
+}
+
+/**
+ * Compare two arrays of strings.
+ *
+ * @param {Array<string>} pFirstArray - First array (or undefined)
+ * @param {Array<string>} pSecondArray - Second array (or undefined)
+ * @returns {number} - -1/0/1 following comparison semantics
+ */
+function compareArrays(pFirstArray, pSecondArray) {
+	const lFirst = pFirstArray || [];
+	const lSecond = pSecondArray || [];
+	const lMinLength = Math.min(lFirst.length, lSecond.length);
+
+	// eslint-disable-next-line unicorn/prevent-abbreviations, no-plusplus
+	for (let i = 0; i < lMinLength; i++) {
+		// eslint-disable-next-line security/detect-object-injection
+		const lComparison = lFirst[i].localeCompare(lSecond[i]);
+		if (lComparison !== 0) {
+			return lComparison;
+		}
+	}
+
+	return Math.sign(lFirst.length - lSecond.length);
+}
+
+/**
+ *
+ * @param {IViolation} pFirstViolation
+ * @param {IViolation} pSecondViolation
+ * @returns
+ */
+// eslint-disable-next-line complexity
 export function compareViolations(pFirstViolation, pSecondViolation) {
 	return (
 		compareSeverities(
@@ -24,7 +82,17 @@ export function compareViolations(pFirstViolation, pSecondViolation) {
 		) ||
 		pFirstViolation.rule.name.localeCompare(pSecondViolation.rule.name) ||
 		pFirstViolation.from.localeCompare(pSecondViolation.from) ||
-		pFirstViolation.to.localeCompare(pSecondViolation.to)
+		pFirstViolation.to.localeCompare(pSecondViolation.to) ||
+		(pFirstViolation.unresolvedTo ?? "").localeCompare(
+			pSecondViolation.unresolvedTo ?? "",
+		) ||
+		(pFirstViolation.type ?? "").localeCompare(pSecondViolation.type ?? "") ||
+		compareArrays(
+			pFirstViolation.dependencyTypes,
+			pSecondViolation.dependencyTypes,
+		) ||
+		compareArraysByName(pFirstViolation.cycle, pSecondViolation.cycle) ||
+		compareArraysByName(pFirstViolation.via, pSecondViolation.via)
 	);
 }
 

package/src/meta.cjs

@@ -1,8 +1,8 @@
 /* generated - don't edit */
 module.exports = {
-	version: "17.4.3",
+	version: "18.0.0-beta-2",
 	engines: {
-		node: "^20.12||^22||>=24",
+		node: "^22||^24||>=26",
 	},
 	supportedTranspilers: {
 		babel: ">=7.0.0 <8.0.0",