dependency-cruiser 17.2.0 → 17.3.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "dependency-cruiser",
-  "version": "17.2.0",
+  "version": "17.3.2",
   "description": "Validate and visualize dependencies. With your rules. JavaScript, TypeScript, CoffeeScript. ES6, CommonJS, AMD.",
   "keywords": [
     "static analysis",
@@ -18,50 +18,51 @@
   ],
   "author": "Sander Verweij (https://sverweij.github.io)",
   "contributors": [
-    "Hirotaka Miyagi (https://mh4gf.dev)",
-    "TruongSinh Tran-Nguyen (https://truongsinh.pro)",
-    "Bastian Hess (https://github.com/bashess)",
+    "0xflotus (https://github.com/0xflotus)",
     "Álvaro Cuesta (https://github.com/alvaro-cuesta)",
     "anna (https://github.com/annamooseity)",
-    "Radosław Kłos (https://klos.dev)",
-    "Joshua T (https://github.com/radiantly)",
-    "Ivan (https://github.com/Winner95)",
-    "Millicent Billette (https://github.com/1000i100)",
-    "Frieder Bluemle (https://github.com/friederbluemle)",
-    "davidparkagoda (https://github.com/davidparkagoda)",
-    "Matt Button (https://github.com/BRMatt)",
-    "Jon Lauridsen (https://jonlauridsen.com)",
-    "Klaus Meinhardt (https://github.com/ajafff)",
-    "cunzaizhuyi (https://github.com/cunzaizhuyi)",
-    "Greg Lockwood (https://github.com/greglockwood)",
-    "Jeremy Magland (https://github.com/magland)",
-    "Sebastian Landwehr (https://sebastianlandwehr.com)",
-    "Brody McKee (https://github.com/mrmckeb)",
+    "Bastian Hess (https://github.com/bashess)",
     "Bin (https://github.com/soulhat)",
-    "정건우 (https://www.zigae.com/)",
-    "Roy Swinkels (https://github.com/donroyco)",
-    "Martin Slota (https://github.com/martinslota)",
-    "Luke Page (https://github.com/lukeapage)",
-    "Emily Marigold Klassen (https://forivall.com)",
+    "Brody McKee (https://github.com/mrmckeb)",
     "Christian Vuerings (https://github.com/christianvuerings)",
-    "Yuanhai He (https://bestmike007.com)",
-    "Quentin de Metz (https://github.com/quentindemetz)",
-    "Lars Artmann (https://larsartmann.com)",
-    "Jessica Kerr (https://jessitron.com)",
     "Creative Ataraxia (https://github.com/Creative-Ataraxia)",
-    "0xflotus (https://github.com/0xflotus)",
-    "KenjiroKubota (https://github.com/kubotak-is)",
+    "cunzaizhuyi (https://github.com/cunzaizhuyi)",
     "Daniel Edholm Ignat (https://github.com/dignite)",
     "Daniel Rodríguez Rivero (https://danielorodriguez.com)",
+    "davidparkagoda (https://github.com/davidparkagoda)",
+    "electrovir (https://github.com/electrovir)",
+    "Emily Marigold Klassen (https://forivall.com)",
+    "Frederik Schubert (https://github.com/ferdynator)",
+    "Frieder Bluemle (https://github.com/friederbluemle)",
+    "fusheng (https://github.com/lin-hun)",
+    "Greg Lockwood (https://github.com/greglockwood)",
+    "Hirotaka Miyagi (https://mh4gf.dev)",
+    "Ivan (https://github.com/Winner95)",
+    "Jeremy Magland (https://github.com/magland)",
+    "Jessica Kerr (https://jessitron.com)",
+    "Jon Lauridsen (https://jonlauridsen.com)",
+    "Joshua T (https://github.com/radiantly)",
+    "KenjiroKubota (https://github.com/kubotak-is)",
+    "Kentaro Suzuki (https://github.com/sushichan044)",
+    "Klaus Meinhardt (https://github.com/ajafff)",
+    "Lars Artmann (https://larsartmann.com)",
+    "Luke Page (https://github.com/lukeapage)",
+    "Martin Slota (https://github.com/martinslota)",
+    "Matt Button (https://github.com/BRMatt)",
+    "Millicent Billette (https://github.com/1000i100)",
     "Nick Ribal (https://github.com/elektronik2k5)",
+    "Quentin de Metz (https://github.com/quentindemetz)",
+    "Radosław Kłos (https://klos.dev)",
     "Richard Musiol (https://github.com/neelance)",
+    "Roy Swinkels (https://github.com/donroyco)",
+    "Sebastian Landwehr (https://sebastianlandwehr.com)",
     "Sharang Pai (https://sharangpai.me)",
     "Stefan Gojan (https://stefan-gojan.de)",
-    "Valentin Semirulnik (https://github.com/7rulnik)",
     "Tharun Rajendran (https://github.com/tharun208)",
-    "electrovir (https://github.com/electrovir)",
-    "fusheng (https://github.com/lin-hun)",
-    "Frederik Schubert (https://github.com/ferdynator)"
+    "TruongSinh Tran-Nguyen (https://truongsinh.pro)",
+    "Valentin Semirulnik (https://github.com/7rulnik)",
+    "Yuanhai He (https://bestmike007.com)",
+    "정건우 (https://www.zigae.com/)"
   ],
   "type": "module",
   "license": "MIT",
@@ -141,34 +142,26 @@
     "README.md"
   ],
   "dependencies": {
-    "acorn": "^8.15.0",
-    "acorn-jsx": "^5.3.2",
-    "acorn-jsx-walk": "^2.0.0",
-    "acorn-loose": "^8.5.2",
-    "acorn-walk": "^8.3.4",
-    "ajv": "^8.17.1",
-    "commander": "^14.0.2",
-    "enhanced-resolve": "^5.18.3",
-    "ignore": "^7.0.5",
-    "interpret": "^3.1.1",
-    "is-installed-globally": "^1.0.0",
-    "json5": "^2.2.3",
-    "memoize": "^10.2.0",
-    "picomatch": "^4.0.3",
-    "prompts": "^2.4.2",
-    "rechoir": "^0.8.0",
-    "safe-regex": "^2.1.1",
-    "semver": "^7.7.3",
-    "tsconfig-paths-webpack-plugin": "^4.2.0",
-    "watskeburt": "^4.2.3"
-  },
-  "overrides": {
-    "cross-spawn": ">=6.0.6",
-    "nanoid": "^3.3.8"
-  },
-  "resolutions": {
-    "cross-spawn": ">=6.0.6",
-    "nanoid": "^3.3.8"
+    "acorn": "8.15.0",
+    "acorn-jsx": "5.3.2",
+    "acorn-jsx-walk": "2.0.0",
+    "acorn-loose": "8.5.2",
+    "acorn-walk": "8.3.4",
+    "ajv": "8.17.1",
+    "commander": "14.0.2",
+    "enhanced-resolve": "5.18.3",
+    "ignore": "7.0.5",
+    "interpret": "3.1.1",
+    "is-installed-globally": "1.0.0",
+    "json5": "2.2.3",
+    "memoize": "10.2.0",
+    "picomatch": "4.0.3",
+    "prompts": "2.4.2",
+    "rechoir": "0.8.0",
+    "safe-regex": "2.1.1",
+    "semver": "7.7.3",
+    "tsconfig-paths-webpack-plugin": "4.2.0",
+    "watskeburt": "5.0.0"
   },
   "engines": {
     "node": "^20.12||^22||>=24"

package/src/cache/content-strategy.mjs

@@ -87,15 +87,15 @@ export default class ContentStrategy {
   revisionDataEqual(pExistingRevisionData, pNewRevisionData) {
     return Boolean(
       pExistingRevisionData &&
-        pNewRevisionData &&
-        // Even though we don't really have a SHA1, it might be the previous version
-        // of the cache did, e.g. because it was rendered with the metadata cache
-        // strategy. In that case the SHA1 comparison is a reliable, fast bailout.
-        pExistingRevisionData.SHA1 === pNewRevisionData.SHA1 &&
-        isDeepStrictEqual(
-          pExistingRevisionData.changes,
-          pNewRevisionData.changes,
-        ),
+      pNewRevisionData &&
+      // Even though we don't really have a SHA1, it might be the previous version
+      // of the cache did, e.g. because it was rendered with the metadata cache
+      // strategy. In that case the SHA1 comparison is a reliable, fast bailout.
+      pExistingRevisionData.SHA1 === pNewRevisionData.SHA1 &&
+      isDeepStrictEqual(
+        pExistingRevisionData.changes,
+        pNewRevisionData.changes,
+      ),
     );
   }
 

package/src/cache/find-content-changes.mjs

@@ -19,6 +19,7 @@ import findAllFiles from "#utl/find-all-files.mjs";
 
 /**
  * @param {Set<string>} pFileSet
+ * @param {string} pBaseDirectory
  * @param {typeof getFileHashSync} pFileHashFunction
  * @returns {(pModule:IModule) => IRevisionChange}
  */

package/src/cache/options-compatible.mjs

@@ -106,6 +106,8 @@ export function optionsAreCompatible(pOldOptions, pNewOptions) {
     pOldOptions.combinedDependencies === pNewOptions.combinedDependencies &&
     pOldOptions.experimentalStats === pNewOptions.experimentalStats &&
     pOldOptions.detectJSDocImports === pNewOptions.detectJSDocImports &&
+    pOldOptions.detectProcessBuiltinModuleCalls ===
+      pNewOptions.detectProcessBuiltinModuleCalls &&
     pOldOptions.skipAnalysisNotInRules === pNewOptions.skipAnalysisNotInRules &&
     metricsIsCompatible(pOldOptions.metrics, pNewOptions.metrics) &&
     // includeOnly suffers from a backwards compatibility disease

package/src/cli/index.mjs

@@ -20,9 +20,8 @@ async function extractResolveOptions(pCruiseOptions) {
     pCruiseOptions?.ruleSet?.options?.webpackConfig?.fileName ?? null;
 
   if (lWebPackConfigFileName) {
-    const { default: extractWebpackResolveConfig } = await import(
-      "#config-utl/extract-webpack-resolve-config.mjs"
-    );
+    const { default: extractWebpackResolveConfig } =
+      await import("#config-utl/extract-webpack-resolve-config.mjs");
     lResolveOptions = await extractWebpackResolveConfig(
       lWebPackConfigFileName,
       pCruiseOptions?.ruleSet?.options?.webpackConfig?.env ?? null,
@@ -34,9 +33,8 @@ async function extractResolveOptions(pCruiseOptions) {
 
 async function addKnownViolations(pCruiseOptions) {
   if (pCruiseOptions.knownViolationsFile) {
-    const { default: extractKnownViolations } = await import(
-      "#config-utl/extract-known-violations.mjs"
-    );
+    const { default: extractKnownViolations } =
+      await import("#config-utl/extract-known-violations.mjs");
     const lKnownViolations = await extractKnownViolations(
       pCruiseOptions.knownViolationsFile,
     );
@@ -56,9 +54,8 @@ async function extractTSConfigOptions(pCruiseOptions) {
     pCruiseOptions?.ruleSet?.options?.tsConfig?.fileName ?? null;
 
   if (lTSConfigFileName) {
-    const { default: extractTSConfig } = await import(
-      "#config-utl/extract-ts-config.mjs"
-    );
+    const { default: extractTSConfig } =
+      await import("#config-utl/extract-ts-config.mjs");
     lReturnValue = extractTSConfig(lTSConfigFileName);
   }
 
@@ -70,9 +67,8 @@ async function extractBabelConfigOptions(pCruiseOptions) {
   const lBabelConfigFileName =
     pCruiseOptions?.ruleSet?.options?.babelConfig?.fileName ?? null;
   if (lBabelConfigFileName) {
-    const { default: extractBabelConfig } = await import(
-      "#config-utl/extract-babel-config.mjs"
-    );
+    const { default: extractBabelConfig } =
+      await import("#config-utl/extract-babel-config.mjs");
     lReturnValue = extractBabelConfig(lBabelConfigFileName);
   }
 
@@ -177,9 +173,8 @@ export default async function executeCli(
     }
     /* c8 ignore stop */
     if (lCruiseOptions.info === true) {
-      const { default: formatMetaInfo } = await import(
-        "./format-meta-info.mjs"
-      );
+      const { default: formatMetaInfo } =
+        await import("./format-meta-info.mjs");
       lStreams.stdout.write(await formatMetaInfo());
     } else if (lCruiseOptions.init) {
       const { default: initConfig } = await import("./init-config/index.mjs");

package/src/cli/init-config/build-config.mjs

@@ -73,6 +73,17 @@ function buildDetectJSDocumentImportsAttribute(pInitOptions) {
     : "// detectJSDocImports: true,";
 }
 
+/**
+ *
+ * @param {IInitConfig} pInitOptions
+ * @returns {string}
+ */
+function buildDetectProcessBuiltinModuleCalls(pInitOptions) {
+  return pInitOptions.detectProcessBuiltinModuleCalls
+    ? "detectProcessBuiltinModuleCalls: true,"
+    : "// detectProcessBuiltinModuleCalls: true,";
+}
+
 /**
  * @param {IInitConfig} pInitOptions
  * @returns {string}
@@ -213,6 +224,10 @@ export default function buildConfig(pInitOptions) {
       "{{detectJSDocImportsAttribute}}",
       buildDetectJSDocumentImportsAttribute(pInitOptions),
     )
+    .replace(
+      "{{detectProcessBuiltinModuleCalls}}",
+      buildDetectProcessBuiltinModuleCalls(pInitOptions),
+    )
     .replace(
       "{{tsPreCompilationDepsAttribute}}",
       buildTsPreCompilationDepsAttribute(pInitOptions),

package/src/cli/init-config/config-template.mjs

@@ -239,6 +239,13 @@ module.exports = {
      */
     {{detectJSDocImportsAttribute}}
 
+    /*
+      false: don't look at process.getBuiltinModule calls (the default)
+      true: dependency-cruiser will detect calls to process.getBuiltinModule/
+      globalThis.process.getBuiltinModule as imports.
+     */
+    {{detectProcessBuiltinModuleCalls}}
+
     /* prefix for links in html and svg output (e.g. 'https://github.com/you/yourrepo/blob/main/'
        to open it on your online repo or \`vscode://file/$\{process.cwd()}/\` to 
        open it in visual studio code),

package/src/cli/init-config/get-user-input.mjs

@@ -113,9 +113,16 @@ const QUESTIONS = [
   {
     name: "detectJSDocImports",
     type: () => (tscIsAvailable() ? "confirm" : false),
-    message: "Do you want to detect JSDoc imports as well (slower)?",
+    message: "Do you want to detect JSDoc imports (slightly slower)?",
     initial: false,
   },
+  {
+    name: "detectProcessBuiltinModuleCalls",
+    type: "confirm",
+    message:
+      "Do you want to detect process.getBuiltinModule imports (slightly slower)?",
+    initial: true,
+  },
   {
     name: "tsPreCompilationDeps",
     type: (_, pAnswers) => (pAnswers.useTsConfig ? "confirm" : false),

package/src/cli/init-config/index.mjs

@@ -45,6 +45,7 @@ function getOneShotConfig(pOneShotConfigId) {
     useTsConfig: hasTSConfigCandidates(),
     tsConfig: getTSConfigCandidates().shift(),
     detectJSDocImports: false,
+    detectProcessBuiltinModuleCalls: true,
     tsPreCompilationDeps: hasTSConfigCandidates(),
     useWebpackConfig: hasWebpackConfigCandidates(),
     webpackConfig: getWebpackConfigCandidates().shift(),

package/src/cli/init-config/normalize-init-options.mjs

@@ -19,12 +19,12 @@ import meta from "#meta.cjs";
 function usesTypeScript(pInitOptions, pExtensions) {
   return Boolean(
     pInitOptions.tsConfig ||
-      pInitOptions.tsPreCompilationDeps ||
-      (pExtensions || []).some((pExtension) =>
-        [".ts", ".tsx", ".d.ts", ".mts", ".d.mts", ".cts", ".d.cts"].includes(
-          pExtension,
-        ),
+    pInitOptions.tsPreCompilationDeps ||
+    (pExtensions || []).some((pExtension) =>
+      [".ts", ".tsx", ".d.ts", ".mts", ".d.mts", ".cts", ".d.cts"].includes(
+        pExtension,
       ),
+    ),
   );
 }
 

package/src/enrich/derive/{dependents/index.mjs → dependents.mjs}

@@ -1,6 +1,6 @@
-import getDependents from "./get-dependents.mjs";
+import { isDependent } from "./module-utl.mjs";
 
-/** @import { IFlattenedRuleSet } from "../../../../types/rule-set.mjs" */
+/** @import { IFlattenedRuleSet } from "../../../types/rule-set.mjs" */
 
 function isDependentsRule(pRule) {
   // used in folder rules and when moreUnstable is in the 'to' => governed by
@@ -16,6 +16,13 @@ function isDependentsRule(pRule) {
   );
 }
 
+export function getDependents(pModule, pModules) {
+  // perf between O(n) in an unconnected graph and O(n^2) in a fully connected one
+  return pModules
+    .filter(isDependent(pModule.source))
+    .map((pDependentModule) => pDependentModule.source);
+}
+
 /**
  * @param {IFlattenedRuleSet} pRuleSet
  * @returns {boolean}

package/src/enrich/derive/folders/aggregate-to-folders.mjs

@@ -13,12 +13,12 @@ import IndexedModuleGraph from "#graph-utl/indexed-module-graph.mjs";
 import { uniq } from "#utl/array-util.mjs";
 
 function upsertCouplings(pAllDependents, pNewDependents) {
-  pNewDependents.forEach((pNewDependent) => {
-    pAllDependents[pNewDependent] = pAllDependents[pNewDependent] || {
+  for (const lNewDependent of pNewDependents) {
+    pAllDependents[lNewDependent] = pAllDependents[lNewDependent] || {
       count: 0,
     };
-    pAllDependents[pNewDependent].count += 1;
-  });
+    pAllDependents[lNewDependent].count += 1;
+  }
 }
 
 /**
@@ -64,9 +64,9 @@ function upsertFolderAttributes(pAllMetrics, pModule, pDirname) {
 }
 
 function aggregateToFolder(pAllFolders, pModule) {
-  getParentFolders(dirname(pModule.source)).forEach((pParentDirectory) =>
-    upsertFolderAttributes(pAllFolders, pModule, pParentDirectory),
-  );
+  for (const lParentDirectory of getParentFolders(dirname(pModule.source))) {
+    upsertFolderAttributes(pAllFolders, pModule, lParentDirectory);
+  }
   return pAllFolders;
 }
 

package/src/enrich/derive/reachable.mjs

@@ -171,25 +171,29 @@ function addReachabilityToGraph(pGraph, pIndexedGraph, pReachableRule) {
   const lFromModules = pGraph.filter(isModuleInRuleFrom(pReachableRule));
 
   return pGraph.map((pModule) => {
-    let lClonedModule = structuredClone(pModule);
-
-    if (shouldAddReaches(pReachableRule, lClonedModule)) {
-      lClonedModule = addReachesToModule(
-        lClonedModule,
+    // strictly speaking we should clone pModule to prevent mutating it,
+    // but in practice this function is called with a structuredClone'd graph
+    // anyway and the (reference only) copy we use now is faster (observable
+    // even on dependency-cruiser's self scan) and less memory intentsive.
+    let lModule = pModule;
+
+    if (shouldAddReaches(pReachableRule, lModule)) {
+      lModule = addReachesToModule(
+        lModule,
         pGraph,
         pIndexedGraph,
         pReachableRule,
       );
     }
-    if (shouldAddReachable(pReachableRule, lClonedModule, pGraph)) {
-      lClonedModule = addReachableToModule(
-        lClonedModule,
+    if (shouldAddReachable(pReachableRule, lModule, pGraph)) {
+      lModule = addReachableToModule(
+        lModule,
         pIndexedGraph,
         pReachableRule,
         lFromModules,
       );
     }
-    return lClonedModule;
+    return lModule;
   });
 }
 
@@ -199,11 +203,11 @@ export default function deriveReachables(pGraph, pRuleSet) {
   if (lReachableRules.length > 0) {
     const lIndexedGraph = new IndexedModuleGraph(pGraph);
 
-    return lReachableRules.reduce(
-      (pReturnGraph, pRule) =>
-        addReachabilityToGraph(pReturnGraph, lIndexedGraph, pRule),
-      structuredClone(pGraph),
-    );
+    let lResultGraph = structuredClone(pGraph);
+    for (const lRule of lReachableRules) {
+      lResultGraph = addReachabilityToGraph(lResultGraph, lIndexedGraph, lRule);
+    }
+    return lResultGraph;
   }
   return pGraph;
 }

package/src/enrich/enrich-modules.mjs

@@ -1,6 +1,6 @@
 import deriveCycles from "./derive/circular.mjs";
 import deriveOrphans from "./derive/orphan/index.mjs";
-import addDependents from "./derive/dependents/index.mjs";
+import addDependents from "./derive/dependents.mjs";
 import deriveReachable from "./derive/reachable.mjs";
 import addValidations from "./add-validations.mjs";
 import softenKnownViolations from "./soften-known-violations.mjs";

package/src/enrich/summarize/summarize-options.mjs

@@ -5,6 +5,7 @@ const SHAREABLE_OPTIONS = [
   "collapse",
   "combinedDependencies",
   "detectJSDocImports",
+  "detectProcessBuiltinModuleCalls",
   "doNotFollow",
   "enhancedResolveOptions",
   "exclude",

package/src/extract/acorn/estree-helpers.mjs

@@ -1,14 +1,15 @@
-function isStringLiteral(pArgument) {
+/* eslint-disable no-inline-comments */
+export function isStringLiteral(pArgument) {
   return pArgument.type === "Literal" && typeof pArgument.value === "string";
 }
 
-function firstArgumentIsAString(pArgumentsNode) {
+export function firstArgumentIsAString(pArgumentsNode) {
   return (
     pArgumentsNode && pArgumentsNode[0] && isStringLiteral(pArgumentsNode[0])
   );
 }
 
-function isPlaceholderLessTemplateLiteral(pArgument) {
+export function isPlaceholderLessTemplateLiteral(pArgument) {
   return (
     pArgument.type === "TemplateLiteral" &&
     pArgument.quasis.length === 1 &&
@@ -16,7 +17,7 @@ function isPlaceholderLessTemplateLiteral(pArgument) {
   );
 }
 
-function firstArgumentIsATemplateLiteral(pArgumentsNode) {
+export function firstArgumentIsATemplateLiteral(pArgumentsNode) {
   return (
     pArgumentsNode &&
     pArgumentsNode[0] &&
@@ -35,19 +36,52 @@ function isMemberCallExpression(pNode, pObjectName, pPropertyName) {
   );
 }
 
+function isNestedMemberCallExpression(
+  pNode,
+  pObjectName,
+  pSecondObjectName,
+  pPropertyName,
+) {
+  return (
+    pNode.type === "CallExpression" &&
+    pNode.callee.type === "MemberExpression" &&
+    pNode.callee.object.type === "MemberExpression" &&
+    pNode.callee.object.object.type === "Identifier" &&
+    pNode.callee.object.object.name === pObjectName && // i.e. globalThis
+    pNode.callee.object.property.type === "Identifier" &&
+    pNode.callee.object.property.name === pSecondObjectName && // i.e. process
+    pNode.callee.property.type === "Identifier" &&
+    pNode.callee.property.name === pPropertyName // i.e. getBuiltinModule
+  );
+}
+
 function isCalleeIdentifier(pNode, pName) {
   return "Identifier" === pNode?.callee?.type && pName === pNode?.callee?.name;
 }
 
-function isRequireOfSomeSort(pNode, pName) {
+export function isRequireOfSomeSort(pNode, pName) {
+  // prevent doing the pName.split for the common case
+  if (pName === "require") {
+    return isCalleeIdentifier(pNode, pName);
+  }
+
   const lRequireStringElements = pName.split(".");
 
-  return lRequireStringElements.length > 1
-    ? isMemberCallExpression(pNode, ...lRequireStringElements)
-    : isCalleeIdentifier(pNode, pName);
+  switch (lRequireStringElements.length) {
+    case 1:
+      return isCalleeIdentifier(pNode, pName);
+    // eslint-disable-next-line no-magic-numbers
+    case 2:
+      return isMemberCallExpression(pNode, ...lRequireStringElements);
+    // eslint-disable-next-line no-magic-numbers
+    case 3:
+      return isNestedMemberCallExpression(pNode, ...lRequireStringElements);
+    default:
+      return false;
+  }
 }
 
-function isLikelyAMDDefineOrRequire(pNode) {
+export function isLikelyAMDDefineOrRequire(pNode) {
   return (
     pNode.expression.type === "CallExpression" &&
     pNode.expression.callee.type === "Identifier" &&
@@ -56,22 +90,10 @@ function isLikelyAMDDefineOrRequire(pNode) {
   );
 }
 
-function isLikelyAMDDefine(pNode) {
+export function isLikelyAMDDefine(pNode) {
   return (
     pNode.expression.type === "CallExpression" &&
     pNode.expression.callee.type === "Identifier" &&
     pNode.expression.callee.name === "define"
   );
 }
-
-export default {
-  firstArgumentIsAString,
-  firstArgumentIsATemplateLiteral,
-  isStringLiteral,
-  isPlaceholderlessTemplateLiteral: isPlaceholderLessTemplateLiteral,
-  isMemberCallExpression,
-  isCalleeIdentifier,
-  isRequireOfSomeSort,
-  isLikelyAMDDefineOrRequire,
-  isLikelyAMDDefine,
-};

package/src/extract/acorn/extract-amd-deps.mjs

@@ -1,29 +1,35 @@
 import { simple as walk_simple, base as walk_base } from "acorn-walk";
 import extractCommonJSDependencies from "./extract-cjs-deps.mjs";
-import estreeHelpers from "./estree-helpers.mjs";
+import {
+  isLikelyAMDDefineOrRequire,
+  isLikelyAMDDefine,
+} from "./estree-helpers.mjs";
 
 function extractRegularAMDDependencies(pNode, pDependencies) {
-  if (estreeHelpers.isLikelyAMDDefineOrRequire(pNode)) {
-    pNode.expression.arguments
-      .filter((pArgument) => pArgument.type === "ArrayExpression")
-      .forEach((pArgument) =>
-        pArgument.elements.forEach((pElement) => {
-          if (pElement.value && typeof pElement.value === "string") {
-            pDependencies.push({
-              module: pElement.value,
-              moduleSystem: "amd",
-              dynamic: false,
-              exoticallyRequired: false,
-              dependencyTypes: ["amd-define"],
-            });
-          }
-        }),
-      );
+  if (isLikelyAMDDefineOrRequire(pNode)) {
+    const lArrayExpressionArguments = pNode.expression.arguments.filter(
+      (pArgument) => pArgument.type === "ArrayExpression",
+    );
+
+    for (const lArgument of lArrayExpressionArguments) {
+      for (const lElement of lArgument.elements) {
+        // eslint-disable-next-line max-depth
+        if (lElement.value && typeof lElement.value === "string") {
+          pDependencies.push({
+            module: lElement.value,
+            moduleSystem: "amd",
+            dynamic: false,
+            exoticallyRequired: false,
+            dependencyTypes: ["amd-define"],
+          });
+        }
+      }
+    }
   }
 }
 
 function extractCommonJSWrappers(pNode, pDependencies, pExoticRequireStrings) {
-  if (estreeHelpers.isLikelyAMDDefine(pNode)) {
+  if (isLikelyAMDDefine(pNode)) {
     pNode.expression.arguments
       .filter(
         (pArgument) =>