dependency-cruiser 16.4.0 → 16.4.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "dependency-cruiser",
-  "version": "16.4.0",
+  "version": "16.4.1",
   "description": "Validate and visualize dependencies. With your rules. JavaScript, TypeScript, CoffeeScript. ES6, CommonJS, AMD.",
   "keywords": [
     "static analysis",

package/src/cache/cache.mjs

@@ -9,9 +9,7 @@ import {
 import { optionsAreCompatible } from "./options-compatible.mjs";
 import MetadataStrategy from "./metadata-strategy.mjs";
 import ContentStrategy from "./content-strategy.mjs";
-// @ts-expect-error ts(2307) - the ts compiler is not privy to the existence of #imports in package.json
 import { scannableExtensions } from "#extract/transpile/meta.mjs";
-// @ts-expect-error ts(2307) - the ts compiler is not privy to the existence of #imports in package.json
 import { bus } from "#utl/bus.mjs";
 
 /**

package/src/cache/find-content-changes.mjs

@@ -8,9 +8,7 @@ import {
   hasInterestingExtension,
   moduleIsInterestingForDiff,
 } from "./helpers.mjs";
-// @ts-expect-error ts(2307) - the ts compiler is not privy to the existence of #imports in package.json
 import { bus } from "#utl/bus.mjs";
-// @ts-expect-error ts(2307) - the ts compiler is not privy to the existence of #imports in package.json
 import findAllFiles from "#utl/find-all-files.mjs";
 
 /**

package/src/cache/metadata-strategy.mjs

@@ -9,7 +9,6 @@ import {
   includeOnlyFilter,
   changeHasInterestingExtension,
 } from "./helpers.mjs";
-// @ts-expect-error ts(2307) - the ts compiler is not privy to the existence of #imports in package.json
 import { bus } from "#utl/bus.mjs";
 
 /**

package/src/cli/init-config/find-extensions.mjs

@@ -1,10 +1,7 @@
 // @ts-check
 /* eslint-disable security/detect-object-injection */
-// @ts-expect-error ts(2307) - the ts compiler is not privy to the existence of #imports in package.json
 import { scannableExtensions } from "#extract/transpile/meta.mjs";
-// @ts-expect-error ts(2307) - the ts compiler is not privy to the existence of #imports in package.json
 import getExtension from "#utl/get-extension.mjs";
-// @ts-expect-error ts(2307) - the ts compiler is not privy to the existence of #imports in package.json
 import findAllFiles from "#utl/find-all-files.mjs";
 
 /**

package/src/extract/resolve/module-classifiers.mjs

@@ -168,8 +168,15 @@ function isWorkspaceAliased(pModuleName, pResolvedModuleName, pManifest) {
     // oh and: ```picomatch.isMatch('asdf', 'asdf/**') === true``` so
     // in case it's only 'asdf' that's in the resolved module name for some reason
     // we're good as well.
+    //
+    // workspaces is supposed to be array of strings, where each string is
+    // a glob pattern. However, in the field there's occasions where it's
+    // not a string. We'll just ignore those for now, hence the presence of
+    // the `typeof pWorkspace === "string"` check.
     const lModuleFriendlyWorkspaceGlobs = lWorkspaces.map((pWorkspace) =>
-      pWorkspace.endsWith("/") ? `${pWorkspace}**` : `${pWorkspace}/**`,
+      typeof pWorkspace === "string" && pWorkspace.endsWith("/")
+        ? `${pWorkspace}**`
+        : `${pWorkspace}/**`,
     );
     if (picomatch.isMatch(pResolvedModuleName, lModuleFriendlyWorkspaceGlobs)) {
       return true;

package/src/meta.cjs

@@ -1,7 +1,7 @@
 /* generated - don't edit */
 
 module.exports = {
-  version: "16.4.0",
+  version: "16.4.1",
   engines: {
     node: "^18.17||>=20",
   },

package/src/validate/match-dependency-rule.mjs

@@ -1,7 +1,6 @@
 // @ts-check
 import { isModuleOnlyRule, isFolderScope } from "./rule-classifiers.mjs";
 import matchers from "./matchers.mjs";
-// @ts-expect-error ts(2307) - apparently tsc doesn't understand subpath imports yet
 import { extractGroups } from "#utl/regex-util.mjs";
 
 /**

package/src/validate/match-module-rule.mjs

@@ -13,7 +13,7 @@ import { extractGroups } from "#utl/regex-util.mjs";
 function matchesOrphanRule(pRule, pModule) {
   return (
     Object.hasOwn(pRule?.from ?? {}, "orphan") &&
-    // @ts-expect-error the 'has' above guarantees there's a 'from.orphan' attribute
+    // @ts-expect-error the 'hasOwn' above guarantees there's a 'from.orphan' attribute
     pModule.orphan === pRule.from.orphan &&
     matchers.fromPath(pRule, pModule) &&
     matchers.fromPathNot(pRule, pModule)
@@ -34,11 +34,11 @@ function matchesReachableRule(pRule, pModule) {
     Object.hasOwn(pRule?.to ?? {}, "reachable") &&
     Object.hasOwn(pModule, "reachable")
   ) {
-    // @ts-expect-error the 'has' above ensures the 'reachable' exists
+    // @ts-expect-error the 'hasOwn' above ensures the 'reachable' exists
     const lReachableRecord = pModule.reachable.find(
       (pReachable) =>
         pReachable.asDefinedInRule === pRule.name &&
-        // @ts-expect-error the 'has' above ensures the 'to.reachable' exists
+        // @ts-expect-error the 'hasOwn' above ensures the 'to.reachable' exists
         pReachable.value === pRule.to.reachable,
     );
     if (lReachableRecord) {
@@ -66,7 +66,7 @@ function matchesReachesRule(pRule, pModule) {
   return (
     Object.hasOwn(pRule?.to ?? {}, "reachable") &&
     Object.hasOwn(pModule, "reaches") &&
-    // @ts-expect-error the 'has' above guarantees the .reaches exists
+    // @ts-expect-error the 'hasOwn' above guarantees the .reaches exists
     pModule.reaches.some(
       (pReaches) =>
         pReaches.asDefinedInRule === pRule.name &&