dependency-cruiser 16.10.3 → 16.10.4-beta-2

package/configs/plugins/stats-reporter-plugin.mjs

@@ -76,7 +76,7 @@ export default (pCruiseResult) => ({
   output: JSON.stringify(
     samplePluginReporter(pCruiseResult),
     null,
-    DEFAULT_JSON_INDENT
+    DEFAULT_JSON_INDENT,
   ),
   exitCode: 0,
 });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "dependency-cruiser",
-  "version": "16.10.3",
+  "version": "16.10.4-beta-2",
   "description": "Validate and visualize dependencies. With your rules. JavaScript, TypeScript, CoffeeScript. ES6, CommonJS, AMD.",
   "keywords": [
     "static analysis",

package/src/enrich/derive/folders/utl.mjs

@@ -7,13 +7,13 @@ export function findFolderByName(pAllFolders, pName) {
 
 export function getAfferentCouplings(pModule, pDirname) {
   return pModule.dependents.filter(
-    (pDependent) => !pDependent.startsWith(pDirname.concat(sep))
+    (pDependent) => !pDependent.startsWith(pDirname.concat(sep)),
   );
 }
 
 export function getEfferentCouplings(pModule, pDirname) {
   return pModule.dependencies.filter(
-    (pDependency) => !pDependency.resolved.startsWith(pDirname.concat(sep))
+    (pDependency) => !pDependency.resolved.startsWith(pDirname.concat(sep)),
   );
 }
 

package/src/enrich/derive/module-utl.mjs

@@ -1,7 +1,7 @@
 export function isDependent(pResolvedName) {
   return (pModule) =>
     pModule.dependencies.some(
-      (pDependency) => pDependency.resolved === pResolvedName
+      (pDependency) => pDependency.resolved === pResolvedName,
     );
 }
 
@@ -23,7 +23,7 @@ export function metricsAreCalculable(pModule) {
  */
 export function calculateInstability(
   pEfferentCouplingCount,
-  pAfferentCouplingCount
+  pAfferentCouplingCount,
 ) {
   // when both afferentCouplings and efferentCouplings equal 0 instability will
   // yield NaN. Judging Bob Martin's intention, a component with no outgoing

package/src/enrich/soften-known-violations.mjs

@@ -59,11 +59,12 @@ function softenDependencyViolations(
   }
   return pDependency;
 }
+
 /**
  *
  * @param {import("../../types/cruise-result.mjs").IModule} pModule
- * @param {import("../../types/baseline-violations.js").IBaselineViolations} pKnownViolations
- * @param {import("../../types/shared-types.js").SeverityType} pSoftenedSeverity
+ * @param {import("../../types/baseline-violations.mjs").IBaselineViolations} pKnownViolations
+ * @param {import("../../types/shared-types.mjs").SeverityType} pSoftenedSeverity
  * @returns {import("../../types/cruise-result.mjs").IModule}
  */
 function softenKnownViolation(pModule, pKnownViolations, pSoftenedSeverity) {
@@ -76,9 +77,8 @@ function softenKnownViolation(pModule, pKnownViolations, pSoftenedSeverity) {
         softenModuleViolation(
           pRule,
           pModule.source,
-          pKnownViolations.filter(
-            (pKnownError) =>
-              pKnownError.from === pKnownError.to && !pKnownError.cycle,
+          pKnownViolations.filter((pKnownViolation) =>
+            ["module", "reachability"].includes(pKnownViolation.type),
           ),
           pSoftenedSeverity,
         ),
@@ -92,23 +92,26 @@ function softenKnownViolation(pModule, pKnownViolations, pSoftenedSeverity) {
       softenDependencyViolations(
         pDependency,
         pModule.source,
-        pKnownViolations.filter(
-          (pKnownError) =>
-            pKnownError.from !== pKnownError.to || pKnownError.cycle,
+        pKnownViolations.filter((pKnownViolation) =>
+          ["dependency", "cycle", "instability"].includes(pKnownViolation.type),
         ),
         pSoftenedSeverity,
       ),
     ),
   };
 
+  // TODO: folder level violations (e.g. with 'instability' rules - these need
+  // to be softened within the "folders" node, which lives next to the "modules"
+  // one)
+
   return lReturnValue;
 }
 
 /**
  *
  * @param {import("../../types/cruise-result.mjs").IModule[]} pModules
- * @param {import("../../types/baseline-violations.js").IBaselineViolations} pKnownViolations
- * @param {import("../../types/shared-types.js").SeverityType} pSoftenedSeverity
+ * @param {import("../../types/baseline-violations.mjs").IBaselineViolations} pKnownViolations
+ * @param {import("../../types/shared-types.mjs").SeverityType} pSoftenedSeverity
  * @returns {import("../../types/cruise-result.mjs").IModule[]}
  */
 export default function softenKnownViolations(

package/src/enrich/summarize/get-stats.mjs

@@ -9,7 +9,7 @@ export function getViolationStats(pViolations) {
       warn: 0,
       info: 0,
       ignore: 0,
-    }
+    },
   );
 }
 
@@ -20,6 +20,6 @@ export function getModulesCruised(pModules) {
 export function getDependenciesCruised(pModules) {
   return pModules.reduce(
     (pAll, pModule) => pAll + pModule.dependencies.length,
-    0
+    0,
   );
 }

package/src/enrich/summarize/is-same-violation.mjs

@@ -2,23 +2,35 @@ function pluckName({ name }) {
   return name;
 }
 
+// eslint-disable-next-line complexity
 export default function isSameViolation(pLeftViolation, pRightViolation) {
-  let lReturnValue = false;
-
   if (pLeftViolation.rule.name === pRightViolation.rule.name) {
     if (pRightViolation.cycle && pLeftViolation.cycle) {
-      lReturnValue =
+      return (
         pLeftViolation.cycle.length === pRightViolation.cycle.length &&
         pLeftViolation.cycle
           .map(pluckName)
           .every((pModule) =>
             pRightViolation.cycle.map(pluckName).includes(pModule),
-          );
-    } else {
-      lReturnValue =
+          )
+      );
+    }
+    if (pRightViolation.via && pLeftViolation.via) {
+      return (
         pLeftViolation.from === pRightViolation.from &&
-        pLeftViolation.to === pRightViolation.to;
+        pLeftViolation.to === pRightViolation.to &&
+        pLeftViolation.via.length === pRightViolation.via.length &&
+        pLeftViolation.via
+          .map(pluckName)
+          .every((pModule) =>
+            pRightViolation.via.map(pluckName).includes(pModule),
+          )
+      );
     }
+    return (
+      pLeftViolation.from === pRightViolation.from &&
+      pLeftViolation.to === pRightViolation.to
+    );
   }
-  return lReturnValue;
+  return false;
 }

package/src/graph-utl/consolidate-to-folder.mjs

@@ -19,6 +19,6 @@ function squashModuleToDirectory(pModule) {
 
 export default function consolidateToFolder(pModules) {
   return consolidateModules(pModules.map(squashModuleToDirectory)).map(
-    consolidateModuleDependencies
+    consolidateModuleDependencies,
   );
 }

package/src/graph-utl/consolidate-to-pattern.mjs

@@ -35,10 +35,10 @@ function squashModuleToPattern(pCollapsePattern) {
       consolidated: determineConsolidatedness(
         pModule.consolidated,
         lCollapseMatch,
-        pModule.source
+        pModule.source,
       ),
       dependencies: pModule.dependencies.map(
-        squashDependencyToPattern(pCollapsePattern)
+        squashDependencyToPattern(pCollapsePattern),
       ),
     };
   };
@@ -46,6 +46,6 @@ function squashModuleToPattern(pCollapsePattern) {
 
 export default function consolidateToPattern(pModules, pCollapsePattern) {
   return consolidateModules(
-    pModules.map(squashModuleToPattern(pCollapsePattern))
+    pModules.map(squashModuleToPattern(pCollapsePattern)),
   ).map(consolidateModuleDependencies);
 }

package/src/graph-utl/strip-self-transitions.mjs

@@ -2,7 +2,7 @@ export default function stripSelfTransitions(pModule) {
   return {
     ...pModule,
     dependencies: pModule.dependencies.filter(
-      (pDependency) => pModule.source !== pDependency.resolved
+      (pDependency) => pModule.source !== pDependency.resolved,
     ),
   };
 }

package/src/meta.cjs

@@ -1,7 +1,7 @@
 /* generated - don't edit */
 
 module.exports = {
-  version: "16.10.3",
+  version: "16.10.4-beta-2",
   engines: {
     node: "^18.17||>=20",
   },

package/src/report/utl/dependency-to-incidence-transformer.mjs

@@ -9,7 +9,7 @@ function compareOnSource(pOne, pTwo) {
 function determineIncidenceType(pFromListEntry) {
   return (pModule) => {
     let lDependency = pModule.dependencies.find(
-      (pDependency) => pDependency.resolved === pFromListEntry.source
+      (pDependency) => pDependency.resolved === pFromListEntry.source,
     );
 
     if (lDependency) {

package/src/utl/find-all-files.mjs

@@ -26,7 +26,7 @@ function fileIsDirectory(pFullPathToFile, pBaseDirectory) {
  */
 function walk(
   pDirectoryName,
-  { baseDir, ignoreFilterFn, excludeFilterFn, includeOnlyFilterFn }
+  { baseDir, ignoreFilterFn, excludeFilterFn, includeOnlyFilterFn },
 ) {
   return readdirSync(join(baseDir, pDirectoryName))
     .map((pFileName) => join(pDirectoryName, pFileName))
@@ -51,12 +51,12 @@ function walk(
               ignoreFilterFn,
               excludeFilterFn,
               includeOnlyFilterFn,
-            })
+            }),
           );
         }
         return pSum.concat(fullPathToFile);
       },
-      []
+      [],
     )
     .map((pFullPathToFile) => pathToPosix(pFullPathToFile));
 }
@@ -90,7 +90,7 @@ export default function findAllFiles(
     additionalIgnorePatterns,
     excludeFilterFn,
     includeOnlyFilterFn,
-  }
+  },
 ) {
   const lIgnoreFileContents =
     ignoreFileContents ?? readIgnoreFile(join(baseDir, ".gitignore"));