dependency-cruiser 11.18.0 → 12.0.0

package/configs/rules/no-orphans.js

@@ -1,5 +1,5 @@
 const DOT_FILE_PATTERN = "(^|/)\\.[^/]+\\.(js|cjs|mjs|ts|json)$";
-const TS_DECLARATION_FILE_PATTERN = "\\.d\\.ts$";
+const TS_DECLARATION_FILE_PATTERN = "\\.d\\.(c|m)?ts$";
 const TS_CONFIG_FILE_PATTERN = "(^|/)tsconfig\\.json$";
 const OTHER_CONFIG_FILES_PATTERN =
   "(^|/)(babel|webpack)\\.config\\.(js|cjs|mjs|ts|json)$";
@@ -18,7 +18,7 @@ module.exports = {
     "remove it. If it's logical this module is an orphan (i.e. it's a config file), " +
     "add an exception for it in your dependency-cruiser configuration. By default " +
     "this rule does not scrutinize dotfiles (e.g. .eslintrc.js), TypeScript declaration " +
-    "files (.d.ts), tsconfig.json and some of the babel and webpack configs.",
+    "files (.d.ts/ .d.cts/ .d.mts), tsconfig.json and some of the babel and webpack configs.",
   severity: "warn",
   from: {
     orphan: true,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "dependency-cruiser",
-  "version": "11.18.0",
+  "version": "12.0.0",
   "description": "Validate and visualize dependencies. With your rules. JavaScript, TypeScript, CoffeeScript. ES6, CommonJS, AMD.",
   "keywords": [
     "static analysis",
@@ -145,7 +145,7 @@
     "acorn-jsx-walk": "2.0.0",
     "acorn-loose": "8.3.0",
     "acorn-walk": "8.2.0",
-    "ajv": "8.11.0",
+    "ajv": "8.11.2",
     "chalk": "^4.1.2",
     "commander": "9.4.1",
     "enhanced-resolve": "5.10.0",
@@ -169,21 +169,21 @@
     "wrap-ansi": "^7.0.0"
   },
   "devDependencies": {
-    "@babel/core": "7.19.6",
+    "@babel/core": "7.20.2",
     "@babel/plugin-transform-modules-commonjs": "7.19.6",
     "@babel/preset-typescript": "7.18.6",
-    "@swc/core": "1.3.10",
-    "@types/lodash": "4.14.186",
-    "@types/node": "18.11.5",
+    "@swc/core": "1.3.18",
+    "@types/lodash": "4.14.189",
+    "@types/node": "18.11.9",
     "@types/prompts": "2.4.1",
-    "@typescript-eslint/eslint-plugin": "5.41.0",
-    "@typescript-eslint/parser": "5.41.0",
-    "@vue/compiler-sfc": "3.2.41",
+    "@typescript-eslint/eslint-plugin": "5.43.0",
+    "@typescript-eslint/parser": "5.43.0",
+    "@vue/compiler-sfc": "3.2.45",
     "c8": "7.12.0",
-    "chai": "4.3.6",
+    "chai": "4.3.7",
     "chai-json-schema": "1.5.1",
     "coffeescript": "2.7.0",
-    "eslint": "8.26.0",
+    "eslint": "8.27.0",
     "eslint-config-moving-meadow": "4.0.2",
     "eslint-config-prettier": "8.5.0",
     "eslint-plugin-budapestian": "5.0.1",
@@ -193,7 +193,7 @@
     "eslint-plugin-node": "11.1.0",
     "eslint-plugin-security": "1.5.0",
     "eslint-plugin-unicorn": "^44.0.2",
-    "husky": "8.0.1",
+    "husky": "8.0.2",
     "intercept-stdout": "0.1.2",
     "lint-staged": "12.3.4",
     "mocha": "10.1.0",
@@ -202,11 +202,11 @@
     "prettier": "2.7.1",
     "proxyquire": "2.1.3",
     "shx": "0.3.4",
-    "svelte": "3.52.0",
+    "svelte": "3.53.1",
     "symlink-dir": "5.0.1",
-    "typescript": "4.8.4",
-    "upem": "7.3.0",
-    "vue-template-compiler": "2.7.13",
+    "typescript": "4.9.3",
+    "upem": "7.3.1",
+    "vue-template-compiler": "2.7.14",
     "yarn": "1.22.19"
   },
   "upem": {
@@ -276,7 +276,7 @@
     "types/**"
   ],
   "engines": {
-    "node": "^12.20||^14||>=16"
+    "node": "^14||^16||>=18"
   },
   "supportedTranspilers": {
     "babel": ">=7.0.0 <8.0.0",

package/src/cli/index.js

@@ -1,5 +1,4 @@
 const glob = require("glob");
-const get = require("lodash/get");
 const clone = require("lodash/clone");
 const set = require("lodash/set");
 const isInstalledGlobally = require("is-installed-globally");
@@ -21,17 +20,14 @@ const setUpPerformanceLogListener = require("./listeners/performance-log");
 
 function extractResolveOptions(pCruiseOptions) {
   let lResolveOptions = {};
-  const lWebPackConfigFileName = get(
-    pCruiseOptions,
-    "ruleSet.options.webpackConfig.fileName",
-    null
-  );
+  const lWebPackConfigFileName =
+    pCruiseOptions?.ruleSet?.options?.webpackConfig?.fileName ?? null;
 
   if (lWebPackConfigFileName) {
     lResolveOptions = extractWebpackResolveConfig(
       lWebPackConfigFileName,
-      get(pCruiseOptions, "ruleSet.options.webpackConfig.env", null),
-      get(pCruiseOptions, "ruleSet.options.webpackConfig.arguments", null)
+      pCruiseOptions?.ruleSet?.options?.webpackConfig?.env ?? null,
+      pCruiseOptions?.ruleSet?.options?.webpackConfig?.arguments ?? null
     );
   }
   return lResolveOptions;
@@ -54,11 +50,8 @@ function addKnownViolations(pCruiseOptions) {
 
 function extractTSConfigOptions(pCruiseOptions) {
   let lReturnValue = {};
-  const lTSConfigFileName = get(
-    pCruiseOptions,
-    "ruleSet.options.tsConfig.fileName",
-    null
-  );
+  const lTSConfigFileName =
+    pCruiseOptions?.ruleSet?.options?.tsConfig?.fileName ?? null;
 
   if (lTSConfigFileName) {
     lReturnValue = extractTSConfig(lTSConfigFileName);
@@ -69,11 +62,8 @@ function extractTSConfigOptions(pCruiseOptions) {
 
 function extractBabelConfigOptions(pCruiseOptions) {
   let lReturnValue = {};
-  const lBabelConfigFileName = get(
-    pCruiseOptions,
-    "ruleSet.options.babelConfig.fileName",
-    null
-  );
+  const lBabelConfigFileName =
+    pCruiseOptions?.ruleSet?.options?.babelConfig?.fileName ?? null;
 
   if (lBabelConfigFileName) {
     lReturnValue = extractBabelConfig(lBabelConfigFileName);
@@ -87,12 +77,11 @@ function setUpListener(pCruiseOptions) {
     "cli-feedback": setUpCliFeedbackListener,
     "performance-log": setUpPerformanceLogListener,
   };
-  const lListenerID = get(
-    pCruiseOptions,
-    "progress",
-    get(pCruiseOptions, "ruleSet.options.progress.type")
-  );
-  const lListenerFunction = get(lString2Listener, lListenerID);
+  const lListenerID =
+    pCruiseOptions?.progress ??
+    pCruiseOptions?.ruleSet?.options?.progress?.type;
+  // eslint-disable-next-line security/detect-object-injection
+  const lListenerFunction = lString2Listener?.[lListenerID];
   /* c8 ignore next 3 */
   if (Boolean(lListenerFunction)) {
     lListenerFunction(bus);

package/src/config-utl/extract-babel-config.js

@@ -4,7 +4,6 @@
 const fs = require("fs");
 const path = require("path");
 const json5 = require("json5");
-const get = require("lodash/get");
 const has = require("lodash/has");
 const tryRequire = require("semver-try-require");
 const { supportedTranspilers } = require("../../src/meta.js");
@@ -48,7 +47,7 @@ function getJSON5Config(pBabelConfigFileName) {
   }
 
   if (pBabelConfigFileName.endsWith("package.json")) {
-    lReturnValue = get(lReturnValue, "babel", {});
+    lReturnValue = lReturnValue?.babel ?? {};
   }
   return lReturnValue;
 }

package/src/config-utl/extract-known-violations.js

@@ -7,10 +7,6 @@ module.exports = function extractKnownViolations(pKnownViolationsFileName) {
     return json5.parse(
       readFileSync(makeAbsolute(pKnownViolationsFileName), "utf8")
     );
-    // TODO: apparently node12 native coverage doesn't see this is covered with UT
-    //      (node 14 and 16 do), so c8 doesn't either. The ignore can be removed
-    //      once we stop supporting node 12
-    /* c8 ignore start */
   } catch (pError) {
     if (pError instanceof SyntaxError) {
       throw new SyntaxError(
@@ -19,9 +15,8 @@ module.exports = function extractKnownViolations(pKnownViolationsFileName) {
     }
     throw pError;
   }
-  /* c8 ignore stop */
 
-  // TODO: validate the json against the schme? (might be more clear to do it here,
+  // TODO: validate the json against the schema? (might be more clear to do it here,
   // even if (in context of the cli) it's done again when validating the whole
   // config
 };

package/src/config-utl/extract-ts-config.js

@@ -1,6 +1,5 @@
 const path = require("path");
 const tryRequire = require("semver-try-require");
-const get = require("lodash/get");
 const { supportedTranspilers } = require("../../src/meta.js");
 
 const typescript = tryRequire("typescript", supportedTranspilers.typescript);
@@ -11,7 +10,7 @@ const FORMAT_DIAGNOSTICS_HOST = {
 
     // depends on the platform which branch is taken, hence the c8 ignore
     /* c8 ignore start */
-    if (get(typescript, "sys.useCaseSensitiveFileNames", false)) {
+    if (typescript?.sys?.useCaseSensitiveFileNames ?? false) {
       lReturnValue = pFileName;
     }
     /* c8 ignore stop */

package/src/enrich/derive/reachable/index.js

@@ -1,17 +1,16 @@
 /* eslint-disable security/detect-object-injection, no-inline-comments */
 
 const clone = require("lodash/clone");
-const get = require("lodash/get");
 const has = require("lodash/has");
 const matchers = require("../../../validate/matchers");
 const { extractGroups } = require("../../../utl/regex-util");
 const getPath = require("./get-path");
 
 function getReachableRules(pRuleSet) {
-  return get(pRuleSet, "forbidden", [])
+  return (pRuleSet?.forbidden ?? [])
     .filter((pRule) => has(pRule.to, "reachable"))
     .concat(
-      get(pRuleSet, "allowed", []).filter((pRule) => has(pRule.to, "reachable"))
+      (pRuleSet?.allowed ?? []).filter((pRule) => has(pRule.to, "reachable"))
     );
 }
 
@@ -85,8 +84,8 @@ function hasCapturingGroups(pRule) {
   const lCapturingGroupPlaceholderRe = "\\$[0-9]+";
 
   return Boolean(
-    get(pRule, "to.path", "").match(lCapturingGroupPlaceholderRe) ||
-      get(pRule, "to.pathNot", "").match(lCapturingGroupPlaceholderRe)
+    (pRule?.to?.path ?? "").match(lCapturingGroupPlaceholderRe) ||
+      (pRule?.to?.pathNot ?? "").match(lCapturingGroupPlaceholderRe)
   );
 }
 function shouldAddReachable(pRule, pModuleTo, pGraph) {

package/src/enrich/enrich-modules.js

@@ -1,4 +1,3 @@
-const get = require("lodash/get");
 const bus = require("../utl/bus");
 const busLogLevels = require("../utl/bus-log-levels");
 const addFocus = require("../../src/graph-utl/add-focus");
@@ -31,7 +30,7 @@ module.exports = function enrichModules(pModules, pOptions) {
   bus.emit("progress", "analyzing: add focus (if any)", {
     level: busLogLevels.INFO,
   });
-  lModules = addFocus(lModules, get(pOptions, "focus"));
+  lModules = addFocus(lModules, pOptions.focus);
 
   // when validate === false we might want to skip the addValidations.
   // We don't at this time, however, as "valid" is a mandatory

package/src/enrich/summarize/add-rule-set-used.js

@@ -1,4 +1,3 @@
-const get = require("lodash/get");
 const clone = require("lodash/clone");
 
 // the fixed name for allowed rules served a purpose during the extraction
@@ -11,10 +10,10 @@ function removeNames(pRule) {
 }
 
 module.exports = function addRuleSetUsed(pOptions) {
-  const lForbidden = get(pOptions, "ruleSet.forbidden");
-  const lAllowed = get(pOptions, "ruleSet.allowed");
-  const lAllowedSeverity = get(pOptions, "ruleSet.allowedSeverity");
-  const lRequired = get(pOptions, "ruleSet.required");
+  const lForbidden = pOptions?.ruleSet?.forbidden;
+  const lAllowed = pOptions?.ruleSet?.allowed;
+  const lAllowedSeverity = pOptions?.ruleSet?.allowedSeverity;
+  const lRequired = pOptions?.ruleSet?.required;
 
   return Object.assign(
     lForbidden ? { forbidden: lForbidden } : {},

package/src/enrich/summarize/summarize-modules.js

@@ -1,5 +1,4 @@
 const _flattenDeep = require("lodash/flattenDeep");
-const get = require("lodash/get");
 const has = require("lodash/has");
 const uniqWith = require("lodash/uniqWith");
 const { findRuleByName } = require("../../graph-utl/rule-set");
@@ -25,7 +24,7 @@ function toDependencyViolationSummary(pRule, pModule, pDependency, pRuleSet) {
 
   if (
     has(pDependency, "cycle") &&
-    get(findRuleByName(pRuleSet, pRule.name), "to.circular")
+    findRuleByName(pRuleSet, pRule.name)?.to?.circular
   ) {
     lReturnValue = {
       ...lReturnValue,
@@ -88,10 +87,7 @@ function toModuleViolationSummary(pRule, pModule, pRuleSet) {
   let lReturnValue = [
     { type: "module", from: pModule.source, to: pModule.source, rule: pRule },
   ];
-  if (
-    pModule.reaches &&
-    get(findRuleByName(pRuleSet, pRule.name), "to.reachable")
-  ) {
+  if (pModule.reaches && findRuleByName(pRuleSet, pRule.name)?.to?.reachable) {
     lReturnValue = pModule.reaches
       .filter((pReachable) => pReachable.asDefinedInRule === pRule.name)
       .reduce(

package/src/enrich/summarize/summarize-options.js

@@ -1,4 +1,3 @@
-const get = require("lodash/get");
 const has = require("lodash/has");
 
 const SHAREABLE_OPTIONS = [
@@ -62,7 +61,7 @@ function makeIncludeOnlyBackwardsCompatible(pOptions) {
   return pOptions.includeOnly
     ? {
         ...pOptions,
-        includeOnly: get(pOptions, "includeOnly.path"),
+        includeOnly: pOptions?.includeOnly?.path,
       }
     : pOptions;
 }

package/src/extract/ast-extractors/estree-helpers.js

@@ -1,5 +1,3 @@
-const get = require("lodash/get");
-
 function isStringLiteral(pArgument) {
   return pArgument.type === "Literal" && typeof pArgument.value === "string";
 }
@@ -40,10 +38,7 @@ function isMemberCallExpression(pNode, pObjectName, pPropertyName) {
 }
 
 function isCalleeIdentifier(pNode, pName) {
-  return (
-    "Identifier" === get(pNode, "callee.type") &&
-    pName === get(pNode, "callee.name")
-  );
+  return "Identifier" === pNode?.callee?.type && pName === pNode?.callee?.name;
 }
 
 function isRequireOfSomeSort(pNode, pName) {

package/src/extract/parse/to-javascript-ast.js

@@ -2,7 +2,6 @@ const fs = require("fs");
 const acorn = require("acorn");
 const acornLoose = require("acorn-loose");
 const acornJsx = require("acorn-jsx");
-const get = require("lodash/get");
 const memoize = require("lodash/memoize");
 const transpile = require("../transpile");
 const getExtension = require("../utl/get-extension");
@@ -22,7 +21,7 @@ function needsJSXTreatment(pFileRecord, pTranspileOptions) {
   return (
     pFileRecord.extension === ".jsx" ||
     (pFileRecord.extension === ".tsx" &&
-      get(pTranspileOptions, "tsConfig.options.jsx") ===
+      pTranspileOptions?.tsConfig?.options?.jsx ===
         TSCONFIG_CONSTANTS.PRESERVE_JSX)
   );
 }

package/src/extract/resolve/get-manifest/merge-manifests.js

@@ -1,5 +1,5 @@
+/* eslint-disable security/detect-object-injection */
 const uniq = require("lodash/uniq");
-const get = require("lodash/get");
 const clone = require("lodash/clone");
 
 function normalizeManifestKeys(pManifest) {
@@ -64,12 +64,12 @@ module.exports = function mergeManifests(pClosestManifest, pFurtherManifest) {
       key: pKey,
       value: pKey.startsWith("bundle")
         ? mergeDependencyArray(
-            get(pClosestManifest, pKey, []),
-            get(pFurtherManifest, pKey, [])
+            pClosestManifest?.[pKey] ?? [],
+            pFurtherManifest?.[pKey] ?? []
           )
         : mergeDependencyKey(
-            get(pClosestManifest, pKey, {}),
-            get(pFurtherManifest, pKey, {})
+            pClosestManifest?.[pKey] ?? {},
+            pFurtherManifest?.[pKey] ?? {}
           ),
     }))
     .reduce((pJoinedObject, pJoinedKey) => {

package/src/extract/resolve/index.js

@@ -1,7 +1,6 @@
 const fs = require("fs");
 const path = require("path");
 const monkeyPatchedModule = require("module");
-const get = require("lodash/get");
 const pathToPosix = require("../utl/path-to-posix");
 const { isRelativeModuleName } = require("./module-classifiers");
 const resolveAMD = require("./resolve-amd");
@@ -51,18 +50,18 @@ function canBeResolvedToTsVariant(pModuleName) {
   return [".js", ".jsx"].includes(path.extname(pModuleName));
 }
 
-function isTypeScriptishExtension(pModuleName) {
-  return [".ts", ".tsx"].includes(path.extname(pModuleName));
+function isTypeScriptIshExtension(pModuleName) {
+  return [".ts", ".tsx", ".cts", ".mts"].includes(path.extname(pModuleName));
 }
 function resolveYarnVirtual(pPath) {
-  const pnpAPI = get(monkeyPatchedModule, "findPnpApi", () => false)(pPath);
+  const pnpAPI = (monkeyPatchedModule?.findPnpApi ?? (() => false))(pPath);
 
   // the pnp api only works in plug'n play environments, and resolveVirtual
   // only under yarn(berry). As we can't run a 'regular' nodejs environment
   // and a yarn(berry) one at the same time, ignore in the test coverage and
   // cover it in a separate integration test.
   /* c8 ignore start */
-  if (pnpAPI && get(pnpAPI, "VERSIONS.resolveVirtual", 0) === 1) {
+  if (pnpAPI && (pnpAPI?.VERSIONS?.resolveVirtual ?? 0) === 1) {
     return pnpAPI.resolveVirtual(path.resolve(pPath)) || pPath;
   }
   /* c8 ignore stop */
@@ -113,7 +112,7 @@ function resolveWithRetry(
       pResolveOptions
     );
 
-    if (isTypeScriptishExtension(lReturnValueCandidate.resolved)) {
+    if (isTypeScriptIshExtension(lReturnValueCandidate.resolved)) {
       lReturnValue = lReturnValueCandidate;
     }
   }

package/src/extract/transpile/meta.js

@@ -1,4 +1,3 @@
-const get = require("lodash/get");
 const { supportedTranspilers } = require("../../../src/meta.js");
 const swc = require("../parse/to-swc-ast");
 const javaScriptWrap = require("./javascript-wrap");
@@ -21,7 +20,9 @@ const EXTENSION2WRAPPER = {
   ".tsx": typeScriptTsxWrap,
   ".d.ts": typeScriptWrap,
   ".cts": typeScriptWrap,
+  ".d.cts": typeScriptWrap,
   ".mts": typeScriptESMWrap,
+  ".d.mts": typeScriptESMWrap,
   ".vue": vueWrap,
   ".svelte": svelteWrap,
   ".ls": liveScriptWrap,
@@ -86,7 +87,7 @@ function extensionIsAvailable(pExtension) {
  */
 module.exports.getWrapper = (pExtension, pTranspilerOptions) => {
   if (
-    Object.keys(get(pTranspilerOptions, "babelConfig", {})).length > 0 &&
+    Object.keys(pTranspilerOptions?.babelConfig ?? {}).length > 0 &&
     BABELEABLE_EXTENSIONS.includes(pExtension)
   ) {
     return babelWrap;
@@ -109,7 +110,7 @@ module.exports.allExtensions = Object.keys(EXTENSION2WRAPPER).map(
 
 /**
  * an array of extensions that are 'scannable' (have a valid transpiler
- * available for) in the current environemnt.
+ * available for) in the current environment.
  *
  * @type {string[]}
  */
@@ -117,7 +118,7 @@ module.exports.scannableExtensions =
   Object.keys(EXTENSION2WRAPPER).filter(extensionIsAvailable);
 
 /**
- * returns an array of supported transpilers, whith for each transpiler:
+ * returns an array of supported transpilers, with for each transpiler:
  * - the version (range) supported
  * - whether or not it is available in the current environment
  *

package/src/extract/transpile/svelte-preprocess.js

@@ -1,6 +1,4 @@
-/* eslint-disable no-magic-numbers */
-/* eslint-disable security/detect-object-injection */
-const get = require("lodash/get");
+/* eslint-disable no-magic-numbers, security/detect-object-injection */
 
 /*
  parseAttributes copied verbatim from
@@ -35,9 +33,9 @@ function composeTranspilerOptions(pTranspilerOptions) {
   return {
     ...pTranspilerOptions,
     tsConfig: {
-      ...get(pTranspilerOptions, "tsConfig", {}),
+      ...(pTranspilerOptions?.tsConfig ?? {}),
       options: {
-        ...get(pTranspilerOptions, "tsConfig.options", {}),
+        ...(pTranspilerOptions?.tsConfig?.options ?? {}),
         importsNotUsedAsValues: "preserve",
         jsx: "preserve",
       },

package/src/extract/transpile/typescript-wrap.js

@@ -1,5 +1,4 @@
 const tryRequire = require("semver-try-require");
-const get = require("lodash/get");
 const { supportedTranspilers } = require("../../../src/meta.js");
 
 const typescript = tryRequire("typescript", supportedTranspilers.typescript);
@@ -26,7 +25,7 @@ function getCompilerOptions(pFlavor, pTSConfig) {
     // compatibility.
     target: "es2015",
     ...lCompilerOptions,
-    ...get(pTSConfig, "options", {}),
+    ...(pTSConfig?.options ?? {}),
   };
 }
 

package/src/extract/utl/get-extension.js

@@ -1,24 +1,22 @@
+// @ts-check
 const path = require("path");
 
+const EXTENSION_RE = /(?<extension>((\.d\.(c|m)?ts)|\.coffee\.md)$)/;
+
 /**
  * Returns the extension of the given file name path.
  *
  * Just using path.extname would be fine for most cases,
  * except for coffeescript, where a markdown extension can
  * mean literate coffeescript, and for typescript where
- * .d.ts and .ts are slightly different beasts
+ * .d.ts, .d.cts, .d.mts are slightly different beasts from
+ * .ts, .cts and .mts
  *
  * @param {string} pFileName path to the file to be parsed
  * @return {string}          extension
  */
 module.exports = function getExtensions(pFileName) {
-  if (pFileName.endsWith(".d.ts")) {
-    return ".d.ts";
-  }
-
-  if (pFileName.endsWith(".coffee.md")) {
-    return ".coffee.md";
-  }
+  const lMatchResult = pFileName.match(EXTENSION_RE);
 
-  return path.extname(pFileName);
+  return lMatchResult?.groups?.extension ?? path.extname(pFileName);
 };

package/src/graph-utl/consolidate-module-dependencies.js

@@ -1,5 +1,4 @@
 const clone = require("lodash/clone");
-const get = require("lodash/get");
 const _reject = require("lodash/reject");
 const uniq = require("lodash/uniq");
 const compare = require("./compare");
@@ -12,7 +11,7 @@ function mergeDependency(pLeftDependency, pRightDependency) {
       pLeftDependency.dependencyTypes.concat(pRightDependency.dependencyTypes)
     ),
     rules: pLeftDependency.rules
-      .concat(get(pRightDependency, "rules", []))
+      .concat(pRightDependency?.rules ?? [])
       .sort(compare.rules),
     valid: pLeftDependency.valid && pRightDependency.valid,
   };

package/src/graph-utl/consolidate-modules.js

@@ -1,5 +1,4 @@
 const clone = require("lodash/clone");
-const get = require("lodash/get");
 const _reject = require("lodash/reject");
 const uniqBy = require("lodash/uniqBy");
 const compare = require("./compare");
@@ -13,7 +12,7 @@ function mergeModule(pLeftModule, pRightModule) {
       (pDependency) => pDependency.resolved
     ),
     rules: pLeftModule.rules
-      .concat(get(pRightModule, "rules", []))
+      .concat(pRightModule?.rules ?? [])
       .sort(compare.rules),
     valid: pLeftModule.valid && pRightModule.valid,
     consolidated:

package/src/graph-utl/rule-set.js

@@ -1,4 +1,3 @@
-const get = require("lodash/get");
 const has = require("lodash/has");
 
 /**
@@ -13,7 +12,7 @@ const has = require("lodash/has");
  * @return {import("../../types/rule-set").IForbiddenRuleType|undefined} - a rule (or 'undefined' if nothing found)
  */
 function findRuleByName(pRuleSet, pName) {
-  return get(pRuleSet, "forbidden", []).find(
+  return (pRuleSet?.forbidden ?? []).find(
     (pForbiddenRule) => pForbiddenRule.name === pName
   );
 }
@@ -29,10 +28,10 @@ function findRuleByName(pRuleSet, pName) {
  */
 function ruleSetHasLicenseRule(pRuleSet) {
   return (
-    get(pRuleSet, "forbidden", []).some(
+    (pRuleSet?.forbidden ?? []).some(
       (pRule) => has(pRule, "to.license") || has(pRule, "to.licenseNot")
     ) ||
-    get(pRuleSet, "allowed", []).some(
+    (pRuleSet?.allowed ?? []).some(
       (pRule) => has(pRule, "to.license") || has(pRule, "to.licenseNot")
     )
   );
@@ -44,11 +43,11 @@ function ruleSetHasLicenseRule(pRuleSet) {
  */
 function ruleSetHasDeprecationRule(pRuleSet) {
   return (
-    get(pRuleSet, "forbidden", []).some((pRule) =>
-      get(pRule, "to.dependencyTypes", []).includes("deprecated")
+    (pRuleSet?.forbidden ?? []).some((pRule) =>
+      (pRule?.to?.dependencyTypes ?? []).includes("deprecated")
     ) ||
-    get(pRuleSet, "allowed", []).some((pRule) =>
-      get(pRule, "to.dependencyTypes", []).includes("deprecated")
+    (pRuleSet?.allowed ?? []).some((pRule) =>
+      (pRule?.to?.dependencyTypes ?? []).includes("deprecated")
     )
   );
 }

package/src/main/options/validate.js

@@ -1,4 +1,3 @@
-const get = require("lodash/get");
 const has = require("lodash/has");
 const safeRegex = require("safe-regex");
 const report = require("../../report");
@@ -67,8 +66,8 @@ function validatePathsSafety(pFilterOption) {
     validateRegExpSafety(pFilterOption);
   }
 
-  validateRegExpSafety(get(pFilterOption, "path", ""));
-  validateRegExpSafety(get(pFilterOption, "pathNot", ""));
+  validateRegExpSafety(pFilterOption?.path ?? "");
+  validateRegExpSafety(pFilterOption?.pathNot ?? "");
 }
 
 /**

package/src/main/resolve-options/normalize.js

@@ -14,7 +14,7 @@ const DEFAULT_CACHE_DURATION = 4000;
 const DEFAULT_RESOLVE_OPTIONS = {
   // for later: check semantics of enhanced-resolve symlinks and
   // node's preserveSymlinks. They seem to be
-  // symlink === !preserveSynlinks - but using it that way
+  // symlink === !preserveSymlinks - but using it that way
   // breaks backwards compatibility
   //
   // Someday we'll rely on this and remove the code that manually
@@ -55,7 +55,7 @@ function getNonOverridableResolveOptions(pCacheDuration) {
     // worse.
     fileSystem: new enhancedResolve.CachedInputFileSystem(fs, pCacheDuration),
     // our code depends on sync behavior, so having this
-    // overriden is not an option
+    // overridden is not an option
     useSyncFileSystemCalls: true,
   };
 }
@@ -91,7 +91,7 @@ function compileResolveOptions(
     const TsConfigPathsPlugin = require("tsconfig-paths-webpack-plugin");
     lResolveOptions.plugins = pushPlugin(
       lResolveOptions.plugins,
-      // @ts-ignore TS2351 "TsConfPathsPlugin is not constructuable" - is unjustified
+      // @ts-ignore TS2351 "TsConfPathsPlugin is not constructable" - is unjustified
       new TsConfigPathsPlugin({
         configFile: pResolveOptions.tsConfig,
         // TsConfigPathsPlugin doesn't (can't) read enhanced-resolve's
@@ -120,7 +120,6 @@ function compileResolveOptions(
 }
 
 /**
- *
  * @param {import("../../../types/dependency-cruiser").IResolveOptions} pResolveOptions
  * @param {import("../../../types/dependency-cruiser").ICruiseOptions} pOptions
  * @param {import("typescript").ParsedTsconfig} pTSConfig
@@ -143,7 +142,7 @@ module.exports = function normalizeResolveOptions(
       symlinks: get(pOptions, "preserveSymlinks", null),
       tsConfig: get(pOptions, "ruleSet.options.tsConfig.fileName", null),
 
-      /* squirel the externalModuleResolutionStrategy and combinedDependencies
+      /* squirrel the externalModuleResolutionStrategy and combinedDependencies
          thing into the resolve options
          - they're not for enhanced resolve, but they are for what we consider
          resolve options ...

package/src/meta.js

@@ -1,9 +1,9 @@
 /* generated - don't edit */
 
 module.exports = {
-  version: "11.18.0",
+  version: "12.0.0",
   engines: {
-    node: "^12.20||^14||>=16",
+    node: "^14||^16||>=18",
   },
   supportedTranspilers: {
     babel: ">=7.0.0 <8.0.0",

package/src/report/dot/module-utl.js

@@ -69,7 +69,7 @@ function makeInstabilityString(pModule, pShowMetrics = false) {
   if (pShowMetrics && has(pModule, "instability") && !pModule.consolidated) {
     lInstabilityString = ` <FONT color="#808080" point-size="8">${utl.formatInstability(
       pModule.instability
-    )}</FONT>`;
+    )}%</FONT>`;
   }
   return lInstabilityString;
 }

package/src/report/dot/prepare-folder-level.js

@@ -1,4 +1,3 @@
-const get = require("lodash/get");
 const consolidateToFolder = require("../../graph-utl/consolidate-to-folder");
 const compare = require("../../graph-utl/compare");
 const stripSelfTransitions = require("../../graph-utl/strip-self-transitions");
@@ -11,5 +10,5 @@ module.exports = (pResults, pTheme, _, pShowMetrics) => {
     .map(moduleUtl.folderify(pShowMetrics))
     .map(stripSelfTransitions)
     .map(moduleUtl.applyTheme(pTheme))
-    .map(moduleUtl.addURL(get(pResults, "summary.optionsUsed.prefix", "")));
+    .map(moduleUtl.addURL(pResults?.summary?.optionsUsed?.prefix ?? ""));
 };

package/src/report/error-html/utl.js

@@ -1,10 +1,9 @@
-const get = require("lodash/get");
 const has = require("lodash/has");
 const { version } = require("../../../src/meta.js");
 const { formatViolation, formatInstability } = require("../utl/index.js");
 
 function getFormattedAllowedRule(pRuleSetUsed) {
-  const lAllowed = get(pRuleSetUsed, "allowed", []);
+  const lAllowed = pRuleSetUsed?.allowed ?? [];
   const lCommentedRule = lAllowed.find((pRule) => has(pRule, "comment"));
   const lComment = lCommentedRule ? lCommentedRule.comment : "-";
 
@@ -12,7 +11,7 @@ function getFormattedAllowedRule(pRuleSetUsed) {
     ? {
         name: "not-in-allowed",
         comment: lComment,
-        severity: get(pRuleSetUsed, "allowedSeverity", "warn"),
+        severity: pRuleSetUsed?.allowedSeverity ?? "warn",
       }
     : [];
 }
@@ -49,7 +48,7 @@ function formatModuleTo() {
 function formatInstabilityTo(pViolation) {
   return `${pViolation.to}&nbsp;<span class="extra">(I: ${formatInstability(
     pViolation.metrics.to.instability
-  )})</span>`;
+  )}%)</span>`;
 }
 
 function determineTo(pViolation) {
@@ -70,7 +69,7 @@ function determineTo(pViolation) {
 function formatInstabilityFromExtras(pViolation) {
   return `&nbsp;<span class="extra">(I: ${formatInstability(
     pViolation.metrics.from.instability
-  )})</span>`;
+  )}%)</span>`;
 }
 
 function determineFromExtras(pViolation) {
@@ -125,8 +124,8 @@ function aggregateCountsPerRule(pViolations) {
 function aggregateViolations(pViolations, pRuleSetUsed) {
   const lViolationCounts = aggregateCountsPerRule(pViolations);
 
-  return get(pRuleSetUsed, "forbidden", [])
-    .concat(get(pRuleSetUsed, "required", []))
+  return (pRuleSetUsed?.forbidden ?? [])
+    .concat(pRuleSetUsed?.required ?? [])
     .concat(getFormattedAllowedRule(pRuleSetUsed))
     .map((pRule) => mergeCountsIntoRule(pRule, lViolationCounts))
     .sort(

package/src/report/error.js

@@ -1,6 +1,5 @@
 const chalk = require("chalk");
 const figures = require("figures");
-const get = require("lodash/get");
 const { findRuleByName } = require("../graph-utl/rule-set");
 const wrapAndIndent = require("../utl/wrap-and-indent");
 const utl = require("./utl/index.js");
@@ -50,9 +49,9 @@ function formatInstabilityViolation(pViolation) {
     chalk.dim(
       `instability: ${utl.formatInstability(
         pViolation.metrics.from.instability
-      )} ${figures.arrowRight} ${utl.formatInstability(
+      )}% ${figures.arrowRight} ${utl.formatInstability(
         pViolation.metrics.to.instability
-      )}`
+      )}%`
     ),
     EXTRA_PATH_INFORMATION_INDENT
   )}`;
@@ -106,11 +105,7 @@ function addExplanation(pRuleSet, pLong) {
   return pLong
     ? (pViolation) => ({
         ...pViolation,
-        comment: get(
-          findRuleByName(pRuleSet, pViolation.rule.name),
-          "comment",
-          "-"
-        ),
+        comment: findRuleByName(pRuleSet, pViolation.rule.name)?.comment ?? "-",
       })
     : (pViolation) => pViolation;
 }

package/src/report/teamcity.js

@@ -91,7 +91,7 @@ function formatInstabilityViolation(pViolation) {
     pViolation
   )} (instability: ${utl.formatInstability(
     pViolation.metrics.from.instability
-  )} -> ${utl.formatInstability(pViolation.metrics.to.instability)})`;
+  )}% -> ${utl.formatInstability(pViolation.metrics.to.instability)}%)`;
 }
 
 function bakeViolationMessage(pViolation) {

package/src/validate/rule-classifiers.js

@@ -1,5 +1,4 @@
 const has = require("lodash/has");
-const get = require("lodash/get");
 
 /**
  * @param {import("../../types/strict-rule-set").IStrictAnyRuleType} pRule a dependency-cruiser rule
@@ -21,7 +20,7 @@ function isModuleOnlyRule(pRule) {
 function isFolderScope(pRule) {
   // TODO might be possible to just rule pRule.scope as it's now
   // normalized away before getting here.
-  return get(pRule, "scope", "module") === "folder";
+  return (pRule?.scope ?? module) === "folder";
 }
 
 module.exports = { isModuleOnlyRule, isFolderScope };