dependency-cruiser 11.14.2 → 11.15.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "dependency-cruiser",
-  "version": "11.14.2",
+  "version": "11.15.0",
   "description": "Validate and visualize dependencies. With your rules. JavaScript, TypeScript, CoffeeScript. ES6, CommonJS, AMD.",
   "keywords": [
     "static analysis",
@@ -104,6 +104,7 @@
     "lint:types:tsc": "tsc --project types/tsconfig.json",
     "lint:types:lint": "eslint --no-ignore --config types/.eslintrc.json types/*.d.ts",
     "lint:types:fix": "eslint --no-ignore --config types/.eslintrc.json --fix types/*.d.ts",
+    "prepare": "husky install",
     "scm:push": "run-p --aggregate-output scm:push:*",
     "scm:push:bitbucket-mirror": "run-p --aggregate-output scm:push:bitbucket-mirror:*",
     "scm:push:bitbucket-mirror:commits": "git push bitbucket-mirror",
@@ -134,7 +135,7 @@
     "test:watch": "mocha --watch --watch-extensions=json --reporter=min test/\\*\\*/\\*.spec.js",
     "update-dependencies": "npm-run-all upem:update upem:install build:clean build lint:fix depcruise test:cover",
     "upem:install": "npm install",
-    "upem:update": "npm outdated --json | upem",
+    "upem:update": "npm outdated --json --long | upem | pbcopy && pbpaste",
     "version": "npm-run-all build depcruise:graph:doc scm:stage"
   },
   "dependencies": {
@@ -152,9 +153,11 @@
     "glob": "7.2.0",
     "handlebars": "4.7.7",
     "indent-string": "^4.0.0",
+    "interpret": "^2.2.0",
     "json5": "2.2.1",
     "lodash": "4.17.21",
     "prompts": "2.4.2",
+    "rechoir": "^0.8.0",
     "safe-regex": "2.1.1",
     "semver": "^7.3.7",
     "semver-try-require": "^5.0.2",
@@ -167,12 +170,12 @@
     "@babel/core": "7.18.10",
     "@babel/plugin-transform-modules-commonjs": "7.18.6",
     "@babel/preset-typescript": "7.18.6",
-    "@swc/core": "1.2.231",
-    "@types/lodash": "4.14.182",
-    "@types/node": "18.7.3",
+    "@swc/core": "1.2.241",
+    "@types/lodash": "4.14.184",
+    "@types/node": "18.7.8",
     "@types/prompts": "2.0.14",
-    "@typescript-eslint/eslint-plugin": "5.33.0",
-    "@typescript-eslint/parser": "5.33.0",
+    "@typescript-eslint/eslint-plugin": "5.33.1",
+    "@typescript-eslint/parser": "5.33.1",
     "@vue/compiler-sfc": "3.2.37",
     "c8": "7.12.0",
     "chai": "4.3.6",
@@ -187,7 +190,7 @@
     "eslint-plugin-node": "11.1.0",
     "eslint-plugin-security": "1.5.0",
     "eslint-plugin-unicorn": "^43.0.1",
-    "husky": "^4.3.8",
+    "husky": "8.0.1",
     "intercept-stdout": "0.1.2",
     "lint-staged": "12.3.4",
     "mocha": "10.0.0",
@@ -199,8 +202,8 @@
     "svelte": "3.49.0",
     "symlink-dir": "5.0.1",
     "typescript": "4.7.4",
-    "upem": "7.0.2",
-    "vue-template-compiler": "2.7.8",
+    "upem": "7.2.0",
+    "vue-template-compiler": "2.7.9",
     "yarn": "1.22.19"
   },
   "upem": {
@@ -208,12 +211,12 @@
       {
         "package": "chalk",
         "policy": "wanted",
-        "because": "version 5 only exports ejs - and we use cjs and don't transpile"
+        "because": "version 5 only exports esm - and we use cjs and don't transpile"
       },
       {
         "package": "figures",
         "policy": "wanted",
-        "because": "version 4 only exports ejs - and we use cjs and don't transpile"
+        "because": "version 4 only exports esm - and we use cjs and don't transpile"
       },
       {
         "package": "glob",
@@ -221,14 +224,14 @@
         "because": "from version 7.2.1 behavior on windows changes - in a potentially breaking fashion. Wait with upgrading until we're majoring or from when there's a vuln in 7.2.0"
       },
       {
-        "package": "husky",
+        "package": "indent-string",
         "policy": "wanted",
-        "because": "https://github.com/typicode/husky/issues/822"
+        "because": "version 5 only exports esm - and we use cjs and don't transpile"
       },
       {
-        "package": "indent-string",
+        "package": "interpret",
         "policy": "wanted",
-        "because": "version 5 only exports ejs - and we use cjs and don't transpile"
+        "because": "we want to keep interpret ~similar to what webpack-cli uses (which is ^2.2.0)"
       },
       {
         "package": "lint-staged",
@@ -238,12 +241,17 @@
       {
         "package": "normalize-newline",
         "policy": "wanted",
-        "because": "version 4 only exports ejs - and we use cjs and don't transpile (this only used in unit tests - but one of'em is a cjs one ...)"
+        "because": "version 4 only exports esm - and we use cjs and don't transpile (this only used in unit tests - but one of'em is a cjs one ...)"
+      },
+      {
+        "package": "rechoir",
+        "policy": "wanted",
+        "because": "we want to keep rechoir ~similar to what webpack-cli uses (which is ^0.7.0, but ^0.8.0 is similar enough and more recent anyway)"
       },
       {
         "package": "wrap-ansi",
         "policy": "wanted",
-        "because": "version 8 only exports ejs - and we use cjs and don't transpile"
+        "because": "version 8 only exports esm - and we use cjs and don't transpile"
       }
     ]
   },
@@ -278,11 +286,6 @@
     "vue-template-compiler": ">=2.0.0 <3.0.0",
     "@vue/compiler-sfc": ">=3.0.0 <4.0.0"
   },
-  "husky": {
-    "hooks": {
-      "pre-commit": "lint-staged"
-    }
-  },
   "lint-staged": {
     "{src,config}/**/*.js": [
       "eslint --fix"

package/src/cli/init-config/environment-helpers.js

@@ -1,5 +1,5 @@
-const fs = require("fs");
-const path = require("path");
+const { readFileSync, readdirSync, accessSync, statSync, R_OK } = require("fs");
+const { join } = require("path");
 const has = require("lodash/has");
 const get = require("lodash/get");
 const { DEFAULT_CONFIG_FILE_NAME } = require("../defaults");
@@ -9,7 +9,7 @@ const LIKELY_TEST_FOLDERS = ["test", "spec", "tests", "specs", "bdd"];
 const LIKELY_PACKAGES_FOLDERS = ["packages"];
 const TSCONFIG_CANDIDATE_PATTERN = /.*tsconfig.*\.json$/gi;
 const JSCONFIG_CANDIDATE_PATTERN = /.*jsconfig.*\.json$/gi;
-const WEBPACK_CANDIDATE_PATTERN = /.*webpack.*\.c?js(on)?$/gi;
+const WEBPACK_CANDIDATE_PATTERN = /.*webpack.*\.(c?js|json5?|ts|ya?ml)$/gi;
 const BABEL_CONFIG_CANDIDATE_PATTERN = /^\.babelrc$|.*babel.*\.json/gi;
 
 /**
@@ -17,11 +17,11 @@ const BABEL_CONFIG_CANDIDATE_PATTERN = /^\.babelrc$|.*babel.*\.json/gi;
  *
  * @param {string} pManifestFileName - the file name where the package manifest (package.json) lives
  * @returns {any} - the contents of said manifest as a javascript object
- * @throws ENOENT when the manifest wasn't found
- * @throws SyntaxError when the manifest's json is invalid
+ * @throws {ENOENT} when the manifest wasn't found
+ * @throws {SyntaxError} when the manifest's json is invalid
  */
 function readManifest(pManifestFileName = "./package.json") {
-  return JSON.parse(fs.readFileSync(pManifestFileName, "utf8"));
+  return JSON.parse(readFileSync(pManifestFileName, "utf8"));
 }
 
 /*
@@ -30,7 +30,7 @@ function readManifest(pManifestFileName = "./package.json") {
  */
 function fileExists(pFile) {
   try {
-    fs.accessSync(pFile, fs.R_OK);
+    accessSync(pFile, R_OK);
   } catch (pError) {
     return false;
   }
@@ -61,21 +61,17 @@ function isTypeModule() {
 }
 
 function getFolderNames(pFolderName) {
-  return fs
-    .readdirSync(pFolderName, "utf8")
-    .filter((pFileName) =>
-      fs.statSync(path.join(pFolderName, pFileName)).isDirectory()
-    );
+  return readdirSync(pFolderName, "utf8").filter((pFileName) =>
+    statSync(join(pFolderName, pFileName)).isDirectory()
+  );
 }
 
 function getMatchingFileNames(pPattern, pFolderName = process.cwd()) {
-  return fs
-    .readdirSync(pFolderName, "utf8")
-    .filter(
-      (pFileName) =>
-        fs.statSync(path.join(pFolderName, pFileName)).isFile() &&
-        pFileName.match(pPattern)
-    );
+  return readdirSync(pFolderName, "utf8").filter(
+    (pFileName) =>
+      statSync(join(pFolderName, pFileName)).isFile() &&
+      pFileName.match(pPattern)
+  );
 }
 
 function isLikelyMonoRepo(pFolderNames = getFolderNames(process.cwd())) {

package/src/config-utl/extract-webpack-resolve-config.js

@@ -1,3 +1,4 @@
+const { extname } = require("path");
 const makeAbsolute = require("./make-absolute");
 
 function pryConfigFromTheConfig(
@@ -22,6 +23,52 @@ function pryConfigFromTheConfig(
   return lReturnValue;
 }
 
+function suggestModules(pSuggestionList, pWebpackConfigFilename) {
+  let lReturnValue = "";
+  let lSuggestionList = pSuggestionList;
+
+  if (pSuggestionList && typeof pSuggestionList === "string") {
+    lSuggestionList = [pSuggestionList];
+  }
+
+  if (Array.isArray(lSuggestionList) && lSuggestionList.length > 0) {
+    lReturnValue = lSuggestionList.reduce(
+      (pAll, pCurrent) =>
+        (pAll += `         - ${pCurrent.module || pCurrent}\n`),
+      `\n         Some npm modules that might fix that problem (one of which you'll` +
+        `\n         need so '${pWebpackConfigFilename}' works with webpack anyway):\n`
+    );
+  }
+  return lReturnValue;
+}
+
+function tryRegisterNonNative(pWebpackConfigFilename) {
+  const lConfigExtension = extname(pWebpackConfigFilename);
+
+  if (lConfigExtension === ".mjs") {
+    throw new Error(
+      `dependency-cruiser currently does not support webpack configurations in` +
+        `\n         ES Module format (like '${pWebpackConfigFilename}').\n`
+    );
+  }
+
+  const interpret = require("interpret");
+  const rechoir = require("rechoir");
+
+  try {
+    rechoir.prepare(interpret.extensions, pWebpackConfigFilename);
+  } catch (pError) {
+    throw new Error(
+      `${pError.message}` +
+        `\n${suggestModules(
+          // eslint-disable-next-line security/detect-object-injection
+          interpret.extensions[lConfigExtension],
+          pWebpackConfigFilename
+        )}`
+    );
+  }
+}
+
 /**
  * Reads the file with name `pWebpackConfigFilename` and (applying the
  * environment `pEnvironment` and the arguments `pArguments` (which can
@@ -35,16 +82,23 @@ function pryConfigFromTheConfig(
  * @throws {Error} when the webpack config isn't usable (e.g. because it
  *                 doesn't exist, or because it's invalid)
  */
+// eslint-disable-next-line max-lines-per-function, complexity
 module.exports = function extractWebpackResolveConfig(
   pWebpackConfigFilename,
   pEnvironment,
   pArguments
 ) {
   let lReturnValue = {};
+  const lNativelySupportedExtensions = [".js", ".cjs", ".json", ".node"];
+  const lWebpackConfigFilename = makeAbsolute(pWebpackConfigFilename);
+
+  if (!lNativelySupportedExtensions.includes(extname(pWebpackConfigFilename))) {
+    tryRegisterNonNative(pWebpackConfigFilename);
+  }
 
   try {
     /* eslint node/global-require:0, security/detect-non-literal-require:0, import/no-dynamic-require:0 */
-    const lWebpackConfigModule = require(makeAbsolute(pWebpackConfigFilename));
+    const lWebpackConfigModule = require(lWebpackConfigFilename);
     const lWebpackConfig = pryConfigFromTheConfig(
       lWebpackConfigModule,
       pEnvironment,

package/src/meta.js

@@ -1,7 +1,7 @@
 /* generated - don't edit */
 
 module.exports = {
-  version: "11.14.2",
+  version: "11.15.0",
   engines: {
     node: "^12.20||^14||>=16",
   },