dependency-cruiser 10.3.1-beta-2 → 10.3.1-beta-3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "dependency-cruiser",
-  "version": "10.3.1-beta-2",
+  "version": "10.3.1-beta-3",
   "description": "Validate and visualize dependencies. With your rules. JavaScript, TypeScript, CoffeeScript. ES6, CommonJS, AMD.",
   "keywords": [
     "static analysis",

package/src/enrich/soften-known-violations.js

@@ -1,5 +1,6 @@
 const bus = require("../utl/bus");
 const busLogLevels = require("../utl/bus-log-levels");
+const isSameViolation = require("./summarize/is-same-violation");
 
 function softenModuleViolation(
   pRule,
@@ -19,25 +20,6 @@ function softenModuleViolation(
   };
 }
 
-function knownErrorMatchesViolation(pKnownError, pViolationKey) {
-  if (pKnownError.rule.name === pViolationKey.rule.name) {
-    if (pViolationKey.cycle && pKnownError.cycle) {
-      return (
-        pKnownError.cycle.length === pViolationKey.cycle.length &&
-        pKnownError.cycle.every((pModule) =>
-          pViolationKey.cycle.includes(pModule)
-        )
-      );
-    } else {
-      return (
-        pKnownError.from === pViolationKey.from &&
-        pKnownError.to === pViolationKey.to
-      );
-    }
-  }
-  return false;
-}
-
 function softenDependencyViolation(
   pViolationKey,
   pKnownDependencyViolations,
@@ -46,7 +28,7 @@ function softenDependencyViolation(
   return {
     ...pViolationKey.rule,
     severity: pKnownDependencyViolations.some((pKnownError) =>
-      knownErrorMatchesViolation(pKnownError, pViolationKey)
+      isSameViolation(pKnownError, pViolationKey)
     )
       ? pSoftenedSeverity
       : pViolationKey.rule.severity,

package/src/enrich/summarize/is-same-violation.js

@@ -0,0 +1,18 @@
+module.exports = function isSameViolation(pLeftViolation, pRightViolation) {
+  let lReturnValue = false;
+
+  if (pLeftViolation.rule.name === pRightViolation.rule.name) {
+    if (pRightViolation.cycle && pLeftViolation.cycle) {
+      lReturnValue =
+        pLeftViolation.cycle.length === pRightViolation.cycle.length &&
+        pLeftViolation.cycle.every((pModule) =>
+          pRightViolation.cycle.includes(pModule)
+        );
+    } else {
+      lReturnValue =
+        pLeftViolation.from === pRightViolation.from &&
+        pLeftViolation.to === pRightViolation.to;
+    }
+  }
+  return lReturnValue;
+};

package/src/enrich/summarize/summarize-modules.js

@@ -1,8 +1,9 @@
 const _flattenDeep = require("lodash/flattenDeep");
 const _get = require("lodash/get");
+const _uniqWith = require("lodash/uniqWith");
 const { findRuleByName } = require("../../graph-utl/rule-set");
 const compare = require("../../graph-utl/compare");
-const deDuplicateViolations = require("./de-duplicate-violations");
+const isSameViolation = require("./is-same-violation");
 
 function cutNonTransgressions(pSourceEntry) {
   return {
@@ -129,10 +130,11 @@ function extractModuleViolations(pModules, pRuleSet) {
 }
 
 module.exports = function summarizeModules(pModules, pRuleSet) {
-  const lViolations = deDuplicateViolations(
+  const lViolations = _uniqWith(
     extractDependencyViolations(pModules, pRuleSet)
       .concat(extractModuleViolations(pModules, pRuleSet))
-      .sort(compare.violations)
+      .sort(compare.violations),
+    isSameViolation
   );
 
   return {

package/src/meta.js

@@ -1,7 +1,7 @@
 /* generated - don't edit */
 
 module.exports = {
-  version: "10.3.1-beta-2",
+  version: "10.3.1-beta-3",
   engines: {
     node: "^12.20||^14||>=16",
   },

package/src/enrich/summarize/de-duplicate-violations.js

@@ -1,20 +0,0 @@
-const _uniqWith = require("lodash/uniqWith");
-
-function violationIsEqual(pLeftViolation, pRightViolation) {
-  let lReturnValue = false;
-  if (
-    pLeftViolation.rule.name === pRightViolation.rule.name &&
-    pLeftViolation.cycle
-  ) {
-    lReturnValue =
-      pLeftViolation.cycle.length === pRightViolation.cycle.length &&
-      pLeftViolation.cycle.every((pModuleName) =>
-        pRightViolation.cycle.includes(pModuleName)
-      );
-  }
-  return lReturnValue;
-}
-
-module.exports = function deDuplicateViolations(pViolations) {
-  return _uniqWith(pViolations, violationIsEqual);
-};