dependency-cruiser 10.3.0 → 10.3.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "dependency-cruiser",
-  "version": "10.3.0",
+  "version": "10.3.1",
   "description": "Validate and visualize dependencies. With your rules. JavaScript, TypeScript, CoffeeScript. ES6, CommonJS, AMD.",
   "keywords": [
     "static analysis",
@@ -139,10 +139,10 @@
     "ajv": "8.6.3",
     "chalk": "4.1.2",
     "commander": "8.2.0",
-    "enhanced-resolve": "5.8.2",
+    "enhanced-resolve": "5.8.3",
     "figures": "^3.2.0",
     "get-stream": "^6.0.1",
-    "glob": "7.1.7",
+    "glob": "7.2.0",
     "handlebars": "4.7.7",
     "indent-string": "^4.0.0",
     "inquirer": "8.1.5",
@@ -159,13 +159,13 @@
     "@babel/core": "7.15.5",
     "@babel/plugin-transform-modules-commonjs": "7.15.4",
     "@babel/preset-typescript": "7.15.0",
-    "@swc/core": "1.2.88",
-    "@typescript-eslint/eslint-plugin": "4.31.1",
-    "@typescript-eslint/parser": "4.31.1",
+    "@swc/core": "1.2.91",
+    "@typescript-eslint/eslint-plugin": "4.31.2",
+    "@typescript-eslint/parser": "4.31.2",
     "c8": "7.9.0",
     "chai": "4.3.4",
     "chai-json-schema": "1.5.1",
-    "coffeescript": "2.5.1",
+    "coffeescript": "2.6.0",
     "eslint": "7.32.0",
     "eslint-config-moving-meadow": "2.0.9",
     "eslint-config-prettier": "8.3.0",
@@ -178,12 +178,12 @@
     "husky": "^4.3.8",
     "intercept-stdout": "0.1.2",
     "lint-staged": "11.1.2",
-    "mocha": "9.1.1",
+    "mocha": "9.1.2",
     "normalize-newline": "4.1.0",
     "npm-run-all": "4.1.5",
     "prettier": "2.4.1",
     "shx": "0.3.3",
-    "svelte": "3.42.6",
+    "svelte": "3.43.0",
     "symlink-dir": "5.0.1",
     "typescript": "4.4.3",
     "upem": "^7.0.0",

package/src/enrich/soften-known-violations.js

@@ -1,5 +1,6 @@
 const bus = require("../utl/bus");
 const busLogLevels = require("../utl/bus-log-levels");
+const isSameViolation = require("./summarize/is-same-violation");
 
 function softenModuleViolation(
   pRule,
@@ -26,11 +27,8 @@ function softenDependencyViolation(
 ) {
   return {
     ...pViolationKey.rule,
-    severity: pKnownDependencyViolations.some(
-      (pKnownError) =>
-        pKnownError.from === pViolationKey.from &&
-        pKnownError.to === pViolationKey.to &&
-        pKnownError.rule.name === pViolationKey.rule.name
+    severity: pKnownDependencyViolations.some((pKnownError) =>
+      isSameViolation(pKnownError, pViolationKey)
     )
       ? pSoftenedSeverity
       : pViolationKey.rule.severity,
@@ -48,7 +46,12 @@ function softenDependencyViolations(
       ...pDependency,
       rules: pDependency.rules.map((pRule) =>
         softenDependencyViolation(
-          { rule: pRule, from: pModuleSource, to: pDependency.resolved },
+          {
+            rule: pRule,
+            from: pModuleSource,
+            to: pDependency.resolved,
+            cycle: pDependency.cycle,
+          },
           pKnownDependencyViolations,
           pSoftenedSeverity
         )

package/src/enrich/summarize/is-same-violation.js

@@ -0,0 +1,18 @@
+module.exports = function isSameViolation(pLeftViolation, pRightViolation) {
+  let lReturnValue = false;
+
+  if (pLeftViolation.rule.name === pRightViolation.rule.name) {
+    if (pRightViolation.cycle && pLeftViolation.cycle) {
+      lReturnValue =
+        pLeftViolation.cycle.length === pRightViolation.cycle.length &&
+        pLeftViolation.cycle.every((pModule) =>
+          pRightViolation.cycle.includes(pModule)
+        );
+    } else {
+      lReturnValue =
+        pLeftViolation.from === pRightViolation.from &&
+        pLeftViolation.to === pRightViolation.to;
+    }
+  }
+  return lReturnValue;
+};

package/src/enrich/summarize/summarize-modules.js

@@ -1,8 +1,9 @@
 const _flattenDeep = require("lodash/flattenDeep");
 const _get = require("lodash/get");
+const _uniqWith = require("lodash/uniqWith");
 const { findRuleByName } = require("../../graph-utl/rule-set");
 const compare = require("../../graph-utl/compare");
-const deDuplicateViolations = require("./de-duplicate-violations");
+const isSameViolation = require("./is-same-violation");
 
 function cutNonTransgressions(pSourceEntry) {
   return {
@@ -23,6 +24,7 @@ function extractMetaData(pViolations) {
       error: 0,
       warn: 0,
       info: 0,
+      ignore: 0,
     }
   );
 }
@@ -128,10 +130,11 @@ function extractModuleViolations(pModules, pRuleSet) {
 }
 
 module.exports = function summarizeModules(pModules, pRuleSet) {
-  const lViolations = deDuplicateViolations(
+  const lViolations = _uniqWith(
     extractDependencyViolations(pModules, pRuleSet)
       .concat(extractModuleViolations(pModules, pRuleSet))
-      .sort(compare.violations)
+      .sort(compare.violations),
+    isSameViolation
   );
 
   return {

package/src/meta.js

@@ -1,7 +1,7 @@
 /* generated - don't edit */
 
 module.exports = {
-  version: "10.3.0",
+  version: "10.3.1",
   engines: {
     node: "^12.20||^14||>=16",
   },

package/src/schema/cruise-result.schema.js

@@ -172,6 +172,7 @@ module.exports = {
         error: { type: "number" },
         warn: { type: "number" },
         info: { type: "number" },
+        ignore: { type: "number" },
         totalCruised: { type: "number" },
         totalDependenciesCruised: { type: "number" },
         ruleSetUsed: { $ref: "#/definitions/RuleSetType" },

package/types/cruise-result.d.ts

@@ -271,6 +271,10 @@ export interface ISummary {
    * the number of errors in the dependencies
    */
   error: number;
+  /**
+   * the number of ignored notices in the dependencies
+   */
+  ignore: number;
   /**
    * the number of informational level notices in the dependencies
    */

package/src/enrich/summarize/de-duplicate-violations.js

@@ -1,18 +0,0 @@
-const _difference = require("lodash/difference");
-const _uniqWith = require("lodash/uniqWith");
-
-function violationIsEqual(pLeftViolation, pRightViolation) {
-  if (
-    pLeftViolation.rule.name === pRightViolation.rule.name &&
-    pLeftViolation.cycle
-  ) {
-    return (
-      _difference(pLeftViolation.cycle, pRightViolation.cycle).length === 0
-    );
-  }
-  return false;
-}
-
-module.exports = function deDuplicateViolations(pViolations) {
-  return _uniqWith(pViolations, violationIsEqual);
-};