delimit-cli 4.6.0 → 4.6.2

package/gateway/core/semver_classifier.py

@@ -26,17 +26,42 @@ class SemverBump(Enum):
 
 # ── Change-type buckets ──────────────────────────────────────────────
 
+# LED-1600: this bucket MUST stay aligned with diff_engine_v2.Change.is_breaking.
+# Previously it listed only 10 of the engine's breaking types, so a
+# PARAM_REQUIRED_CHANGED, RESPONSE_TYPE_CHANGED, SECURITY_REMOVED,
+# SECURITY_SCOPE_REMOVED, MAX_LENGTH_DECREASED, MIN_LENGTH_INCREASED or
+# PARAM_TYPE_CHANGED — all of which the engine flags `is_breaking=True` — was
+# silently classified MINOR instead of MAJOR. That is the exact "silent semver
+# minor->major leak" this LED closes: a breaking change slipping through as
+# non-breaking is the worst failure mode for a merge gate. The context-
+# sensitive field types (FIELD_REMOVED / REQUIRED_FIELD_ADDED /
+# FIELD_REQUIREMENT_RELAXED) are NOT listed here as unconditional — their
+# breaking-ness depends on request/response direction and is read per-Change
+# via `is_breaking` in classify() below.
 BREAKING_TYPES = frozenset({
     ChangeType.ENDPOINT_REMOVED,
     ChangeType.METHOD_REMOVED,
     ChangeType.REQUIRED_PARAM_ADDED,
     ChangeType.PARAM_REMOVED,
     ChangeType.RESPONSE_REMOVED,
-    ChangeType.REQUIRED_FIELD_ADDED,
-    ChangeType.FIELD_REMOVED,
     ChangeType.TYPE_CHANGED,
     ChangeType.FORMAT_CHANGED,
     ChangeType.ENUM_VALUE_REMOVED,
+    ChangeType.PARAM_TYPE_CHANGED,
+    ChangeType.PARAM_REQUIRED_CHANGED,
+    ChangeType.RESPONSE_TYPE_CHANGED,
+    ChangeType.SECURITY_REMOVED,
+    ChangeType.SECURITY_SCOPE_REMOVED,
+    ChangeType.MAX_LENGTH_DECREASED,
+    ChangeType.MIN_LENGTH_INCREASED,
+})
+
+# Context-sensitive types whose breaking-ness is decided per-Change by the
+# engine's direction-aware is_breaking, not by membership in BREAKING_TYPES.
+CONTEXT_SENSITIVE_TYPES = frozenset({
+    ChangeType.FIELD_REMOVED,
+    ChangeType.REQUIRED_FIELD_ADDED,
+    ChangeType.FIELD_REQUIREMENT_RELAXED,
 })
 
 ADDITIVE_TYPES = frozenset({
@@ -65,7 +90,14 @@ def classify(changes: List[Change]) -> SemverBump:
     has_additive = False
 
     for change in changes:
-        if change.type in BREAKING_TYPES:
+        # LED-1600: the engine's is_breaking is the single source of truth.
+        # For context-sensitive types it already encodes request/response
+        # direction; for everything else it matches BREAKING_TYPES membership.
+        # Using it here closes the gap where a breaking change (e.g. an
+        # optional->required param, or a response field removal) was bucketed
+        # MINOR. `getattr` keeps the function working for duck-typed Change-
+        # likes that may not carry the property.
+        if _is_breaking(change):
             has_breaking = True
             break  # short-circuit — can't go higher than MAJOR
         if change.type in ADDITIVE_TYPES:
@@ -78,6 +110,20 @@ def classify(changes: List[Change]) -> SemverBump:
     return SemverBump.PATCH
 
 
+def _is_breaking(change) -> bool:
+    """Authoritative breaking check for a Change.
+
+    Prefers the engine's direction-aware ``is_breaking`` property. Falls back
+    to BREAKING_TYPES membership for objects that don't expose it (e.g. test
+    doubles). Context-sensitive types are only breaking when ``is_breaking``
+    says so; never inferred from the type alone.
+    """
+    val = getattr(change, "is_breaking", None)
+    if isinstance(val, bool):
+        return val
+    return getattr(change, "type", None) in BREAKING_TYPES
+
+
 def classify_detailed(changes: List[Change]) -> Dict[str, Any]:
     """Return a detailed classification with per-category breakdowns.
 
@@ -85,9 +131,9 @@ def classify_detailed(changes: List[Change]) -> Dict[str, Any]:
     """
     bump = classify(changes)
 
-    breaking = [c for c in changes if c.type in BREAKING_TYPES]
-    additive = [c for c in changes if c.type in ADDITIVE_TYPES]
-    patch = [c for c in changes if c.type in PATCH_TYPES]
+    breaking = [c for c in changes if _is_breaking(c)]
+    additive = [c for c in changes if not _is_breaking(c) and c.type in ADDITIVE_TYPES]
+    patch = [c for c in changes if not _is_breaking(c) and c.type in PATCH_TYPES]
 
     return {
         "bump": bump.value,

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "delimit-cli",
   "mcpName": "io.github.delimit-ai/delimit-mcp-server",
-  "version": "4.6.0",
+  "version": "4.6.2",
   "description": "Unify Claude Code, Codex, Cursor, and Gemini CLI with persistent context, governance, and multi-model debate.",
   "main": "index.js",
   "files": [
@@ -42,6 +42,9 @@
     "!scripts/demo-v420-clean.sh",
     "!scripts/demo-v420-deliberation.sh",
     "!scripts/sync-gateway.sh",
+    "!scripts/build-license-core.sh",
+    "!scripts/security-check.sh",
+    "!scripts/test-license-core-so.sh",
     "!gateway/ai/continuity.py",
     "server.json",
     "README.md",

package/scripts/build-license-core.sh

@@ -1,85 +0,0 @@
-#!/bin/bash
-# LED-1259: Compile gateway/ai/license_core.py to a native .so via Nuitka,
-# then strip the plaintext .py from the bundle so customers cannot grep
-# the validation logic for bypass identifiers.
-#
-# Linux-only first ship. Mac/Windows expansion is filed as a follow-up
-# ledger item — non-linux customers will hit the Python fallback in
-# license.py (degraded Pro features) until we ship per-platform binaries.
-#
-# Idempotent: safe to re-run; will rebuild on every invocation.
-
-set -euo pipefail
-
-SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
-NPM_ROOT="$(cd "$SCRIPT_DIR/.." && pwd)"
-AI_DIR="$NPM_ROOT/gateway/ai"
-SRC="$AI_DIR/license_core.py"
-
-# ── Platform gate ────────────────────────────────────────────────────
-UNAME_S="$(uname -s)"
-UNAME_M="$(uname -m)"
-if [ "$UNAME_S" != "Linux" ]; then
-    echo "⚠️  build-license-core: non-Linux host ($UNAME_S) — skipping compile."
-    echo "   First ship is linux-only. The bundle will fall back to .py."
-    exit 0
-fi
-
-if [ ! -f "$SRC" ]; then
-    echo "❌ Source not found: $SRC"
-    exit 1
-fi
-
-# ── Toolchain check ──────────────────────────────────────────────────
-PY="${PYTHON:-python3}"
-if ! command -v "$PY" >/dev/null 2>&1; then
-    echo "❌ python3 not found"
-    exit 1
-fi
-
-PY_VER="$($PY -c 'import sys; print(f"{sys.version_info.major}.{sys.version_info.minor}")')"
-echo "🔧 build-license-core: python=$PY ($PY_VER), arch=$UNAME_M"
-
-if ! "$PY" -m nuitka --version >/dev/null 2>&1; then
-    echo "📦 nuitka not installed — installing via pip..."
-    "$PY" -m pip install --quiet --user nuitka
-fi
-
-NUITKA_VER="$($PY -m nuitka --version 2>&1 | head -1)"
-echo "   nuitka=$NUITKA_VER"
-
-# ── Compile ──────────────────────────────────────────────────────────
-echo "🔨 Compiling license_core.py → .so (this takes ~30s)..."
-cd "$AI_DIR"
-"$PY" -m nuitka --module --quiet --remove-output --output-dir=. license_core.py
-
-# ── Verify output ────────────────────────────────────────────────────
-SO_FILE="$(ls -1 license_core.cpython-*-*.so 2>/dev/null | head -1 || true)"
-if [ -z "$SO_FILE" ] || [ ! -f "$SO_FILE" ]; then
-    echo "❌ Compile failed — no .so produced in $AI_DIR"
-    ls -la "$AI_DIR"/license_core* 2>&1 || true
-    exit 1
-fi
-
-SO_SIZE="$(stat -c%s "$SO_FILE")"
-echo "   ✅ produced: $SO_FILE ($SO_SIZE bytes)"
-
-# ── Bypass-identifier scan ───────────────────────────────────────────
-# Customers must not be able to `strings | grep` the .so for known
-# bypass class names. Fail the build if any leak through.
-BYPASS_HITS="$(strings "$SO_FILE" | grep -iE 'DELIMIT_TEST_MODE|DELIMIT_INTERNAL_LICENSE_KEY|JAMSONS' || true)"
-if [ -n "$BYPASS_HITS" ]; then
-    echo "❌ Bypass identifiers found in compiled .so:"
-    echo "$BYPASS_HITS"
-    exit 1
-fi
-echo "   ✅ strings-grep clean (no bypass identifiers)"
-
-# ── Drop the plaintext source from the bundle ────────────────────────
-# .npmignore + package.json will also exclude it, but removing here is
-# belt-and-suspenders so dev/test inspection of the bundle dir matches
-# what gets packed.
-rm -f "$AI_DIR/license_core.py"
-echo "   ✅ removed plaintext license_core.py from bundle"
-
-echo "✅ build-license-core complete: $SO_FILE"

package/scripts/security-check.sh

@@ -1,66 +0,0 @@
-#!/bin/bash
-# Pre-publish security check — blocks npm publish if secrets are found
-# Run: bash scripts/security-check.sh
-
-set -euo pipefail
-
-echo "🔍 Delimit pre-publish security scan..."
-
-FAIL=0
-
-# Pack to temp and scan the actual tarball contents
-TMPDIR=$(mktemp -d)
-npm pack --pack-destination "$TMPDIR" --quiet 2>/dev/null
-TARBALL=$(ls "$TMPDIR"/*.tgz)
-tar -xzf "$TARBALL" -C "$TMPDIR"
-
-# 1. Credential patterns
-echo -n "  Credentials... "
-if grep -rEi '(password|passwd|secret|api_key|apikey)\s*[:=]\s*["\x27][^"\x27]{4,}' "$TMPDIR/package/" --include="*.py" --include="*.js" --include="*.json" 2>/dev/null | grep -v 'environ\|getenv\|process\.env\|os\.environ\|<configured\|example\|placeholder\|REDACTED\|\${credentials\|credentials\.\|security-scan-ignore'; then
-    echo "❌ FOUND CREDENTIALS"
-    FAIL=1
-else
-    echo "✅ clean"
-fi
-
-# 2. Blocklist terms
-echo -n "  Blocklist... "
-BLOCKLIST="jamsonsholdings|Bladabah|Domainvested26|Delimit26|home/jamsons|infracore|crypttrx|\.wr_env"
-if grep -rEi "$BLOCKLIST" "$TMPDIR/package/" --include="*.py" --include="*.js" --include="*.json" 2>/dev/null; then
-    echo "❌ BLOCKED TERMS FOUND"
-    FAIL=1
-else
-    echo "✅ clean"
-fi
-
-# 3. PII (email addresses that aren't examples)
-echo -n "  PII... "
-if grep -rEi '[a-z0-9._%+-]+@(gmail|yahoo|hotmail|outlook|proton|jamsons|wire\.report|domainvested)' "$TMPDIR/package/" --include="*.py" --include="*.js" --include="*.json" 2>/dev/null | grep -v "example\|placeholder\|<configured\|noreply\|e\.g\.\|docstring\|Args:\|Credential resolution"; then
-    echo "❌ PII FOUND"
-    FAIL=1
-else
-    echo "✅ clean"
-fi
-
-# 4. Proprietary files that shouldn't ship
-echo -n "  Proprietary files... "
-PROPRIETARY="social_target\.py|social\.py|founding_users\.py|inbox_daemon\.py|deliberation\.py"
-if find "$TMPDIR/package/" -name "*.py" | grep -Ei "$PROPRIETARY" 2>/dev/null; then
-    echo "❌ PROPRIETARY FILES IN PACKAGE"
-    FAIL=1
-else
-    echo "✅ clean"
-fi
-
-# Cleanup
-rm -rf "$TMPDIR"
-
-if [ $FAIL -ne 0 ]; then
-    echo ""
-    echo "❌ SECURITY CHECK FAILED — do not publish"
-    exit 1
-fi
-
-echo ""
-echo "✅ All security checks passed"
-exit 0

package/scripts/test-license-core-so.sh

@@ -1,107 +0,0 @@
-#!/bin/bash
-# LED-1259: Verify that the compiled license_core .so:
-#   1. Compiles cleanly from gateway/ai/license_core.py
-#   2. Imports successfully when the .py is absent
-#   3. Exposes all public functions/constants the shim relies on
-#   4. Returns correct validation verdicts for known-valid / known-expired
-#      license dicts
-#   5. Contains zero bypass identifiers in `strings` output
-#
-# Runs in an isolated tmp dir so it doesn't pollute the bundle layout.
-
-set -euo pipefail
-
-SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
-NPM_ROOT="$(cd "$SCRIPT_DIR/.." && pwd)"
-SRC="$NPM_ROOT/gateway/ai/license_core.py"
-
-if [ "$(uname -s)" != "Linux" ]; then
-    echo "⏭️  test-license-core-so: non-Linux host — skipping (Linux-only first ship)"
-    exit 0
-fi
-
-if [ ! -f "$SRC" ]; then
-    echo "ℹ️  license_core.py not in bundle (already compiled or pre-build) — copying from gateway src for test"
-    GW_SRC="${GATEWAY_OVERRIDE:-/home/delimit/delimit-gateway}/ai/license_core.py"
-    if [ ! -f "$GW_SRC" ]; then
-        echo "❌ No license_core.py source found (bundle or gateway). Cannot test."
-        exit 1
-    fi
-    SRC="$GW_SRC"
-fi
-
-PY="${PYTHON:-python3}"
-TMP="$(mktemp -d)"
-trap 'rm -rf "$TMP"' EXIT
-
-echo "🧪 test-license-core-so: building in $TMP"
-mkdir -p "$TMP/ai"
-touch "$TMP/ai/__init__.py"
-cp "$SRC" "$TMP/license_core.py"
-
-cd "$TMP"
-"$PY" -m nuitka --module --quiet --remove-output --output-dir=. license_core.py 2>&1 | tail -3
-
-SO_FILE="$(ls -1 license_core.cpython-*-*.so 2>/dev/null | head -1)"
-if [ -z "$SO_FILE" ]; then
-    echo "❌ Compile failed — no .so produced"
-    exit 1
-fi
-echo "  ✅ compiled: $SO_FILE ($(stat -c%s "$SO_FILE") bytes)"
-
-# Strings-grep for bypass identifiers
-HITS="$(strings "$SO_FILE" | grep -iE 'DELIMIT_TEST_MODE|DELIMIT_INTERNAL_LICENSE_KEY|JAMSONS' || true)"
-if [ -n "$HITS" ]; then
-    echo "❌ Bypass identifiers leaked into .so:"
-    echo "$HITS"
-    exit 1
-fi
-echo "  ✅ strings-grep clean"
-
-# Move .so under ai/, drop the .py, run import + behaviour checks
-mv "$SO_FILE" "ai/$SO_FILE"
-rm -f license_core.py
-
-"$PY" - <<'PY'
-import os, sys, time
-sys.path.insert(0, ".")
-
-# Import via the compiled .so only — no .py present
-from ai.license_core import (
-    is_license_valid, revalidate_license, needs_revalidation,
-    PRO_TOOLS, LICENSE_FILE, FREE_TRIAL_LIMITS, activate,
-    load_license, check_premium, gate_tool,
-)
-
-assert isinstance(PRO_TOOLS, frozenset) and len(PRO_TOOLS) > 0, "PRO_TOOLS must be a non-empty frozenset"
-assert FREE_TRIAL_LIMITS.get("delimit_deliberate") == 3, "FREE_TRIAL_LIMITS missing delimit_deliberate=3"
-assert "delimit_deliberate" in PRO_TOOLS, "PRO_TOOLS must include delimit_deliberate"
-assert callable(activate), "activate must be callable"
-assert callable(revalidate_license), "revalidate_license must be callable"
-
-# Known-valid: pro tier, recent last_validated_at
-valid_recent = {"tier": "pro", "valid": True, "last_validated_at": time.time()}
-assert is_license_valid(valid_recent) is True, "recent pro license should be valid"
-assert needs_revalidation(valid_recent) is False, "recent pro license should not need revalidation"
-
-# Known-invalid: pro tier but last_validated_at > 44 days ago (beyond hard cutoff)
-expired = {"tier": "pro", "valid": True, "last_validated_at": time.time() - 60 * 86400}
-assert is_license_valid(expired) is False, "expired (60d) pro license must be invalid"
-assert needs_revalidation(expired) is True, "expired (60d) pro license must need revalidation"
-
-# Free tier never valid for Pro
-free = {"tier": "free", "valid": True}
-assert is_license_valid(free) is False, "free tier must not pass is_license_valid"
-
-# valid=False forces invalid even when timestamp is recent
-revoked = {"tier": "pro", "valid": False, "last_validated_at": time.time()}
-assert is_license_valid(revoked) is False, "revoked license must be invalid"
-
-# Legacy file with no timestamps — should signal needs_revalidation=True
-legacy = {"tier": "pro", "valid": True}
-assert needs_revalidation(legacy) is True, "legacy license without timestamps must need revalidation"
-
-print("ALL_OK")
-PY
-
-echo "✅ test-license-core-so: all checks passed"