deflake 1.2.47 → 1.2.49

package/cli.js

@@ -375,6 +375,7 @@ async function analyzeAndFix(artifacts, client, argv, capturedOutput = '', backu
     
     console.log(`${C.BRIGHT}🔍 Analyzing ${artifacts.length} failure(s)...${C.RESET}\n`);
     let count = 0;
+    const fixedFiles = new Set(); // Dedup: track files already fixed to avoid cascading mutations
     for (let i = 0; i < artifacts.length; i++) {
         const art = artifacts[i];
         console.log(`${C.CYAN}━━━ [${i+1}/${artifacts.length}] ${art.name} ━━━${C.RESET}`);
@@ -404,6 +405,14 @@ async function analyzeAndFix(artifacts, client, argv, capturedOutput = '', backu
             // Step 1: Location extraction
             if (loc) {
                 console.log(`   ${C.GRAY}📍 Location:${C.RESET} ${path.basename(loc.path)}:${loc.line} ${C.GRAY}(from ${locSource})${C.RESET}`);
+                
+                // Dedup: skip if this EXACT file:line was already fixed by a previous artifact
+                const fileKey = `${loc.path}:${loc.line}`;
+                if (fixedFiles.has(fileKey)) {
+                    console.log(`   ${C.GREEN}⏭️  Already fixed by a previous artifact — skipping duplicate${C.RESET}`);
+                    console.log('');
+                    continue;
+                }
             } else {
                 console.log(`   ${C.YELLOW}📍 Location: Could not extract from any source${C.RESET}`);
             }
@@ -455,9 +464,16 @@ async function analyzeAndFix(artifacts, client, argv, capturedOutput = '', backu
                         if (p.new_line && p.action === 'REPLACE') {
                             const validation = validateSelectorAgainstAxTree(p.new_line, content);
                             if (!validation.valid) {
-                                allValid = false;
-                                rejections.push(`Line ${p.line}: "${p.new_line.trim()}" → REJECTED: ${validation.reason}`);
-                                console.log(`   ${C.YELLOW}🔍 Validation FAILED for line ${p.line}: ${validation.reason}${C.RESET}`);
+                                // On last retry: allow getByRole/getByText through (dynamic elements not in initial AX tree)
+                                const isLastRetry = retryIdx === MAX_VALIDATION_RETRIES - 1;
+                                const isAccessibilitySelector = /getBy(Role|Text|Label|Placeholder)/.test(p.new_line);
+                                if (isLastRetry && isAccessibilitySelector) {
+                                    console.log(`   ${C.YELLOW}🔍 Validation SOFT-PASS for line ${p.line}: ${validation.reason} (last retry, allowing accessibility selector)${C.RESET}`);
+                                } else {
+                                    allValid = false;
+                                    rejections.push(`Line ${p.line}: "${p.new_line.trim()}" → REJECTED: ${validation.reason}`);
+                                    console.log(`   ${C.YELLOW}🔍 Validation FAILED for line ${p.line}: ${validation.reason}${C.RESET}`);
+                                }
                             } else {
                                 console.log(`   ${C.GREEN}🔍 Validation OK for line ${p.line}: ${validation.reason}${C.RESET}`);
                             }
@@ -520,6 +536,7 @@ async function analyzeAndFix(artifacts, client, argv, capturedOutput = '', backu
                                 console.log(`   ${C.BRIGHT}💉 Applying patches...${C.RESET}`);
                                 if (await applyFix(res, fixLoc, backups)) {
                                    count++;
+                                   fixedFiles.add(`${fixLoc.path}:${fixLoc.line}`); // Track: don't fix this exact location again
                                    console.log(`   ${C.GREEN}${C.BRIGHT}✅ Fix applied to ${path.basename(fixLoc.path)}:${fixLoc.line}${C.RESET}`);
                                 } else {
                                    console.log(`   ${C.YELLOW}⚠️  Patches could not be applied (see details above)${C.RESET}`);
@@ -601,6 +618,11 @@ async function applyFix(res, loc, backups = new Map()) {
                     console.log(`   ${C.GRAY}⏭️  Skipped (already present): ${p.new_line.trim().substring(0, 60)}...${C.RESET}`);
                     continue;
                 }
+                // Safety: block constructor patterns (this.xxx =) from being inserted into spec/test files
+                if (/\.(spec|test)\.(ts|js)$/.test(filePath) && /^\s*this\.\w+\s*=/.test(p.new_line)) {
+                    console.log(`   ${C.YELLOW}⏭️  Blocked: constructor assignment in spec file (${p.new_line.trim().substring(0, 50)})${C.RESET}`);
+                    continue;
+                }
                 if (p.action === 'INSERT_AFTER') {
                     // SAFETY: Detect if we'd insert at class scope (outside any method)
                     // Pattern: line is '}' (end of constructor/method) and next non-blank line starts a new method

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "deflake",
-  "version": "1.2.47",
+  "version": "1.2.49",
   "description": "AI-powered self-healing tool for Playwright, Cypress, and WebdriverIO tests.",
   "main": "client.js",
   "bin": {