deepspace 0.6.0 → 0.6.1

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # deepspace
 
+## 0.6.1
+
+### Patch Changes
+
+- Make silent failures visible. `RecordProvider` now accepts an `onWriteError` prop (`(error: WriteError) => void`, where `WriteError` is `{ kind: 'permission' | 'validation', title, detail }`) — previously the friendly-error pipeline (server rejection → `parseServerError` → callback) was unreachable from the public API, so a denied or invalid optimistic write looked like a success with no signal anywhere. Unhandled rejections fall back to a loud `console.error` explaining how to wire real UI (note: this fires in production too — existing apps that never wired a handler will start logging rejected writes to the console; each unique error logs once, repeats are suppressed), and the starter template routes `onWriteError` to its toast system out of the box (permission → warning toast, validation → error toast). On localhost, a signed-out `RecordProvider` without `allowAnonymous` renders a visible diagnostic instead of a blank page (production still renders nothing), and passing `schemas` alongside `roomId` (where it's ignored) warns once; both diagnostics can be forced on or off via `globalThis.DEEPSPACE_DEV = true | false` (LAN/tunnel previews, consumer test suites). `deepspace dev` and `deepspace deploy` now run schema lint up front and print findings (e.g. a `visibilityField` no role enforces) in the terminal, capped at 5 with an overflow count — previously these only appeared in the worker console after a client connected.
+
 ## 0.6.0
 
 ### Minor Changes

package/dist/cli.js

@@ -3,8 +3,8 @@
 // src/cli/cli.ts
 import { defineCommand as defineCommand22, runMain } from "citty";
 import { spawnSync as spawnSync6 } from "child_process";
-import { readFileSync as readFileSync17, existsSync as existsSync14 } from "fs";
-import { dirname as dirname5, join as join15 } from "path";
+import { readFileSync as readFileSync17, existsSync as existsSync15 } from "fs";
+import { dirname as dirname5, join as join16 } from "path";
 import { fileURLToPath as fileURLToPath3 } from "url";
 
 // src/cli/lib/cli-errors.ts
@@ -1342,7 +1342,7 @@ var logout_default = defineCommand2({
 
 // src/cli/commands/dev.ts
 import { defineCommand as defineCommand3 } from "citty";
-import { resolve as resolve4, basename as basename2, join as join9 } from "path";
+import { resolve as resolve4, basename as basename2, join as join10 } from "path";
 import spawn from "cross-spawn";
 
 // src/cli/auth.ts
@@ -1788,6 +1788,112 @@ function removeMacosJunk(dir) {
   return removed;
 }
 
+// src/cli/lib/schema-lint.ts
+import { existsSync as existsSync9 } from "fs";
+import { join as join9 } from "path";
+import { pathToFileURL } from "url";
+
+// src/server/schemas/registry.ts
+var USERS_COLUMNS = [
+  { name: "email", storage: "text", interpretation: "plain" },
+  { name: "name", storage: "text", interpretation: "plain" },
+  { name: "imageUrl", storage: "text", interpretation: "plain" },
+  { name: "role", storage: "text", interpretation: "plain" },
+  { name: "createdAt", storage: "text", interpretation: { kind: "datetime" } },
+  { name: "lastSeenAt", storage: "text", interpretation: { kind: "datetime" } }
+];
+var BASE_USERS_SCHEMA = {
+  name: "users",
+  columns: [...USERS_COLUMNS],
+  permissions: {
+    "*": { read: "own", create: false, update: false, delete: false },
+    admin: { read: true, create: false, update: true, delete: true }
+  }
+};
+function lintSchema(schema) {
+  const warnings = [];
+  const VISIBILITY_AWARE = ["published", "shared"];
+  if (schema.visibilityField) {
+    const offendingRoles = Object.entries(schema.permissions).filter(([, perms]) => perms.read === true).map(([role]) => role);
+    if (offendingRoles.length > 0) {
+      const usesAware = Object.values(schema.permissions).some(
+        (p10) => typeof p10.read === "string" && VISIBILITY_AWARE.includes(p10.read)
+      );
+      if (!usesAware) {
+        warnings.push(
+          `[${schema.name}] visibilityField is declared but no role uses read: 'published' or 'shared'. Roles with read: true (${offendingRoles.join(", ")}) will see every row regardless of visibility. Change those to read: 'published' (owner OR public) or 'shared' (owner OR collaborator OR public) to actually enforce the filter, or remove visibilityField if you don't intend to gate reads by it.`
+        );
+      }
+    }
+  }
+  if (schema.ownerField) {
+    const col = schema.columns.find((c) => c.name === schema.ownerField);
+    if (col && !col.userBound) {
+      warnings.push(
+        `[${schema.name}] ownerField is '${schema.ownerField}' but that column is not marked userBound: true. A client can create a row with someone else's id in this field, bypassing 'own' permission checks. Add userBound: true (and ideally immutable: true) to the column.`
+      );
+    }
+  }
+  for (const col of schema.columns) {
+    if (col.userBound && col.storage !== "text") {
+      warnings.push(
+        `[${schema.name}] column '${col.name}' is userBound but storage is '${col.storage}'. userBound stamps the user id (a string); use storage: 'text'.`
+      );
+    }
+  }
+  return warnings;
+}
+
+// src/cli/lib/schema-lint.ts
+async function lintProjectSchemas(appDir) {
+  const schemasPath = join9(appDir, "src", "schemas.ts");
+  if (!existsSync9(schemasPath)) return null;
+  let schemas;
+  try {
+    const esbuild = await import("esbuild");
+    const outFile = join9(appDir, ".wrangler", "deploy", "schemas.lint.bundle.mjs");
+    await esbuild.build({
+      entryPoints: [schemasPath],
+      bundle: true,
+      format: "esm",
+      platform: "node",
+      target: "node18",
+      outfile: outFile,
+      logLevel: "silent",
+      write: true
+    });
+    const mod = await import(`${pathToFileURL(outFile).href}?t=${Date.now()}`);
+    schemas = mod.schemas;
+  } catch {
+    console.warn(
+      "Schema lint skipped: could not bundle src/schemas.ts (the worker still lints at runtime)."
+    );
+    return null;
+  }
+  if (!Array.isArray(schemas)) return null;
+  const findings = [];
+  for (const schema of schemas) {
+    if (!schema || typeof schema !== "object") continue;
+    try {
+      findings.push(...lintSchema(schema));
+    } catch {
+    }
+  }
+  return findings;
+}
+var MAX_PRINTED_FINDINGS = 5;
+function formatSchemaLintFindings(findings) {
+  if (findings.length === 0) return [];
+  const n = findings.length;
+  const shown = findings.slice(0, MAX_PRINTED_FINDINGS);
+  const hidden = n - shown.length;
+  return [
+    `Schema lint: ${n} warning${n === 1 ? "" : "s"} in src/schemas.ts \u2014 ${n === 1 ? "this ships" : "these ship"} as permission/privacy bugs:`,
+    ...shown.map((f) => `  \u2022 ${f}`),
+    ...hidden > 0 ? [`  \u2026and ${hidden} more \u2014 fix the above and re-run to see the rest.`] : []
+  ];
+}
+
 // src/cli/lib/port.ts
 import { createServer } from "net";
 var DEFAULT_PORT = 5173;
@@ -1874,7 +1980,7 @@ var dev_default = defineCommand3({
         );
       } else {
         console.warn(
-          `Warning: could not update ${join9(worktree.mainRepoRoot, ".claude", "launch.json")} (malformed or unwritable) \u2014 the Claude preview tool may serve the main repo's code instead of this worktree.`
+          `Warning: could not update ${join10(worktree.mainRepoRoot, ".claude", "launch.json")} (malformed or unwritable) \u2014 the Claude preview tool may serve the main repo's code instead of this worktree.`
         );
       }
       if (!explicitPort && process.env.DEEPSPACE_PORT) {
@@ -1887,6 +1993,10 @@ var dev_default = defineCommand3({
       updatePort: explicitPort
     });
     ensureInstallReady(appDir);
+    const lintFindings = await lintProjectSchemas(appDir);
+    if (lintFindings && lintFindings.length > 0) {
+      for (const line of formatSchemaLintFindings(lintFindings)) console.warn(line);
+    }
     let token;
     try {
       token = await ensureToken();
@@ -2474,15 +2584,15 @@ var screenshot_default = defineCommand6({
 // src/cli/commands/test-accounts.ts
 import { defineCommand as defineCommand7 } from "citty";
 import * as p3 from "@clack/prompts";
-import { readFileSync as readFileSync10, writeFileSync as writeFileSync8, existsSync as existsSync9, mkdirSync as mkdirSync4 } from "fs";
-import { join as join10 } from "path";
+import { readFileSync as readFileSync10, writeFileSync as writeFileSync8, existsSync as existsSync10, mkdirSync as mkdirSync4 } from "fs";
+import { join as join11 } from "path";
 import { homedir as homedir4 } from "os";
 var SESSION_COOKIE2 = "__Secure-better-auth.session_token";
 var AUTH_URL4 = process.env.DEEPSPACE_AUTH_URL ?? PLATFORM_URLS.auth;
-var DIR3 = join10(homedir4(), ".deepspace");
-var ACCOUNTS_PATH = join10(DIR3, "test-accounts.json");
+var DIR3 = join11(homedir4(), ".deepspace");
+var ACCOUNTS_PATH = join11(DIR3, "test-accounts.json");
 function loadAccounts() {
-  if (!existsSync9(ACCOUNTS_PATH)) return [];
+  if (!existsSync10(ACCOUNTS_PATH)) return [];
   try {
     return JSON.parse(readFileSync10(ACCOUNTS_PATH, "utf-8"));
   } catch {
@@ -2764,9 +2874,9 @@ var test_accounts_default = defineCommand7({
 import { defineCommand as defineCommand8 } from "citty";
 import { execSync as execSync2 } from "child_process";
 import { randomUUID } from "crypto";
-import { readFileSync as readFileSync11, readdirSync as readdirSync4, existsSync as existsSync10 } from "fs";
-import { join as join11, resolve as resolve7, dirname as dirname2 } from "path";
-import { pathToFileURL } from "url";
+import { readFileSync as readFileSync11, readdirSync as readdirSync4, existsSync as existsSync11 } from "fs";
+import { join as join12, resolve as resolve7, dirname as dirname2 } from "path";
+import { pathToFileURL as pathToFileURL2 } from "url";
 import * as p4 from "@clack/prompts";
 var DEPLOY_URL3 = process.env.DEEPSPACE_DEPLOY_URL ?? PLATFORM_URLS.deploy;
 var API_URL2 = process.env.DEEPSPACE_API_URL ?? PLATFORM_URLS.api;
@@ -2978,7 +3088,7 @@ var deploy_default = defineCommand8({
     }
     p4.log.info(`Id: ${appId}`);
     const readCustomDevVarsAt = (path) => {
-      if (!existsSync10(path)) return {};
+      if (!existsSync11(path)) return {};
       const section = extractCustomDevVars(stripGeneratedSecretsCache(readFileSync11(path, "utf-8")));
       if (!section) return {};
       try {
@@ -3017,6 +3127,10 @@ var deploy_default = defineCommand8({
     }
     const junk = removeMacosJunk(appDir);
     if (junk > 0) p4.log.info(`Removed ${junk} macOS metadata file(s) (._*, .DS_Store)`);
+    const lintFindings = await lintProjectSchemas(appDir);
+    if (lintFindings && lintFindings.length > 0) {
+      p4.log.warn(formatSchemaLintFindings(lintFindings).join("\n"));
+    }
     const s = createSpinner();
     s.start("Building...");
     let preparedWranglerConfig;
@@ -3039,14 +3153,14 @@ var deploy_default = defineCommand8({
       preparedWranglerConfig?.cleanup();
     }
     s.stop("Built");
-    const deployConfigPath = join11(appDir, ".wrangler", "deploy", "config.json");
-    if (!existsSync10(deployConfigPath)) {
+    const deployConfigPath = join12(appDir, ".wrangler", "deploy", "config.json");
+    if (!existsSync11(deployConfigPath)) {
       p4.cancel("Build output config not found at .wrangler/deploy/config.json");
       process.exit(1);
     }
     const deployConfig = JSON.parse(readFileSync11(deployConfigPath, "utf-8"));
     const outputWranglerPath = resolve7(dirname2(deployConfigPath), deployConfig.configPath);
-    if (!existsSync10(outputWranglerPath)) {
+    if (!existsSync11(outputWranglerPath)) {
       p4.cancel(`Output wrangler.json not found at ${outputWranglerPath}`);
       process.exit(1);
     }
@@ -3059,13 +3173,13 @@ var deploy_default = defineCommand8({
       process.exit(1);
     }
     const workerDir = dirname2(outputWranglerPath);
-    const workerBundlePath = join11(workerDir, outputConfig.main);
+    const workerBundlePath = join12(workerDir, outputConfig.main);
     const clientDir = outputConfig.assets?.directory ? resolve7(workerDir, outputConfig.assets.directory) : null;
-    if (!existsSync10(workerBundlePath)) {
+    if (!existsSync11(workerBundlePath)) {
       p4.cancel(`Worker bundle not found at ${workerBundlePath}`);
       process.exit(1);
     }
-    if (!clientDir || !existsSync10(clientDir)) {
+    if (!clientDir || !existsSync11(clientDir)) {
       p4.cancel(`Client assets not found at ${clientDir}`);
       process.exit(1);
     }
@@ -3300,13 +3414,13 @@ then redeploy. (Pass --allow-missing-secrets to deploy without them.)`
   }
 });
 async function syncSubscriptionPlans(appDir, appName, token) {
-  const subsPath = join11(appDir, "src", "subscriptions.ts");
-  if (!existsSync10(subsPath)) return;
+  const subsPath = join12(appDir, "src", "subscriptions.ts");
+  if (!existsSync11(subsPath)) return;
   let plans;
   try {
     const esbuild = await import("esbuild");
-    const outDir = join11(appDir, ".wrangler", "deploy");
-    const outFile = join11(outDir, "subscriptions.bundle.mjs");
+    const outDir = join12(appDir, ".wrangler", "deploy");
+    const outFile = join12(outDir, "subscriptions.bundle.mjs");
     await esbuild.build({
       entryPoints: [subsPath],
       bundle: true,
@@ -3317,7 +3431,7 @@ async function syncSubscriptionPlans(appDir, appName, token) {
       logLevel: "silent",
       write: true
     });
-    const mod = await import(`${pathToFileURL(outFile).href}?t=${Date.now()}`);
+    const mod = await import(`${pathToFileURL2(outFile).href}?t=${Date.now()}`);
     plans = mod.subscriptionPlans;
   } catch (err) {
     p4.log.warn(`Could not load src/subscriptions.ts: ${errMessage(err)}`);
@@ -3448,13 +3562,13 @@ current billing period? (Skip to leave them grandfathered.)`
   }
 }
 async function syncOneTimeProducts(appDir, appName, token) {
-  const productsPath = join11(appDir, "src", "products.ts");
-  if (!existsSync10(productsPath)) return;
+  const productsPath = join12(appDir, "src", "products.ts");
+  if (!existsSync11(productsPath)) return;
   let products;
   try {
     const esbuild = await import("esbuild");
-    const outDir = join11(appDir, ".wrangler", "deploy");
-    const outFile = join11(outDir, "products.bundle.mjs");
+    const outDir = join12(appDir, ".wrangler", "deploy");
+    const outFile = join12(outDir, "products.bundle.mjs");
     await esbuild.build({
       entryPoints: [productsPath],
       bundle: true,
@@ -3465,7 +3579,7 @@ async function syncOneTimeProducts(appDir, appName, token) {
       logLevel: "silent",
       write: true
     });
-    const mod = await import(`${pathToFileURL(outFile).href}?t=${Date.now()}`);
+    const mod = await import(`${pathToFileURL2(outFile).href}?t=${Date.now()}`);
     products = mod.oneTimeProducts;
   } catch (err) {
     p4.log.warn(`Could not load src/products.ts: ${errMessage(err)}`);
@@ -3529,7 +3643,7 @@ function collectAssets(dir) {
   function walk(d, prefix) {
     for (const entry of readdirSync4(d, { withFileTypes: true })) {
       if (entry.name === ".assetsignore") continue;
-      const full = join11(d, entry.name);
+      const full = join12(d, entry.name);
       const rel = prefix ? `${prefix}/${entry.name}` : entry.name;
       if (entry.isDirectory()) {
         walk(full, rel);
@@ -3710,26 +3824,26 @@ var apps_default = defineCommand11({
 
 // src/cli/commands/add.ts
 import { defineCommand as defineCommand12 } from "citty";
-import { existsSync as existsSync11, readFileSync as readFileSync12 } from "fs";
-import { resolve as resolve8, join as join12, dirname as dirname3 } from "path";
+import { existsSync as existsSync12, readFileSync as readFileSync12 } from "fs";
+import { resolve as resolve8, join as join13, dirname as dirname3 } from "path";
 import { fileURLToPath } from "url";
 import { spawnSync as spawnSync5 } from "child_process";
 function findScript(from) {
-  const inNodeModules = join12(from, "node_modules", "deepspace", "scripts", "add-feature.cjs");
-  if (existsSync11(inNodeModules)) return inNodeModules;
-  const inDotDeepspace = join12(from, ".deepspace", "scripts", "add-feature.cjs");
-  if (existsSync11(inDotDeepspace)) return inDotDeepspace;
+  const inNodeModules = join13(from, "node_modules", "deepspace", "scripts", "add-feature.cjs");
+  if (existsSync12(inNodeModules)) return inNodeModules;
+  const inDotDeepspace = join13(from, ".deepspace", "scripts", "add-feature.cjs");
+  if (existsSync12(inDotDeepspace)) return inDotDeepspace;
   return null;
 }
 function runningScript() {
   const here = dirname3(fileURLToPath(import.meta.url));
-  const script = join12(here, "..", "scripts", "add-feature.cjs");
-  return existsSync11(script) ? script : null;
+  const script = join13(here, "..", "scripts", "add-feature.cjs");
+  return existsSync12(script) ? script : null;
 }
 function isDeepSpaceApp(dir) {
-  if (existsSync11(join12(dir, "wrangler.toml"))) return true;
-  const pkgPath = join12(dir, "package.json");
-  if (!existsSync11(pkgPath)) return false;
+  if (existsSync12(join13(dir, "wrangler.toml"))) return true;
+  const pkgPath = join13(dir, "package.json");
+  if (!existsSync12(pkgPath)) return false;
   try {
     const pkg2 = JSON.parse(readFileSync12(pkgPath, "utf-8"));
     return Boolean(pkg2.dependencies?.deepspace || pkg2.devDependencies?.deepspace);
@@ -3790,7 +3904,7 @@ var add_default = defineCommand12({
       const passArgs2 = args.list ? ["--list"] : args.info ? ["--info", String(args.info)] : ["--help"];
       runInstaller(script2, passArgs2, process.cwd());
     }
-    if (!existsSync11(appDir)) {
+    if (!existsSync12(appDir)) {
       console.error(`Target directory not found: ${appDir}`);
       console.error("Create a new app first: deepspace create <name>");
       process.exit(1);
@@ -3806,8 +3920,8 @@ var add_default = defineCommand12({
     if (!script) {
       console.error("Could not find the deepspace feature installer.");
       console.error("Looked in:");
-      console.error(`  ${join12(appDir, "node_modules", "deepspace", "scripts", "add-feature.cjs")}`);
-      console.error(`  ${join12(appDir, ".deepspace", "scripts", "add-feature.cjs")}`);
+      console.error(`  ${join13(appDir, "node_modules", "deepspace", "scripts", "add-feature.cjs")}`);
+      console.error(`  ${join13(appDir, ".deepspace", "scripts", "add-feature.cjs")}`);
       console.error("Are you in a DeepSpace app directory? Try `npm install` first.");
       process.exit(1);
     }
@@ -4833,8 +4947,8 @@ var invoke_default = defineCommand17({
 
 // src/cli/commands/library.ts
 import { defineCommand as defineCommand18 } from "citty";
-import { existsSync as existsSync12, readFileSync as readFileSync14 } from "fs";
-import { join as join13, resolve as resolve9 } from "path";
+import { existsSync as existsSync13, readFileSync as readFileSync14 } from "fs";
+import { join as join14, resolve as resolve9 } from "path";
 import { parse as parseToml4 } from "smol-toml";
 import * as p8 from "@clack/prompts";
 var DEFAULT_LIBRARY_APP = "deepdotspace-site";
@@ -4912,8 +5026,8 @@ var publish = defineCommand18({
     let appName = typeof args.app === "string" && args.app.trim() ? args.app.trim() : void 0;
     if (!appName) {
       const appDir = resolve9(typeof args.dir === "string" && args.dir ? args.dir : ".");
-      const wranglerPath = join13(appDir, "wrangler.toml");
-      if (!existsSync12(wranglerPath)) {
+      const wranglerPath = join14(appDir, "wrangler.toml");
+      if (!existsSync13(wranglerPath)) {
         return die("No --app provided and no wrangler.toml found. Either pass --app <name> or run from your app's directory.");
       }
       const cfg = parseToml4(readFileSync14(wranglerPath, "utf-8"));
@@ -5050,8 +5164,8 @@ var library_default = defineCommand18({
 // src/cli/commands/feedback.ts
 import { defineCommand as defineCommand19 } from "citty";
 import * as p9 from "@clack/prompts";
-import { existsSync as existsSync13, readFileSync as readFileSync15 } from "fs";
-import { dirname as dirname4, join as join14 } from "path";
+import { existsSync as existsSync14, readFileSync as readFileSync15 } from "fs";
+import { dirname as dirname4, join as join15 } from "path";
 import { fileURLToPath as fileURLToPath2 } from "url";
 import { release } from "os";
 var API_URL7 = process.env.DEEPSPACE_API_URL ?? PLATFORM_URLS.api;
@@ -5074,11 +5188,11 @@ function readCliVersion() {
   try {
     const here = dirname4(fileURLToPath2(import.meta.url));
     const candidates = [
-      join14(here, "..", "package.json"),
-      join14(here, "..", "..", "..", "package.json")
+      join15(here, "..", "package.json"),
+      join15(here, "..", "..", "..", "package.json")
     ];
     for (const path of candidates) {
-      if (!existsSync13(path)) continue;
+      if (!existsSync14(path)) continue;
       const pkg2 = JSON.parse(readFileSync15(path, "utf-8"));
       if (pkg2.name === "deepspace" && pkg2.version) return pkg2.version;
     }
@@ -5696,8 +5810,8 @@ var init_default = defineCommand21({
 
 // src/cli/cli.ts
 var __dirname = dirname5(fileURLToPath3(import.meta.url));
-var pkg = JSON.parse(readFileSync17(join15(__dirname, "..", "package.json"), "utf-8"));
-if (process.platform === "linux" && !process.env.SSL_CERT_FILE && existsSync14("/etc/ssl/certs/ca-certificates.crt")) {
+var pkg = JSON.parse(readFileSync17(join16(__dirname, "..", "package.json"), "utf-8"));
+if (process.platform === "linux" && !process.env.SSL_CERT_FILE && existsSync15("/etc/ssl/certs/ca-certificates.crt")) {
   process.env.SSL_CERT_FILE = "/etc/ssl/certs/ca-certificates.crt";
 }
 var create2 = defineCommand22({