deepspace 0.22.0 → 0.23.0

package/dist/worker.js

@@ -379,6 +379,7 @@ var MSG_YJS_AWARENESS = 23;
 var ROLE_ANONYMOUS = "viewer";
 var ROLE_DEFAULT = "member";
 var ROLE_ADMIN = "admin";
+var RECORD_NOT_FOUND = "Record not found";
 
 // src/server/schemas/registry.ts
 function collectionTableName(name) {
@@ -581,13 +582,11 @@ function checkUnclaimedOwnerTransition(schema, role, nextData, userId) {
   }
   return `Role '${role}' can set '${schema.ownerField}' only to their own user id or leave it unclaimed`;
 }
+var SYSTEM_ASSIGNED_COLUMNS = /* @__PURE__ */ new Set(["email", "name", "imageUrl", "role"]);
+var SYSTEM_MAINTAINED_COLUMNS = /* @__PURE__ */ new Set(["createdAt", "lastSeenAt"]);
 var SYSTEM_MANAGED_COLUMNS = /* @__PURE__ */ new Set([
-  "email",
-  "name",
-  "imageUrl",
-  "role",
-  "createdAt",
-  "lastSeenAt"
+  ...SYSTEM_ASSIGNED_COLUMNS,
+  ...SYSTEM_MAINTAINED_COLUMNS
 ]);
 var USERS_COLUMNS = [
   { name: "email", storage: "text", interpretation: "plain" },
@@ -1180,6 +1179,11 @@ function encode(message) {
 function getResolvedColumns(schema) {
   return (schema.columns ?? []).map(resolveColumn);
 }
+function systemManagedColumnError(column, isUpdate) {
+  const roleHint = column === "role" ? ", or the admin-gated useUsers().setRole() to change a role" : "";
+  const remedy = isUpdate ? `Re-sending the current value of '${column}' unchanged is accepted and ignored.` : `A users row is created by registration, so no value for '${column}' is accepted here \u2014 omit it.`;
+  return `FIELD ERROR: '${column}' is system-managed and cannot be set by a record write \u2014 nothing was written. Use tools.registerUser({ userId, isAdmin })${roleHint}. ${remedy}`;
+}
 function notifyTeamMembershipChange(ctx, collection, record) {
   if (collection !== "team_members") return;
   const affectedUserId = record.data.UserId;
@@ -1250,11 +1254,9 @@ function handleDelete(ctx, ws, attachment, payload) {
   }
 }
 function putRecord(ctx, collection, recordId, data, userId, userRole, skipUserRbac = false, systemUpdate = false) {
-  const isSystem = SYSTEM_COLLECTIONS.has(collection);
-  const schema = ctx.schemaRegistry.get(collection);
-  if (!schema && !isSystem) {
-    return { success: false, error: `Schema not registered for collection: ${collection}` };
-  }
+  const resolved = resolveCollection(ctx, collection);
+  if (!resolved.ok) return { success: false, error: resolved.error };
+  const schema = resolved.schema;
   if (!schema) {
     return { success: false, error: `Schema not registered for collection: ${collection}` };
   }
@@ -1309,17 +1311,7 @@ function putRecord(ctx, collection, recordId, data, userId, userRole, skipUserRb
       }
     }
   }
-  let finalData = mergedData;
-  if (!systemUpdate && schema.name === "users") {
-    finalData = { ...mergedData };
-    for (const key of SYSTEM_MANAGED_COLUMNS) {
-      if (existing?.data[key] !== void 0) {
-        finalData[key] = existing.data[key];
-      } else {
-        delete finalData[key];
-      }
-    }
-  }
+  const finalData = { ...mergedData };
   if (!skipUserRbac) {
     const permCtx = ctx.getPermissionContext();
     if (isUpdate) {
@@ -1351,6 +1343,17 @@ function putRecord(ctx, collection, recordId, data, userId, userRole, skipUserRb
       return { success: false, error: `FIELD ERROR: ${ownerError}` };
     }
   }
+  if (!systemUpdate && schema.name === "users") {
+    for (const col of columns) {
+      if (!SYSTEM_MANAGED_COLUMNS.has(col.name)) continue;
+      const current = existing?.data[col.name];
+      if (SYSTEM_ASSIGNED_COLUMNS.has(col.name) && Object.hasOwn(data, col.name) && coerceValue(data[col.name], col.storage, col.interpretation) !== coerceValue(current, col.storage, col.interpretation)) {
+        return { success: false, error: systemManagedColumnError(col.name, isUpdate) };
+      }
+      if (current !== void 0) finalData[col.name] = current;
+      else delete finalData[col.name];
+    }
+  }
   const colValues = dataToColumnValues(finalData, columns);
   const now = (/* @__PURE__ */ new Date()).toISOString();
   const tbl = collectionTableName(collection);
@@ -1410,14 +1413,12 @@ function putRecord(ctx, collection, recordId, data, userId, userRole, skipUserRb
   return { success: true, data: { recordId, record } };
 }
 function deleteRecord(ctx, collection, recordId, userId, userRole, skipUserRbac = false) {
-  const isSystem = SYSTEM_COLLECTIONS.has(collection);
-  const schema = ctx.schemaRegistry.get(collection);
-  if (!schema && !isSystem) {
-    return { success: false, error: `Schema not registered for collection: ${collection}` };
-  }
+  const resolved = resolveCollection(ctx, collection);
+  if (!resolved.ok) return { success: false, error: resolved.error };
+  const schema = resolved.schema;
   const existing = getRecord(ctx.sql, collection, recordId, schema);
   if (!existing) {
-    return { success: false, error: "Record not found" };
+    return { success: false, error: RECORD_NOT_FOUND };
   }
   if (!skipUserRbac && schema && !canDelete(schema, userRole, { ...existing, recordId }, userId, ctx.getPermissionContext())) {
     return { success: false, error: `DELETE DENIED: role=${userRole}, collection=${collection}` };
@@ -1436,14 +1437,12 @@ function deleteRecord(ctx, collection, recordId, userId, userRole, skipUserRbac
   return { success: true, data: { deleted: true } };
 }
 function readRecord(ctx, collection, recordId, userId, userRole, skipUserRbac = false) {
-  const isSystem = SYSTEM_COLLECTIONS.has(collection);
-  const schema = ctx.schemaRegistry.get(collection);
-  if (!schema && !isSystem) {
-    return { success: false, error: `Schema not registered for collection: ${collection}` };
-  }
+  const resolved = resolveCollection(ctx, collection);
+  if (!resolved.ok) return { success: false, error: resolved.error };
+  const schema = resolved.schema;
   const existing = getRecord(ctx.sql, collection, recordId, schema);
   if (!existing) {
-    return { success: false, error: "Record not found" };
+    return { success: false, error: RECORD_NOT_FOUND };
   }
   if (!skipUserRbac && schema && !canRead(schema, userRole, { ...existing, recordId }, userId, ctx.getPermissionContext())) {
     return { success: false, error: `READ DENIED: role=${userRole}, collection=${collection}` };
@@ -1474,9 +1473,7 @@ function hasYjsSubscription(attachment, target) {
     (subscription) => subscription.collection === target.collection && subscription.recordId === target.recordId && subscription.fieldName === target.fieldName
   );
 }
-var SYSTEM_COLLECTIONS = /* @__PURE__ */ new Set([
-  "canvas-settings"
-]);
+var SYSTEM_COLLECTIONS = /* @__PURE__ */ new Set(["canvas-settings"]);
 var SYSTEM_COLLECTION_SCHEMAS = [
   {
     name: "canvas-settings",
@@ -1493,10 +1490,7 @@ function getOrCreateYjsDoc(ctx, docKey) {
   let doc = ctx.yjsDocs.get(docKey);
   if (doc) return doc;
   doc = new Y2.Doc();
-  const row = ctx.sql.exec(
-    `SELECT state FROM yjs_docs WHERE doc_key = ?`,
-    docKey
-  ).toArray()[0];
+  const row = ctx.sql.exec(`SELECT state FROM yjs_docs WHERE doc_key = ?`, docKey).toArray()[0];
   if (row?.state) {
     try {
       Y2.applyUpdate(doc, new Uint8Array(row.state));
@@ -1561,11 +1555,17 @@ function handleYjsJoin(ctx, ws, attachment, payload) {
     }
   } else {
     if (!schema) {
-      ctx.send(ws, { type: MSG.ERROR, payload: { error: `Schema not registered for collection: ${collection}` } });
+      const resolution = resolveCollection(ctx, collection);
+      ctx.send(ws, {
+        type: MSG.ERROR,
+        payload: {
+          error: resolution.ok ? `Schema not registered for collection: ${collection}` : resolution.error
+        }
+      });
       return;
     }
     if (!record) {
-      ctx.send(ws, { type: MSG.ERROR, payload: { error: "Record not found" } });
+      ctx.send(ws, { type: MSG.ERROR, payload: { error: RECORD_NOT_FOUND } });
       return;
     }
     const permCtx = ctx.getPermissionContext();
@@ -1598,7 +1598,10 @@ function handleYjsJoin(ctx, ws, attachment, payload) {
     writeVarUint8Array(encoder2, fullState);
     ctx.sendBinary(ws, toUint8Array(encoder2));
   }
-  ctx.send(ws, { type: MSG.YJS_JOIN, payload: { collection, recordId, fieldName, canWrite: hasWriteAccess } });
+  ctx.send(ws, {
+    type: MSG.YJS_JOIN,
+    payload: { collection, recordId, fieldName, canWrite: hasWriteAccess }
+  });
 }
 function handleYjsLeave(ctx, ws, attachment, payload) {
   const { collection, recordId, fieldName } = payload;
@@ -1667,7 +1670,14 @@ function handleYjsBinaryMessage(ctx, ws, attachment, data) {
         if (!syncSchema) return;
         const record = getRecord(ctx.sql, collection, recordId, syncSchema);
         if (!record) return;
-        if (!canUpdate(syncSchema, attachment.role, { ...record, recordId }, attachment.userId, ctx.getPermissionContext())) return;
+        if (!canUpdate(
+          syncSchema,
+          attachment.role,
+          { ...record, recordId },
+          attachment.userId,
+          ctx.getPermissionContext()
+        ))
+          return;
       }
       const update = readVarUint8Array(decoder);
       Y2.applyUpdate(doc, update, "client");
@@ -1741,6 +1751,19 @@ function handleYjsDisconnect(ctx, ws, attachment) {
 }
 
 // src/server/handlers/subscriptions.ts
+function resolveCollection(ctx, collection) {
+  const isSystem = SYSTEM_COLLECTIONS.has(collection);
+  const schema = ctx.schemaRegistry.get(collection);
+  if (!schema && !isSystem) {
+    const known = ctx.schemaRegistry.names().sort().join(", ") || "(none)";
+    const room = ctx.scopeId ? `Room '${ctx.scopeId}'` : "This room";
+    return {
+      ok: false,
+      error: `Schema not registered for collection: ${collection} \u2014 ${room} serves only: ${known}. Records are sharded by scope, so address the room that owns '${collection}', or add it to the schemas this room is constructed with.`
+    };
+  }
+  return { ok: true, schema, isSystem };
+}
 function handleSubscribe(ctx, ws, attachment, payload) {
   const { subscriptionId, query } = payload;
   const records = executeQuery(ctx, query, attachment.userId, attachment.role);
@@ -1749,15 +1772,20 @@ function handleSubscribe(ctx, ws, attachment, payload) {
 function handleUnsubscribe(_ctx, _ws, _attachment, _payload) {
 }
 function executeQuery(ctx, query, userId, userRole, skipUserRbac = false) {
-  const isSystem = SYSTEM_COLLECTIONS.has(query.collection);
-  const schema = ctx.schemaRegistry.get(query.collection);
-  if (!schema && !isSystem) {
-    return [];
-  }
-  if (!schema) {
+  const resolved = resolveCollection(ctx, query.collection);
+  if (!resolved.ok) return [];
+  if (!resolved.schema) {
     return executeSystemQuery(ctx, query);
   }
-  return executeTableQuery(ctx, query, schema, userId, userRole, isSystem, skipUserRbac);
+  return executeTableQuery(
+    ctx,
+    query,
+    resolved.schema,
+    userId,
+    userRole,
+    resolved.isSystem,
+    skipUserRbac
+  );
 }
 function executeSystemQuery(ctx, query) {
   const tbl = collectionTableName(query.collection);
@@ -2258,7 +2286,10 @@ async function handleToolsRequest(ctx, request, path) {
     const toolName = path.replace("tools/describe/", "");
     const tool3 = BUILT_IN_TOOLS.find((t) => t.name === toolName);
     if (!tool3) {
-      return Response.json({ error: `Tool not found: ${toolName}` }, { status: 404, headers: CORS_HEADERS });
+      return Response.json(
+        { error: `Tool not found: ${toolName}` },
+        { status: 404, headers: CORS_HEADERS }
+      );
     }
     return Response.json({ tool: tool3 }, { headers: CORS_HEADERS });
   }
@@ -2303,6 +2334,7 @@ async function handleToolExecute(ctx, request) {
   const recordCtx = {
     sql: ctx.sql,
     schemaRegistry: ctx.schemaRegistry,
+    scopeId: ctx.scopeId,
     state: ctx.state,
     getPermissionContext: ctx.getPermissionContext,
     send: ctx.send
@@ -2317,6 +2349,8 @@ async function executeTool(ctx, toolName, params, userId, userRole, skipUserRbac
     case "records.query": {
       const collection = params.collection;
       if (!collection) return { success: false, error: "Missing required param: collection" };
+      const resolved = resolveCollection(ctx, collection);
+      if (!resolved.ok) return { success: false, error: resolved.error };
       const query = {
         collection,
         where: params.where,
@@ -2426,10 +2460,13 @@ async function executeTool(ctx, toolName, params, userId, userRole, skipUserRbac
 }
 function checkYjsPermission(ctx, collection, recordId, userId, userRole, action) {
   if (SYSTEM_COLLECTIONS.has(collection)) return null;
-  const schema = ctx.schemaRegistry.get(collection);
-  if (!schema) return { success: false, error: `Schema not registered for collection: ${collection}` };
+  const resolution = resolveCollection(ctx, collection);
+  if (!resolution.ok) return { success: false, error: resolution.error };
+  const schema = resolution.schema;
+  if (!schema)
+    return { success: false, error: `Schema not registered for collection: ${collection}` };
   const record = getRecord(ctx.sql, collection, recordId, schema);
-  if (!record) return { success: false, error: `Record not found: ${collection}/${recordId}` };
+  if (!record) return { success: false, error: `${RECORD_NOT_FOUND}: ${collection}/${recordId}` };
   const recordWithId = { ...record, recordId };
   const permCtx = ctx.getPermissionContext();
   if (action === "read" && !canRead(schema, userRole, recordWithId, userId, permCtx)) {
@@ -2462,9 +2499,7 @@ function withYjsDoc(ctx, docKey, operation) {
 function executeYjsTool(ctx, toolName, params, userId, userRole) {
   switch (toolName) {
     case "yjs.list": {
-      const rows = ctx.sql.exec(
-        `SELECT doc_key, updated_at FROM yjs_docs ORDER BY updated_at DESC`
-      ).toArray();
+      const rows = ctx.sql.exec(`SELECT doc_key, updated_at FROM yjs_docs ORDER BY updated_at DESC`).toArray();
       const docs = rows.map((row) => {
         const firstColon = row.doc_key.indexOf(":");
         const lastColon = row.doc_key.lastIndexOf(":");
@@ -3087,6 +3122,10 @@ var RecordRoom = class extends BaseRoom {
       sql: this.sql,
       state: this.state,
       schemaRegistry: this.schemaRegistry,
+      // Every record room stub is addressed with `idFromName(scopeId)`, so the
+      // DO's own name is the scope. Handlers use it to name the room when a
+      // caller asks it for a collection that lives in a different scope.
+      scopeId: this.state.id.name,
       getPermissionContext: () => this.getPermissionContext(),
       send: (ws, msg) => this.send(ws, msg),
       sendBinary: (ws, data) => this.sendBinaryHelper(ws, data),
@@ -7542,7 +7581,7 @@ function authWorkerFetch(env, path, init) {
 function buildCronContext(env, ownerUserId, roomId = "default") {
   const roomIdObj = env.RECORD_ROOMS.idFromName(roomId);
   const room = env.RECORD_ROOMS.get(roomIdObj);
-  async function executeTool3(tool3, params) {
+  async function executeTool2(tool3, params) {
     const response = await room.fetch(
       new Request("https://internal/api/tools/execute", {
         method: "POST",
@@ -7565,18 +7604,18 @@ function buildCronContext(env, ownerUserId, roomId = "default") {
       const params = { collection };
       if (opts?.where) params.where = opts.where;
       if (opts?.limit) params.limit = opts.limit;
-      const data = await executeTool3("records.query", params);
+      const data = await executeTool2("records.query", params);
       const records2 = data?.records;
       return records2 ?? [];
     },
     async create(collection, data) {
-      return executeTool3("records.create", { collection, data });
+      return executeTool2("records.create", { collection, data });
     },
     async update(collection, recordId, data) {
-      return executeTool3("records.update", { collection, recordId, data });
+      return executeTool2("records.update", { collection, recordId, data });
     },
     async delete(collection, recordId) {
-      return executeTool3("records.delete", { collection, recordId });
+      return executeTool2("records.delete", { collection, recordId });
     }
   };
   const integrations = {
@@ -8312,7 +8351,7 @@ function makeDefaultSummarizer(env, options = {}) {
 }
 
 // src/server/utils/chat-history.ts
-async function executeTool2(stub, userId, tool3, params) {
+async function executeToolAsApp(stub, userId, tool3, params) {
   const res = await stub.fetch(new Request("https://internal/api/tools/execute", {
     method: "POST",
     headers: {
@@ -8353,13 +8392,15 @@ function toMessageRow(env) {
 }
 async function getChat(stub, chatId, userId) {
   try {
-    const result = await executeTool2(stub, userId, "records.get", {
+    const result = await executeToolAsApp(stub, userId, "records.get", {
       collection: "ai-chats",
       recordId: chatId
     });
-    return result.record ? toChatRow(result.record) : null;
+    if (!result.record) return null;
+    const chat = toChatRow(result.record);
+    return chat.userId === userId ? chat : null;
   } catch (err) {
-    if (err instanceof Error && err.message.includes("Record not found")) return null;
+    if (err instanceof Error && err.message.includes(RECORD_NOT_FOUND)) return null;
     throw err;
   }
 }
@@ -8367,28 +8408,28 @@ async function createChat(stub, userId, opts = {}) {
   const data = { userId };
   if (opts.title !== void 0) data.title = opts.title;
   if (opts.model !== void 0) data.model = opts.model;
-  const result = await executeTool2(stub, userId, "records.create", {
+  const result = await executeToolAsApp(stub, userId, "records.create", {
     collection: "ai-chats",
     data
   });
   return toChatRow(result.record);
 }
 async function updateChat(stub, chatId, userId, patch) {
-  await executeTool2(stub, userId, "records.update", {
+  await executeToolAsApp(stub, userId, "records.update", {
     collection: "ai-chats",
     recordId: chatId,
     data: patch
   });
 }
 async function deleteChatCascade(stub, chatId, userId) {
-  const list = await executeTool2(stub, userId, "records.query", {
+  const list = await executeToolAsApp(stub, userId, "records.query", {
     collection: "ai-messages",
     where: { chatId }
   });
   const errors = [];
   for (const env of list.records) {
     try {
-      await executeTool2(stub, userId, "records.delete", {
+      await executeToolAsApp(stub, userId, "records.delete", {
         collection: "ai-messages",
         recordId: env.recordId
       });
@@ -8397,7 +8438,7 @@ async function deleteChatCascade(stub, chatId, userId) {
     }
   }
   try {
-    await executeTool2(stub, userId, "records.delete", {
+    await executeToolAsApp(stub, userId, "records.delete", {
       collection: "ai-chats",
       recordId: chatId
     });
@@ -8413,7 +8454,7 @@ async function deleteChatCascade(stub, chatId, userId) {
   }
 }
 async function loadMessages(stub, chatId, userId) {
-  const result = await executeTool2(stub, userId, "records.query", {
+  const result = await executeToolAsApp(stub, userId, "records.query", {
     collection: "ai-messages",
     where: { chatId, userId },
     orderBy: "createdAt",
@@ -8429,7 +8470,7 @@ async function appendMessage(stub, msg) {
     content: msg.content
   };
   if (msg.parts !== void 0) data.parts = msg.parts;
-  await executeTool2(stub, msg.userId, "records.create", {
+  await executeToolAsApp(stub, msg.userId, "records.create", {
     collection: "ai-messages",
     recordId: msg.id,
     data
@@ -10185,6 +10226,7 @@ export {
   PresenceRoom,
   REACTIONS_SCHEMA,
   READ_RECEIPTS_SCHEMA,
+  RECORD_NOT_FOUND,
   REGISTRY_INSTANCE,
   RELEASE_STAMP_PATH,
   REPO_STORE_LIMIT_BYTES,
@@ -10201,7 +10243,9 @@ export {
   SDK_RUN_WORKER_FIRST,
   SECURE_ROOM_BOUNDARIES_MIGRATION_ID,
   STRICT_APP_ID_RE,
+  SYSTEM_ASSIGNED_COLUMNS,
   SYSTEM_COLLECTIONS,
+  SYSTEM_MAINTAINED_COLUMNS,
   SYSTEM_MANAGED_COLUMNS,
   SchemaRegistry,
   TEST_ACCOUNT_EMAIL_SUFFIX,