deepline 0.3.7 → 0.3.8

package/dist/bundling-sources/shared_libs/plays/secret-guardrails.ts

@@ -5,6 +5,139 @@ const PRIVATE_KEY_PATTERN =
 const BEARER_LITERAL_PATTERN = /\bBearer\s+[A-Za-z0-9._~+/=-]{16,}/i;
 const ASSIGNMENT_SECRET_LITERAL_PATTERN =
   /\b(?:api[_-]?key|token|secret|password)\b\s*[:=]\s*['"][^'"]{12,}['"]/i;
+const SECRET_AUTH_LITERAL_FINDING =
+  'literal credential passed to ctx.secrets auth helper';
+
+function skipQuoted(source: string, start: number): number {
+  const quote = source[start];
+  let index = start + 1;
+  while (index < source.length) {
+    if (source[index] === '\\') {
+      index += 2;
+    } else if (source[index] === quote) {
+      return index + 1;
+    } else {
+      index += 1;
+    }
+  }
+  return source.length;
+}
+
+function skipTrivia(source: string, start: number): number {
+  let index = start;
+  while (index < source.length) {
+    if (/\s/.test(source[index])) {
+      index += 1;
+    } else if (source.startsWith('//', index)) {
+      index = source.indexOf('\n', index + 2);
+      if (index === -1) return source.length;
+    } else if (source.startsWith('/*', index)) {
+      index = source.indexOf('*/', index + 2);
+      if (index === -1) return source.length;
+      index += 2;
+    } else {
+      return index;
+    }
+  }
+  return index;
+}
+
+function consumeIdentifier(
+  source: string,
+  start: number,
+  expected: string,
+): number | undefined {
+  return source.startsWith(expected, start) &&
+    !/[A-Za-z0-9_$]/.test(source[start - 1] ?? '') &&
+    !/[A-Za-z0-9_$]/.test(source[start + expected.length] ?? '')
+    ? start + expected.length
+    : undefined;
+}
+
+function consumeMember(
+  source: string,
+  start: number,
+  expected: string,
+): number | undefined {
+  let index = skipTrivia(source, start);
+  if (source[index] === '.') {
+    return consumeIdentifier(source, skipTrivia(source, index + 1), expected);
+  }
+  if (source[index] !== '[') return undefined;
+  index = skipTrivia(source, index + 1);
+  if (source[index] !== "'" && source[index] !== '"') return undefined;
+  const end = skipQuoted(source, index);
+  if (source.slice(index + 1, end - 1) !== expected) return undefined;
+  index = skipTrivia(source, end);
+  return source[index] === ']' ? index + 1 : undefined;
+}
+
+function skipExpression(source: string, start: number): number {
+  let index = start;
+  let depth = 0;
+  while (index < source.length) {
+    const char = source[index];
+    if (char === "'" || char === '"' || char === '`') {
+      index = skipQuoted(source, index);
+      continue;
+    }
+    if (source.startsWith('//', index) || source.startsWith('/*', index)) {
+      index = skipTrivia(source, index);
+      continue;
+    }
+    if (char === '(' || char === '[' || char === '{') {
+      depth += 1;
+    } else if (char === ')' || char === ']' || char === '}') {
+      if (depth === 0) return index;
+      depth -= 1;
+    } else if (char === ',' && depth === 0) {
+      return index;
+    }
+    index += 1;
+  }
+  return index;
+}
+
+function isDirectStringLiteral(source: string, start: number): boolean {
+  const quote = source[start];
+  if (quote !== "'" && quote !== '"' && quote !== '`') return false;
+  const end = skipQuoted(source, start);
+  return quote !== '`' || !source.slice(start, end).includes('${');
+}
+
+function hasLiteralSecretAuthCredential(source: string): boolean {
+  for (let index = 0; index < source.length; index += 1) {
+    const char = source[index];
+    if (char === "'" || char === '"' || char === '`') {
+      index = skipQuoted(source, index) - 1;
+      continue;
+    }
+    if (source.startsWith('//', index) || source.startsWith('/*', index)) {
+      index = skipTrivia(source, index) - 1;
+      continue;
+    }
+
+    const afterCtx = consumeIdentifier(source, index, 'ctx');
+    if (!afterCtx) continue;
+    const afterSecrets = consumeMember(source, afterCtx, 'secrets');
+    if (!afterSecrets) continue;
+    const afterHeader = consumeMember(source, afterSecrets, 'header');
+    const helper = afterHeader ? 'header' : 'bearer';
+    const afterHelper =
+      afterHeader ?? consumeMember(source, afterSecrets, 'bearer');
+    if (!afterHelper) continue;
+    const afterOpen = skipTrivia(source, afterHelper);
+    if (source[afterOpen] !== '(') continue;
+
+    const firstArgument = skipTrivia(source, afterOpen + 1);
+    const credential =
+      helper === 'header'
+        ? skipTrivia(source, skipExpression(source, firstArgument) + 1)
+        : firstArgument;
+    if (isDirectStringLiteral(source, credential)) return true;
+  }
+  return false;
+}
 /**
  * Returns the inline-secret findings in a string (empty if none). The throwing
  * validator below and the workflows→plays migration validator both call this so
@@ -22,6 +155,9 @@ export function collectInlineSecretFindings(sourceCode: string): string[] {
   if (ASSIGNMENT_SECRET_LITERAL_PATTERN.test(sourceCode)) {
     findings.push('secret-looking assignment literal');
   }
+  if (hasLiteralSecretAuthCredential(sourceCode)) {
+    findings.push(SECRET_AUTH_LITERAL_FINDING);
+  }
   return [...new Set(findings)];
 }
 
@@ -36,7 +172,7 @@ export function validatePlaySourceHasNoInlineSecrets(input: {
       `Play source ${input.filePath} appears to contain inline secret material: ${[
         ...new Set(findings),
       ].join(', ')}.`,
-      'Author secrets in the dashboard and use ctx.secrets.get("NAME") with an approved helper such as ctx.secrets.bearer(handle).',
+      'Author secrets in the dashboard, declare them in the Play\'s top-level secrets option, and read them at runtime with await ctx.secrets.get("NAME").',
     ].join(' '),
   );
 }

package/dist/bundling-sources/shared_libs/security/safe-fetch.ts

@@ -13,6 +13,8 @@ export type SafeFetchOptions = {
   fetchImpl?: SafeFetchImplementation;
   maxRedirects?: number;
   sensitiveHeaders?: Iterable<string>;
+  /** Drop every caller-supplied header when a redirect changes origin. */
+  stripHeadersOnCrossOriginRedirect?: boolean;
 };
 
 function removeHeader(headers: Headers, name: string) {
@@ -29,10 +31,11 @@ function requestInitForRedirect(
   to: URL,
   status: number,
   sensitiveHeaders: Iterable<string>,
+  stripHeadersOnCrossOriginRedirect: boolean,
 ): RequestInit {
-  const headers = new Headers(init.headers);
+  let headers = new Headers(init.headers);
   let method = String(init.method ?? 'GET').toUpperCase();
-  let body = init.body;
+  let body = init.body ?? undefined;
 
   if (
     status === 303 ||
@@ -45,11 +48,23 @@ function requestInitForRedirect(
   }
 
   if (from.origin !== to.origin) {
-    removeHeader(headers, 'authorization');
-    removeHeader(headers, 'cookie');
-    removeHeader(headers, 'proxy-authorization');
-    for (const header of sensitiveHeaders) {
-      removeHeader(headers, header);
+    if (body !== undefined) {
+      throw new Error(
+        'Cross-origin redirect blocked because it would replay a request body.',
+      );
+    }
+    if (stripHeadersOnCrossOriginRedirect) {
+      // Callers that can construct credentials from plaintext secrets cannot
+      // reliably identify every transformed value. Do not forward any caller
+      // header across an origin boundary in that trust model.
+      headers = new Headers();
+    } else {
+      removeHeader(headers, 'authorization');
+      removeHeader(headers, 'cookie');
+      removeHeader(headers, 'proxy-authorization');
+      for (const header of sensitiveHeaders) {
+        removeHeader(headers, header);
+      }
     }
   }
 
@@ -71,6 +86,8 @@ export async function safePublicFetch(
   const maxRedirects = options.maxRedirects ?? 10;
   const fetchImpl = options.fetchImpl ?? fetch;
   const sensitiveHeaders = options.sensitiveHeaders ?? [];
+  const stripHeadersOnCrossOriginRedirect =
+    options.stripHeadersOnCrossOriginRedirect === true;
   let currentUrl = assertPublicHttpUrl(input);
   let currentInit: RequestInit = {
     ...init,
@@ -117,6 +134,7 @@ export async function safePublicFetch(
       nextUrl,
       response.status,
       sensitiveHeaders,
+      stripHeadersOnCrossOriginRedirect,
     );
     currentUrl = nextUrl;
   }

package/dist/cli/index.js

@@ -1047,7 +1047,7 @@ var SDK_RELEASE = {
   // 0.3.0 introduces raw-v2: complete scrubbed provider responses are
   // available at toolResponse.rawV2 while toolResponse.raw and all declared
   // getters keep their established compatibility behavior.
-  version: "0.3.7",
+  version: "0.3.8",
   updateSummary: "New raw-v2 tool responses preserve complete scrubbed provider envelopes at toolResponse.rawV2, including JSON:API included resources, links, cursors, and totals. Existing toolResponse.raw and declared getters keep working unchanged.",
   contracts: {
     api: {
@@ -2020,10 +2020,30 @@ function redactSecretLikeString(value) {
 function createSecretRedactionContext(initialValues = []) {
   const exactSecrets = /* @__PURE__ */ new Set();
   function register(value) {
-    if (value.length >= 4) exactSecrets.add(value);
+    if (value.length > 0) exactSecrets.add(value);
   }
   for (const value of initialValues) register(value);
-  function redactString2(value) {
+  function containsRegisteredSecret(value, {
+    includeEncoded = false,
+    minimumLength = 1
+  } = {}) {
+    for (const secret of exactSecrets) {
+      if (secret.length < minimumLength) continue;
+      if (value.includes(secret)) return true;
+      if (includeEncoded) {
+        try {
+          const encoded = encodeURIComponent(secret);
+          if (encoded !== secret && value.includes(encoded)) return true;
+        } catch {
+        }
+      }
+    }
+    return false;
+  }
+  function matchesRegisteredSecret(value) {
+    return exactSecrets.has(value);
+  }
+  function redactRegisteredSecrets(value) {
     let output2 = value;
     for (const secret of exactSecrets) {
       output2 = output2.replace(
@@ -2041,6 +2061,10 @@ function createSecretRedactionContext(initialValues = []) {
       } catch {
       }
     }
+    return output2;
+  }
+  function redactString2(value) {
+    const output2 = redactRegisteredSecrets(value);
     return redactSecretLikeString(output2);
   }
   function redact(value) {
@@ -2073,6 +2097,9 @@ function createSecretRedactionContext(initialValues = []) {
   }
   return {
     register,
+    containsRegisteredSecret,
+    matchesRegisteredSecret,
+    redactRegisteredSecrets,
     redactString: redactString2,
     redactKnownSecrets,
     redact
@@ -16692,8 +16719,11 @@ var PLAY_AUTHORING_CLOUD_TYPE_DECLARATIONS = [
   `  secrets?: readonly ${cloudReferenceType("bindings.secrets[]")}[];`,
   "};",
   "declare const SECRET_HANDLE_BRAND: unique symbol;",
+  "declare const SECRET_PROMISE_BRAND: unique symbol;",
   "export type SecretHandle = { readonly [SECRET_HANDLE_BRAND]: never; readonly name: string; toString(): string; toJSON(): never };",
-  "export type SecretAuth = { readonly kind: 'bearer' | 'header'; readonly secret: SecretHandle; readonly header?: string };",
+  "export type SecretPromise = Promise<string> & { readonly [SECRET_PROMISE_BRAND]: never };",
+  "export type SecretValue = SecretHandle;",
+  "export type SecretAuth = { readonly kind: 'bearer' | 'header'; readonly secret: string | SecretPromise | SecretHandle; readonly header?: string };",
   "export type SecretAuthInput = SecretAuth | readonly SecretAuth[];",
   "export type PlayInputContract<TInput> = { readonly schema: Record<string, unknown>; readonly __inputType?: TInput };",
   "export type PlayReturnObject = Record<string, unknown> & { readonly _metadata?: never };",
@@ -16744,7 +16774,7 @@ var PLAY_AUTHORING_CLOUD_TYPE_DECLARATIONS = [
   `  tool<K extends string>(key: ${cloudReferenceType("ctx.tool.key")}, toolId: K, input: ${cloudReferenceType("ctx.tool.input")}, options?: { description?: ${cloudReferenceType("ctx.tool.options.description")} }): Promise<ToolExecutionOutput<K>>;`,
   "  step<T>(id: string, run: () => T | Promise<T>, options?: RuntimeStepOptions): Promise<T>;",
   "  fetch(key: string, url: string | URL, init?: RequestInit & { headers?: HeadersInit & { 'Idempotency-Key'?: string; 'X-Idempotency-Key'?: string }; auth?: SecretAuthInput }, options?: FetchOptions): Promise<PlayFetchResponse>;",
-  "  secrets: { get(name: string): SecretHandle; bearer(secret: SecretHandle): SecretAuth; header(header: string, secret: SecretHandle): SecretAuth };",
+  "  secrets: { get(name: string): SecretPromise; bearer(secret: string | SecretPromise | SecretHandle): SecretAuth; header(header: string, secret: string | SecretPromise | SecretHandle): SecretAuth };",
   `  runPlay<TOutput = unknown>(key: string, playRef: ${cloudReferenceType("ctx.runPlay.playRef")}, input: ${cloudReferenceType("ctx.runPlay.input")}, options: PlayCallOptions): Promise<TOutput>;`,
   "  log(message: string): void;",
   `  sleep(ms: ${cloudReferenceType("ctx.sleep.ms")}): Promise<void>;`,
@@ -16885,15 +16915,118 @@ function listPlayFileExports(sourceCode) {
   return exports2;
 }
 
-// ../shared_libs/plays/docflow.ts
-var MERMAID_NODE_ATTRIBUTES = ["label", "type", "in", "out", "arm"];
-var LEGACY_DOCFLOW_ATTRIBUTES = ["id", ...MERMAID_NODE_ATTRIBUTES];
-
 // ../shared_libs/plays/secret-guardrails.ts
 var SECRET_ENV_PATTERN = /\bprocess(?:\.env|\[['"]env['"]\])(?:\.|\[['"])([A-Z0-9_]*(?:API[_-]?KEY|TOKEN|SECRET|PASSWORD|PRIVATE[_-]?KEY|ACCESS[_-]?KEY)[A-Z0-9_]*)(?:['"]\])?/g;
 var PRIVATE_KEY_PATTERN = /-----BEGIN (?:RSA |EC |OPENSSH |PGP )?PRIVATE KEY-----/;
 var BEARER_LITERAL_PATTERN = /\bBearer\s+[A-Za-z0-9._~+/=-]{16,}/i;
 var ASSIGNMENT_SECRET_LITERAL_PATTERN = /\b(?:api[_-]?key|token|secret|password)\b\s*[:=]\s*['"][^'"]{12,}['"]/i;
+var SECRET_AUTH_LITERAL_FINDING = "literal credential passed to ctx.secrets auth helper";
+function skipQuoted(source, start) {
+  const quote = source[start];
+  let index = start + 1;
+  while (index < source.length) {
+    if (source[index] === "\\") {
+      index += 2;
+    } else if (source[index] === quote) {
+      return index + 1;
+    } else {
+      index += 1;
+    }
+  }
+  return source.length;
+}
+function skipTrivia(source, start) {
+  let index = start;
+  while (index < source.length) {
+    if (/\s/.test(source[index])) {
+      index += 1;
+    } else if (source.startsWith("//", index)) {
+      index = source.indexOf("\n", index + 2);
+      if (index === -1) return source.length;
+    } else if (source.startsWith("/*", index)) {
+      index = source.indexOf("*/", index + 2);
+      if (index === -1) return source.length;
+      index += 2;
+    } else {
+      return index;
+    }
+  }
+  return index;
+}
+function consumeIdentifier(source, start, expected) {
+  return source.startsWith(expected, start) && !/[A-Za-z0-9_$]/.test(source[start - 1] ?? "") && !/[A-Za-z0-9_$]/.test(source[start + expected.length] ?? "") ? start + expected.length : void 0;
+}
+function consumeMember(source, start, expected) {
+  let index = skipTrivia(source, start);
+  if (source[index] === ".") {
+    return consumeIdentifier(source, skipTrivia(source, index + 1), expected);
+  }
+  if (source[index] !== "[") return void 0;
+  index = skipTrivia(source, index + 1);
+  if (source[index] !== "'" && source[index] !== '"') return void 0;
+  const end = skipQuoted(source, index);
+  if (source.slice(index + 1, end - 1) !== expected) return void 0;
+  index = skipTrivia(source, end);
+  return source[index] === "]" ? index + 1 : void 0;
+}
+function skipExpression(source, start) {
+  let index = start;
+  let depth = 0;
+  while (index < source.length) {
+    const char = source[index];
+    if (char === "'" || char === '"' || char === "`") {
+      index = skipQuoted(source, index);
+      continue;
+    }
+    if (source.startsWith("//", index) || source.startsWith("/*", index)) {
+      index = skipTrivia(source, index);
+      continue;
+    }
+    if (char === "(" || char === "[" || char === "{") {
+      depth += 1;
+    } else if (char === ")" || char === "]" || char === "}") {
+      if (depth === 0) return index;
+      depth -= 1;
+    } else if (char === "," && depth === 0) {
+      return index;
+    }
+    index += 1;
+  }
+  return index;
+}
+function isDirectStringLiteral(source, start) {
+  const quote = source[start];
+  if (quote !== "'" && quote !== '"' && quote !== "`") return false;
+  const end = skipQuoted(source, start);
+  return quote !== "`" || !source.slice(start, end).includes("${");
+}
+function hasLiteralSecretAuthCredential(source) {
+  for (let index = 0; index < source.length; index += 1) {
+    const char = source[index];
+    if (char === "'" || char === '"' || char === "`") {
+      index = skipQuoted(source, index) - 1;
+      continue;
+    }
+    if (source.startsWith("//", index) || source.startsWith("/*", index)) {
+      index = skipTrivia(source, index) - 1;
+      continue;
+    }
+    const afterCtx = consumeIdentifier(source, index, "ctx");
+    if (!afterCtx) continue;
+    const afterSecrets = consumeMember(source, afterCtx, "secrets");
+    if (!afterSecrets) continue;
+    const afterHeader = consumeMember(source, afterSecrets, "header");
+    const helper = afterHeader ? "header" : "bearer";
+    const afterHelper = afterHeader ?? consumeMember(source, afterSecrets, "bearer");
+    if (!afterHelper) continue;
+    const afterOpen = skipTrivia(source, afterHelper);
+    if (source[afterOpen] !== "(") continue;
+    const firstArgument = skipTrivia(source, afterOpen + 1);
+    const credential = helper === "header" ? skipTrivia(source, skipExpression(source, firstArgument) + 1) : firstArgument;
+    if (isDirectStringLiteral(source, credential)) return true;
+  }
+  return false;
+}
 function collectInlineSecretFindings(sourceCode) {
   const findings = [];
   for (const match of sourceCode.matchAll(SECRET_ENV_PATTERN)) {
@@ -16905,6 +17038,9 @@ function collectInlineSecretFindings(sourceCode) {
   if (ASSIGNMENT_SECRET_LITERAL_PATTERN.test(sourceCode)) {
     findings.push("secret-looking assignment literal");
   }
+  if (hasLiteralSecretAuthCredential(sourceCode)) {
+    findings.push(SECRET_AUTH_LITERAL_FINDING);
+  }
   return [...new Set(findings)];
 }
 
@@ -25254,6 +25390,14 @@ Concepts:
   bundle local .play.ts files for development workflows.
   Running a local file does not make it live; use publish or set-live for that.
 
+Authoring:
+  Use normal TypeScript interpolation for human-facing strings:
+    const readyMessage = \`Put \${input.title} through to send-ready.\`;
+  An authored diagram is optional. Docflow parses only an explicit
+  /** @mermaid ... */ block and its // @mermaid-node annotations; ordinary
+  prose comments are never Docflow syntax. When Docflow is enabled, plays check
+  gives missing diagrams a non-blocking visualization warning.
+
 Common commands:
   deepline plays search email --json
   deepline plays describe prebuilt/person-linkedin-to-email --json