deepdebug-local-agent 1.0.21 → 1.0.23

package/test/adapters/registry.test.js

@@ -0,0 +1,101 @@
+// test/adapters/registry.test.js
+// Contract tests for the Phase 2 adapter registry — Plan 02-12 Wave 3.
+// Validates loadAdapters() construction, allowed-stack enforcement, and
+// stopAll() lifecycle/timeout behaviour (AC-4, AC-11).
+
+import { test, describe } from 'node:test';
+import assert from 'node:assert/strict';
+import {
+  loadAdapters,
+  stopAll,
+  ALLOWED_STACK_LIST,
+} from '../../src/adapters/index.js';
+
+describe('adapter registry', () => {
+  test('loadAdapters({legacyStacks:[]}) returns []', () => {
+    assert.deepEqual(loadAdapters({ legacyStacks: [] }), []);
+  });
+
+  test('loadAdapters({}) returns [] (missing legacyStacks treated as empty)', () => {
+    assert.deepEqual(loadAdapters({}), []);
+  });
+
+  test('loadAdapters({legacyStacks:["sap"]}) returns 1 SapLogAdapter, unstarted', () => {
+    const adapters = loadAdapters({ legacyStacks: ['sap'] });
+    assert.equal(adapters.length, 1);
+    assert.equal(adapters[0].constructor.name, 'SapLogAdapter');
+    assert.equal(adapters[0].isRunning, false);
+  });
+
+  test('loadAdapters with all 5 stacks returns 5 unstarted adapters', () => {
+    const adapters = loadAdapters({ legacyStacks: ALLOWED_STACK_LIST.slice() });
+    assert.equal(adapters.length, 5);
+    const ctorNames = adapters.map((a) => a.constructor.name).sort();
+    assert.deepEqual(
+      ctorNames,
+      [
+        'As400LogAdapter',
+        'CobolLogAdapter',
+        'IbmMqLogAdapter',
+        'OracleFormsLogAdapter',
+        'SapLogAdapter',
+      ],
+    );
+    for (const a of adapters) assert.equal(a.isRunning, false);
+  });
+
+  test('loadAdapters({legacyStacks:["unknown"]}) throws with stack name', () => {
+    assert.throws(
+      () => loadAdapters({ legacyStacks: ['unknown'] }),
+      /unknown/,
+    );
+  });
+
+  test('loadAdapters propagates per-stack config to constructor', () => {
+    const adapters = loadAdapters({
+      legacyStacks: ['sap'],
+      sap: { sapDir: '/tmp/test-sap', instanceNumber: '42', interval: 1234 },
+    });
+    assert.equal(adapters[0].sapDir, '/tmp/test-sap');
+    assert.equal(adapters[0].instanceNumber, '42');
+    assert.equal(adapters[0].interval, 1234);
+  });
+
+  test('stopAll([]) resolves silently', async () => {
+    await stopAll([]);
+  });
+
+  test('stopAll(undefined) resolves silently', async () => {
+    await stopAll(undefined);
+  });
+
+  test('stopAll calls stop() on each adapter', async () => {
+    let stopped = 0;
+    const fake = { stop: async () => { stopped++; } };
+    await stopAll([fake, fake, fake]);
+    assert.equal(stopped, 3);
+  });
+
+  test('stopAll respects timeout — slow stop does not block forever', async () => {
+    const slow = { stop: () => new Promise(() => { /* never resolve */ }) };
+    const before = Date.now();
+    await stopAll([slow], 200);
+    const elapsed = Date.now() - before;
+    assert.ok(elapsed < 1000, `stopAll should return within timeout; took ${elapsed}ms`);
+  });
+
+  test('stopAll swallows per-adapter stop() errors (never throws)', async () => {
+    const bad = { stop: async () => { throw new Error('boom'); } };
+    const good = { stop: async () => { /* ok */ } };
+    // Should resolve without rejecting.
+    await stopAll([bad, good, bad]);
+  });
+
+  test('ALLOWED_STACK_LIST is the canonical 5-stack list, frozen', () => {
+    assert.deepEqual(
+      [...ALLOWED_STACK_LIST].sort(),
+      ['as400', 'cobol', 'ibmmq', 'oracle-forms', 'sap'],
+    );
+    assert.equal(Object.isFrozen(ALLOWED_STACK_LIST), true);
+  });
+});

package/test/adapters/sap/sap.test.js

@@ -0,0 +1,142 @@
+import { test, describe, before, after } from 'node:test';
+import assert from 'node:assert/strict';
+import { writeFileSync, appendFileSync, truncateSync, mkdirSync, rmSync } from 'node:fs';
+import { mkdtempSync } from 'node:fs';
+import { tmpdir } from 'node:os';
+import { join } from 'node:path';
+import { setTimeout as sleep } from 'node:timers/promises';
+import { SapLogAdapter } from '../../../src/adapters/sap/index.js';
+import { SAP_DEV_W_REGEX, SAP_SLOG_REGEX } from '../../../src/adapters/sap/sap-parser.js';
+
+function tempSapTree() {
+  const root = mkdtempSync(join(tmpdir(), 'sap-test-'));
+  const workDir = join(root, 'D00', 'work');
+  const logDir = join(root, 'D00', 'log');
+  mkdirSync(workDir, { recursive: true });
+  mkdirSync(logDir, { recursive: true });
+  return { root, workDir, logDir };
+}
+
+async function awaitEvents(adapter, n, timeoutMs = 12000) {
+  const events = [];
+  return new Promise((resolve, reject) => {
+    const onErr = (e) => { events.push(e); if (events.length >= n) { adapter.off('error', onErr); resolve(events); } };
+    adapter.on('error', onErr);
+    setTimeout(() => { adapter.off('error', onErr); resolve(events); }, timeoutMs);
+  });
+}
+
+describe('SapLogAdapter', () => {
+  test('TAIL mode default — pre-existing content not emitted (AC-9)', async () => {
+    const { root, workDir } = tempSapTree();
+    const f = join(workDir, 'dev_w0');
+    writeFileSync(f, [
+      'trc file: "dev_w0"',
+      'M  *** ERROR => Pre-existing CONVT_NO_NUMBER',
+    ].join('\n') + '\n');
+
+    const adapter = new SapLogAdapter({ sapDir: root, instanceNumber: '00', interval: 200 });
+    await adapter.start();
+    const events = await awaitEvents(adapter, 1, 1500);
+    await adapter.stop();
+    assert.equal(events.length, 0, 'no events should fire for pre-existing content');
+    rmSync(root, { recursive: true, force: true });
+  });
+
+  test('emits 6-key event on appended dev_w error line (AC-2)', async () => {
+    const { root, workDir } = tempSapTree();
+    const f = join(workDir, 'dev_w0');
+    writeFileSync(f, 'trc file: "dev_w0"\n');
+
+    const adapter = new SapLogAdapter({ sapDir: root, instanceNumber: '00', interval: 200 });
+    await adapter.start();
+    await sleep(400);
+    appendFileSync(f, 'M  *** ERROR => Runtime error CONVT_NO_NUMBER\n');
+    const events = await awaitEvents(adapter, 1, 5000);
+    await adapter.stop();
+
+    assert.equal(events.length, 1);
+    const e = events[0];
+    assert.equal(Object.keys(e).sort().join(','), 'adapter,errorCode,file,message,source,timestamp');
+    assert.equal(e.adapter, 'sap');
+    assert.equal(e.errorCode, 'CONVT_NO_NUMBER');
+    assert.equal(e.file, f);
+    assert.match(e.message, /CONVT_NO_NUMBER/);
+    assert.equal(e.source, workDir);
+    assert.match(e.timestamp, /^\d{4}-\d{2}-\d{2}T/);
+    rmSync(root, { recursive: true, force: true });
+  });
+
+  test('emits event on SLOG line', async () => {
+    const { root, logDir } = tempSapTree();
+    const f = join(logDir, 'SLOG00');
+    writeFileSync(f, '| 2024-01-15 09:00:00 | I | 00 | System log opened |\n');
+
+    const adapter = new SapLogAdapter({ sapDir: root, instanceNumber: '00', interval: 200 });
+    await adapter.start();
+    await sleep(400);
+    appendFileSync(f, '| 2024-01-15 09:12:44 | E | 04 | Database error in select on ZSALES_ORDER, sy-subrc = 4 |\n');
+    const events = await awaitEvents(adapter, 1, 5000);
+    await adapter.stop();
+    assert.equal(events.length, 1);
+    assert.equal(events[0].adapter, 'sap');
+    rmSync(root, { recursive: true, force: true });
+  });
+
+  test('start/stop/start lifecycle idempotent (AC-1)', async () => {
+    const { root, workDir } = tempSapTree();
+    writeFileSync(join(workDir, 'dev_w0'), 'trc\n');
+    const adapter = new SapLogAdapter({ sapDir: root, instanceNumber: '00', interval: 200 });
+    await adapter.start();
+    await adapter.start(); // idempotent
+    await adapter.stop();
+    await adapter.stop(); // idempotent
+    await adapter.start();
+    await adapter.stop();
+    rmSync(root, { recursive: true, force: true });
+  });
+
+  test('rotation: truncate + append → event emitted (AC-10)', async () => {
+    const { root, workDir } = tempSapTree();
+    const f = join(workDir, 'dev_w0');
+    writeFileSync(f, 'trc\nM  *** ERROR => OLD_BASELINE\n');
+
+    const adapter = new SapLogAdapter({ sapDir: root, instanceNumber: '00', interval: 200 });
+    await adapter.start();
+    await sleep(400);
+    truncateSync(f, 0);
+    await sleep(400);
+    appendFileSync(f, 'M  *** ERROR => Runtime error CONVT_NO_NUMBER\n');
+    const events = await awaitEvents(adapter, 1, 5000);
+    await adapter.stop();
+    assert.ok(events.length >= 1, 'rotation should produce at least 1 event');
+    rmSync(root, { recursive: true, force: true });
+  });
+
+  test('ENOENT silent — no event, no throw', async () => {
+    const adapter = new SapLogAdapter({ sapDir: '/nonexistent/path-' + Date.now(), instanceNumber: '00', interval: 200 });
+    await adapter.start();
+    await sleep(500);
+    await adapter.stop();
+  });
+
+  test('parser regexes exported and callable (T-2-03)', () => {
+    assert.ok(SAP_DEV_W_REGEX instanceof RegExp);
+    assert.ok(SAP_SLOG_REGEX instanceof RegExp);
+    const m = 'M  *** ERROR => Runtime error CONVT_NO_NUMBER'.match(SAP_DEV_W_REGEX);
+    assert.ok(m, 'dev_w regex should match runtime error line');
+  });
+
+  test('replayOnStart: true emits pre-existing content', async () => {
+    const { root, workDir } = tempSapTree();
+    const f = join(workDir, 'dev_w0');
+    writeFileSync(f, 'M  *** ERROR => Runtime error CONVT_NO_NUMBER\n');
+
+    const adapter = new SapLogAdapter({ sapDir: root, instanceNumber: '00', interval: 200, replayOnStart: true });
+    await adapter.start();
+    const events = await awaitEvents(adapter, 1, 5000);
+    await adapter.stop();
+    assert.ok(events.length >= 1);
+    rmSync(root, { recursive: true, force: true });
+  });
+});