decorated-pi 0.6.0 → 0.7.1

package/README.md

@@ -14,7 +14,7 @@ pi install /path/to/decorated-pi
 
 ### 1. Token Efficiency
 
-Multiple layers of token savings that compound across every session.
+Multiple layers of token savings that compound across every session. **All integrated CLI tools only require installing their respective CLIs — zero config**.
 
 **RTK** — integrates [RTK](https://github.com/rtk-ai/rtk) to compress bash output into structured summaries, so the LLM never sees raw noise.
 
@@ -48,12 +48,33 @@ Drop‑in replacements for Pi's built‑in tools, with better UX and fewer waste
 
 #### Smarter `@` File Search
 
-| Aspect | Pi native `@` | `decorated-pi` |
+`decorated-pi` replaces pi's built-in `@` autocomplete with a high-speed file finder backed by **[`@ff-labs/fff-node`](https://github.com/dmtrKovalenko/fff)**— a Rust SIMD fuzzy file search engine with in-memory index, frecency ranking, and git status awareness. Pi's native provider shells out to `fd` on every keystroke.
+
+| Aspect | Pi native `@` | `decorated-pi` (FFF) |
 | ------ | :---: | :---: |
-| **Speed** | ❌ re‑scans filesystem on every trigger | ✅ caches once per `@` trigger |
-| **Noise filtering** | ❌ no penalty system, shows hidden files | ✅ tiered penalty auto‑filters clutter |
-| **Default suggestions** | ❌ all files visible on empty query | ✅ only visible project files |
-| **Match precision** | ❌ case‑insensitive simple scoring | ✅ multi‑level case‑sensitive scoring |
+| **Speed** | ❌ walks filesystem via `fd` subprocess on every keystroke | ✅ in‑memory index built once per session, ~0.1 ms / query |
+| **Ranking** | ❌ 4‑bucket case‑sensitive score (exact/starts/contains/path) | ✅ fuzzy match + frecency + git status (boots from git log) |
+| **Noise** | ❌ shows every file in the project, including `.git`, `node_modules`, `dist` | ✅ filters `git‑ignored` files; substring filter on path keeps short queries relevant |
+
+###### Benchmark of `@`
+
+```
+┌─ smart-at benchmark
+├─ generated 500,000 files in 3.9 s
+├─ FFF scan complete in 664 ms
+│  RSS after FFF index: 408 MB  (+330 MB over baseline)
+├─ accuracy (14 queries)
+│                  top‑1   top‑3   top‑5   false‑pos
+│  smart-at         93%     93%     93%    0
+│  native (fd)      86%     93%     93%    0
+└─ corpus cleaned
+
+name                                            hz      mean
+· smart-at                                      8.10    123 ms
+· native @  (fd subprocess)                     3.12    320 ms
+
+Summary: smart-at is 2.59x faster than native @  (fd subprocess)
+```
 
 #### LSP support
 
@@ -73,7 +94,7 @@ Zero-config MCP client with built-in servers:
 | Exa | `exa_*` | `https://mcp.exa.ai/mcp` |
 | codegraph | `codegraph_*` | bundled binary |
 
-**Custom servers** in `.pi/agent/mcp.json` (project) or `~/.pi/agent/decorated-pi.json` (global). Project overrides global. Tool prompts and schemas are cached locally so MCP tools are available immediately on startup — no manual `/reload` required even on first install.
+**Custom servers** in `.pi/agent/mcp.json` (project) or `~/.pi/agent/mcp.json` (global). Project overrides global. Tool prompts and schemas are cached locally so MCP tools are available immediately on startup.
 
 ```json
 {
@@ -118,8 +139,8 @@ Example redaction on a `read` / `bash` output:
 ### 5. Other
 
 - `/usage` — token stats with cache‑hit rate, per‑model breakdown (Session / Today / This Week / This Month / All Time)
-- Progressive context — supports subdirectory `AGENTS.md` / `CLAUDE.md` discovery and injection
 - `/retry` — continue after interruption
+- Progressive context — supports subdirectory `AGENTS.md` / `CLAUDE.md` discovery and injection
 - **WakaTime** — coding activity tracking via [WakaTime](https://wakatime.com)
 
 ## Configuration
@@ -129,13 +150,22 @@ Runtime settings in `~/.pi/agent/decorated-pi.json`. Modules can be toggled via
 ```json
 {
   "modules": {
-    "patch": true,
-    "safety": true,
-    "rtk": true,
-    "lsp": true,
-    "smart-at": true,
-    "mcp": true,
-    "wakatime": true
+    "tools": {
+      "patchOverrideEdit": true,
+      "ask": true,
+      "lsp": true,
+      "mcp": true
+    },
+    "hooks": {
+      "secretRedaction": true,
+      "rtk": true,
+      "wakatime": true
+    },
+    "commands": {
+      "atOverride": true,
+      "retry": true,
+      "usage": true
+    }
   }
 }
 ```

package/commands/dp-settings.ts

@@ -3,6 +3,7 @@
  */
 
 import type { ExtensionAPI } from "@earendil-works/pi-coding-agent";
+import { moduleSnapshotChanged } from "../settings.js";
 import { ModuleSettingsComponent } from "../ui/module-settings.js";
 
 export function registerDpSettingsCommand(pi: ExtensionAPI): void {
@@ -14,7 +15,11 @@ export function registerDpSettingsCommand(pi: ExtensionAPI): void {
           (tui, theme, _kb, done) =>
             new ModuleSettingsComponent(tui, theme, () => done(undefined))
         );
-        ctx.ui.notify("Module settings updated. /reload to apply.", "warning");
+        // Only prompt for reload when the effective settings differ from
+        // the snapshot taken when pi loaded the extension.
+        if (moduleSnapshotChanged()) {
+          ctx.ui.notify("Module settings updated. /reload to apply.", "warning");
+        }
         return;
       }
       ctx.ui.notify("dp-settings requires interactive mode.", "warning");

package/hooks/mcp.ts

@@ -31,6 +31,11 @@ function cacheScopeForSource(source: string): "global" | "project" {
   return source === "project" ? "project" : "global";
 }
 
+function canUseServer(config: McpServerConfig, cwd?: string): boolean {
+  if (!config.canUseInProject) return true;
+  return config.canUseInProject(cwd ?? process.cwd());
+}
+
 async function connectAll(
   configs: McpServerConfig[],
   registry: any,
@@ -81,6 +86,15 @@ async function connectAll(
   for (const server of configs) {
     if (watchdogFired) break; // remaining servers are already failed
 
+    if (!canUseServer(server, cachedCwd || undefined)) {
+      allServers.set(server.name, {
+        name: server.name, url: server.url ?? server.command ?? "(unknown)", source: server.source,
+        state: "failed", toolCount: 0, tools: [],
+        error: "Project is missing required artefacts for this server",
+      });
+      continue;
+    }
+
     const conn = new McpConnection(server.name, server);
     conn.source = server.source;
     try {
@@ -89,6 +103,18 @@ async function connectAll(
         try { await conn.disconnect(); } catch { /* ignore */ }
         return { schemaChanges, hasNewServer };
       }
+      if (conn.tools.length === 0) {
+        // Server connected but advertises no tools. Treat this as a
+        // failed state and do NOT write an empty cache, otherwise a
+        // subsequent /reload will keep using the empty cache forever.
+        try { await conn.disconnect(); } catch { /* ignore */ }
+        allServers.set(server.name, {
+          name: server.name, url: server.url ?? server.command ?? "(unknown)", source: server.source,
+          state: "failed", toolCount: 0, tools: [],
+          error: "Server connected but returned no tools (e.g. codegraph without a .codegraph index)",
+        });
+        continue;
+      }
       activeConnections.push(conn);
       const actualTools = conn.tools.map((t) => ({ name: t.name, description: t.description, inputSchema: t.inputSchema }));
       const cachedEntry = cache?.servers[server.name];
@@ -195,6 +221,9 @@ export async function updateConfigEnabled(serverName: string, enabled: boolean):
 export async function refreshServerCache(serverName: string, registry: any): Promise<{ ok: boolean; error?: string }> {
   const config = resolveMcpConfigs(cachedCwd).find(s => s.name === serverName);
   if (!config) return { ok: false, error: `Server "${serverName}" not found in config.` };
+  if (!canUseServer(config, cachedCwd || undefined)) {
+    return { ok: false, error: "Project is missing required artefacts for this server" };
+  }
   const existing = activeConnections.find(c => c.serverName === serverName);
   if (existing) {
     try { await existing.disconnect(); } catch { /* ignore */ }
@@ -204,6 +233,12 @@ export async function refreshServerCache(serverName: string, registry: any): Pro
   conn.source = config.source;
   try {
     await conn.connect(30_000);
+    if (conn.tools.length === 0) {
+      try { await conn.disconnect(); } catch { /* ignore */ }
+      const error = "Server connected but returned no tools (e.g. codegraph without a .codegraph index)";
+      allServers.set(config.name, { name: config.name, url: config.url ?? config.command ?? "(unknown)", source: config.source, state: "failed", toolCount: 0, tools: [], error });
+      return { ok: false, error };
+    }
     activeConnections.push(conn);
     allServers.set(config.name, {
       name: config.name, url: config.url ?? config.command ?? "(unknown)", source: config.source,
@@ -242,6 +277,8 @@ export function getCachedMcpConfigs(): McpServerConfig[] {
  * can find it.
  */
 export async function ensureMcpServerReady(pi: ExtensionAPI, config: McpServerConfig, cwd?: string): Promise<void> {
+  if (!canUseServer(config, cwd)) return;
+
   const scope = cacheScopeForSource(config.source);
   const cache = loadScopedMcpCache(scope, cwd);
   const entry = cache?.servers[config.name];
@@ -262,6 +299,21 @@ export async function ensureMcpServerReady(pi: ExtensionAPI, config: McpServerCo
   conn.source = config.source;
   try {
     await conn.connect(30_000);
+    if (conn.tools.length === 0) {
+      // Empty tool list means the server is not useful. Disconnect and
+      // leave cache untouched so the next /reload retries the connection.
+      try { await conn.disconnect(); } catch { /* ignore */ }
+      allServers.set(config.name, {
+        name: config.name,
+        url: config.url ?? config.command ?? "(unknown)",
+        source: config.source,
+        state: "failed",
+        toolCount: 0,
+        tools: [],
+        error: "Server connected but returned no tools (e.g. codegraph without a .codegraph index)",
+      });
+      return;
+    }
     activeConnections.push(conn);
     const tools: McpToolCache[] = conn.tools.map(t => ({
       name: t.name,

package/hooks/session-title.ts

@@ -40,13 +40,37 @@ export function extractFirstMessage(entries: SessionEntryLike[]): string | undef
   return undefined;
 }
 
+function normalizeTitle(text: string): string | undefined {
+  const nl = text.indexOf("\n");
+  const oneLine = (nl === -1 ? text : text.slice(0, nl)).trim();
+  if (!oneLine) return undefined;
+  if (oneLine.length <= MAX_SESSION_TITLE_LENGTH) return oneLine;
+  return oneLine.slice(0, MAX_SESSION_TITLE_LENGTH - 1) + "…";
+}
+
+function trySetSessionName(ctx: any, pi: ExtensionAPI): void {
+  if (ctx.sessionManager.getSessionName()) return;
+  const title = extractFirstMessage(ctx.sessionManager.getBranch());
+  if (title) (pi as any).setSessionName(title);
+}
+
 export const sessionTitleModule: Module = {
   name: "session-title",
   hooks: {
     session_start: [
       (_event, ctx, pi) => {
+        trySetSessionName(ctx, pi);
+      },
+    ],
+    input: [
+      (event, ctx, pi) => {
+        // Skip if already named, not a fresh interactive message,
+        // or stream steering/follow-up messages.
         if (ctx.sessionManager.getSessionName()) return;
-        const title = extractFirstMessage(ctx.sessionManager.getBranch());
+        if (event.source === "extension") return;
+        if (event.streamingBehavior) return;
+        const text = typeof event.text === "string" ? event.text.trim() : "";
+        const title = normalizeTitle(text);
         if (title) (pi as any).setSessionName(title);
       },
     ],