declapract-typescript-ehmpathy 0.49.13 → 0.49.14

package/dist/.test/assets/format/repo-with-terraform/package.json

@@ -1,5 +1,12 @@
 {
   "name": "test-project",
   "version": "1.0.0",
-  "scripts": {}
+  "scripts": {
+    "fix:format:biome": "biome check --write",
+    "fix:format:terraform": "terraform fmt -recursive provision",
+    "fix:format": "npm run fix:format:biome && npm run fix:format:terraform",
+    "test:format:terraform": "terraform fmt -recursive -check provision",
+    "test:format:biome": "biome format",
+    "test:format": "npm run test:format:biome && npm run test:format:terraform"
+  }
 }

package/dist/.test/assets/format/repo-without-terraform/declapract.use.yml

@@ -1,6 +1,5 @@
-# .note = declarations dir is symlinked by the test to src/practices/format/.test/assets/declarations
-# .why  = a consumer on a NON-terraform usecase, used to prove the format practice's package.json
-#         `contents` fn OMITS the terraform formatter (fix:format is biome-only) when no terraform
-#         practice is in play.
+# .note = declarations dir is symlinked by the test to src/.test/assets/format/declarations
+# .why  = a consumer on a NON-terraform usecase, with a fresh package.json, used to prove the
+#         format practice writes the biome-only fix:format / test:format chains.
 declarations: 'declarations/declapract.declare.yml'
 useCase: without-terraform

package/dist/.test/assets/lint/declarations/declapract.declare.yml

@@ -0,0 +1,4 @@
+# minimal declarations for lint integration tests
+declare:
+  practices: practices
+  use-cases: useCases.yml

package/dist/.test/assets/lint/declarations/practices/lint/.depcheckrc.yml.declapract.integration.test.ts

@@ -0,0 +1,184 @@
+import fs from 'fs/promises';
+import path from 'node:path';
+
+import { executeApply } from 'declapract';
+import depcheck from 'depcheck';
+import { genTempDir, given, then, useBeforeAll, when } from 'test-fns';
+import yaml from 'yaml';
+
+// executeApply is slow (full practice evaluation), so widen the jest budget
+jest.setTimeout(180_000);
+
+/**
+ * .what = the source files a live rhachet repo holds under `.agent/`, each with an import
+ * .why  = written at test time (never committed), so this repo's own depcheck never sees
+ *         the fake imports; each file proves one ignorePatterns entry
+ */
+const AGENT_SOURCES = [
+  {
+    // a plugin cache in an enrolled actor dir (#639)
+    relpath: '.agent/.actors/actor.via.hash=abc123/brain/.claude/plugins/x.test.ts',
+    imports: 'claude-code',
+  },
+  {
+    // a role skill vendored from another repo (#512)
+    relpath: '.agent/repo=ghlitch/role=operator/skills/use.vpc.tunnel.ts',
+    imports: 'declastruct-unix-network',
+  },
+  {
+    // this repo's own role skill: still source, so still checked
+    relpath: '.agent/repo=.this/role=any/skills/own.skill.ts',
+    imports: 'own-undeclared-dep',
+  },
+];
+
+/**
+ * .what = writes the `.agent/` sources into a repo dir, and links `.claude` into the actor dir
+ * .why  = rhachet links a repo's `.claude` into the enrolled actor's brain dir, so depcheck
+ *         reaches the actor's plugin cache through the link too, past the `.agent/.actors` ignore
+ */
+const setAgentSources = async (input: { dir: string }) => {
+  for (const source of AGENT_SOURCES) {
+    const filepath = path.join(input.dir, source.relpath);
+    await fs.mkdir(path.dirname(filepath), { recursive: true });
+    await fs.writeFile(filepath, `import '${source.imports}';\n`);
+  }
+  await fs.symlink(
+    '.agent/.actors/actor.via.hash=abc123/brain/.claude',
+    path.join(input.dir, '.claude'),
+  );
+};
+
+/**
+ * .what = runs depcheck on a repo dir with the given `.depcheckrc.yml` contents
+ * .why  = proves the declared patterns hold under depcheck's own `ignore` semantics —
+ *         the `!.agent/repo=.this` negation (F74) too, which a unit test cannot see
+ */
+const getUndeclaredDeps = async (input: {
+  dir: string;
+  depcheckrc: string;
+}): Promise<string[]> => {
+  const parsed = yaml.parse(input.depcheckrc) as {
+    ignores?: string[];
+    ignorePatterns?: string[];
+  };
+  const result = await depcheck(input.dir, {
+    ignoreMatches: parsed.ignores ?? [],
+    // the test-only declarations symlink is not part of the consumer repo
+    ignorePatterns: ['declarations', ...(parsed.ignorePatterns ?? [])],
+  });
+  return Object.keys(result.missing).sort();
+};
+
+/**
+ * .what = pipeline test for the .depcheckrc.yml merge (#639, #512) + expo ignore (#609)
+ * .why  = only executeApply proves the extant file is reached (a CONTAINS template alone
+ *         never touches an extant file), and only depcheck itself proves the patterns hold
+ */
+describe('lint practice .depcheckrc.yml', () => {
+  given('[case1] a node repo with an extant .depcheckrc.yml that predates ignorePatterns', () => {
+    const tempDir = genTempDir({
+      slug: 'lint-depcheckrc-extant',
+      clone: './src/practices/lint/.test/assets/repo-depcheckrc-extant',
+      symlink: [{ at: 'declarations', to: './src/.test/assets/lint/declarations' }],
+    });
+    const rcPath = () => path.join(tempDir, '.depcheckrc.yml');
+
+    const state = useBeforeAll(async () => {
+      await setAgentSources({ dir: tempDir });
+      const config = path.join(tempDir, 'declapract.use.yml');
+      const before = await fs.readFile(rcPath(), 'utf-8');
+      const undeclaredBefore = await getUndeclaredDeps({ dir: tempDir, depcheckrc: before });
+      await executeApply({ config, file: '.depcheckrc.yml' });
+      const after1 = await fs.readFile(rcPath(), 'utf-8');
+      const undeclaredAfter = await getUndeclaredDeps({ dir: tempDir, depcheckrc: after1 });
+      await executeApply({ config, file: '.depcheckrc.yml' });
+      const after2 = await fs.readFile(rcPath(), 'utf-8');
+      return { before, after1, after2, undeclaredBefore, undeclaredAfter };
+    }, 170_000);
+
+    when('[t0] declapract apply', () => {
+      then('ignorePatterns holds the actor dir, its `.claude` link, and the vendored-role pair', () => {
+        const parsed = yaml.parse(state.after1) as { ignorePatterns: string[] };
+        expect(parsed.ignorePatterns).toEqual([
+          '.agent/.actors',
+          '.claude',
+          '.agent/repo=*',
+          '!.agent/repo=.this',
+        ]);
+      });
+
+      then('the repo-own ignores survive, with their comments', () => {
+        const parsed = yaml.parse(state.after1) as { ignores: string[] };
+        expect(parsed.ignores).toContain('my-own-dep');
+        expect(parsed.ignores).toContain('rhachet*');
+        expect(state.after1).toContain('# repo-own header comment');
+        expect(state.after1).toContain('# repo-own reason for a repo-own ignore');
+      });
+
+      then('a node repo gains no metro-config ignore', () => {
+        expect(state.after1).not.toContain('metro-config');
+      });
+
+      then('before: depcheck flags the actor cache and the vendored skill', () => {
+        expect(state.undeclaredBefore).toEqual([
+          'claude-code',
+          'declastruct-unix-network',
+          'own-undeclared-dep',
+        ]);
+      });
+
+      then('after: depcheck flags only the repo-own skill — the negation holds', () => {
+        expect(state.undeclaredAfter).toEqual(['own-undeclared-dep']);
+      });
+
+      then('the before + after contents match snapshot', () => {
+        expect(state.before).toMatchSnapshot('.depcheckrc.yml — before');
+        expect(state.after1).toMatchSnapshot('.depcheckrc.yml — after apply');
+      });
+    });
+
+    when('[t1] declapract apply again', () => {
+      then('zero bytes change', () => {
+        expect(state.after2).toEqual(state.after1);
+      });
+    });
+  });
+
+  given('[case2] the same extant repo under the expo usecase (#609)', () => {
+    const tempDir = genTempDir({
+      slug: 'lint-depcheckrc-expo',
+      clone: './src/practices/lint/.test/assets/repo-depcheckrc-extant',
+      symlink: [{ at: 'declarations', to: './src/.test/assets/lint/declarations' }],
+    });
+    const rcPath = () => path.join(tempDir, '.depcheckrc.yml');
+
+    const state = useBeforeAll(async () => {
+      const config = path.join(tempDir, 'declapract.use.expo.yml');
+      // .note = filter by file only, so tests-expo stays in projectPractices
+      await executeApply({ config, file: '.depcheckrc.yml' });
+      const after1 = await fs.readFile(rcPath(), 'utf-8');
+      await executeApply({ config, file: '.depcheckrc.yml' });
+      const after2 = await fs.readFile(rcPath(), 'utf-8');
+      return { after1, after2 };
+    }, 170_000);
+
+    when('[t0] declapract apply', () => {
+      then('ignores holds metro-config', () => {
+        const parsed = yaml.parse(state.after1) as { ignores: string[] };
+        expect(parsed.ignores).toContain('metro-config');
+        expect(parsed.ignores).toContain('my-own-dep');
+      });
+
+      then('the after contents match snapshot', () => {
+        expect(state.after1).toMatchSnapshot('.depcheckrc.yml — expo after apply');
+      });
+    });
+
+    when('[t1] declapract apply again', () => {
+      then('zero bytes change', () => {
+        expect(state.after2).toEqual(state.after1);
+      });
+    });
+  });
+});

package/dist/.test/assets/lint/declarations/practices/lint/.depcheckrc.yml.self-application.declapract.integration.test.ts

@@ -0,0 +1,33 @@
+import { readFile } from 'fs/promises';
+import { given, then, when } from 'test-fns';
+
+import path from 'node:path';
+
+import { check, contents } from './best-practice/.depcheckrc.yml.declapract';
+
+/**
+ * .what = proves this repo's own `.depcheckrc.yml` holds every entry the lint practice declares
+ * .why  = this repo consumes its own practices; a declared ignore that never lands at the root
+ *         lets `test:lint:deps` fail on a host-local `.agent/.actors` file the practice already
+ *         excludes for every adopter
+ */
+describe('lint .depcheckrc.yml self-application', () => {
+  given('[case1] this repo root', () => {
+    when('[t0] the practice check runs over the root file', () => {
+      then('every declared ignore + ignorePattern is present', async () => {
+        const context = {
+          relativeFilePath: '.depcheckrc.yml',
+          projectPractices: ['lint'],
+        } as unknown as Parameters<typeof check>[1]; // .note = only the read fields are set
+        const declaredFileContents = await contents(context as never);
+        const rootContents = await readFile(
+          path.join(__dirname, '../../../.depcheckrc.yml'),
+          'utf-8',
+        );
+        expect(() =>
+          check(rootContents, { ...context, declaredFileContents }),
+        ).not.toThrow();
+      });
+    });
+  });
+});

package/dist/.test/assets/lint/declarations/practices/lint/.dpdmrc.yaml.declapract.integration.test.ts

@@ -0,0 +1,106 @@
+import fs from 'fs/promises';
+import path from 'node:path';
+
+import { executeApply } from 'declapract';
+import { genTempDir, given, then, useBeforeAll, when } from 'test-fns';
+import yaml from 'yaml';
+
+// executeApply is slow (full practice evaluation), so widen the jest budget
+jest.setTimeout(180_000);
+
+/**
+ * .what = pipeline test for the `.dpdmrc.yaml` policy check + fix (#628)
+ * .why  = the file was EQUALS, so every apply deleted the cited devDep entries the policy itself
+ *         allows. only executeApply proves the relaxed check lets an adopter entry survive, that
+ *         a node_modules entry is repaired in place, and that a second apply changes zero bytes.
+ * .teeth = turn the declaration back to EQUALS and case1 goes red: the cited entry is deleted.
+ */
+describe('lint practice .dpdmrc.yaml', () => {
+  /**
+   * .what = apply `.dpdmrc.yaml` twice on a temp clone, capture the file before + after each
+   */
+  const applyTwice = async (input: { tempDir: string; seed: string | null }) => {
+    const rcPath = path.join(input.tempDir, '.dpdmrc.yaml');
+    if (input.seed) await fs.writeFile(rcPath, input.seed);
+    const config = path.join(input.tempDir, 'declapract.use.yml');
+    const before = await fs.readFile(rcPath, 'utf-8');
+    await executeApply({ config, file: '.dpdmrc.yaml' });
+    const after1 = await fs.readFile(rcPath, 'utf-8');
+    await executeApply({ config, file: '.dpdmrc.yaml' });
+    const after2 = await fs.readFile(rcPath, 'utf-8');
+    return { before, after1, after2 };
+  };
+
+  given('[case1] an adopter .dpdmrc.yaml with a cited devDep exclude entry', () => {
+    const tempDir = genTempDir({
+      slug: 'lint-dpdmrc-cited',
+      clone: './src/practices/lint/.test/assets/repo-dpdmrc-extant',
+      symlink: [{ at: 'declarations', to: './src/.test/assets/lint/declarations' }],
+    });
+    const state = useBeforeAll(
+      async () => applyTwice({ tempDir, seed: null }),
+      170_000,
+    );
+
+    when('[t0] declapract apply', () => {
+      then('the entry survives', () => {
+        expect(yaml.parse(state.after1).exclude).toEqual(['jest-circus']);
+      });
+
+      then('the file is untouched, comments and all', () => {
+        expect(state.after1).toEqual(state.before);
+      });
+    });
+
+    when('[t1] declapract apply a second time', () => {
+      then('zero bytes change', () => {
+        expect(state.after2).toEqual(state.after1);
+      });
+    });
+  });
+
+  given('[case2] an adopter .dpdmrc.yaml that excludes node_modules', () => {
+    const tempDir = genTempDir({
+      slug: 'lint-dpdmrc-node-modules',
+      clone: './src/practices/lint/.test/assets/repo-dpdmrc-extant',
+      symlink: [{ at: 'declarations', to: './src/.test/assets/lint/declarations' }],
+    });
+    const state = useBeforeAll(
+      async () =>
+        applyTwice({
+          tempDir,
+          seed: [
+            '# this repo dpdm exclude list',
+            'exclude:',
+            '  # cited: jest-circus require cycle',
+            '  - jest-circus',
+            '  - ^node_modules',
+            '',
+          ].join('\n'),
+        }),
+      170_000,
+    );
+
+    when('[t0] declapract apply', () => {
+      then('the node_modules entry is dropped and the cited entry survives', () => {
+        expect(yaml.parse(state.after1).exclude).toEqual(['jest-circus']);
+      });
+
+      then('the comments survive', () => {
+        expect(state.after1).toContain('# this repo dpdm exclude list');
+        expect(state.after1).toContain('# cited: jest-circus require cycle');
+      });
+
+      then('before + after match snapshot', () => {
+        expect(state.before).toMatchSnapshot('.dpdmrc.yaml — before');
+        expect(state.after1).toMatchSnapshot('.dpdmrc.yaml — after');
+      });
+    });
+
+    when('[t1] declapract apply a second time', () => {
+      then('zero bytes change', () => {
+        expect(state.after2).toEqual(state.after1);
+      });
+    });
+  });
+});

package/dist/.test/assets/lint/declarations/practices/lint/.test/assets/repo-depcheckrc-denylisted/.depcheckrc.yml

@@ -0,0 +1,8 @@
+# repo-own header comment
+ignores:
+  - "@src/*"
+  - date-fns
+  # repo-own reason for a repo-own ignore
+  - my-own-dep
+  - ts-node
+  - core-js

package/dist/.test/assets/lint/declarations/practices/lint/.test/assets/repo-depcheckrc-denylisted/declapract.use.yml

@@ -0,0 +1,6 @@
+# .note = declarations dir is symlinked by the test to src/.test/assets/lint/declarations
+# .why  = a node repo whose extant .depcheckrc.yml still ignores denylisted packages
+#         (date-fns, ts-node, core-js), so the depcheck-denylisted-ignores bad practice fires
+# .note = no `variables:` block — the lint practice references zero `@declapract{variable.*}`
+declarations: 'declarations/declapract.declare.yml'
+useCase: lint-node

package/dist/.test/assets/lint/declarations/practices/lint/.test/assets/repo-depcheckrc-denylisted/package.json

@@ -0,0 +1,4 @@
+{
+  "name": "test-project",
+  "version": "1.0.0"
+}

package/dist/.test/assets/lint/declarations/practices/lint/.test/assets/repo-depcheckrc-extant/.depcheckrc.yml

@@ -0,0 +1,5 @@
+# repo-own header comment
+ignores:
+  - "@src/*"
+  # repo-own reason for a repo-own ignore
+  - my-own-dep

package/dist/.test/assets/lint/declarations/practices/lint/.test/assets/repo-depcheckrc-extant/declapract.use.expo.yml

@@ -0,0 +1,4 @@
+# .note = declarations dir is symlinked by the test to src/.test/assets/lint/declarations
+# .why  = the same extant repo under the expo usecase, so tests-expo is in projectPractices (#609)
+declarations: 'declarations/declapract.declare.yml'
+useCase: lint-expo

package/dist/.test/assets/lint/declarations/practices/lint/.test/assets/repo-depcheckrc-extant/declapract.use.yml

@@ -0,0 +1,4 @@
+# .note = declarations dir is symlinked by the test to src/.test/assets/lint/declarations
+# .why  = a node repo with an extant .depcheckrc.yml that predates ignorePatterns (#639)
+declarations: 'declarations/declapract.declare.yml'
+useCase: lint-node

package/dist/.test/assets/lint/declarations/practices/lint/.test/assets/repo-depcheckrc-extant/package.json

@@ -0,0 +1,4 @@
+{
+  "name": "test-project",
+  "version": "1.0.0"
+}

package/dist/.test/assets/lint/declarations/practices/lint/.test/assets/repo-dpdmrc-extant/.dpdmrc.yaml

@@ -0,0 +1,4 @@
+# this repo's own dpdm exclude list
+exclude:
+  # jest-circus requires itself through jest-each; upstream: jestjs/jest#00000 (fixture citation)
+  - jest-circus

package/dist/.test/assets/lint/declarations/practices/lint/.test/assets/repo-dpdmrc-extant/declapract.use.yml

@@ -0,0 +1,4 @@
+# .note = declarations dir is symlinked by the test to src/.test/assets/lint/declarations
+# .why  = a node repo whose .dpdmrc.yaml holds a cited devDep exclude entry (#628)
+declarations: 'declarations/declapract.declare.yml'
+useCase: lint-node

package/dist/.test/assets/lint/declarations/practices/lint/.test/assets/repo-dpdmrc-extant/package.json

@@ -0,0 +1,4 @@
+{
+  "name": "test-project",
+  "version": "1.0.0"
+}

package/dist/.test/assets/lint/declarations/practices/lint/__snapshots__/.depcheckrc.yml.declapract.integration.test.ts.snap

@@ -0,0 +1,79 @@
+// Jest Snapshot v1, https://jestjs.io/docs/snapshot-testing
+
+exports[`lint practice .depcheckrc.yml given: [case1] a node repo with an extant .depcheckrc.yml that predates ignorePatterns when: [t0] declapract apply then: the before + after contents match snapshot: .depcheckrc.yml — after apply 1`] = `
+"# repo-own header comment
+ignores:
+  - "@src/*"
+  # repo-own reason for a repo-own ignore
+  - my-own-dep
+  - "@src/.*"
+  - rhachet*
+  - declastruct-aws
+  - declastruct-unix-network
+  - declapract
+  - declapract-typescript-ehmpathy
+  - "@commitlint/config-conventional"
+  - "@tsconfig/node20"
+  - "@tsconfig/strictest"
+  - "@biomejs/biome"
+  - esbuild-register
+  - "@swc/core"
+  - "@swc/jest"
+  - husky
+  - tsx
+  - tsc-alias
+  - yalc
+  - test-fns
+  - type-fns
+  - yaml
+ignorePatterns:
+  - .agent/.actors
+  - .claude
+  - .agent/repo=*
+  - "!.agent/repo=.this"
+"
+`;
+
+exports[`lint practice .depcheckrc.yml given: [case1] a node repo with an extant .depcheckrc.yml that predates ignorePatterns when: [t0] declapract apply then: the before + after contents match snapshot: .depcheckrc.yml — before 1`] = `
+"# repo-own header comment
+ignores:
+  - "@src/*"
+  # repo-own reason for a repo-own ignore
+  - my-own-dep
+"
+`;
+
+exports[`lint practice .depcheckrc.yml given: [case2] the same extant repo under the expo usecase (#609) when: [t0] declapract apply then: the after contents match snapshot: .depcheckrc.yml — expo after apply 1`] = `
+"# repo-own header comment
+ignores:
+  - "@src/*"
+  # repo-own reason for a repo-own ignore
+  - my-own-dep
+  - "@src/.*"
+  - rhachet*
+  - declastruct-aws
+  - declastruct-unix-network
+  - declapract
+  - declapract-typescript-ehmpathy
+  - "@commitlint/config-conventional"
+  - "@tsconfig/node20"
+  - "@tsconfig/strictest"
+  - "@biomejs/biome"
+  - esbuild-register
+  - "@swc/core"
+  - "@swc/jest"
+  - husky
+  - tsx
+  - tsc-alias
+  - yalc
+  - test-fns
+  - type-fns
+  - yaml
+  - metro-config
+ignorePatterns:
+  - .agent/.actors
+  - .claude
+  - .agent/repo=*
+  - "!.agent/repo=.this"
+"
+`;

package/dist/.test/assets/lint/declarations/practices/lint/__snapshots__/.dpdmrc.yaml.declapract.integration.test.ts.snap

@@ -0,0 +1,18 @@
+// Jest Snapshot v1, https://jestjs.io/docs/snapshot-testing
+
+exports[`lint practice .dpdmrc.yaml given: [case2] an adopter .dpdmrc.yaml that excludes node_modules when: [t0] declapract apply then: before + after match snapshot: .dpdmrc.yaml — after 1`] = `
+"# this repo dpdm exclude list
+exclude:
+  # cited: jest-circus require cycle
+  - jest-circus
+"
+`;
+
+exports[`lint practice .dpdmrc.yaml given: [case2] an adopter .dpdmrc.yaml that excludes node_modules when: [t0] declapract apply then: before + after match snapshot: .dpdmrc.yaml — before 1`] = `
+"# this repo dpdm exclude list
+exclude:
+  # cited: jest-circus require cycle
+  - jest-circus
+  - ^node_modules
+"
+`;

package/dist/.test/assets/lint/declarations/practices/lint/__snapshots__/depcheck-denylisted-ignores.declapract.integration.test.ts.snap

@@ -0,0 +1,47 @@
+// Jest Snapshot v1, https://jestjs.io/docs/snapshot-testing
+
+exports[`lint depcheck-denylisted-ignores given: [case1] a node repo whose .depcheckrc.yml ignores denylisted packages when: [t0] before any apply then: the input file matches snapshot: .depcheckrc.yml — before 1`] = `
+"# repo-own header comment
+ignores:
+  - "@src/*"
+  - date-fns
+  # repo-own reason for a repo-own ignore
+  - my-own-dep
+  - ts-node
+  - core-js
+"
+`;
+
+exports[`lint depcheck-denylisted-ignores given: [case1] a node repo whose .depcheckrc.yml ignores denylisted packages when: [t1] apply runs then: the output matches snapshot: .depcheckrc.yml — after 1`] = `
+"# repo-own header comment
+ignores:
+  - "@src/*"
+  # repo-own reason for a repo-own ignore
+  - my-own-dep
+  - "@src/.*"
+  - rhachet*
+  - declastruct-aws
+  - declastruct-unix-network
+  - declapract
+  - declapract-typescript-ehmpathy
+  - "@commitlint/config-conventional"
+  - "@tsconfig/node20"
+  - "@tsconfig/strictest"
+  - "@biomejs/biome"
+  - esbuild-register
+  - "@swc/core"
+  - "@swc/jest"
+  - husky
+  - tsx
+  - tsc-alias
+  - yalc
+  - test-fns
+  - type-fns
+  - yaml
+ignorePatterns:
+  - .agent/.actors
+  - .claude
+  - .agent/repo=*
+  - "!.agent/repo=.this"
+"
+`;

package/dist/.test/assets/lint/declarations/practices/lint/__snapshots__/dpdmrc-exclude-policy.declapract.integration.test.ts.snap

@@ -0,0 +1,3 @@
+// Jest Snapshot v1, https://jestjs.io/docs/snapshot-testing
+
+exports[`lint .dpdmrc.yaml exclude policy given: the shipped .dpdmrc.yaml when: the exclude list is read then: the emitted exclude value matches snapshot: dpdmrc exclude value 1`] = `[]`;

package/dist/.test/assets/lint/declarations/practices/lint/__snapshots__/lint-cycles-command.declapract.integration.test.ts.snap

@@ -0,0 +1,3 @@
+// Jest Snapshot v1, https://jestjs.io/docs/snapshot-testing
+
+exports[`lint test:lint:cycles reads .dpdmrc.yaml via node + yaml (#601, #616) given: [case1] the shipped command when: [t0] its text is read then: the command matches snapshot: test:lint:cycles 1`] = `"EXCL=$(node -p "(require('yaml').parse(require('fs').readFileSync('.dpdmrc.yaml','utf8'))?.exclude ?? []).join('|')") && dpdm --no-warning --no-tree --transform --exit-code circular:1 --exclude "$EXCL" 'src/**/!(*.test).ts'"`;

package/dist/.test/assets/lint/declarations/practices/lint/bad-practices/biome-json-extension/biome.json.declapract.ts

@@ -0,0 +1,7 @@
+import { FileCheckType, type FileFixFunction } from 'declapract';
+
+export const check = FileCheckType.EXISTS;
+
+export const fix: FileFixFunction = () => {
+  return { contents: null }; // delete biome.json so biome.jsonc can be used instead
+};

package/dist/.test/assets/lint/declarations/practices/lint/bad-practices/depcheck-denylisted-ignores/.declapract.readme.md

@@ -0,0 +1,8 @@
+These packages should not be ignored in depcheck - they are either deprecated or have better alternatives:
+
+- date-fns: use luxon instead
+- procedure-fns: deprecated
+- ts-node: use tsx instead
+- ts-jest: use @swc/jest instead
+- core-js: no longer needed with modern node
+- babel-jest: use @swc/jest instead

package/dist/.test/assets/lint/declarations/practices/lint/bad-practices/depcheck-denylisted-ignores/.depcheckrc.yml.declapract.ts

@@ -0,0 +1,64 @@
+import type { FileCheckFunction, FileFixFunction } from 'declapract';
+import yaml from 'yaml';
+
+const denylist = [
+  'date-fns',
+  'procedure-fns',
+  'ts-node',
+  'ts-jest',
+  'core-js',
+  'babel-jest',
+  '@trivago/prettier-plugin-sort-imports',
+  '@tsconfig/node-lts-strictest',
+];
+
+export const check: FileCheckFunction = (contents) => {
+  if (!contents) throw new Error('no file found'); // no file = not bad practice
+
+  const parsed = yaml.parse(contents) as { ignores?: string[] };
+  const currentIgnores = parsed?.ignores ?? [];
+
+  // Find denylisted ignores that are present
+  const denylistedPresent = currentIgnores.filter((item) =>
+    denylist.includes(item),
+  );
+
+  // Bad practice: throw if no denylisted items found (all is fine), return if denylisted items exist
+  if (denylistedPresent.length === 0) {
+    throw new Error('no denylisted packages found in ignores');
+  }
+  // Return (don't throw) = bad practice detected
+};
+
+export const fix: FileFixFunction = (contents) => {
+  if (!contents) return { contents };
+
+  // Parse using parseDocument to preserve comments
+  const doc = yaml.parseDocument(contents);
+  const parsed = doc.toJSON() as { ignores?: string[] };
+  const currentIgnores = parsed?.ignores ?? [];
+
+  // Find denylisted ignores that are present
+  const denylistedPresent = currentIgnores.filter((item) =>
+    denylist.includes(item),
+  );
+
+  if (denylistedPresent.length === 0) return { contents };
+
+  // Remove denylisted ignores from the document
+  // note = `as any` at an external boundary (the `yaml` library ships no node type for
+  //        `doc.get`, which returns `unknown`). correct type = the library's `YAMLSeq`
+  //        with an `items` array. removal path = when `yaml` exports a typed `get`, or a
+  //        local `isYamlSeq` type-guard narrows the node before the `.items` access.
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
+  const ignoresNode = doc.get('ignores') as any;
+  if (ignoresNode?.items) {
+    // Filter out denylisted items
+    ignoresNode.items = ignoresNode.items.filter(
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
+      (item: any) => !denylist.includes(item.value ?? item),
+    );
+  }
+
+  return { contents: doc.toString() };
+};