declapract-typescript-ehmpathy 0.48.5 → 0.49.1

package/dist/practices/cicd-service/best-practice/.github/workflows/.deploy-sls.yml

@@ -90,6 +90,11 @@ jobs:
           key: ${{ needs.install.outputs.node-modules-cache-key }}
           fail-on-cache-miss: true
 
+      # .why = keyrack.yml can extend other manifests via symlinks (e.g., .agent/repo=ehmpathy/role=mechanic/keyrack.yml)
+      #        prepare:rhachet creates these symlinks so keyrack.source() can hydrate extended keys
+      - name: prepare:rhachet
+        run: npm run prepare:rhachet --if-present
+
       - name: vpc:tunnel:open
         if: inputs.needs-vpn-for-acceptance
         run: ACCESS=${{ inputs.stage }} .agent/repo=.this/skills/use.vpc.tunnel.ts

package/dist/practices/errors/bad-practices/local-error-imports/src/<star><star>/<star>.ts.declapract.ts

@@ -0,0 +1,85 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
+import type { FileCheckFunction, FileFixFunction } from 'declapract';
+import { UnexpectedCodePathError } from 'helpful-errors';
+
+/**
+ * known error classes exported by helpful-errors
+ *
+ * only these classes should be rewritten — custom error classes
+ * (e.g., UserInputError, HumanGuidanceError) must be left alone
+ */
+const KNOWN_CLASSES = [
+  'UnexpectedCodePathError',
+  'BadRequestError',
+  'HelpfulError',
+  'MalfunctionError',
+  'ConstraintError',
+];
+
+/**
+ * pattern source for local imports that end with a known error class name
+ *
+ * anchored to line start via ^ with multiline flag (m)
+ * supports both `import { X }` and `import type { X }`
+ *
+ * examples that match:
+ *   import { UnexpectedCodePathError } from '../../utils/errors/UnexpectedCodePathError'
+ *   import type { BadRequestError } from '@src/domain.operations/BadRequestError'
+ *
+ * examples that do NOT match:
+ *   from 'helpful-errors' (already correct)
+ *   from '../../utils/errors/UserInputError' (custom class)
+ *   const msg = "import { X } from 'local/UnexpectedCodePathError'" (mid-line)
+ *   // import { X } from '../../errors/UnexpectedCodePathError' (comment)
+ */
+const IMPORT_PREFIX = `(^\\s*import\\s+(?:type\\s+)?\\{[^}]+\\}\\s+)`;
+const FROM_LOCAL_ERROR = `from ['"][^'"]*\\/(${KNOWN_CLASSES.join('|')})['"]`;
+const LOCAL_ERROR_IMPORT_PATTERN_SOURCE = `${IMPORT_PREFIX}${FROM_LOCAL_ERROR}`;
+
+/**
+ * regex for test: match once, multiline mode
+ */
+const LOCAL_ERROR_IMPORT_PATTERN = new RegExp(
+  LOCAL_ERROR_IMPORT_PATTERN_SOURCE,
+  'm',
+);
+
+/**
+ * regex for replace: match all occurrences, multiline mode
+ */
+const LOCAL_ERROR_IMPORT_PATTERN_GLOBAL = new RegExp(
+  LOCAL_ERROR_IMPORT_PATTERN_SOURCE,
+  'gm',
+);
+
+/**
+ * .what = detect local error imports that should use helpful-errors
+ * .why = flag files for fix by declapract
+ */
+export const check: FileCheckFunction = (contents) => {
+  // matches bad practice if local error import found
+  if (contents && LOCAL_ERROR_IMPORT_PATTERN.test(contents)) return;
+
+  // no local error imports found — file does not need migration
+  UnexpectedCodePathError.throw(
+    'no local error imports found; file uses helpful-errors or custom errors',
+    { hint: 'this file does not need migration to helpful-errors' },
+  );
+};
+
+/**
+ * .what = replace local error imports with helpful-errors
+ * .why = consolidate error class sources for easier maintenance
+ */
+export const fix: FileFixFunction = (contents) => {
+  // skip if empty
+  if (!contents) return {};
+
+  // replace all local error imports, preserve import prefix via $1
+  return {
+    contents: contents.replace(
+      LOCAL_ERROR_IMPORT_PATTERN_GLOBAL,
+      "$1from 'helpful-errors'",
+    ),
+  };
+};

package/package.json

@@ -2,7 +2,7 @@
   "name": "declapract-typescript-ehmpathy",
   "author": "ehmpathy",
   "description": "declapract best practices declarations for typescript",
-  "version": "0.48.5",
+  "version": "0.49.1",
   "license": "MIT",
   "main": "src/index.js",
   "repository": "ehmpathy/declapract-typescript-ehmpathy",
@@ -59,7 +59,6 @@
   },
   "devDependencies": {
     "@biomejs/biome": "2.3.8",
-    "declapract": "0.13.26",
     "@commitlint/cli": "19.5.0",
     "@commitlint/config-conventional": "19.5.0",
     "@swc/core": "1.15.3",
@@ -70,18 +69,19 @@
     "@types/jest": "30.0.0",
     "@types/node": "22.15.21",
     "cz-conventional-changelog": "3.3.0",
+    "declapract": "0.13.26",
     "declastruct": "1.9.1",
     "declastruct-github": "1.4.0",
     "depcheck": "1.4.3",
     "esbuild-register": "3.6.0",
     "husky": "8.0.3",
     "jest": "30.2.0",
-    "rhachet": "1.41.17",
+    "rhachet": "1.41.21",
     "rhachet-brains-anthropic": "0.4.1",
     "rhachet-brains-xai": "0.3.3",
-    "rhachet-roles-bhrain": "0.29.0",
-    "rhachet-roles-bhuild": "0.21.15",
-    "rhachet-roles-ehmpathy": "1.35.12",
+    "rhachet-roles-bhrain": "0.29.2",
+    "rhachet-roles-bhuild": "0.21.16",
+    "rhachet-roles-ehmpathy": "1.35.15",
     "tsc-alias": "1.8.10",
     "tsx": "4.20.6",
     "type-fns": "1.21.2",