declapract-typescript-ehmpathy 0.48.2 → 0.48.4

package/dist/practices/bottleneck/bad-practices/bottleneck/package.json

@@ -0,0 +1,5 @@
+{
+  "dependencies": {
+    "bottleneck": "@declapract{check.minVersion('0.0.0')}"
+  }
+}

package/dist/practices/bottleneck/bad-practices/bottleneck/package.json.declapract.ts

@@ -0,0 +1,19 @@
+import { FileCheckType, type FileFixFunction } from 'declapract';
+
+export const check = FileCheckType.CONTAINS;
+
+export const fix: FileFixFunction = (contents) => {
+  if (!contents) return { contents };
+  const packageJSON = JSON.parse(contents);
+  const updatedPackageJSON = {
+    ...packageJSON,
+    dependencies: {
+      ...packageJSON.dependencies,
+      bottleneck: undefined,
+      'with-bottleneck': packageJSON.dependencies?.bottleneck,
+    },
+  };
+  return {
+    contents: JSON.stringify(updatedPackageJSON, null, 2),
+  };
+};

package/dist/practices/environments/best-practice/package.json

@@ -1,5 +1,7 @@
 {
   "dependencies": {
-    "sdk-environment": "@declapract{check.minVersion('0.1.3')}"
+    "@aws-sdk/client-account": "@declapract{check.minVersion('3.1042.0')}",
+    "@aws-sdk/client-iam": "@declapract{check.minVersion('3.1042.0')}",
+    "sdk-environment": "@declapract{check.minVersion('0.1.4')}"
   }
 }

package/dist/practices/logs/bad-practices/simple-log-methods/package.json

@@ -0,0 +1,5 @@
+{
+  "dependencies": {
+    "simple-log-methods": "@declapract{check.minVersion('0.0.0')}"
+  }
+}

package/dist/practices/logs/bad-practices/simple-log-methods/package.json.declapract.ts

@@ -0,0 +1,18 @@
+import { FileCheckType, type FileFixFunction } from 'declapract';
+
+export const check = FileCheckType.CONTAINS;
+
+export const fix: FileFixFunction = (contents) => {
+  if (!contents) return { contents };
+  const packageJSON = JSON.parse(contents);
+  const updatedPackageJSON = {
+    ...packageJSON,
+    dependencies: {
+      ...packageJSON.dependencies,
+      'simple-log-methods': undefined,
+    },
+  };
+  return {
+    contents: JSON.stringify(updatedPackageJSON, null, 2),
+  };
+};

package/dist/practices/logs/bad-practices/simple-log-methods/src/<star><star>/<star>.ts.declapract.ts

@@ -0,0 +1,15 @@
+import type { FileCheckFunction, FileFixFunction } from 'declapract';
+
+export const check: FileCheckFunction = (contents) => {
+  if (contents?.includes("from 'simple-log-methods'")) return;
+  throw new Error('does not match bad practice');
+};
+
+export const fix: FileFixFunction = (contents) => {
+  if (!contents) return {};
+  return {
+    contents: contents
+      .replace(/from 'simple-log-methods'/g, "from 'sdk-logs'")
+      .replace(/generateLogMethods/g, 'genLogMethods'),
+  };
+};

package/dist/practices/logs/best-practice/package.json

@@ -0,0 +1,5 @@
+{
+  "dependencies": {
+    "sdk-logs": "@declapract{check.minVersion('0.9.2')}"
+  }
+}

package/dist/practices/logs/best-practice/src/utils/logger.ts

@@ -0,0 +1,3 @@
+import { genLogMethods } from 'sdk-logs';
+
+export const log = genLogMethods();

package/dist/practices/provision-github/best-practice/package.json

@@ -1,6 +1,6 @@
 {
   "devDependencies": {
     "declastruct": "@declapract{check.minVersion('1.9.1')}",
-    "declastruct-github": "@declapract{check.minVersion('1.4.0')}"
+    "declastruct-github": "@declapract{check.minVersion('1.5.5')}"
   }
 }

package/dist/practices/provision-github/best-practice/provision/github.repo/resources.ts

@@ -5,6 +5,7 @@ import {
   DeclaredGithubEnvironment,
   DeclaredGithubRepo,
   DeclaredGithubRepoConfig,
+  DeclaredGithubTeamRepoAccess,
   getDeclastructGithubProvider,
 } from 'declastruct-github';
 import { type DomainEntity, RefByUnique } from 'domain-objects';
@@ -126,6 +127,13 @@ export const getResources = async (): Promise<DomainEntity<any>[]> => {
     restrictions: null,
   });
 
+  // grant releasers team access to the repo (required before they can be environment reviewers)
+  const teamReleasersAccess = DeclaredGithubTeamRepoAccess.as({
+    team: { org: { login: '@declapract{variable.organizationName}' }, slug: 'releasers' },
+    repo,
+    permission: 'push', // write access needed to deploy
+  });
+
   // declare environment for production deployments from main (auto-approved)
   const envProductionOnMain = DeclaredGithubEnvironment.as({
     repo,
@@ -151,6 +159,7 @@ export const getResources = async (): Promise<DomainEntity<any>[]> => {
     repo,
     repoConfig,
     branchMainProtection,
+    teamReleasersAccess, // must come before environments that reference this team
     envProductionOnMain,
     envProductionOnElse,
   ];

package/dist/practices/rhachet/best-practice/package.json

@@ -6,7 +6,8 @@
     "rhachet-brains-xai": "@declapract{check.minVersion('0.3.3')}",
     "rhachet-roles-bhrain": "@declapract{check.minVersion('0.29.0')}",
     "rhachet-roles-bhuild": "@declapract{check.minVersion('0.21.15')}",
-    "rhachet-roles-ehmpathy": "@declapract{check.minVersion('1.35.12')}"
+    "rhachet-roles-ehmpathy": "@declapract{check.minVersion('1.35.12')}",
+    "rhachet-roles-rhachet": "@declapract{check.minVersion('0.1.7')}"
   },
   "scripts": {
     "prepare:rhachet": "rhachet init --keys --hooks --roles mechanic behaver driver reviewer librarian ergonomist architect dispatcher",

package/dist/useCases.yml

@@ -19,6 +19,7 @@ use-cases:
       - tests
       - typescript
       - pnpm
+      - bottleneck
   npm-package:
     extends:
       - typescript-project
@@ -39,7 +40,7 @@ use-cases:
       - environments-aws
       - lambda-clients
       - lambda-handlers
-      - logging
+      - logs
       - node-service
       - runtime-type-checking
       - serverless

package/package.json

@@ -2,7 +2,7 @@
   "name": "declapract-typescript-ehmpathy",
   "author": "ehmpathy",
   "description": "declapract best practices declarations for typescript",
-  "version": "0.48.2",
+  "version": "0.48.4",
   "license": "MIT",
   "main": "src/index.js",
   "repository": "ehmpathy/declapract-typescript-ehmpathy",
@@ -47,10 +47,10 @@
     "prepare": "if [ -e .git ] && [ -z \"${CI:-}\" ]; then npm run prepare:husky && npm run prepare:rhachet; fi"
   },
   "dependencies": {
-    "domain-objects": "0.31.9",
+    "domain-objects": "0.31.13",
     "expect": "29.4.2",
     "flat": "5.0.2",
-    "helpful-errors": "1.5.3",
+    "helpful-errors": "1.7.3",
     "test-fns": "1.15.7",
     "yaml": "2.8.2"
   },

package/readme.md

@@ -123,7 +123,7 @@ React Native mobile apps with Expo
 - **lambda-handlers** - Standard Lambda function structure
 - **lambda-clients** - Type-safe Lambda client wrappers
 - **config** - Environment configuration with AWS Parameter Store
-- **logs** - Structured logging with `simple-log-methods`
+- **logs** - Structured logging with `sdk-logs`
 - **uuid** - UUID generation standards
 - etc
 

package/dist/practices/logging/best-practice/package.json

@@ -1,5 +0,0 @@
-{
-  "dependencies": {
-    "simple-log-methods": "@declapract{check.minVersion('0.5.0')}"
-  }
-}

package/dist/practices/logging/best-practice/src/utils/logger.ts

@@ -1,3 +0,0 @@
-import { generateLogMethods } from 'simple-log-methods';
-
-export const log = generateLogMethods();