declapract-typescript-ehmpathy 0.47.9 → 0.47.10

package/dist/practices/tests/bad-practices/old-acceptance-dir-location/.declapract.readme.md

@@ -0,0 +1,22 @@
+# old-acceptance-dir-location
+
+## .what
+
+detects test files located in `acceptance/` directory and migrates them to `blackbox/`.
+
+## .why
+
+the term "blackbox" makes the testing philosophy explicit:
+- blackbox tests interact only through public contracts (APIs, CLIs, SDKs)
+- no access to internal implementation details
+- tests validate behavior from the caller's perspective
+
+the rename from `acceptance/` to `blackbox/` clarifies this intent.
+
+## .fix
+
+moves all files from `acceptance/` to `blackbox/` while preserving the directory structure.
+
+## .note
+
+the `.acceptance.test.ts` file extension is preserved — it communicates the test type while the directory name communicates the testing philosophy.

package/dist/practices/tests/bad-practices/old-acceptance-dir-location/acceptance/<star><star>/<star>.acceptance.test.ts.declapract.ts

@@ -0,0 +1,19 @@
+import { FileCheckType, type FileFixFunction } from 'declapract';
+
+export const check = FileCheckType.EXISTS; // if files exist in acceptance/, flag as bad practice
+
+/**
+ * .what = moves acceptance test files from acceptance/ to blackbox/
+ * .why = blackbox/ naming makes the testing philosophy explicit
+ */
+export const fix: FileFixFunction = (contents, context) => {
+  // move from acceptance/ to blackbox/
+  const newPath = context.relativeFilePath.replace(
+    /^acceptance\//,
+    'blackbox/',
+  );
+  return {
+    contents: contents ?? null,
+    relativeFilePath: newPath,
+  };
+};

package/dist/practices/tests/bad-practices/old-acceptance-dir-location/acceptance/<star><star>/<star>.ts.declapract.ts

@@ -0,0 +1,19 @@
+import { FileCheckType, type FileFixFunction } from 'declapract';
+
+export const check = FileCheckType.EXISTS; // if any ts files exist in acceptance/, flag as bad practice
+
+/**
+ * .what = moves ts files from acceptance/ to blackbox/
+ * .why = blackbox/ naming makes the testing philosophy explicit
+ */
+export const fix: FileFixFunction = (contents, context) => {
+  // move from acceptance/ to blackbox/
+  const newPath = context.relativeFilePath.replace(
+    /^acceptance\//,
+    'blackbox/',
+  );
+  return {
+    contents: contents ?? null,
+    relativeFilePath: newPath,
+  };
+};

package/dist/practices/tests/bad-practices/old-acceptance-import-paths/.declapract.readme.md

@@ -0,0 +1,31 @@
+# old-acceptance-import-paths
+
+## .what
+
+detects import statements that reference the old `acceptance/` directory path.
+
+## .why
+
+the `acceptance/` directory has been renamed to `blackbox/` to make the testing philosophy explicit:
+- blackbox tests interact only through public contracts
+- no access to internal implementation details
+
+import paths must be updated to reference `blackbox/` instead of `acceptance/`.
+
+## .fix
+
+replaces all occurrences of `acceptance/` with `blackbox/` in import paths.
+
+## .examples
+
+before:
+```typescript
+import { locally } from '../acceptance/environment';
+import { stage } from '../../acceptance/utils/environment';
+```
+
+after:
+```typescript
+import { locally } from '../blackbox/environment';
+import { stage } from '../../blackbox/utils/environment';
+```

package/dist/practices/tests/bad-practices/old-acceptance-import-paths/<star><star>/<star>.ts.declapract.ts

@@ -0,0 +1,25 @@
+import type { FileCheckFunction, FileFixFunction } from 'declapract';
+
+/**
+ * .what = detects imports that reference acceptance/ directory
+ * .why = acceptance/ has been renamed to blackbox/
+ */
+export const check: FileCheckFunction = (contents) => {
+  // match imports that reference acceptance/ directory
+  if (contents?.match(/from ['"]\.\.?\/.*acceptance\//)) return; // matches bad practice
+  if (contents?.match(/from ['"]acceptance\//)) return; // matches bad practice
+  throw new Error('does not match bad practice');
+};
+
+/**
+ * .what = replaces acceptance/ with blackbox/ in import paths
+ * .why = blackbox/ naming makes the testing philosophy explicit
+ */
+export const fix: FileFixFunction = (contents) => {
+  if (!contents) return {};
+  return {
+    contents: contents
+      .replace(/(['"])(.*)\/acceptance\//g, '$1$2/blackbox/')
+      .replace(/(['"])acceptance\//g, '$1blackbox/'),
+  };
+};

package/dist/practices/tests/bad-practices/old-test-utils-and-assets-location/.declapract.readme.md

@@ -5,4 +5,4 @@ the `.test.utils/` directory replaces `__test_utils__` and `.test.assets/` repla
 examples:
 - `src/domain/__test_utils__/exampleUser.ts` → `src/domain/.test.utils/exampleUser.ts`
 - `src/logic/__test_assets__/fixtures.json` → `src/logic/.test.assets/fixtures.json`
-- `acceptance/__test_utils__/environment.ts` → `acceptance/.test.utils/environment.ts`
+- `blackbox/__test_utils__/environment.ts` → `blackbox/.test.utils/environment.ts`

package/package.json

@@ -2,7 +2,7 @@
   "name": "declapract-typescript-ehmpathy",
   "author": "ehmpathy",
   "description": "declapract best practices declarations for typescript",
-  "version": "0.47.9",
+  "version": "0.47.10",
   "license": "MIT",
   "main": "src/index.js",
   "repository": "ehmpathy/declapract-typescript-ehmpathy",