declapract-typescript-ehmpathy 0.47.71 → 0.47.73

package/dist/practices/environments/bad-practices/old-stage-enum/src/<star><star>/<star>.ts.declapract.ts

@@ -17,7 +17,7 @@ export const check: FileCheckFunction = (contents) => {
 export const fix: FileFixFunction = (contents) => {
   if (!contents) return { contents };
 
-  let fixed = contents
+  const fixed = contents
     // replace enum values with string literals
     .replace(/Stage\.PRODUCTION/g, "'prod'")
     .replace(/Stage\.DEVELOPMENT/g, "'prep'")

package/dist/practices/lint/best-practice/package.json

@@ -10,7 +10,7 @@
     "test:format:biome": "biome format",
     "test:lint:biome": "biome check --diagnostic-level=error",
     "test:lint:biome:all": "biome check",
-    "test:lint:cycles": "dpdm --no-warning --no-tree --exit-code circular:1 --exclude \"$(yq -r '.exclude | if length > 0 then join(\"|\") else \"^$\" end' .dpdmrc.yaml)\" 'src/**/*.ts'",
+    "test:lint:cycles": "dpdm --no-warning --no-tree --exit-code circular:1 --exclude \"$(yq -r '.exclude | join(\"|\") // \"^$\"' .dpdmrc.yaml)\" 'src/**/*.ts'",
     "test:lint:deps": "npx depcheck -c ./.depcheckrc.yml",
     "test:lint": "npm run test:lint:biome && npm run test:lint:cycles && npm run test:lint:deps"
   }

package/dist/practices/provision-github/bad-practices/deprecated-reviewers-variable/declapract.use.yml.declapract.ts

@@ -0,0 +1,41 @@
+import type { FileCheckFunction, FileFixFunction } from 'declapract';
+import yaml from 'yaml';
+
+/**
+ * .what = removes deprecated reviewers.users variable from declapract.use.yml
+ * .why = production-on-else environment now uses team:releaser instead of user list
+ */
+
+export const check: FileCheckFunction = (contents) => {
+  if (!contents) throw new Error('no file found');
+
+  const parsed = yaml.parse(contents) as {
+    variables?: Record<string, unknown>;
+  };
+  const variables = parsed?.variables ?? {};
+
+  // check if reviewers or reviewers.users exists
+  if ('reviewers' in variables) return; // bad practice detected
+
+  throw new Error('no deprecated reviewers variable found');
+};
+
+export const fix: FileFixFunction = (contents) => {
+  if (!contents) return { contents };
+
+  // parse with parseDocument to preserve comments and format
+  const doc = yaml.parseDocument(contents);
+  const parsed = doc.toJSON() as { variables?: Record<string, unknown> };
+
+  if (!parsed?.variables || !('reviewers' in parsed.variables)) {
+    return { contents };
+  }
+
+  // remove the reviewers key from variables
+  const variablesNode = doc.get('variables') as yaml.YAMLMap | undefined;
+  if (variablesNode) {
+    variablesNode.delete('reviewers');
+  }
+
+  return { contents: doc.toString() };
+};

package/dist/practices/provision-github/best-practice/provision/github.repo/resources.ts

@@ -10,7 +10,13 @@ import {
 import { type DomainEntity, RefByUnique } from 'domain-objects';
 import { UnexpectedCodePathError } from 'helpful-errors';
 
-import pkg from '../../package.json';
+import pkgJson from '../../package.json';
+
+const pkg = pkgJson as {
+  description?: string;
+  private?: boolean;
+  homepage?: string;
+};
 
 export const getProviders = async (): Promise<DeclastructProvider[]> => [
   getDeclastructGithubProvider(
@@ -134,7 +140,7 @@ export const getResources = async (): Promise<DomainEntity<any>[]> => {
   const envProductionOnElse = DeclaredGithubEnvironment.as({
     repo,
     name: 'production-on-else',
-    reviewers: { users: @declapract{variable.reviewers.users}, teams: null },
+    reviewers: { users: null, teams: ['releasers'] },
     waitTimer: null, // no delay once approved
     deploymentBranchPolicy: null, // any branch
     preventSelfReview: false, // self-approval allowed if in reviewers list

package/package.json

@@ -2,7 +2,7 @@
   "name": "declapract-typescript-ehmpathy",
   "author": "ehmpathy",
   "description": "declapract best practices declarations for typescript",
-  "version": "0.47.71",
+  "version": "0.47.73",
   "license": "MIT",
   "main": "src/index.js",
   "repository": "ehmpathy/declapract-typescript-ehmpathy",