declapract-typescript-ehmpathy 0.47.65 → 0.47.67

package/dist/getVariables.ts

@@ -3,6 +3,7 @@ import { createGetVariables } from 'declapract';
 export const getProjectVariables = createGetVariables({
   organizationName: 'awesum',
   projectName: 'svc-awesome-thing',
+  reviewers: { users: ['user1', 'user2'] },
 });
 
 export const getServiceVariables = createGetVariables({

package/dist/practices/cicd-service/best-practice/package.json

@@ -1,7 +1,7 @@
 {
   "devDependencies": {
-    "declastruct": "@declapract{check.minVersion('1.7.3')}",
-    "declastruct-aws": "@declapract{check.minVersion('1.4.3')}",
+    "declastruct": "@declapract{check.minVersion('1.9.1')}",
+    "declastruct-aws": "@declapract{check.minVersion('1.5.0')}",
     "declastruct-unix-network": "@declapract{check.minVersion('1.0.5')}"
   }
 }

package/dist/practices/directory-structure-src/bad-practices/domain-dir/src/<star><star>/domain/<star><star>/<star>.declapract.ts

@@ -10,11 +10,37 @@ export const fix: FileFixFunction = (contents, context) => {
     .replace(/\/domain\/objects\//g, '/domain.objects/')
     .replace(/\/domain\//g, '/domain.objects/');
 
+  let fixedContents = contents;
+
+  // fix relative imports for files DIRECTLY in domain/objects/ that move to domain.objects/
+  // these files move UP one directory level, so reduce ../ by one
+  // note: nested files (domain/objects/nested/Deep.ts) stay at same depth, no transform
+  const isDirectChildOfDomainObjects = /\/domain\/objects\/[^/]+$/.test(
+    context.relativeFilePath,
+  );
+  if (fixedContents && isDirectChildOfDomainObjects) {
+    fixedContents = fixedContents.replace(
+      /((?:import|export)[^'"]*['"])((?:\.\.\/)+)/g,
+      (match, importPrefix, dotDots) => {
+        const count = dotDots.split('../').length - 1;
+        if (count === 1) {
+          // '../X' → './X'
+          return `${importPrefix}./`;
+        }
+        // '../../X' → '../X', '../../../X' → '../../X', etc.
+        return `${importPrefix}${'../'.repeat(count - 1)}`;
+      },
+    );
+  }
+
   // fix internal export paths in index files
   // when domain/index.ts moves to domain.objects/index.ts,
   // exports like './objects/User' should become './User'
-  let fixedContents = contents;
-  if (fixedContents && context.relativeFilePath.includes('/domain/index.ts')) {
+  if (
+    fixedContents &&
+    context.relativeFilePath.includes('/domain/') &&
+    context.relativeFilePath.endsWith('/index.ts')
+  ) {
     fixedContents = fixedContents
       // export * from './objects' → remove (objects dir flattened to root)
       .replace(/export\s+\*\s+from\s+['"]\.\/objects['"];?\n?/g, '')

package/dist/practices/provision-github/best-practice/package.json

@@ -1,6 +1,6 @@
 {
   "devDependencies": {
-    "declastruct": "@declapract{check.minVersion('1.7.3')}",
-    "declastruct-github": "@declapract{check.minVersion('1.3.5')}"
+    "declastruct": "@declapract{check.minVersion('1.9.1')}",
+    "declastruct-github": "@declapract{check.minVersion('1.4.0')}"
   }
 }

package/dist/practices/provision-github/best-practice/provision/github.repo/resources.ts

@@ -2,6 +2,7 @@ import type { DeclastructProvider } from 'declastruct';
 import {
   type DeclaredGithubBranch,
   DeclaredGithubBranchProtection,
+  DeclaredGithubEnvironment,
   DeclaredGithubRepo,
   DeclaredGithubRepoConfig,
   getDeclastructGithubProvider,
@@ -119,6 +120,32 @@ export const getResources = async (): Promise<DomainEntity<any>[]> => {
     restrictions: null,
   });
 
+  // declare environment for production deployments from main (auto-approved)
+  const envProductionOnMain = DeclaredGithubEnvironment.as({
+    repo,
+    name: 'production-on-main',
+    reviewers: null, // no approval required — PR merge is the gate
+    waitTimer: null, // no delay
+    deploymentBranchPolicy: { customBranches: ['main'] }, // only main branch
+    preventSelfReview: false,
+  });
+
+  // declare environment for production deployments from other branches (requires approval)
+  const envProductionOnElse = DeclaredGithubEnvironment.as({
+    repo,
+    name: 'production-on-else',
+    reviewers: { users: @declapract{variable.reviewers.users}, teams: null },
+    waitTimer: null, // no delay once approved
+    deploymentBranchPolicy: null, // any branch
+    preventSelfReview: false, // self-approval allowed if in reviewers list
+  });
+
   // and return the full set
-  return [repo, repoConfig, branchMainProtection];
+  return [
+    repo,
+    repoConfig,
+    branchMainProtection,
+    envProductionOnMain,
+    envProductionOnElse,
+  ];
 };

package/package.json

@@ -2,7 +2,7 @@
   "name": "declapract-typescript-ehmpathy",
   "author": "ehmpathy",
   "description": "declapract best practices declarations for typescript",
-  "version": "0.47.65",
+  "version": "0.47.67",
   "license": "MIT",
   "main": "src/index.js",
   "repository": "ehmpathy/declapract-typescript-ehmpathy",
@@ -69,8 +69,8 @@
     "@types/jest": "30.0.0",
     "@types/node": "22.15.21",
     "cz-conventional-changelog": "3.3.0",
-    "declastruct": "1.7.0",
-    "declastruct-github": "1.0.7",
+    "declastruct": "1.9.1",
+    "declastruct-github": "1.4.0",
     "depcheck": "1.4.3",
     "esbuild-register": "3.6.0",
     "husky": "8.0.3",