declapract-typescript-ehmpathy 0.47.53 → 0.47.55

package/dist/.test/infra/withApikeysContext.ts

@@ -1,6 +1,6 @@
-import fs from 'fs';
+import fs from 'node:fs';
 import os from 'os';
-import path from 'path';
+import path from 'node:path';
 
 /**
  * .what = creates a mock context with apikeys config in a temp directory

package/dist/practices/cicd-common/best-practice/.agent/repo=.this/role=any/skills/use.apikeys.sh.declapract.ts

@@ -1,6 +1,7 @@
 import { FileCheckType, type FileFixFunction } from 'declapract';
-import { readFileSync } from 'fs';
-import { dirname, join } from 'path';
+
+import { readFileSync } from 'node:fs';
+import { dirname, join } from 'node:path';
 
 // check that the file contains the core structure
 export const check = FileCheckType.CONTAINS;

package/dist/practices/directory-structure-src/bad-practices/domain-dir/src/<star><star>/domain/<star><star>/<star>.declapract.ts

@@ -10,8 +10,24 @@ export const fix: FileFixFunction = (contents, context) => {
     .replace(/\/domain\/objects\//g, '/domain.objects/')
     .replace(/\/domain\//g, '/domain.objects/');
 
+  // fix internal export paths in index files
+  // when domain/index.ts moves to domain.objects/index.ts,
+  // exports like './objects/User' should become './User'
+  let fixedContents = contents;
+  if (fixedContents && context.relativeFilePath.includes('/domain/index.ts')) {
+    fixedContents = fixedContents
+      // export * from './objects' → remove (objects dir flattened to root)
+      .replace(/export\s+\*\s+from\s+['"]\.\/objects['"];?\n?/g, '')
+      // ./objects/Foo → ./Foo
+      .replace(/(['"])\.\/objects\//g, '$1./')
+      // ../domain/objects/Foo → ../domain.objects/Foo (for cross-references)
+      .replace(/(['"])([^'"]*?)\/domain\/objects\//g, '$1$2/domain.objects/')
+      // ../domain/Foo → ../domain.objects/Foo
+      .replace(/(['"])([^'"]*?)\/domain\//g, '$1$2/domain.objects/');
+  }
+
   return {
-    contents: contents ?? null,
+    contents: fixedContents ?? null,
     relativeFilePath: newPath,
   };
 };

package/dist/practices/directory-structure-src/bad-practices/old-import-paths/src/<star><star>/<star>.ts.declapract.ts

@@ -11,6 +11,7 @@ const OLD_PATH_PATTERNS = [
   /from\s+['"][^'"]*\/model\/domainObjects/,
   /from\s+['"][^'"]*\/model\//,
   /from\s+['"][^'"]*\/services\//,
+  /from\s+['"][^'"]*\/__nonpublished_modules__\//,
 ];
 
 export const check: FileCheckFunction = (contents) => {
@@ -43,7 +44,12 @@ export const fix: FileFixFunction = (contents) => {
     .replace(/(['"])([^'"]*?)\/model\/domainObjects\b/g, '$1$2/domain.objects')
     .replace(/(['"])([^'"]*?)\/model\//g, '$1$2/domain.objects/')
     // services layer fixes (services = business logic, not service clients)
-    .replace(/(['"])([^'"]*?)\/services\//g, '$1$2/domain.operations/');
+    .replace(/(['"])([^'"]*?)\/services\//g, '$1$2/domain.operations/')
+    // nonpublished modules dir fix
+    .replace(
+      /(['"])([^'"]*?)\/__nonpublished_modules__\//g,
+      '$1$2/_topublish/',
+    );
 
   return { contents: fixed };
 };

package/dist/practices/tests/bad-practices/old-acceptance-dir-location/.declapract.integration.test.ts

@@ -1,5 +1,5 @@
 import fs from 'fs/promises';
-import path from 'path';
+import path from 'node:path';
 
 import { executeApply } from 'declapract';
 import { genTempDir, given, then, useThen, when } from 'test-fns';

package/dist/practices/tests/best-practice/jest.acceptance.env.ts

@@ -1,8 +1,9 @@
-import { existsSync, readFileSync } from 'fs';
-import { join } from 'path';
-import util from 'util';
+import { existsSync, readFileSync } from 'node:fs';
+import { join } from 'node:path';
+import util from 'node:util';
+
+import { jest } from '@jest/globals';
 
-// eslint-disable-next-line no-undef
 jest.setTimeout(90000); // we're calling downstream apis
 
 // set console.log to not truncate nested objects

package/dist/practices/tests/best-practice/jest.integration.env.ts

@@ -1,9 +1,10 @@
-import { execSync } from 'child_process';
-import { existsSync, readFileSync } from 'fs';
-import { join } from 'path';
-import util from 'util';
+import { execSync } from 'node:child_process';
+import { existsSync, readFileSync } from 'node:fs';
+import { join } from 'node:path';
+import util from 'node:util';
+
+import { jest } from '@jest/globals';
 
-// eslint-disable-next-line no-undef
 jest.setTimeout(90000); // since we're calling downstream apis
 
 // set console.log to not truncate nested objects

package/dist/practices/tests/best-practice/jest.unit.env.ts

@@ -1,6 +1,8 @@
-import { existsSync } from 'fs';
-import { join } from 'path';
-import util from 'util';
+import { existsSync } from 'node:fs';
+import { join } from 'node:path';
+import util from 'node:util';
+
+import { jest } from '@jest/globals';
 
 // mock that getConfig just returns plaintext test env config in unit tests
 jest.mock('./src/utils/config/getConfig', () => ({

package/dist/practices/uuid/bad-practices/npm-uuidv4/src/<star><star>/<star>.ts.declapract.ts

@@ -0,0 +1,39 @@
+import type { FileCheckFunction, FileFixFunction } from 'declapract';
+
+/**
+ * .what = detects and fixes uuidv4 imports to use uuid-fns instead
+ * .why = uuidv4 package is deprecated, uuid-fns provides same functionality with different export name
+ */
+
+// pattern to detect uuidv4 imports
+const UUIDV4_IMPORT_PATTERN = /from\s+['"]uuidv4['"]/;
+
+export const check: FileCheckFunction = (contents) => {
+  if (!contents) throw new Error('no contents');
+
+  // check if file imports from uuidv4
+  if (UUIDV4_IMPORT_PATTERN.test(contents)) return; // matches bad practice
+
+  throw new Error('does not match bad practice');
+};
+
+export const fix: FileFixFunction = (contents) => {
+  if (!contents) return { contents };
+
+  // replace uuidv4 import with uuid-fns, alias getUuid as uuid to minimize code changes
+  const fixed = contents
+    // handle: import { uuid } from 'uuidv4' → import { getUuid as uuid } from 'uuid-fns'
+    .replace(
+      /import\s*\{\s*uuid\s*\}\s*from\s*['"]uuidv4['"]/g,
+      "import { getUuid as uuid } from 'uuid-fns'",
+    )
+    // handle: import { uuid as X } from 'uuidv4' → import { getUuid as X } from 'uuid-fns'
+    .replace(
+      /import\s*\{\s*uuid\s+as\s+(\w+)\s*\}\s*from\s*['"]uuidv4['"]/g,
+      "import { getUuid as $1 } from 'uuid-fns'",
+    )
+    // handle other uuidv4 imports (e.g., default import)
+    .replace(/from\s*['"]uuidv4['"]/g, "from 'uuid-fns'");
+
+  return { contents: fixed };
+};

package/dist/utils/readFile.ts

@@ -1,5 +1,5 @@
-import fs from 'fs';
-import util from 'util';
+import fs from 'node:fs';
+import util from 'node:util';
 
 export const readFile = async (filePath: string): Promise<string> =>
   util.promisify(fs.readFile)(filePath, 'utf-8');

package/dist/utils/readUseApikeysConfig.ts

@@ -1,6 +1,6 @@
-import fs from 'fs';
-import path from 'path';
-import util from 'util';
+import fs from 'node:fs';
+import path from 'node:path';
+import util from 'node:util';
 
 /**
  * .what = configuration structure for use.apikeys.json

package/package.json

@@ -2,7 +2,7 @@
   "name": "declapract-typescript-ehmpathy",
   "author": "ehmpathy",
   "description": "declapract best practices declarations for typescript",
-  "version": "0.47.53",
+  "version": "0.47.55",
   "license": "MIT",
   "main": "src/index.js",
   "repository": "ehmpathy/declapract-typescript-ehmpathy",