declapract-typescript-ehmpathy 0.47.47 → 0.47.49

package/dist/practices/cicd-common/best-practice/.github/workflows/.test.yml

@@ -220,12 +220,14 @@ jobs:
       - name: test:integration (explicit ${{ matrix.shard.index }})
         if: matrix.shard.type == 'explicit'
         run: |
+          set -eu
           patterns='${{ join(matrix.shard.patterns, '|') }}'
           THOROUGH=true npm run test:integration -- --testPathPatterns="$patterns" --json --outputFile=jest-results.json
 
       - name: test:integration (dynamic ${{ matrix.shard.shard }}/${{ matrix.shard.total }})
         if: matrix.shard.type == 'dynamic'
         run: |
+          set -eu
           exclude='${{ needs.enshard.outputs.integration-patterns }}'
           if [[ -n "$exclude" ]]; then
             THOROUGH=true npm run test:integration -- --testPathIgnorePatterns="$exclude" --shard=${{ matrix.shard.shard }}/${{ matrix.shard.total }} --json --outputFile=jest-results.json
@@ -236,6 +238,7 @@ jobs:
       - name: report slow tests
         if: always() && hashFiles('jest-results.json') != ''
         run: |
+          set -eu
           jq -r '.testResults[] | "\(.name):\(.perfStats.runtime)"' jest-results.json | while IFS=: read -r name runtime; do
             seconds=$((runtime / 1000))
             if [[ $seconds -ge 30 ]]; then
@@ -286,12 +289,14 @@ jobs:
       - name: test:acceptance (explicit ${{ matrix.shard.index }})
         if: matrix.shard.type == 'explicit'
         run: |
+          set -eu
           patterns='${{ join(matrix.shard.patterns, '|') }}'
           THOROUGH=true npm run test:acceptance -- --testPathPatterns="$patterns" --json --outputFile=jest-results.json
 
       - name: test:acceptance (dynamic ${{ matrix.shard.shard }}/${{ matrix.shard.total }})
         if: matrix.shard.type == 'dynamic'
         run: |
+          set -eu
           exclude='${{ needs.enshard.outputs.acceptance-patterns }}'
           if [[ -n "$exclude" ]]; then
             THOROUGH=true npm run test:acceptance -- --testPathIgnorePatterns="$exclude" --shard=${{ matrix.shard.shard }}/${{ matrix.shard.total }} --json --outputFile=jest-results.json
@@ -302,6 +307,7 @@ jobs:
       - name: report slow tests
         if: always() && hashFiles('jest-results.json') != ''
         run: |
+          set -eu
           jq -r '.testResults[] | "\(.name):\(.perfStats.runtime)"' jest-results.json | while IFS=: read -r name runtime; do
             seconds=$((runtime / 1000))
             if [[ $seconds -ge 30 ]]; then
@@ -319,6 +325,7 @@ jobs:
     steps:
       - name: report shard results
         run: |
+          set -eu
           if [[ "${{ needs.test-shards-integration.result }}" == "success" ]]; then
             echo "👌 all integration test shards passed"
           else
@@ -334,6 +341,7 @@ jobs:
     steps:
       - name: report shard results
         run: |
+          set -eu
           if [[ "${{ needs.test-shards-acceptance.result }}" == "success" ]]; then
             echo "👌 all acceptance test shards passed"
           else

package/dist/practices/directory-structure-src/bad-practices/data-dir/src/<star><star>/data/<star><star>/<star>.declapract.ts

@@ -0,0 +1,19 @@
+import { FileCheckType, type FileFixFunction } from 'declapract';
+
+// if files exist in any /data/, this is a bad practice
+export const check = FileCheckType.EXISTS;
+
+export const fix: FileFixFunction = (contents, context) => {
+  // move any /data/dao/* to /access/daos/*
+  // move any /data/clients/* to /access/sdks/*
+  // move other /data/* to /access/*
+  const newPath = context.relativeFilePath
+    .replace(/\/data\/dao\//g, '/access/daos/')
+    .replace(/\/data\/clients\//g, '/access/sdks/')
+    .replace(/\/data\//g, '/access/');
+
+  return {
+    contents: contents ?? null,
+    relativeFilePath: newPath,
+  };
+};

package/dist/practices/directory-structure-src/bad-practices/domain-dir/src/<star><star>/domain/<star><star>/<star>.declapract.ts

@@ -0,0 +1,17 @@
+import { FileCheckType, type FileFixFunction } from 'declapract';
+
+// if files exist in any /domain/, this is a bad practice
+export const check = FileCheckType.EXISTS;
+
+export const fix: FileFixFunction = (contents, context) => {
+  // move any /domain/objects/* to /domain.objects/*
+  // move any /domain/* to /domain.objects/*
+  const newPath = context.relativeFilePath
+    .replace(/\/domain\/objects\//g, '/domain.objects/')
+    .replace(/\/domain\//g, '/domain.objects/');
+
+  return {
+    contents: contents ?? null,
+    relativeFilePath: newPath,
+  };
+};

package/dist/practices/directory-structure-src/bad-practices/logic-dir/src/{logic → <star><star>/logic}/<star><star>/<star>.declapract.ts

@@ -3,13 +3,13 @@ import { FileCheckType, type FileFixFunction } from 'declapract';
 export const check = FileCheckType.EXISTS;
 
 /**
- * .what = moves any file from src/logic/ to src/domain.operations/
+ * .what = moves any file from any /logic/ to /domain.operations/
  * .why = ensures all files are moved, not just .ts files — prevents silent data loss for hidden paths
  */
 export const fix: FileFixFunction = (contents, context) => {
   const newPath = context.relativeFilePath.replace(
-    'src/logic/',
-    'src/domain.operations/',
+    /\/logic\//g,
+    '/domain.operations/',
   );
 
   return {

package/dist/practices/directory-structure-src/bad-practices/model-dir/src/{model/<star><star>/<star>.ts.declapract.ts → <star><star>/model/<star><star>/<star>.declapract.ts}

@@ -10,7 +10,7 @@ export const fix: FileFixFunction = (contents, context) => {
         "export * from './';",
       ) ?? null,
     relativeFilePath: context.relativeFilePath
-      .replace('src/model/domainObjects/', 'src/domain.objects/')
-      .replace('src/model/', 'src/domain.objects/'),
+      .replace(/\/model\/domainObjects\//g, '/domain.objects/')
+      .replace(/\/model\//g, '/domain.objects/'),
   };
 };

package/dist/practices/directory-structure-src/bad-practices/nonpublished-modules-dir/src/__nonpublished_modules__/<star><star>/<star>.declapract.ts

@@ -0,0 +1,17 @@
+import { FileCheckType, type FileFixFunction } from 'declapract';
+
+// if files exist in __nonpublished_modules__/, this is a bad practice
+export const check = FileCheckType.EXISTS;
+
+export const fix: FileFixFunction = (contents, context) => {
+  // move any /__nonpublished_modules__/ to /_topublish/
+  const newPath = context.relativeFilePath.replace(
+    /__nonpublished_modules__\//g,
+    '_topublish/',
+  );
+
+  return {
+    contents: contents ?? null,
+    relativeFilePath: newPath,
+  };
+};

package/dist/practices/directory-structure-src/bad-practices/old-import-paths/src/<star><star>/<star>.ts.declapract.ts

@@ -8,6 +8,9 @@ const OLD_PATH_PATTERNS = [
   /from\s+['"][^'"]*\/domain\/objects/,
   /from\s+['"][^'"]*\/domain\//,
   /from\s+['"][^'"]*\/logic\//,
+  /from\s+['"][^'"]*\/model\/domainObjects/,
+  /from\s+['"][^'"]*\/model\//,
+  /from\s+['"][^'"]*\/services\//,
 ];
 
 export const check: FileCheckFunction = (contents) => {
@@ -35,7 +38,12 @@ export const fix: FileFixFunction = (contents) => {
     .replace(/(['"])([^'"]*?)\/domain\/objects\b/g, '$1$2/domain.objects')
     .replace(/(['"])([^'"]*?)\/domain\//g, '$1$2/domain.objects/')
     // logic layer fixes
-    .replace(/(['"])([^'"]*?)\/logic\//g, '$1$2/domain.operations/');
+    .replace(/(['"])([^'"]*?)\/logic\//g, '$1$2/domain.operations/')
+    // model layer fixes (old structure before domain.objects)
+    .replace(/(['"])([^'"]*?)\/model\/domainObjects\b/g, '$1$2/domain.objects')
+    .replace(/(['"])([^'"]*?)\/model\//g, '$1$2/domain.objects/')
+    // services layer fixes (services = business logic, not service clients)
+    .replace(/(['"])([^'"]*?)\/services\//g, '$1$2/domain.operations/');
 
   return { contents: fixed };
 };

package/dist/practices/directory-structure-src/bad-practices/services-dir/src/<star><star>/services/<star><star>/<star>.declapract.ts

@@ -0,0 +1,16 @@
+import { FileCheckType, type FileFixFunction } from 'declapract';
+
+export const check = FileCheckType.EXISTS; // if a file exists with this path pattern, then it's bad practice
+
+export const fix: FileFixFunction = (contents, context) => {
+  // move any /services/* to /domain.operations/* (services = business logic)
+  const newPath = context.relativeFilePath.replace(
+    /\/services\//g,
+    '/domain.operations/',
+  );
+
+  return {
+    contents: contents ?? null,
+    relativeFilePath: newPath,
+  };
+};

package/dist/practices/tests/best-practice/package.json

@@ -9,11 +9,11 @@
     "@swc/jest": "@declapract{check.minVersion('0.2.39')}"
   },
   "scripts": {
-    "test:auth": "[ \"$ECHO\" = 'true' ] && echo '. .agent/repo=.this/role=any/skills/use.apikeys.sh' || . .agent/repo=.this/role=any/skills/use.apikeys.sh",
-    "test:unit": "jest -c ./jest.unit.config.ts --forceExit --verbose --passWithNoTests $([ -z $THOROUGH ] && echo '--changedSince=main') $([ -n $RESNAP ] && echo '--updateSnapshot')",
-    "test:integration": "jest -c ./jest.integration.config.ts --forceExit --verbose --passWithNoTests $([ -z $THOROUGH ] && echo '--changedSince=main') $([ -n $RESNAP ] && echo '--updateSnapshot')",
-    "test:acceptance:locally": "npm run build && LOCALLY=true jest -c ./jest.acceptance.config.ts --forceExit --verbose --runInBand --passWithNoTests $([ -n $RESNAP ] && echo '--updateSnapshot')",
-    "test": "eval $(ECHO=true npm run --silent test:auth) && npm run test:commits && npm run test:types && npm run test:format && npm run test:lint && npm run test:unit && npm run test:integration && npm run test:acceptance:locally",
-    "test:acceptance": "npm run build && jest -c ./jest.acceptance.config.ts --forceExit --verbose --runInBand --passWithNoTests $([ -n $RESNAP ] && echo '--updateSnapshot')"
+    "test:auth": "[ \"${ECHO:-}\" = 'true' ] && echo '. .agent/repo=.this/role=any/skills/use.apikeys.sh' || . .agent/repo=.this/role=any/skills/use.apikeys.sh",
+    "test:unit": "set -eu && jest -c ./jest.unit.config.ts --forceExit --verbose --passWithNoTests $([ -n \"${CI:-}\" ] && echo '--ci') $([ -z \"${THOROUGH:-}\" ] && echo '--changedSince=main') $([ -n \"${RESNAP:-}\" ] && echo '--updateSnapshot')",
+    "test:integration": "set -eu && jest -c ./jest.integration.config.ts --forceExit --verbose --passWithNoTests $([ -n \"${CI:-}\" ] && echo '--ci') $([ -z \"${THOROUGH:-}\" ] && echo '--changedSince=main') $([ -n \"${RESNAP:-}\" ] && echo '--updateSnapshot')",
+    "test:acceptance:locally": "set -eu && npm run build && LOCALLY=true jest -c ./jest.acceptance.config.ts --forceExit --verbose --runInBand --passWithNoTests $([ -n \"${RESNAP:-}\" ] && echo '--updateSnapshot')",
+    "test": "set -eu && eval $(ECHO=true npm run --silent test:auth) && npm run test:commits && npm run test:types && npm run test:format && npm run test:lint && npm run test:unit && npm run test:integration && npm run test:acceptance:locally",
+    "test:acceptance": "set -eu && npm run build && jest -c ./jest.acceptance.config.ts --forceExit --verbose --runInBand --passWithNoTests $([ -n \"${CI:-}\" ] && echo '--ci') $([ -n \"${RESNAP:-}\" ] && echo '--updateSnapshot')"
   }
 }

package/package.json

@@ -2,7 +2,7 @@
   "name": "declapract-typescript-ehmpathy",
   "author": "ehmpathy",
   "description": "declapract best practices declarations for typescript",
-  "version": "0.47.47",
+  "version": "0.47.49",
   "license": "MIT",
   "main": "src/index.js",
   "repository": "ehmpathy/declapract-typescript-ehmpathy",
@@ -33,18 +33,18 @@
     "test:lint:biome": "npm run biome:nested:hide && biome check --diagnostic-level=error; EXIT=$?; npm run biome:nested:restore; exit $EXIT",
     "test:lint:biome:all": "npm run biome:nested:hide && biome check; EXIT=$?; npm run biome:nested:restore; exit $EXIT",
     "test:lint": "npm run test:lint:biome && npm run test:lint:deps",
-    "test:unit": "jest -c ./jest.unit.config.ts --forceExit --verbose --passWithNoTests $([ -z $THOROUGH ] && echo '--changedSince=main') $([ -n $RESNAP ] && echo '--updateSnapshot')",
-    "test:integration": "jest -c ./jest.integration.config.ts --forceExit --verbose --passWithNoTests $([ -z $THOROUGH ] && echo '--changedSince=main') $([ -n $RESNAP ] && echo '--updateSnapshot')",
-    "test:acceptance:locally": "npm run build && LOCALLY=true jest -c ./jest.acceptance.config.ts --forceExit --verbose --runInBand --passWithNoTests $([ -n $RESNAP ] && echo '--updateSnapshot')",
-    "test": "npm run test:commits && npm run test:types && npm run test:format && npm run test:lint && npm run test:unit && npm run test:integration && npm run test:acceptance:locally && test:validate",
-    "test:acceptance": "npm run build && jest -c ./jest.acceptance.config.ts --forceExit --verbose --runInBand --passWithNoTests",
+    "test:unit": "set -eu && jest -c ./jest.unit.config.ts --forceExit --verbose --passWithNoTests $([ -n \"${CI:-}\" ] && echo '--ci') $([ -z \"${THOROUGH:-}\" ] && echo '--changedSince=main') $([ -n \"${RESNAP:-}\" ] && echo '--updateSnapshot')",
+    "test:integration": "set -eu && jest -c ./jest.integration.config.ts --forceExit --verbose --passWithNoTests $([ -n \"${CI:-}\" ] && echo '--ci') $([ -z \"${THOROUGH:-}\" ] && echo '--changedSince=main') $([ -n \"${RESNAP:-}\" ] && echo '--updateSnapshot')",
+    "test:acceptance:locally": "set -eu && npm run build && LOCALLY=true jest -c ./jest.acceptance.config.ts --forceExit --verbose --runInBand --passWithNoTests $([ -n \"${RESNAP:-}\" ] && echo '--updateSnapshot')",
+    "test": "set -eu && npm run test:commits && npm run test:types && npm run test:format && npm run test:lint && npm run test:unit && npm run test:integration && npm run test:acceptance:locally && test:validate",
+    "test:acceptance": "set -eu && npm run build && jest -c ./jest.acceptance.config.ts --forceExit --verbose --runInBand --passWithNoTests $([ -n \"${CI:-}\" ] && echo '--ci') $([ -n \"${RESNAP:-}\" ] && echo '--updateSnapshot')",
     "prepush": "npm run test && npm run build",
     "prepublish": "npm run build",
     "preversion": "npm run prepush",
     "postversion": "git push origin HEAD --tags --no-verify",
     "prepare:husky": "husky install && chmod ug+x .husky/*",
     "prepare:rhachet": "npx rhachet init --hooks --roles behaver mechanic reviewer",
-    "prepare": "if [ -e .git ] && [ -z $CI ]; then npm run prepare:husky && npm run prepare:rhachet; fi"
+    "prepare": "if [ -e .git ] && [ -z \"${CI:-}\" ]; then npm run prepare:husky && npm run prepare:rhachet; fi"
   },
   "dependencies": {
     "domain-objects": "0.31.9",
@@ -75,11 +75,11 @@
     "esbuild-register": "3.6.0",
     "husky": "8.0.3",
     "jest": "30.2.0",
-    "rhachet": "1.35.3",
+    "rhachet": "1.37.16",
     "rhachet-brains-anthropic": "0.3.3",
-    "rhachet-roles-bhrain": "0.12.5",
-    "rhachet-roles-bhuild": "0.10.0",
-    "rhachet-roles-ehmpathy": "1.26.5",
+    "rhachet-roles-bhrain": "0.20.0",
+    "rhachet-roles-bhuild": "0.14.2",
+    "rhachet-roles-ehmpathy": "1.27.16",
     "tsc-alias": "1.8.10",
     "tsx": "4.20.6",
     "type-fns": "0.8.1",

package/dist/practices/directory-structure-src/bad-practices/data-dir/src/data/<star><star>/<star>.ts.declapract.ts

@@ -1,19 +0,0 @@
-import { FileCheckType, type FileFixFunction } from 'declapract';
-
-// if files exist in src/data/, this is a bad practice
-export const check = FileCheckType.EXISTS;
-
-export const fix: FileFixFunction = (contents, context) => {
-  // move src/data/dao/* to src/access/daos/*
-  // move src/data/clients/* to src/access/sdks/*
-  // move other src/data/* to src/access/*
-  const newPath = context.relativeFilePath
-    .replace('src/data/dao/', 'src/access/daos/')
-    .replace('src/data/clients/', 'src/access/sdks/')
-    .replace('src/data/', 'src/access/');
-
-  return {
-    contents,
-    relativeFilePath: newPath,
-  };
-};

package/dist/practices/directory-structure-src/bad-practices/domain-dir/src/domain/<star><star>/<star>.ts.declapract.ts

@@ -1,17 +0,0 @@
-import { FileCheckType, type FileFixFunction } from 'declapract';
-
-// if files exist in src/domain/, this is a bad practice
-export const check = FileCheckType.EXISTS;
-
-export const fix: FileFixFunction = (contents, context) => {
-  // move src/domain/objects/* to src/domain.objects/*
-  // move src/domain/* to src/domain.objects/*
-  const newPath = context.relativeFilePath
-    .replace('src/domain/objects/', 'src/domain.objects/')
-    .replace('src/domain/', 'src/domain.objects/');
-
-  return {
-    contents,
-    relativeFilePath: newPath,
-  };
-};

package/dist/practices/directory-structure-src/bad-practices/services-dir/src/services/<star><star>/<star>.ts.declapract.ts

@@ -1,3 +0,0 @@
-import { FileCheckType } from 'declapract';
-
-export const check = FileCheckType.EXISTS; // if a file exists with this path pattern, then it's bad practice