declapract-typescript-ehmpathy 0.47.26 → 0.47.28

package/dist/practices/cicd-common/best-practice/.agent/repo=.this/role=any/skills/use.apikeys.sh

@@ -1,31 +1,36 @@
-#!/usr/bin/env bash
+#!/bin/sh
 ######################################################################
 # .what = export api keys for integration tests
-# .why = enables running integration tests that require api keys
+# .why = enables tests that require api keys to run
 #
 # usage:
-#   source .agent/repo=.this/role=any/skills/use.apikeys.sh
+#   . .agent/repo=.this/role=any/skills/use.apikeys.sh
 #
 # note:
-#   - must be called with `source` to export vars to current shell
+#   - must be called with `.` or `source` to export vars to current shell
 #   - loads from ~/.config/rhachet/apikeys.env if available
 #   - falls back to .env.local (gitignored) in repo root
 ######################################################################
 
-# fail if not sourced
-if [[ "${BASH_SOURCE[0]}" == "${0}" ]]; then
-  echo "error: this script must be sourced, not executed"
-  echo "usage: source ${BASH_SOURCE[0]}"
-  exit 1
-fi
+# fail if not sourced (check if $0 matches this file)
+case "$0" in
+  *use.apikeys.sh)
+    echo "error: this file must be sourced, not executed"
+    echo "usage: source $0"
+    exit 1
+    ;;
+esac
+
+# alias source to `.` for posix compat
+source() { . "$@"; }
 
-# try loading from user config first
-if [[ -f ~/.config/rhachet/apikeys.env ]]; then
+# try to load from user config first
+if [ -f ~/.config/rhachet/apikeys.env ]; then
   source ~/.config/rhachet/apikeys.env
   echo "✓ loaded api keys from ~/.config/rhachet/apikeys.env"
 
 # fallback to local gitignored file
-elif [[ -f .env.local ]]; then
+elif [ -f .env.local ]; then
   source .env.local
   echo "✓ loaded api keys from .env.local"
 
@@ -39,20 +44,21 @@ else
   echo "with contents like:"
   echo "  export OPENAI_API_KEY=sk-..."
   echo "  export ANTHROPIC_API_KEY=sk-..."
-  return 1
+  return 1 2>/dev/null || exit 1
 fi
 
 # read required keys from json config if present
 APIKEYS_CONFIG=".agent/repo=.this/role=any/skills/use.apikeys.json"
-if [[ -f "$APIKEYS_CONFIG" ]]; then
-  # extract required keys using jq
+if [ -f "$APIKEYS_CONFIG" ]; then
+  # extract required keys via jq
   REQUIRED_KEYS=$(jq -r '.apikeys.required[]?' "$APIKEYS_CONFIG" 2>/dev/null)
 
   # verify each required key is set
   for KEY in $REQUIRED_KEYS; do
-    if [[ -z "${!KEY}" ]]; then
+    VALUE=$(eval "echo \"\$$KEY\"")
+    if [ -z "$VALUE" ]; then
       echo "⚠ $KEY not set (required by $APIKEYS_CONFIG)"
-      return 1
+      return 1 2>/dev/null || exit 1
     fi
     echo "✓ $KEY set"
   done

package/dist/practices/cicd-common/best-practice/.github/actions/test-shards-setup/action.yml

@@ -0,0 +1,68 @@
+name: test-shards-setup
+description: generate shard matrix from jest.*.shards.jsonc config
+
+inputs:
+  config-file:
+    description: path to the shards config file (e.g., jest.integration.shards.jsonc)
+    required: true
+  test-type:
+    description: label for notices (e.g., integration, acceptance)
+    required: true
+
+outputs:
+  matrix:
+    description: "JSON array of shard configs for matrix strategy"
+    value: ${{ steps.generate.outputs.matrix }}
+  patterns:
+    description: "pipe-delimited patterns for --testPathIgnorePatterns"
+    value: ${{ steps.generate.outputs.patterns }}
+
+runs:
+  using: composite
+  steps:
+    - name: generate matrix from ${{ inputs.config-file }}
+      id: generate
+      shell: bash
+      run: |
+        config_file="${{ inputs.config-file }}"
+        test_type="${{ inputs.test-type }}"
+
+        # no config = single dynamic shard (backwards compat)
+        if [[ ! -f "$config_file" ]]; then
+          echo "$test_type: no config, default to single shard"
+          echo 'matrix=[{"type":"dynamic","shard":1,"total":1}]' >> $GITHUB_OUTPUT
+          echo 'patterns=' >> $GITHUB_OUTPUT
+          exit 0
+        fi
+
+        # read config (strip comments for jq)
+        config=$(grep -v '^\s*//' "$config_file" | jq -c '.')
+
+        # extract explicit shards
+        explicit=$(echo "$config" | jq -c '.explicit // []')
+        explicit_count=$(echo "$explicit" | jq 'length')
+
+        # extract dynamic shard count
+        dynamic_count=$(echo "$config" | jq '.dynamic.shards // 0')
+
+        # build matrix
+        matrix="[]"
+
+        # add explicit shards
+        for i in $(seq 0 $((explicit_count - 1))); do
+          patterns=$(echo "$explicit" | jq -c ".[$i].patterns")
+          matrix=$(echo "$matrix" | jq -c ". + [{\"type\": \"explicit\", \"index\": $i, \"patterns\": $patterns}]")
+        done
+
+        # add dynamic shards
+        for i in $(seq 1 $dynamic_count); do
+          matrix=$(echo "$matrix" | jq -c ". + [{\"type\": \"dynamic\", \"shard\": $i, \"total\": $dynamic_count}]")
+        done
+
+        # collect all explicit patterns for exclusion
+        explicit_patterns=$(echo "$explicit" | jq -r '.[].patterns[]' 2>/dev/null | paste -sd '|' || echo '')
+
+        echo "matrix=$matrix" >> $GITHUB_OUTPUT
+        echo "patterns=$explicit_patterns" >> $GITHUB_OUTPUT
+
+        echo "$test_type: $(echo "$matrix" | jq 'length') shards"

package/dist/practices/tests/best-practice/package.json

@@ -9,7 +9,7 @@
     "@swc/jest": "@declapract{check.minVersion('0.2.39')}"
   },
   "scripts": {
-    "test:auth": "[ \"$ECHO\" = 'true' ] && echo 'source .agent/repo=.this/role=any/skills/use.apikeys.sh' || bash -c 'source .agent/repo=.this/role=any/skills/use.apikeys.sh'",
+    "test:auth": "[ \"$ECHO\" = 'true' ] && echo '. .agent/repo=.this/role=any/skills/use.apikeys.sh' || . .agent/repo=.this/role=any/skills/use.apikeys.sh",
     "test:unit": "jest -c ./jest.unit.config.ts --forceExit --verbose --passWithNoTests $([ -z $THOROUGH ] && echo '--changedSince=main') $([ -n $RESNAP ] && echo '--updateSnapshot')",
     "test:integration": "jest -c ./jest.integration.config.ts --forceExit --verbose --passWithNoTests $([ -z $THOROUGH ] && echo '--changedSince=main') $([ -n $RESNAP ] && echo '--updateSnapshot')",
     "test:acceptance:locally": "npm run build && LOCALLY=true jest -c ./jest.acceptance.config.ts --forceExit --verbose --runInBand --passWithNoTests $([ -n $RESNAP ] && echo '--updateSnapshot')",

package/package.json

@@ -2,7 +2,7 @@
   "name": "declapract-typescript-ehmpathy",
   "author": "ehmpathy",
   "description": "declapract best practices declarations for typescript",
-  "version": "0.47.26",
+  "version": "0.47.28",
   "license": "MIT",
   "main": "src/index.js",
   "repository": "ehmpathy/declapract-typescript-ehmpathy",