declapract-typescript-ehmpathy 0.47.11 → 0.47.13

package/dist/practices/rhachet/bad-practices/prod-deps/.declapract.readme.md

@@ -0,0 +1,55 @@
+# rhachet prod-deps bad practice
+
+## what
+
+detects `rhachet` and `rhachet-roles-*` packages listed as production dependencies and moves them to devDependencies.
+
+## why
+
+rhachet packages are build-time / development tooling only. they should never be shipped as production dependencies because:
+
+1. **no runtime usage** — rhachet is used for agent role management, skill linking, and development workflows. none of this runs at runtime in production.
+
+2. **bloated bundles** — including rhachet in prod deps unnecessarily inflates `node_modules` for deployed applications.
+
+3. **dependency hygiene** — packages that are only used during development belong in `devDependencies`. at worst, if downstream packages need them, they should be declared as `peerDependencies`.
+
+## packages covered
+
+- `rhachet`
+- `rhachet-roles-*` (e.g., `rhachet-roles-ehmpathy`, `rhachet-roles-bhrain`, `rhachet-roles-bhuild`)
+
+## fix
+
+moves all matching packages from `dependencies` to `devDependencies`, preserving their versions.
+
+## correct placement
+
+```json
+{
+  "devDependencies": {
+    "rhachet": "^1.19.0",
+    "rhachet-roles-ehmpathy": "^1.15.0"
+  }
+}
+```
+
+or, if downstream packages need to use them:
+
+```json
+{
+  "peerDependencies": {
+    "rhachet": ">=1.0.0"
+  }
+}
+```
+
+never:
+
+```json
+{
+  "dependencies": {
+    "rhachet": "^1.19.0"
+  }
+}
+```

package/dist/practices/rhachet/bad-practices/prod-deps/package.json

@@ -0,0 +1,5 @@
+{
+  "dependencies": {
+    "rhachet": "@declapract{check.minVersion('0.0.0')}"
+  }
+}

package/dist/practices/rhachet/bad-practices/prod-deps/package.json.declapract.ts

@@ -0,0 +1,47 @@
+import type { FileCheckFunction, FileFixFunction } from 'declapract';
+
+/**
+ * .what = detects rhachet and rhachet-roles-* packages in production dependencies
+ * .why = these packages should be devDependencies or peerDependencies, never direct prod deps
+ */
+
+const rhachetPackagePattern = /^rhachet(-roles-.*)?$/;
+
+export const check: FileCheckFunction = (contents) => {
+  if (!contents) throw new Error('does not match bad practice');
+
+  const packageJSON = JSON.parse(contents);
+  const prodDeps = Object.keys(packageJSON.dependencies ?? {});
+
+  // check if any rhachet package is in prod dependencies
+  const rhachetInProdDeps = prodDeps.some((dep) =>
+    rhachetPackagePattern.test(dep),
+  );
+
+  if (rhachetInProdDeps) return; // matches bad practice
+  throw new Error('does not match bad practice');
+};
+
+export const fix: FileFixFunction = (contents) => {
+  if (!contents) return { contents };
+
+  const packageJSON = JSON.parse(contents);
+  const prodDeps = { ...packageJSON.dependencies };
+  const devDeps = { ...packageJSON.devDependencies };
+
+  // find all rhachet packages in prod deps and move them to dev deps
+  for (const dep of Object.keys(prodDeps)) {
+    if (rhachetPackagePattern.test(dep)) {
+      devDeps[dep] = prodDeps[dep];
+      delete prodDeps[dep];
+    }
+  }
+
+  const fixedPackageJSON = {
+    ...packageJSON,
+    dependencies: Object.keys(prodDeps).length > 0 ? prodDeps : undefined,
+    devDependencies: Object.keys(devDeps).length > 0 ? devDeps : undefined,
+  };
+
+  return { contents: JSON.stringify(fixedPackageJSON, null, 2) };
+};

package/package.json

@@ -2,7 +2,7 @@
   "name": "declapract-typescript-ehmpathy",
   "author": "ehmpathy",
   "description": "declapract best practices declarations for typescript",
-  "version": "0.47.11",
+  "version": "0.47.13",
   "license": "MIT",
   "main": "src/index.js",
   "repository": "ehmpathy/declapract-typescript-ehmpathy",