declapract-typescript-ehmpathy 0.43.12 → 0.43.17

package/dist/practices/cicd-package/best-practice/.github/workflows/.publish-npm.yml

@@ -2,10 +2,9 @@ name: .publish-npm
 
 on:
   workflow_call:
-    secrets:
-      npm-auth-token:
-        required: true
-        description: required credentials to authenticate with the aws account under which to publish
+
+permissions:
+  id-token: write # required for oidc
 
 jobs:
   install:
@@ -31,10 +30,32 @@ jobs:
           path: ./node_modules
           key: ${{ needs.install.outputs.node-modules-cache-key }}
 
+      - name: verify oidc auth
+        run: |
+          OIDC_TOKEN=$(curl -sS -H "Authorization: Bearer $ACTIONS_ID_TOKEN_REQUEST_TOKEN" "$ACTIONS_ID_TOKEN_REQUEST_URL&audience=npm:registry.npmjs.org" | jq -r '.value')
+          PACKAGE_NAME_PLAIN=$(jq -r '.name' package.json)
+          PACKAGE_NAME_ENCODED=$(printf '%s' "$PACKAGE_NAME_PLAIN" | jq -sRr @uri)
+          HTTP_CODE=$(curl -sS -o /dev/null -w '%{http_code}' -X POST -H "Authorization: Bearer $OIDC_TOKEN" "https://registry.npmjs.org/-/npm/v1/oidc/token/exchange/package/$PACKAGE_NAME_ENCODED")
+          if [[ "$HTTP_CODE" =~ ^2 ]]; then
+            echo "oidc: configured for $PACKAGE_NAME_PLAIN"
+          else
+            echo "::error::oidc: not configured for $PACKAGE_NAME_PLAIN (http $HTTP_CODE). add oidc by-hand at https://www.npmjs.com/package/$PACKAGE_NAME_ENCODED/access"
+            exit 1
+          fi
+
+      - name: verify oidc compat
+        run: |
+          NPM_VERSION=$(npm --version)
+          MIN_VERSION="11.5.1"
+          if [ "$(printf '%s\n' "$MIN_VERSION" "$NPM_VERSION" | sort -V | head -n1)" != "$MIN_VERSION" ]; then
+            echo "npm $NPM_VERSION < $MIN_VERSION, will upgrade npm now to support oidc..."
+            npm install -g npm@latest
+          else
+            echo "npm $NPM_VERSION >= $MIN_VERSION, ready to use!"
+          fi
+
       - name: build
         run: npm run build
 
       - name: publish
-        run: npm publish --access public
-        env:
-          NODE_AUTH_TOKEN: ${{ secrets.npm-auth-token }}
+        run: npm publish --access public --provenance

package/dist/practices/cicd-package/best-practice/.github/workflows/publish.yml

@@ -16,5 +16,3 @@ jobs:
   publish:
     uses: ./.github/workflows/.publish-npm.yml
     needs: [test]
-    secrets:
-      npm-auth-token: ${{ secrets.NPM_TOKEN }}

package/dist/practices/domain/best-practice/package.json

@@ -1,6 +1,6 @@
 {
   "dependencies": {
-    "domain-objects": "@declapract{check.minVersion('0.31.3')}",
+    "domain-objects": "@declapract{check.minVersion('0.31.7')}",
     "joi": "@declapract{check.minVersion('17.4.0')}",
     "type-fns": "@declapract{check.minVersion('1.21.0')}"
   }

package/dist/practices/lint/best-practice/biome.json

@@ -8,12 +8,13 @@
   "files": {
     "includes": [
       "**/src/**/*.ts",
+      "**/provision/**/*.ts",
       "!**/dist",
       "!**/coverage",
       "!**/node_modules",
       "!**/.artifact",
-      "!**/.generated/**",
-      "!**/.test*/**"
+      "!**/.generated",
+      "!**/.test*"
     ]
   },
   "formatter": {

package/dist/practices/lint/best-practice/package.json

@@ -4,11 +4,11 @@
     "@biomejs/biome": "2.3.8"
   },
   "scripts": {
-    "fix:format:biome": "biome check --write src",
-    "fix:lint": "biome check --write src",
-    "test:format:biome": "biome format src",
-    "test:lint:biome": "biome check src --diagnostic-level=error",
-    "test:lint:biome:all": "biome check src",
+    "fix:format:biome": "biome check --write",
+    "fix:lint": "biome check --write",
+    "test:format:biome": "biome format",
+    "test:lint:biome": "biome check --diagnostic-level=error",
+    "test:lint:biome:all": "biome check",
     "test:lint:deps": "npx depcheck -c ./.depcheckrc.yml",
     "test:lint": "npm run test:lint:biome && npm run test:lint:deps"
   }

package/dist/practices/node/best-practice/.nvmrc

@@ -1 +1 @@
-v20.12.2
+v22.21.0

package/dist/practices/runtime-type-checking/bad-practices/joi/.declapract.readme.md

@@ -0,0 +1,3 @@
+joi has been replaced by zod as the preferred runtime type-checking library.
+
+zod provides better TypeScript integration with automatic type inference, smaller bundle size, and a more modern API.

package/dist/practices/runtime-type-checking/bad-practices/joi/package.json

@@ -0,0 +1,5 @@
+{
+  "dependencies": {
+    "joi": "@declapract{check.minVersion('0.0.0')}"
+  }
+}

package/dist/practices/runtime-type-checking/bad-practices/joi/package.json.declapract.ts

@@ -0,0 +1,19 @@
+import { FileCheckType, type FileFixFunction } from 'declapract';
+
+export const check = FileCheckType.CONTAINS;
+
+export const fix: FileFixFunction = (contents) => {
+  if (!contents) return { contents };
+  const packageJSON = JSON.parse(contents);
+  const updatedPackageJSON = {
+    ...packageJSON,
+    dependencies: {
+      ...packageJSON.dependencies,
+      joi: undefined,
+      zod: packageJSON.dependencies?.zod ?? '^3.24.0',
+    },
+  };
+  return {
+    contents: JSON.stringify(updatedPackageJSON, null, 2),
+  };
+};

package/dist/practices/runtime-type-checking/best-practice/package.json

@@ -1,5 +1,5 @@
 {
   "dependencies": {
-    "joi": "@declapract{check.minVersion('17.4.0')}"
+    "zod": "@declapract{check.minVersion('3.24.0')}"
   }
 }

package/dist/practices/serverless/best-practice/serverless.yml

@@ -8,7 +8,7 @@ plugins:
 
 provider:
   name: aws
-  runtime: nodejs16.x
+  runtime: nodejs22.x
   memorySize: 1024 # optional, in mb, default is 1024
   timeout: 60 # default timeout to 1min, for resilience against increased cold start times; individual functions can override this
   stage: ${opt:stage}

package/package.json

@@ -2,7 +2,7 @@
   "name": "declapract-typescript-ehmpathy",
   "author": "ehmpathy",
   "description": "declapract best practices declarations for typescript",
-  "version": "0.43.12",
+  "version": "0.43.17",
   "license": "MIT",
   "main": "src/index.js",
   "repository": "ehmpathy/declapract-typescript-ehmpathy",