declapract-typescript-ehmpathy 0.42.2 → 0.42.4

package/dist/practices/artifact/best-practice/package.json

@@ -1,6 +1,6 @@
 {
   "devDependencies": {
-    "simple-artifact-builder": "@declapract{check.minVersion('1.1.13')}"
+    "simple-artifact-builder": "@declapract{check.minVersion('1.1.15')}"
   },
   "scripts": {
     "build:artifact": "npx simple-artifact-builder zip"

package/dist/practices/cicd-common/best-practice/.github/workflows/.install.yml

@@ -16,26 +16,30 @@ jobs:
       - name: checkout
         uses: actions/checkout@v3
 
-      - name: setup pnpm
-        uses: pnpm/action-setup@v4
-
-      - name: set node-version
-        uses: actions/setup-node@v3
-        with:
-          node-version-file: ".nvmrc"
-
       - name: node-modules deps hash
         id: deps-hash
         run: |
           PACKAGE_DEPS_HASH=$(md5sum pnpm-lock.yaml | awk '{print $1}');
           echo "PACKAGE_DEPS_HASH=$PACKAGE_DEPS_HASH"
           echo "package-deps-hash=$PACKAGE_DEPS_HASH" >> "$GITHUB_OUTPUT"
-      - name: node-modules cache get
+
+      - name: node-modules cache check
         uses: actions/cache/restore@v4
         id: cache
         with:
           path: ./node_modules
           key: ${{ runner.os }}-pnpm-${{ steps.deps-hash.outputs.package-deps-hash }}
+          lookup-only: true
+
+      - name: node-modules cache miss setup node
+        if: steps.cache.outputs.cache-hit != 'true'
+        uses: actions/setup-node@v3
+        with:
+          node-version-file: ".nvmrc"
+
+      - name: node-modules cache miss setup pnpm
+        if: steps.cache.outputs.cache-hit != 'true'
+        uses: pnpm/action-setup@v4
 
       - name: node-modules cache miss install
         if: steps.cache.outputs.cache-hit != 'true'

package/dist/practices/cicd-service/best-practice/package.json

@@ -1,6 +1,6 @@
 {
   "devDependencies": {
-    "declastruct": "@declapract{check.minVersion('1.3.0')}",
+    "declastruct": "@declapract{check.minVersion('1.3.1')}",
     "declastruct-aws": "@declapract{check.minVersion('1.0.3')}",
     "declastruct-unix-network": "@declapract{check.minVersion('1.0.0')}"
   }

package/dist/practices/lambda-handlers/best-practice/package.json

@@ -1,6 +1,6 @@
 {
   "dependencies": {
-    "simple-lambda-handlers": "@declapract{check.minVersion('0.9.1')}"
+    "simple-lambda-handlers": "@declapract{check.minVersion('0.10.3')}"
   },
   "devDependencies": {}
 }

package/dist/practices/provision-github/best-practice/package.json

@@ -1,6 +1,6 @@
 {
   "devDependencies": {
-    "declastruct": "@declapract{check.minVersion('1.3.0')}",
+    "declastruct": "@declapract{check.minVersion('1.3.1')}",
     "declastruct-github": "@declapract{check.minVersion('1.0.3')}"
   }
 }

package/dist/practices/tests/bad-practices/old-test-utils-and-assets-location/.declapract.readme.md

@@ -0,0 +1,8 @@
+test utilities and assets should be located in `.test/assets/` instead of `__test_utils__` or `__test_assets__`
+
+the `.test/assets/` directory replaces the `__test_utils__` or `__test_assets__` directory in the same relative location.
+
+examples:
+- `src/domain/__test_utils__/exampleUser.ts` → `src/domain/.test/assets/exampleUser.ts`
+- `src/logic/__test_assets__/fixtures.json` → `src/logic/.test/assets/fixtures.json`
+- `acceptance/__test_utils__/environment.ts` → `acceptance/.test/assets/environment.ts`

package/dist/practices/tests/bad-practices/old-test-utils-and-assets-location/<star><star>/<star>.ts.declapract.ts

@@ -0,0 +1,27 @@
+import type { FileCheckFunction, FileFixFunction } from 'declapract';
+
+/**
+ * check if file has imports from __test_utils__ or __test_assets__ directories
+ */
+export const check: FileCheckFunction = (contents) => {
+  if (contents?.includes('__test_utils__')) return; // matches bad practice
+  if (contents?.includes('__test_assets__')) return; // matches bad practice
+  throw new Error('does not match bad practice');
+};
+
+/**
+ * replace __test_utils__ and __test_assets__ with .test/assets in import paths
+ */
+export const fix: FileFixFunction = (contents) => {
+  if (!contents) return {};
+
+  // simple string replacement - the relative path stays the same, only the directory name changes
+  // e.g., from '../__test_utils__/foo' to '../.test/assets/foo'
+  const fixedContents = contents
+    .replace(/__test_utils__\//g, '.test/assets/')
+    .replace(/__test_assets__\//g, '.test/assets/');
+
+  return {
+    contents: fixedContents,
+  };
+};

package/dist/practices/tests/bad-practices/old-test-utils-and-assets-location/<star><star>/__test_assets__/<star><star>/<star>.declapract.ts

@@ -0,0 +1,17 @@
+import type { FileFixFunction } from 'declapract';
+import { FileCheckType } from 'declapract';
+
+export const check = FileCheckType.EXISTS; // if files exist in __test_assets__ directories, it's bad practice
+
+export const fix: FileFixFunction = (contents, context) => {
+  // move from any/**/__test_assets__/**/* to .test/assets/**/*
+  const newPath = context.relativeFilePath.replace(
+    /__test_assets__\//g,
+    '.test/assets/',
+  );
+
+  return {
+    contents: contents ?? null,
+    relativeFilePath: newPath,
+  };
+};

package/dist/practices/tests/bad-practices/old-test-utils-and-assets-location/<star><star>/__test_utils__/<star><star>/<star>.declapract.ts

@@ -0,0 +1,17 @@
+import type { FileFixFunction } from 'declapract';
+import { FileCheckType } from 'declapract';
+
+export const check = FileCheckType.EXISTS; // if files exist in __test_utils__ directories, it's bad practice
+
+export const fix: FileFixFunction = (contents, context) => {
+  // move from any/**/__test_utils__/**/* to .test/assets/**/*
+  const newPath = context.relativeFilePath.replace(
+    /__test_utils__\//g,
+    '.test/assets/',
+  );
+
+  return {
+    contents: contents ?? null,
+    relativeFilePath: newPath,
+  };
+};

package/license.md

@@ -1,6 +1,6 @@
 MIT License
 
-Copyright (c) 2020 Ehmpathy
+Copyright (c) 2020 ehmpathy
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

package/package.json

@@ -2,7 +2,7 @@
   "name": "declapract-typescript-ehmpathy",
   "author": "ehmpathy",
   "description": "declapract best practices declarations for typescript",
-  "version": "0.42.2",
+  "version": "0.42.4",
   "license": "MIT",
   "main": "src/index.js",
   "repository": "ehmpathy/declapract-typescript-ehmpathy",
@@ -37,11 +37,12 @@
     "prepublish": "npm run build",
     "preversion": "npm run prepush",
     "postversion": "git push origin HEAD --tags --no-verify",
-    "prepare": "[ -d .git ] && npm run prepare:husky || exit 0",
-    "prepare:husky": "npx husky install && chmod ug+x .husky/*"
+    "prepare:husky": "npx husky install && chmod ug+x .husky/*",
+    "prepare": "[ -d .git ] && npm run prepare:husky || exit 0"
   },
   "dependencies": {
-    "domain-objects": "0.29.2",
+    "chalk": "4.1.2",
+    "domain-objects": "0.31.0",
     "expect": "29.4.2",
     "flat": "5.0.2",
     "helpful-errors": "1.5.3",
@@ -51,29 +52,36 @@
     "declapract": ">=0.12.1"
   },
   "devDependencies": {
+    "@babel/core": "7.28.5",
+    "@babel/preset-env": "7.28.5",
     "@commitlint/cli": "19.3.0",
     "@commitlint/config-conventional": "13.1.0",
     "@ehmpathy/as-command": "1.0.1",
     "@trivago/prettier-plugin-sort-imports": "4.3.0",
     "@tsconfig/node-lts-strictest": "18.12.1",
     "@types/flat": "5.0.2",
+    "@types/node": "22.15.21",
     "@types/jest": "29.4.0",
     "@typescript-eslint/eslint-plugin": "7.8.0",
     "@typescript-eslint/parser": "7.8.0",
+    "babel-jest": "30.2.0",
     "core-js": "3.26.1",
     "cz-conventional-changelog": "3.3.0",
+    "declastruct": "1.3.0",
+    "declastruct-github": "1.0.3",
     "depcheck": "1.4.3",
     "eslint": "8.56.0",
     "eslint-config-airbnb-typescript": "18.0.0",
     "eslint-config-prettier": "8.5.0",
     "eslint-plugin-import": "2.26.0",
     "eslint-plugin-prettier": "4.2.1",
-    "eslint-plugin-unused-imports": "4.3.0",
+    "eslint-plugin-unused-imports": "4.1.4",
     "husky": "8.0.3",
     "jest": "29.3.1",
     "prettier": "2.8.1",
     "test-fns": "1.4.2",
-    "ts-jest": "29.1.3",
+    "ts-jest": "29.4.5",
+    "tsx": "4.20.6",
     "type-fns": "0.8.1",
     "typescript": "5.4.5",
     "visualogic": "1.2.3"
@@ -83,5 +91,6 @@
       "path": "./node_modules/cz-conventional-changelog"
     }
   },
-  "bugs": "https://github.com/ehmpathy/declapract-typescript-ehmpathy/issues"
+  "bugs": "https://github.com/ehmpathy/declapract-typescript-ehmpathy/issues",
+  "packageManager": "pnpm@10.24.0"
 }