declapract-typescript-ehmpathy 0.42.0 → 0.42.2

package/dist/practices/husky/bad-practices/postinstall/package.json.declapract.ts

@@ -0,0 +1,18 @@
+import { FileCheckFunction, FileFixFunction } from 'declapract';
+
+export const check: FileCheckFunction = (contents) => {
+  if (!contents) throw new Error('does not match bad practice');
+  const packageJSONObject = JSON.parse(contents);
+  if (Object.keys(packageJSONObject.scripts).includes('postinstall')) return; // matches
+  throw new Error('does not match bad practice');
+};
+
+export const fix: FileFixFunction = (contents) => {
+  if (!contents) return {}; // should not occur
+  const packageJSONObject = JSON.parse(contents);
+  const fixedPackageJSONObject = {
+    ...packageJSONObject,
+    scripts: { ...packageJSONObject.scripts, postinstall: undefined }, // drop postinstall
+  };
+  return { contents: JSON.stringify(fixedPackageJSONObject, null, 2) };
+};

package/dist/practices/husky/best-practice/package.json

@@ -1,7 +1,7 @@
 {
   "scripts": {
     "prepare:husky": "npx husky install && chmod ug+x .husky/*",
-    "postinstall": "[ -d .git ] && npm run prepare:husky || exit 0"
+    "prepare": "[ -d .git ] && npm run prepare:husky || exit 0"
   },
   "devDependencies": {
     "husky": "@declapract{check.minVersion('8.0.3')}"

package/dist/practices/lint/best-practice/.depcheckrc.yml

@@ -5,10 +5,11 @@ ignores:
   - '@commitlint/config-conventional'
   - '@trivago/prettier-plugin-sort-imports'
   - '@tsconfig/node-lts-strictest'
+  - babel-jest
   - core-js
   - ts-jest
-  - ts-node
-  - test-fns
-  - helpful-errors
+  - tsx
   - husky
   - if-env
+  - test-fns
+  - helpful-errors

package/dist/practices/lint/best-practice/package.json

@@ -13,7 +13,7 @@
   "scripts": {
     "fix:lint": "eslint -c ./.eslintrc.js src/**/*.ts --fix",
     "test:lint:eslint": "eslint -c ./.eslintrc.js src/**/*.ts",
-    "test:lint:deps": "npx depcheck -c ./depcheckrc.yml",
+    "test:lint:deps": "npx depcheck -c ./.depcheckrc.yml",
     "test:lint": "npm run test:lint:eslint && npm run test:lint:deps"
   }
 }

package/dist/practices/package-json-order/best-practice/package.json.declapract.ts

@@ -68,6 +68,7 @@ export const desiredRelativeKeyOrder = {
     'postversion',
     'postinstall',
     'prepare:husky',
+    'prepare',
     'deploy:prune',
     'deploy:release',
     'deploy:send-notification',

package/dist/practices/persist-with-rds/best-practice/package.json

@@ -1,7 +1,6 @@
 {
   "dependencies": {
     "pg": "@declapract{check.minVersion('8.3.0')}",
-    "procedure-fns": "@declapract{check.minVersion('1.0.0')}",
     "yesql": "@declapract{check.minVersion('3.2.2')}"
   },
   "devDependencies": {

package/dist/practices/provision-github/bad-practices/terraform-github/provision/github/environment/import-existing-repo.sh.declapract.ts

@@ -0,0 +1,3 @@
+import { FileCheckType } from 'declapract';
+
+export const check = FileCheckType.EXISTS;

package/dist/practices/provision-github/bad-practices/terraform-github/provision/github/environment/main.tf.declapract.ts

@@ -0,0 +1,3 @@
+import { FileCheckType } from 'declapract';
+
+export const check = FileCheckType.EXISTS;

package/dist/practices/provision-github/bad-practices/terraform-github/provision/github/environment/versions.tf.declapract.ts

@@ -0,0 +1,3 @@
+import { FileCheckType } from 'declapract';
+
+export const check = FileCheckType.EXISTS;

package/dist/practices/provision-github/bad-practices/terraform-github/provision/github/product/repository.tf.declapract.ts

@@ -0,0 +1,3 @@
+import { FileCheckType } from 'declapract';
+
+export const check = FileCheckType.EXISTS;

package/dist/practices/provision-github/best-practice/provision/github/declastruct.resources.ts

@@ -97,7 +97,7 @@ export const getResources = async (): Promise<DomainEntity<any>[]> => {
     requiredStatusChecks: {
       strict: true, // branch must be up to date. otherwise, we dont know if it will really pass once it is merged
       contexts: [
-        'suite / install / npm',
+        'suite / install / pnpm',
         'suite / test-commits',
         'suite / test-types',
         'suite / test-format',

package/package.json

@@ -2,7 +2,7 @@
   "name": "declapract-typescript-ehmpathy",
   "author": "ehmpathy",
   "description": "declapract best practices declarations for typescript",
-  "version": "0.42.0",
+  "version": "0.42.2",
   "license": "MIT",
   "main": "src/index.js",
   "repository": "ehmpathy/declapract-typescript-ehmpathy",
@@ -24,7 +24,7 @@
     "test:types": "tsc -p ./tsconfig.build.json --noEmit",
     "test:format:prettier": "prettier --parser typescript --check 'src/**/*.ts' --config ./prettier.config.js",
     "test:format": "npm run test:format:prettier",
-    "test:lint:deps": "npx depcheck -c ./depcheckrc.yml",
+    "test:lint:deps": "npx depcheck -c ./.depcheckrc.yml",
     "test:lint:eslint": "eslint -c ./.eslintrc.js src/**/*.ts",
     "test:lint": "npm run test:lint:eslint && npm run test:lint:deps",
     "test:unit": "jest -c ./jest.unit.config.ts --forceExit --verbose --passWithNoTests $([ -z $THOROUGH ] && echo '--changedSince=main')",
@@ -37,7 +37,7 @@
     "prepublish": "npm run build",
     "preversion": "npm run prepush",
     "postversion": "git push origin HEAD --tags --no-verify",
-    "postinstall": "[ -d .git ] && npm run prepare:husky || exit 0",
+    "prepare": "[ -d .git ] && npm run prepare:husky || exit 0",
     "prepare:husky": "npx husky install && chmod ug+x .husky/*"
   },
   "dependencies": {