declapract-typescript-ehmpathy 0.39.16 → 0.39.18

package/dist/practices/domain/best-practice/package.json

@@ -1,6 +1,6 @@
 {
   "dependencies": {
-    "domain-objects": "@declapract{check.minVersion('0.22.1')}",
+    "domain-objects": "@declapract{check.minVersion('0.25.7')}",
     "joi": "@declapract{check.minVersion('17.4.0')}",
     "type-fns": "@declapract{check.minVersion('1.17.0')}"
   }

package/dist/practices/lint/best-practice/.eslintrc.js

@@ -17,7 +17,7 @@ module.exports = {
     'sort-imports': 'off',
     'import/prefer-default-export': 'off', // default export = bad
     'import/no-default-export': 'error', // require named exports - they make it easier to refactor, enforce consistency, and increase constraints
-    '@typescript-eslint/no-non-null-assertion': 'off', // we use these to help typescript out when we know something it doesnt, and cant easily express that
+    '@typescript-eslint/no-non-null-assertion': 'error', // forbid non-null assertion operators for safer code; you can always `?? UnexpectedCodePathError.throw(...)` to fail fast instead
     'import/no-extraneous-dependencies': [
       'error',
       {
@@ -30,14 +30,13 @@ module.exports = {
         ],
       },
     ],
-    '@typescript-eslint/no-explicit-any': 'off', // sometimes this is a valid definition
+    '@typescript-eslint/no-explicit-any': 'error', // forbid any type for better type safety; you can use `never` or `unknown` instead when its truly unknown or never needed to be known
     '@typescript-eslint/no-unused-vars': ['warn', { argsIgnorePattern: '^_' }],
     'import/no-cycle': 'off',
     'max-classes-per-file': 'off',
     '@typescript-eslint/no-use-before-define': 'off',
     '@typescript-eslint/no-floating-promises': 'error',
     'prefer-destructuring': 'off',
-    '@typescript-eslint/no-non-null-assertion': 'off',
     'lines-between-class-members': 'off',
     '@typescript-eslint/lines-between-class-members': 'off',
     'no-return-await': 'off', // this does not help anything and actually leads to bugs if we subsequently wrap the return in a try catch without remembering to _then_ add await

package/dist/practices/tests/best-practice/.declapract.todo.md

@@ -0,0 +1,3 @@
+cutover to vitest
+
+its faster and has native esm + ts support

package/dist/practices/tests/best-practice/babel.config.js

@@ -0,0 +1,12 @@
+module.exports = {
+  presets: [
+    [
+      '@babel/preset-env',
+      {
+        targets: {
+          node: 'current',
+        },
+      },
+    ],
+  ],
+};

package/dist/practices/tests/best-practice/jest.acceptance.config.ts

@@ -13,7 +13,12 @@ const config: Config = {
   moduleFileExtensions: ['js', 'ts'],
   transform: {
     '^.+\\.tsx?$': 'ts-jest', // https://kulshekhar.github.io/ts-jest/docs/getting-started/presets
+    '^.+\\.(js|jsx|mjs)$': 'babel-jest', // transform esm modules with babel
   },
+  transformIgnorePatterns: [
+    // here's an example of how to ignore esm module transformation, when needed
+    // 'node_modules/(?!(@octokit|universal-user-agent|before-after-hook)/)',
+  ],
   testMatch: ['**/*.acceptance.test.ts'],
   setupFiles: ['core-js'],
   setupFilesAfterEnv: ['./jest.acceptance.env.ts'],

package/dist/practices/tests/best-practice/jest.integration.config.ts

@@ -13,7 +13,12 @@ const config: Config = {
   moduleFileExtensions: ['js', 'ts'],
   transform: {
     '^.+\\.tsx?$': 'ts-jest', // https://kulshekhar.github.io/ts-jest/docs/getting-started/presets
+    '^.+\\.(js|jsx|mjs)$': 'babel-jest', // transform esm modules with babel
   },
+  transformIgnorePatterns: [
+    // here's an example of how to ignore esm module transformation, when needed
+    // 'node_modules/(?!(@octokit|universal-user-agent|before-after-hook)/)',
+  ],
   testMatch: ['**/*.integration.test.ts'],
   setupFiles: ['core-js'],
   setupFilesAfterEnv: ['./jest.integration.env.ts'],

package/dist/practices/tests/best-practice/jest.unit.config.ts

@@ -13,7 +13,12 @@ const config: Config = {
   moduleFileExtensions: ['js', 'ts'],
   transform: {
     '^.+\\.tsx?$': 'ts-jest', // https://kulshekhar.github.io/ts-jest/docs/getting-started/presets
+    '^.+\\.(js|jsx|mjs)$': 'babel-jest', // transform esm modules with babel
   },
+  transformIgnorePatterns: [
+    // here's an example of how to ignore esm module transformation, when needed
+    // 'node_modules/(?!(@octokit|universal-user-agent|before-after-hook)/)',
+  ],
   testMatch: [
     // note: order matters
     '**/*.test.ts',

package/dist/practices/tests/best-practice/package.json

@@ -5,7 +5,10 @@
     "test-fns": "@declapract{check.minVersion('1.4.2')}",
     "ts-jest": "@declapract{check.minVersion('29.1.3')}",
     "ts-node": "@declapract{check.minVersion('10.9.2')}",
-    "core-js": "@declapract{check.minVersion('3.26.1')}"
+    "core-js": "@declapract{check.minVersion('3.26.1')}",
+    "@babel/core": "@declapract{check.minVersion('7.28.5')}",
+    "@babel/preset-env": "@declapract{check.minVersion('7.28.5')}",
+    "babel-jest": "@declapract{check.minVersion('30.2.0')}"
   },
   "scripts": {
     "test:unit": "jest -c ./jest.unit.config.ts --forceExit --verbose --passWithNoTests $([ -z $THOROUGH ] && echo '--changedSince=main')",

package/package.json

@@ -2,7 +2,7 @@
   "name": "declapract-typescript-ehmpathy",
   "author": "ehmpathy",
   "description": "declapract best practices declarations for typescript",
-  "version": "0.39.16",
+  "version": "0.39.18",
   "license": "MIT",
   "main": "src/index.js",
   "repository": "ehmpathy/declapract-typescript-ehmpathy",