declapract-typescript-ehmpathy 0.37.2 → 0.37.4

package/dist/practices/cicd-common/best-practice/.github/workflows/.test.yml

@@ -76,11 +76,14 @@ jobs:
       - name: checkout
         uses: actions/checkout@v3
 
-      - name: set node-version
+      - name: set node version
         uses: actions/setup-node@v3
         with:
           node-version-file: '.nvmrc'
 
+      - name: set terraform version
+        uses: hashicorp/setup-terraform@v3
+
       - name: get node-modules from cache
         uses: actions/cache/restore@v4
         with:

package/dist/practices/errors/best-practice/package.json

@@ -1,5 +1,5 @@
 {
   "dependencies": {
-    "@ehmpathy/error-fns": "@declapract{check.minVersion('1.0.2')}"
+    "@ehmpathy/error-fns": "@declapract{check.minVersion('1.3.7')}"
   }
 }

package/dist/practices/lint/best-practice/.eslintrc.js

@@ -44,5 +44,6 @@ module.exports = {
     'no-return-await': 'off', // this does not help anything and actually leads to bugs if we subsequently wrap the return in a try catch without remembering to _then_ add await
     '@typescript-eslint/return-await': 'off',
     '@typescript-eslint/no-unsafe-declaration-merging': 'off', // dobjs are built off of this
+    '@typescript-eslint/default-param-last': 'off', // interferes with input vs context
   },
 };

package/dist/practices/lint-react-native/best-practice/.eslintrc.js

@@ -49,6 +49,7 @@ module.exports = {
     'no-return-await': 'off', // this does not help anything and actually leads to bugs if we subsequently wrap the return in a try catch without remembering to _then_ add await
     '@typescript-eslint/return-await': 'off',
     '@typescript-eslint/no-unsafe-declaration-merging': 'off',
+    '@typescript-eslint/default-param-last': 'off', // interferes with input vs context
   },
   settings: {
     'import/ignore': ['react-native'], // https://github.com/facebook/react-native/issues/28549

package/dist/practices/serverless/best-practice/serverless.yml

@@ -83,3 +83,30 @@ provider:
       Action:
         - SNS:Publish
       Resource: arn:aws:sns:${aws:region}:${aws:accountId}:${self:service}-*
+    # allow publishing to kinesis firehose streams namespaced by this service
+    - Effect: Allow
+      Action:
+        - firehose:PutRecord
+      Resource: arn:aws:firehose:${aws:region}:${aws:accountId}:deliverystream/${self:service}-* # allow publishing to any streams w/ this services name prefix
+    # allow reading and writing to glue tables namespaced to this service
+    - Effect: Allow
+      Action:
+        - glue:GetDatabase
+        - glue:GetTable
+        - glue:GetTableVersion
+        - glue:GetTableVersions
+        - glue:GetPartition
+        - glue:GetPartitions
+        - glue:CreatePartition
+        - glue:BatchCreatePartition
+      Resource:
+        - arn:aws:glue:${aws:region}:${aws:accountId}:catalog
+        - arn:aws:glue:${aws:region}:${aws:accountId}:database/@declapract{variable.databaseName}_${self:provider.stage}
+        - arn:aws:glue:${aws:region}:${aws:accountId}:table/@declapract{variable.databaseName}_${self:provider.stage}/*
+    # allow athena queries
+    - Effect: Allow
+      Action:
+        - athena:StartQueryExecution
+        - athena:GetQueryExecution
+        - athena:GetQueryResults
+      Resource: '*'

package/package.json

@@ -2,7 +2,7 @@
   "name": "declapract-typescript-ehmpathy",
   "author": "ehmpathy",
   "description": "declapract best practices declarations for typescript",
-  "version": "0.37.2",
+  "version": "0.37.4",
   "license": "MIT",
   "main": "src/index.js",
   "repository": "ehmpathy/declapract-typescript-ehmpathy",