declapract-typescript-ehmpathy 0.33.14 → 0.34.0

package/dist/practices/cicd-service/best-practice/.github/workflows/.deploy-sls.yml

@@ -34,6 +34,9 @@ on:
       open-vpn-config:
         required: false
         description: complete openvpn config required to enter the vpn, if needed
+      pagerduty-integration-key:
+        required: false
+        description: enables sending pagerduty alarms on failure
 
 jobs:
   install:
@@ -143,6 +146,15 @@ jobs:
         if: inputs.needs-vpn-for-acceptance
         run: sudo killall openvpn
 
+      - name: alarm on failure
+        env:
+          PAGERDUTY_INTEGRATION_KEY: ${{ secrets.pagerduty-integration-key }}
+        if: failure() && env.PAGERDUTY_INTEGRATION_KEY
+        uses: Entle/action-pagerduty-alert@0.2.0 # https://github.com/marketplace/actions/pagerduty-alert
+        with:
+          pagerduty-integration-key: '${{ secrets.pagerduty-integration-key }}'
+          pagerduty-dedup-key: github_workflow_failed
+
   prune:
     runs-on: ubuntu-20.04
     needs: [install, deploy]

package/dist/practices/cicd-service/best-practice/.github/workflows/deploy.yml

@@ -70,3 +70,4 @@ jobs:
     secrets:
       aws-access-key-id: ${{ secrets.PROD_AWS_ACCESS_KEY_ID }}
       aws-secret-access-key: ${{ secrets.PROD_AWS_SECRET_ACCESS_KEY }}
+      pagerduty-integration-key: ${{ secrets.PAGERDUTY_INTEGRATION_KEY }}

package/dist/practices/commands/best-practice/src/contract/commands/sayHello.ts

@@ -1,6 +1,5 @@
 import { asCommand } from '@ehmpathy/as-command';
-import { UnexpectedCodePathError } from '@ehmpathy/error-fns';
-import { ProcedureInput, getResourceNameFromFileName } from 'visualogic';
+import { getResourceNameFromFileName } from 'visualogic';
 
 import { stage } from '../../utils/environment';
 import { log } from '../../utils/logger';

package/dist/practices/persist-with-rds/best-practice/package.json

@@ -7,7 +7,7 @@
   "devDependencies": {
     "sql-code-generator": "@declapract{check.minVersion('0.10.1')}",
     "sql-dao-generator": "@declapract{check.minVersion('0.10.0')}",
-    "sql-schema-control": "@declapract{check.minVersion('1.5.2')}",
+    "sql-schema-control": "@declapract{check.minVersion('1.5.3')}",
     "sql-schema-generator": "@declapract{check.minVersion('0.25.2')}",
     "@types/yesql": "@declapract{check.minVersion('3.2.2')}",
     "@types/pg": "@declapract{check.minVersion('8.6.1')}"

package/dist/practices/serverless/best-practice/serverless.yml.declapract.ts

@@ -18,6 +18,10 @@ export const fix: FileFixFunction = (contents) => {
         '## allow invocation of other lambdas',
         '# allow invocation of other lambdas',
       )
+      .replace(
+        'environment:\n    NODE_ENV:',
+        'environment:\n    TZ: UTC # guarantee that utc timezone will be used explicitly, to facilitate a pit of success\n    NODE_ENV:',
+      )
       .replace(
         'NODE_ENV: ${self:custom.stageToNodeEnvMapping.${self:provider.stage}}\n  deploymentBucket',
         'NODE_ENV: ${self:custom.stageToNodeEnvMapping.${self:provider.stage}}\n    AWS_NODEJS_CONNECTION_REUSE_ENABLED: true # https://docs.aws.amazon.com/sdk-for-javascript/v2/developer-guide/node-reusing-connections.html\n  deploymentBucket',

package/package.json

@@ -2,7 +2,7 @@
   "name": "declapract-typescript-ehmpathy",
   "author": "ehmpathy",
   "description": "declapract best practices declarations for typescript",
-  "version": "0.33.14",
+  "version": "0.34.0",
   "main": "src/index.js",
   "repository": "ehmpathy/declapract-typescript-ehmpathy",
   "homepage": "https://github.com/ehmpathy/declapract-typescript-ehmpathy",
@@ -67,6 +67,7 @@
     "husky": "8.0.3",
     "jest": "29.3.1",
     "prettier": "2.8.1",
+    "test-fns": "1.4.2",
     "ts-jest": "29.1.3",
     "ts-node": "10.9.2",
     "type-fns": "0.8.1",