declapract-typescript-ehmpathy 0.25.8 → 0.27.0

package/dist/practices/cicd-common/best-practice/.github/workflows/review.yml

@@ -0,0 +1,26 @@
+name: review
+
+on:
+  pull_request:
+    types:
+      - opened
+      - edited
+      - synchronize
+
+permissions:
+  pull-requests: read
+
+jobs:
+  pullreq-title:
+    runs-on: ubuntu-latest
+    steps:
+      - name: test:pullreq:title
+        uses: amannn/action-semantic-pull-request@v5
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        with:
+          # https://github.com/commitizen/conventional-commit-types
+          types: |
+            fix
+            feat
+            chore

package/dist/practices/cicd-package/best-practice/.github/workflows/.publish-npm.yml

@@ -36,6 +36,6 @@ jobs:
         run: npm run build
 
       - name: publish
-        run: npm publish --provenance --access public
+        run: npm publish --access public
         env:
           NODE_AUTH_TOKEN: ${{ secrets.npm-auth-token }}

package/dist/practices/serverless/best-practice/serverless.yml

@@ -68,7 +68,10 @@ provider:
         - dynamodb:Scan
         - dynamodb:GetItem
         - dynamodb:PutItem
-      Resource: arn:aws:dynamodb:${aws:region}:${aws:accountId}:table/${self:service}-*
+        - dynamodb:DeleteItem
+      Resource:
+        - arn:aws:dynamodb:${aws:region}:${aws:accountId}:table/${self:service}-* # allow read and write to all tables w/ this services name prefix
+        - arn:aws:dynamodb:${aws:region}:${aws:accountId}:table/infrastructure-${self:provider.stage}-table-domain-driven-cache # allow read and write to global domain driven cache
     # allow publishing to sns topics namespaced by this service
     - Effect: Allow
       Action:

package/dist/practices/terraform/best-practice/provision/github/product/repository.tf

@@ -57,13 +57,15 @@ resource "github_branch_protection" "main_branch" {
   required_status_checks {
     strict = true # branch must be up to date. otherwise, we dont know if it will really pass once it is merged
     contexts = [
+      "suite / install",
       "suite / test-commits",
       "suite / test-types",
       "suite / test-format",
       "suite / test-lint",
       "suite / test-unit",
       "suite / test-integration",
-      "suite / test-acceptance-locally"
+      "suite / test-acceptance-locally",
+      "review / pullreq-title",
     ]
   }
 

package/dist/practices/testing/best-practice/jest.acceptance.config.ts

@@ -1,5 +1,8 @@
 import type { Config } from 'jest';
 
+// ensure tests run in utc, like they will on cicd and on server; https://stackoverflow.com/a/56277249/15593329
+process.env.TZ = 'UTC';
+
 // https://jestjs.io/docs/configuration
 const config: Config = {
   verbose: true,

package/dist/practices/testing/best-practice/jest.integration.config.ts

@@ -1,5 +1,8 @@
 import type { Config } from 'jest';
 
+// ensure tests run in utc, like they will on cicd and on server; https://stackoverflow.com/a/56277249/15593329
+process.env.TZ = 'UTC';
+
 // https://jestjs.io/docs/configuration
 const config: Config = {
   verbose: true,

package/dist/practices/testing/best-practice/jest.unit.config.ts

@@ -1,5 +1,8 @@
 import type { Config } from 'jest';
 
+// ensure tests run in utc, like they will on cicd and on server; https://stackoverflow.com/a/56277249/15593329
+process.env.TZ = 'UTC';
+
 // https://jestjs.io/docs/configuration
 const config: Config = {
   verbose: true,

package/package.json

@@ -2,7 +2,7 @@
   "name": "declapract-typescript-ehmpathy",
   "author": "ehmpathy",
   "description": "declapract best practices declarations for typescript",
-  "version": "0.25.8",
+  "version": "0.27.0",
   "main": "src/index.js",
   "repository": "ehmpathy/declapract-typescript-ehmpathy",
   "homepage": "https://github.com/ehmpathy/declapract-typescript-ehmpathy",