declapract-typescript-ehmpathy 0.23.3 → 0.23.6

package/dist/practices/cicd-common/best-practice/.github/workflows/.test.yml

@@ -190,7 +190,7 @@ jobs:
             || echo 'correct aws account';
 
       - name: provision:integration-test-db
-        run: npm run provision:integration-test-db
+        run: npm run provision:integration-test-db --if-present
 
       - name: test:integration
         run: npm run test:integration
@@ -231,7 +231,7 @@ jobs:
             || echo 'correct aws account';
 
       - name: provision:integration-test-db
-        run: npm run provision:integration-test-db
+        run: npm run provision:integration-test-db --if-present
 
       - name: test:acceptance:locally
         run: npm run test:acceptance:locally

package/dist/practices/cicd-package/best-practice/.github/workflows/.publish-npm.yml

@@ -17,6 +17,7 @@ jobs:
       - name: set node version
         uses: actions/setup-node@v3
         with:
+          registry-url: 'https://registry.npmjs.org/'
           node-version-file: '.nvmrc'
           cache: 'npm'
 
@@ -26,4 +27,4 @@ jobs:
       - name: publish
         run: npm publish
         env:
-          NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
+          NODE_AUTH_TOKEN: ${{ secrets.npm-auth-token }}

package/dist/practices/cicd-package/best-practice/.github/workflows/publish.yml

@@ -11,5 +11,6 @@ jobs:
 
   publish:
     uses: ./.github/workflows/.publish-npm.yml
+    needs: [test]
     secrets:
       npm-auth-token: ${{ secrets.NPM_TOKEN }}

package/dist/practices/testing/best-practice/jest.unit.env.ts

@@ -1,12 +1,16 @@
-import { stage, Stage } from './src/utils/environment';
-
 jest.mock('./src/utils/config/getConfig', () => ({
   getConfig: jest.fn().mockImplementation(() => require('./config/test.json')), // mock that getConfig just returns plaintext test env config in unit tests
 }));
 
 /**
- * sanity check that unit tests are only run in 'test' environment
- * - if they are run in prod environment, we could load a bunch of junk data into our prod databases, which would be no bueno
+ * sanity check that unit tests are only run the 'test' environment
+ *
+ * usecases
+ * - prevent polluting prod state with test data
+ * - prevent executing financially impacting mutations
  */
-if (stage !== Stage.TEST && process.env.I_KNOW_WHAT_IM_DOING !== 'true')
+if (
+  process.env.NODE_ENV !== 'test' &&
+  process.env.I_KNOW_WHAT_IM_DOING !== 'true'
+)
   throw new Error(`unit-test is not targeting stage 'test'`);

package/dist/practices/testing/best-practice/jest.unit.env.ts.declapract.ts

@@ -15,8 +15,7 @@ export const contents: FileContentsFunction = async (context) => {
   let contents = contentsSuperset;
   if (!context.projectPractices.includes('config'))
     contents = contents.replace(
-      `
-jest.mock('./src/utils/config/getConfig', () => ({
+      `jest.mock('./src/utils/config/getConfig', () => ({
   getConfig: jest.fn().mockImplementation(() => require('./config/test.json')), // mock that getConfig just returns plaintext test env config in unit tests
 }));
 `,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "declapract-typescript-ehmpathy",
-  "version": "0.23.3",
+  "version": "0.23.6",
   "description": "declapract best practices declarations for typescript",
   "main": "src/index.js",
   "repository": "ehmpathy/declapract-typescript-ehmpathy",

package/dist/practices/cicd-package/best-practice/package.json

@@ -1,6 +0,0 @@
-{
-  "scripts": {
-    "fix:format:terraform": "echo 'terraform not used'",
-    "test:format:terraform": "echo 'terraform not used'"
-  }
-}

package/dist/practices/cicd-package/best-practice/package.json.declapract.ts

@@ -1,4 +0,0 @@
-import { FileCheckType } from 'declapract';
-
-// TODO: move this check out into the function that defines `fix:format`, and have it check whether it should include terraform instead
-export const check = FileCheckType.CONTAINS;