declapract-typescript-ehmpathy 0.22.1 → 0.22.2

package/dist/practices/cicd-deploy-service/best-practice/.github/workflows/.terraform.yml

@@ -67,7 +67,7 @@ jobs:
 
       - name: terraform plan
         id: plan
-        run: terraform plan | tee ./plan.log
+        run: terraform plan -detailed-exitcode | tee ./plan.log
         env:
           GITHUB_TOKEN: ${{ secrets.github-token }} # allow specifying a github token to pass to the terraform command
 

package/dist/practices/persist-with-dynamodb/best-practice/jest.integration.env.ts

@@ -0,0 +1,5 @@
+/**
+ * specify that dynamodb should use the local dynamodb database, if running in test env
+ */
+if (stage === Stage.TEST)
+  process.env.USE_CUSTOM_DYNAMODB_ENDPOINT = 'http://localhost:7337';

package/dist/practices/persist-with-dynamodb/best-practice/jest.integration.env.ts.declapract.ts

@@ -0,0 +1,3 @@
+import { FileCheckType } from 'declapract';
+
+export const check = FileCheckType.CONTAINS;

package/dist/practices/persist-with-dynamodb/best-practice/provision/aws/environments/test/main.tf

@@ -0,0 +1,3 @@
+endpoints {
+  dynamodb = "http://localhost:7337/"
+}

package/dist/practices/persist-with-dynamodb/best-practice/provision/aws/environments/test/main.tf.declapract.ts

@@ -0,0 +1,3 @@
+import { FileCheckType } from 'declapract';
+
+export const check = FileCheckType.CONTAINS; // should contain specifier that test applies to local dynamodb

package/dist/practices/terraform/best-practice/provision/aws/environments/test/main.tf

@@ -1,10 +1,6 @@
 provider "aws" {
   region              = "us-east-1"
   allowed_account_ids = ["@declapract{variable.awsAccountId.dev}"] # `test` environment resources are provisioned in the `dev` aws account
-
-  endpoints {
-    dynamodb = "http://localhost:7337/"
-  }
 }
 
 terraform {

package/dist/practices/testing/best-practice/jest.integration.env.ts

@@ -10,9 +10,3 @@ jest.setTimeout(90000); // since we're calling downstream apis
  */
 if (stage !== Stage.TEST && process.env.I_KNOW_WHAT_IM_DOING !== 'true')
   throw new Error(`integration-test is not targeting stage 'test'`);
-
-/**
- * specify that dynamodb should use the local dynamodb database, if running in test env
- */
-if (stage === Stage.TEST)
-  process.env.USE_CUSTOM_DYNAMODB_ENDPOINT = 'http://localhost:7337';

package/dist/practices/typescript/best-practice/tsconfig.json

@@ -5,6 +5,7 @@
     "noPropertyAccessFromIndexSignature": false,
     "noUnusedLocals": false, // this is something a linter should warn on, not something a compiler should fail on
     "noUnusedParameters": false, // this is something a linter should warn on, not something a compiler should fail on
+    "exactOptionalPropertyTypes": false, // too clunky when `{ name?: string }` !== `{ name?: string | undefined }`. too rare of a cause of issue to be worth it
     "noImplicitOverride": false,
     "resolveJsonModule": true,
     "sourceMap": true,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "declapract-typescript-ehmpathy",
-  "version": "0.22.1",
+  "version": "0.22.2",
   "description": "declapract best practices declarations for typescript",
   "main": "src/index.js",
   "repository": "ehmpathy/declapract-typescript-ehmpathy",