declapract-typescript-ehmpathy 0.22.0 → 0.22.2

package/dist/practices/cicd-deploy-service/best-practice/.github/workflows/.sql-schema-control.yml

@@ -35,7 +35,7 @@ jobs:
   plan:
     runs-on: ubuntu-latest
     outputs:
-      has-changes-planned: ${{ steps.evaluate-plan.output.has-changes-planned }}
+      has-changes-planned: ${{ steps.evaluate-plan.outputs.has-changes-planned }}
     steps:
       - name: checkout
         uses: actions/checkout@v3
@@ -105,6 +105,9 @@ jobs:
             echo "has-changes-planned=true" >> "$GITHUB_OUTPUT"
           fi
 
+      - name: has changes planned?
+        run: echo "${{ steps.evaluate-plan.outputs.has-changes-planned }}"
+
       - name: vpn:disconnect
         run: sudo killall openvpn
 

package/dist/practices/cicd-deploy-service/best-practice/.github/workflows/.terraform.yml

@@ -37,7 +37,7 @@ jobs:
       run:
         working-directory: ${{ inputs.working-directory }}
     outputs:
-      has-changes-planned: ${{ steps.evaluate-plan.output.has-changes-planned }}
+      has-changes-planned: ${{ steps.evaluate-plan.outputs.has-changes-planned }}
     steps:
       - name: checkout
         uses: actions/checkout@v3
@@ -67,7 +67,7 @@ jobs:
 
       - name: terraform plan
         id: plan
-        run: terraform plan | tee ./plan.log
+        run: terraform plan -detailed-exitcode | tee ./plan.log
         env:
           GITHUB_TOKEN: ${{ secrets.github-token }} # allow specifying a github token to pass to the terraform command
 
@@ -81,6 +81,9 @@ jobs:
             echo "has-changes-planned=true" >> "$GITHUB_OUTPUT"
           fi
 
+      - name: has changes planned?
+        run: echo "${{ steps.evaluate-plan.outputs.has-changes-planned }}"
+
   apply:
     runs-on: ubuntu-latest
     environment: ${{ inputs.github-environment }}
@@ -114,6 +117,6 @@ jobs:
         run: terraform init
 
       - name: terraform apply
-        run: terraform apply
+        run: terraform apply -auto-approve
         env:
           GITHUB_TOKEN: ${{ secrets.github-token }} # allow specifying a github token to pass to the terraform command

package/dist/practices/cicd-deploy-service/best-practice/.github/workflows/provision.yml

@@ -11,6 +11,17 @@ on:
   workflow_dispatch:
 
 jobs:
+  aws-test:
+    uses: ./.github/workflows/.terraform.yml
+    with:
+      working-directory: provision/aws/environments/test
+      github-environment: dev
+      aws-region: us-east-1
+      aws-account-id: '@declapract{variable.awsAccountId.dev}'
+    secrets:
+      aws-access-key-id: ${{ secrets.DEV_AWS_ACCESS_KEY_ID }}
+      aws-secret-access-key: ${{ secrets.DEV_AWS_SECRET_ACCESS_KEY }}
+
   aws-dev:
     uses: ./.github/workflows/.terraform.yml
     with:

package/dist/practices/persist-with-dynamodb/best-practice/jest.integration.env.ts

@@ -0,0 +1,5 @@
+/**
+ * specify that dynamodb should use the local dynamodb database, if running in test env
+ */
+if (stage === Stage.TEST)
+  process.env.USE_CUSTOM_DYNAMODB_ENDPOINT = 'http://localhost:7337';

package/dist/practices/persist-with-dynamodb/best-practice/jest.integration.env.ts.declapract.ts

@@ -0,0 +1,3 @@
+import { FileCheckType } from 'declapract';
+
+export const check = FileCheckType.CONTAINS;

package/dist/practices/persist-with-dynamodb/best-practice/provision/aws/environments/test/main.tf

@@ -0,0 +1,3 @@
+endpoints {
+  dynamodb = "http://localhost:7337/"
+}

package/dist/practices/persist-with-dynamodb/best-practice/provision/aws/environments/test/main.tf.declapract.ts

@@ -0,0 +1,3 @@
+import { FileCheckType } from 'declapract';
+
+export const check = FileCheckType.CONTAINS; // should contain specifier that test applies to local dynamodb

package/dist/practices/persist-with-rds/bad-practices/old-integration-test-db-dir/.declapract.readme.md

@@ -0,0 +1 @@
+we switched from `provision/docker/integration_test_db` to `provision/docker/integration-test-db`

package/dist/practices/persist-with-rds/bad-practices/old-integration-test-db-dir/provision/docker/integration_test_db/<star><star>/<star>.declapract.ts

@@ -0,0 +1,3 @@
+import { FileCheckType } from 'declapract';
+
+export const check = FileCheckType.EXISTS; // if a file exists with this path pattern, then it's bad practice

package/dist/practices/persist-with-rds/best-practice/package.json

@@ -16,6 +16,7 @@
     "generate:schema": "npx sql-schema-generator generate -c codegen.sql.schema.yml && npm run fix:format",
     "generate:types-from-sql": "npx sql-code-generator generate -c codegen.sql.types.yml && npm run fix:format",
     "provision:docker:clear": "docker rm -f $(docker ps -a -f 'publish=7821' -q) 2>/dev/null || true && echo 'ensured port is available 👍'",
+    "provision:docker:prepare": "cp provision/schema/sql/init/.extensions.sql provision/docker/integration-test-db/init/extensions.sql && cp provision/schema/sql/init/.schema.sql provision/docker/integration-test-db/init/schema.sql && cp provision/schema/sql/init/.user.cicd.sql provision/docker/integration-test-db/init/user.cicd.sql",
     "provision:docker:up": "docker-compose -f ./provision/docker/integration-test-db/docker-compose.yml up -d --force-recreate --build --renew-anon-volumes",
     "provision:docker:await": "docker-compose -f ./provision/docker/integration-test-db/docker-compose.yml exec -T postgres /root/wait-for-postgres.sh",
     "provision:docker:down": "docker-compose -f ./provision/docker/integration-test-db/docker-compose.yml down",

package/dist/practices/terraform/best-practice/provision/aws/environments/test/main.tf

@@ -1,10 +1,6 @@
 provider "aws" {
   region              = "us-east-1"
   allowed_account_ids = ["@declapract{variable.awsAccountId.dev}"] # `test` environment resources are provisioned in the `dev` aws account
-
-  endpoints {
-    dynamodb = "http://localhost:7337/"
-  }
 }
 
 terraform {

package/dist/practices/testing/best-practice/jest.integration.env.ts

@@ -10,9 +10,3 @@ jest.setTimeout(90000); // since we're calling downstream apis
  */
 if (stage !== Stage.TEST && process.env.I_KNOW_WHAT_IM_DOING !== 'true')
   throw new Error(`integration-test is not targeting stage 'test'`);
-
-/**
- * specify that dynamodb should use the local dynamodb database, if running in test env
- */
-if (stage === Stage.TEST)
-  process.env.USE_CUSTOM_DYNAMODB_ENDPOINT = 'http://localhost:7337';

package/dist/practices/typescript/best-practice/tsconfig.json

@@ -5,6 +5,7 @@
     "noPropertyAccessFromIndexSignature": false,
     "noUnusedLocals": false, // this is something a linter should warn on, not something a compiler should fail on
     "noUnusedParameters": false, // this is something a linter should warn on, not something a compiler should fail on
+    "exactOptionalPropertyTypes": false, // too clunky when `{ name?: string }` !== `{ name?: string | undefined }`. too rare of a cause of issue to be worth it
     "noImplicitOverride": false,
     "resolveJsonModule": true,
     "sourceMap": true,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "declapract-typescript-ehmpathy",
-  "version": "0.22.0",
+  "version": "0.22.2",
   "description": "declapract best practices declarations for typescript",
   "main": "src/index.js",
   "repository": "ehmpathy/declapract-typescript-ehmpathy",