dd-trace 6.12.0 → 6.14.0

package/packages/datadog-instrumentations/src/mariadb.js

@@ -11,9 +11,11 @@ const {
   runOutsidePoolQueryAcquire,
   runPoolAcquireError,
   runWithPoolWait,
+  setPromisePoolConnectionConfig,
   takePoolWaitTime,
   wrapPoolQueryMethod,
 } = require('./helpers/pool-acquire')
+const { wrapCallbackBundle, wrapPromiseBundle } = require('./mariadb-bundle')
 
 const commandAddCh = channel('apm:mariadb:command:add')
 const connectionStartCh = channel('apm:mariadb:connection:start')
@@ -96,6 +98,8 @@ function createWrapQuery (options) {
       if (!startCh.hasSubscribers) return query.apply(this, arguments)
 
       const ctx = { sql, conf: options }
+      const poolWaitTime = takePoolWaitTime(this)
+      if (poolWaitTime !== undefined) ctx.poolWaitTime = poolWaitTime
 
       return startCh.runStores(ctx, query, this, ...arguments)
         .then(result => {
@@ -145,8 +149,11 @@ function createWrapQueryCallback (options) {
 function wrapConnection (promiseMethod, Connection) {
   return function (options) {
     Connection.apply(this, arguments)
+    setPromisePoolConnectionConfig(this, options)
 
+    const query = this[promiseMethod]
     shimmer.wrap(this, promiseMethod, createWrapQuery(options))
+    if (this.query === query) this.query = this[promiseMethod]
     shimmer.wrap(this, '_queryCallback', createWrapQueryCallback(options))
   }
 }
@@ -443,3 +450,9 @@ addHook({ name, file: 'lib/connection.js', versions: ['>=2.0.4 <=2.5.1'] }, (Con
 addHook({ name, file: 'lib/pool-base.js', versions: ['>=2.0.4 <3'] }, (PoolBase) => {
   return shimmer.wrapFunction(PoolBase, wrapPoolBase)
 })
+
+// MariaDB 3.5.3 added single-file CommonJS bundles that do not load the original source modules at runtime.
+// Matching their generated, minified internals would couple instrumentation to unstable bundle output, so wrap
+// the runtime objects returned by the public factories instead.
+addHook({ name, versions: ['>=3.5.3'] }, wrapPromiseBundle)
+addHook({ name, file: 'dist/callback.cjs', versions: ['>=3.5.3'] }, wrapCallbackBundle)

package/packages/datadog-instrumentations/src/mocha/common.js

@@ -11,6 +11,60 @@ const MINIMUM_MOCHA_VERSION = DD_MAJOR >= 6 ? '>=8.0.0' : '>=5.2.0'
 const parameterizedTestCh = channel('ci:mocha:test:parameterize')
 const patched = new WeakSet()
 
+/**
+ * Registers every Mocha package view that can expose the constructor.
+ *
+ * @param {string[]} versions
+ * @param {(Mocha: Function, frameworkVersion: string) => Function} wrapMochaRun
+ * @returns {void}
+ */
+function addMochaRunHooks (versions, wrapMochaRun) {
+  const patchedMochaConstructors = new WeakSet()
+
+  /**
+   * @param {Function} Mocha
+   * @param {string} frameworkVersion
+   * @returns {Function}
+   */
+  function wrapMochaOnce (Mocha, frameworkVersion) {
+    if (patchedMochaConstructors.has(Mocha)) return Mocha
+    patchedMochaConstructors.add(Mocha)
+    return wrapMochaRun(Mocha, frameworkVersion)
+  }
+
+  /**
+   * @param {object|Function} MochaPackage
+   * @param {string} frameworkVersion
+   * @returns {object|Function}
+   */
+  function wrapMochaPackage (MochaPackage, frameworkVersion) {
+    wrapMochaOnce(MochaPackage.default ?? MochaPackage, frameworkVersion)
+    return MochaPackage
+  }
+
+  addHook({
+    name: 'mocha',
+    versions,
+    filePattern: String.raw`lib/mocha\.(?:c?js)$`,
+  }, wrapMochaOnce)
+
+  // Mocha 12's ESM package root can load lib/mocha.cjs before the CJS hook observes it. ESM imports report the
+  // package root while synchronous require reports index.js, so hook both views. Keeping the namespace intact makes
+  // the ESM hook skip its separate default-export callback, and wrapMochaOnce deduplicates loaders exposing both.
+  addHook({
+    name: 'mocha',
+    versions: ['>=12.0.0'],
+    patchDefault: false,
+  }, wrapMochaPackage)
+
+  addHook({
+    name: 'mocha',
+    versions: ['>=12.0.0'],
+    file: 'index.js',
+    patchDefault: false,
+  }, wrapMochaPackage)
+}
+
 // mocha-each support
 addHook({
   name: 'mocha-each',
@@ -38,7 +92,8 @@ addHook({
   name: 'mocha',
   versions: [MINIMUM_MOCHA_VERSION],
   file: 'lib/suite.js',
-}, (Suite) => {
+}, (SuitePackage) => {
+  const Suite = SuitePackage.Suite ?? SuitePackage
   shimmer.wrap(Suite.prototype, 'addTest', addTest => function (test) {
     const callSites = getCallSites()
     const testCallSite = callSites.find(site => site.getFileName() === test.file)
@@ -47,5 +102,7 @@ addHook({
     }
     return addTest.apply(this, arguments)
   })
-  return Suite
+  return SuitePackage
 })
+
+module.exports = { addMochaRunHooks }

package/packages/datadog-instrumentations/src/mocha/main.js

@@ -35,6 +35,7 @@ const {
   isMarkedAsUnskippable,
 } = require('../../../dd-trace/src/plugins/util/test')
 
+const { addMochaRunHooks } = require('./common')
 const {
   isNewTest,
   getTestProperties,
@@ -60,8 +61,6 @@ const {
   adjustRunnerFailuresForTestOptimization,
 } = require('./utils')
 
-require('./common')
-
 const MINIMUM_MOCHA_VERSION = DD_MAJOR >= 6 ? '>=8.0.0' : '>=5.2.0'
 
 /**
@@ -536,7 +535,10 @@ function stopCurrentHook (runner, hook) {
     if (test) {
       if (hook.parent?._afterEach?.includes(hook) || hook.parent?._afterAll?.includes(hook)) {
         markTestTerminal(runner, test)
-        if (!test._ddTestFinishStarted) runnerTestEndHandlers.get(runner)?.(test)
+        if (!test._ddTestFinishStarted) {
+          const onTestEnd = runnerTestEndHandlers.get(runner)
+          onTestEnd?.(test)
+        }
       } else {
         markTestPending(runner, test)
       }
@@ -763,14 +765,18 @@ function wrapRunnerEmit (Runner) {
             const test = hook.ctx?.currentTest
             if (test && hook.parent?._afterEach?.includes(hook)) {
               markTestTerminal(this, test)
-              if (!test._ddTestFinishStarted) runnerTestEndHandlers.get(this)?.(test)
+              if (!test._ddTestFinishStarted) {
+                const onTestEnd = runnerTestEndHandlers.get(this)
+                onTestEnd?.(test)
+              }
             }
           } else if (event === 'pending' || event === 'pass' || event === 'fail' || event === 'retry' ||
             event === 'test end') {
             const test = arguments[1]
             stopAfterEachHooks(this, test)
             if (event === 'test end' && !test._ddTestFinishStarted) {
-              runnerTestEndHandlers.get(this)?.(test)
+              const onTestEnd = runnerTestEndHandlers.get(this)
+              onTestEnd?.(test)
             }
           }
         }
@@ -1063,13 +1069,15 @@ function getExecutionConfiguration (runner, isParallel, frameworkVersion, onFini
 // In this hook we delay the execution with options.delay to grab library configuration,
 // skippable and known tests.
 // It is called but skipped in parallel mode.
-addHook({
-  name: 'mocha',
-  versions: [MINIMUM_MOCHA_VERSION],
-  file: 'lib/mocha.js',
-}, (Mocha, frameworkVersion) => {
+/**
+ * @param {Function} Mocha
+ * @param {string} frameworkVersion
+ * @returns {Function}
+ */
+function wrapMochaRun (Mocha, frameworkVersion) {
   warnDeprecatedMochaVersion(frameworkVersion)
 
+  // Shimmer is required because run must return its Runner while execution is paused and resumed after configuration.
   shimmer.wrap(Mocha.prototype, 'run', run => function (...args) {
     // Workers do not need to request any data, just run the tests
     if (!testFinishCh.hasSubscribers || getEnvironmentVariable('MOCHA_WORKER_ID') || this.options.parallel) {
@@ -1121,12 +1129,14 @@ addHook({
     return runner
   })
   return Mocha
-})
+}
+
+addMochaRunHooks([MINIMUM_MOCHA_VERSION], wrapMochaRun)
 
 addHook({
   name: 'mocha',
   versions: [MINIMUM_MOCHA_VERSION],
-  file: 'lib/cli/run-helpers.js',
+  filePattern: String.raw`lib/cli/run-helpers\.(?:c?js)$`,
 }, (run) => {
   // `runMocha` is an async function
   shimmer.wrap(run, 'runMocha', runMocha => function (...args) {
@@ -1157,7 +1167,7 @@ addHook({
 addHook({
   name: 'mocha',
   versions: [MINIMUM_MOCHA_VERSION],
-  file: 'lib/runner.js',
+  filePattern: String.raw`lib/runner\.(?:c?js)$`,
 }, function (Runner, frameworkVersion) {
   if (patched.has(Runner)) return Runner
 
@@ -1588,7 +1598,7 @@ addHook({
 addHook({
   name: 'mocha',
   versions: ['>=8.0.0'],
-  file: 'lib/nodejs/parallel-buffered-runner.js',
+  filePattern: String.raw`lib/nodejs/parallel-buffered-runner\.(?:c?js)$`,
 }, (ParallelBufferedRunner, frameworkVersion) => {
   shimmer.wrap(ParallelBufferedRunner.prototype, 'run', run => function (cb, { files, options = {} }) {
     if (!testFinishCh.hasSubscribers) {
@@ -1667,7 +1677,7 @@ addHook({
 addHook({
   name: 'mocha',
   versions: ['>=8.0.0'],
-  file: 'lib/nodejs/buffered-worker-pool.js',
+  filePattern: String.raw`lib/nodejs/buffered-worker-pool\.(?:c?js)$`,
 }, (BufferedWorkerPoolPackage, frameworkVersion) => {
   const { BufferedWorkerPool } = BufferedWorkerPoolPackage
 

package/packages/datadog-instrumentations/src/mocha/utils.js

@@ -507,7 +507,8 @@ function inheritDatadogPropertiesFromRetriedTest (test) {
 }
 
 function runnableWrapper (RunnablePackage, libraryConfig) {
-  shimmer.wrap(RunnablePackage.prototype, 'run', run => function (...args) {
+  const Runnable = RunnablePackage.Runnable ?? RunnablePackage
+  shimmer.wrap(Runnable.prototype, 'run', run => function (...args) {
     if (!testFinishCh.hasSubscribers) {
       return run.apply(this, args)
     }

package/packages/datadog-instrumentations/src/mocha/webdriverio-protocol.js

@@ -6,6 +6,11 @@ const {
   WEBDRIVERIO_WORKER_EVENT,
   WEBDRIVERIO_WORKER_ORIGIN,
 } = require('../../../dd-trace/src/ci-visibility/exporters/test-worker/webdriverio')
+const { FINAL_FLUSH_TIMEOUT } = require('../../../dd-trace/src/ci-visibility/final-flush')
+
+const SCREENSHOT_UPLOAD = 'dd:test-optimization:webdriverio:screenshot:upload'
+const SCREENSHOT_UPLOAD_RESPONSE = 'dd:test-optimization:webdriverio:screenshot:upload:response'
+const SCREENSHOT_UPLOAD_TIMEOUT_MS = FINAL_FLUSH_TIMEOUT + 5000
 
 /**
  * Sends a message over WebdriverIO's worker IPC envelope.
@@ -30,10 +35,103 @@ function sendWebdriverioWorkerMessage (message, onError, onDone) {
   })
 }
 
+let screenshotUploadRequestId = 0
+const screenshotUploadRequests = new Map()
+
+/**
+ * Removes shared screenshot response listeners when there are no pending requests.
+ *
+ * @returns {void}
+ */
+function removeScreenshotUploadListeners () {
+  if (screenshotUploadRequests.size !== 0) return
+
+  process.off('message', onScreenshotUploadResponse)
+  process.off('disconnect', onScreenshotUploadDisconnect)
+}
+
+/**
+ * Completes one pending screenshot upload request.
+ *
+ * @param {string} requestId
+ * @param {Error} [error]
+ * @returns {void}
+ */
+function finishScreenshotUploadRequest (requestId, error) {
+  const request = screenshotUploadRequests.get(requestId)
+  if (!request) return
+
+  screenshotUploadRequests.delete(requestId)
+  clearTimeout(request.timeout)
+  removeScreenshotUploadListeners()
+  request.onDone(error)
+}
+
+/**
+ * Dispatches one coordinator screenshot response to its pending request.
+ *
+ * @param {object} message
+ * @returns {void}
+ */
+function onScreenshotUploadResponse (message) {
+  if (message?.name !== SCREENSHOT_UPLOAD_RESPONSE) return
+
+  const { error: errorMessage, requestId } = message.content || {}
+  if (!requestId) return
+
+  finishScreenshotUploadRequest(requestId, errorMessage ? new Error(errorMessage) : undefined)
+}
+
+/**
+ * Fails every pending screenshot upload after coordinator disconnect.
+ *
+ * @returns {void}
+ */
+function onScreenshotUploadDisconnect () {
+  for (const requestId of screenshotUploadRequests.keys()) {
+    finishScreenshotUploadRequest(
+      requestId,
+      new Error('WebdriverIO coordinator disconnected during screenshot upload')
+    )
+  }
+}
+
+/**
+ * Requests one screenshot upload from the WebdriverIO coordinator.
+ *
+ * @param {object} content - Screenshot upload metadata
+ * @param {(error?: Error) => void} onDone - Upload completion callback
+ * @returns {void}
+ */
+function requestWebdriverioScreenshotUpload (content, onDone) {
+  const requestId = `${process.pid}-${++screenshotUploadRequestId}`
+  const timeout = setTimeout(() => {
+    finishScreenshotUploadRequest(requestId, new Error('WebdriverIO screenshot upload timed out'))
+  }, SCREENSHOT_UPLOAD_TIMEOUT_MS)
+  timeout.unref?.()
+  if (screenshotUploadRequests.size === 0) {
+    process.on('message', onScreenshotUploadResponse)
+    process.once('disconnect', onScreenshotUploadDisconnect)
+  }
+  screenshotUploadRequests.set(requestId, { onDone, timeout })
+  sendWebdriverioWorkerMessage({
+    origin: 'datadog',
+    name: SCREENSHOT_UPLOAD,
+    content: { ...content, requestId },
+  }, error => finishScreenshotUploadRequest(
+    requestId,
+    error || new Error('WebdriverIO screenshot upload IPC failed')
+  ))
+}
+
 module.exports = {
   CONFIGURATION_REQUEST: 'dd:test-optimization:webdriverio:configuration:request',
   CONFIGURATION_RESPONSE: 'dd:test-optimization:webdriverio:configuration:response',
   createWebdriverioWorkerMessage,
+  requestWebdriverioScreenshotUpload,
+  SCREENSHOT_UPLOAD,
+  SCREENSHOT_UPLOAD_RESPONSE,
+  SCREENSHOT_UPLOAD_TIMEOUT_MS,
   sendWebdriverioWorkerMessage,
   SUITE_FINISH: 'dd:test-optimization:webdriverio:test-suite:finish',
   WORKER_READY: 'dd:test-optimization:webdriverio:worker:ready',

package/packages/datadog-instrumentations/src/mocha/worker.js

@@ -7,6 +7,7 @@ const { getEnvironmentVariable } = require('../../../dd-trace/src/config/helper'
 const log = require('../../../dd-trace/src/log')
 const { DD_MAJOR } = require('../../../../version')
 
+const { addMochaRunHooks } = require('./common')
 const {
   runnableWrapper,
   getOnTestHandler,
@@ -29,7 +30,6 @@ const {
   WEBDRIVERIO_WORKER_ENV,
   WORKER_READY,
 } = require('./webdriverio-protocol')
-require('./common')
 
 const MINIMUM_MOCHA_VERSION = DD_MAJOR >= 6 ? '>=8.0.0' : '>=5.2.0'
 
@@ -360,13 +360,15 @@ function isFailedTestReplayEnabled () {
   return config.isTestDynamicInstrumentationEnabled && config.isDiEnabled
 }
 
-addHook({
-  name: 'mocha',
-  versions: ['>=8.0.0'],
-  file: 'lib/mocha.js',
-}, (Mocha, frameworkVersion) => {
+/**
+ * @param {Function} Mocha
+ * @param {string} frameworkVersion
+ * @returns {Function}
+ */
+function wrapMochaRun (Mocha, frameworkVersion) {
   reportWebdriverioWorkerReady(frameworkVersion)
 
+  // Shimmer is required because run must return its Runner while execution is paused and resumed after configuration.
   shimmer.wrap(Mocha.prototype, 'run', run => function (...args) {
     applyMochaOptions(this.options)
     if (!isWebdriverioWorker || !workerFinishCh.hasSubscribers) {
@@ -438,13 +440,15 @@ addHook({
   })
 
   return Mocha
-})
+}
+
+addMochaRunHooks(['>=8.0.0'], wrapMochaRun)
 
 // Runner is also hooked in mocha/main.js, but in here we only generate test events.
 addHook({
   name: 'mocha',
   versions: [MINIMUM_MOCHA_VERSION],
-  file: 'lib/runner.js',
+  filePattern: String.raw`lib/runner\.(?:c?js)$`,
 }, function (Runner) {
   shimmer.wrap(Runner.prototype, 'runTests', runTests => getRunTestsWrapper(runTests, config))
 

package/packages/datadog-instrumentations/src/net.js

@@ -27,8 +27,6 @@ addHook({ name: 'net' }, (net) => {
     }
 
     const options = getOptions(args)
-    const lastIndex = args.length - 1
-    const callback = args[lastIndex]
 
     if (!options) return connect.apply(this, args)
 
@@ -38,42 +36,39 @@ addHook({ name: 'net' }, (net) => {
     const errorCh = protocol === 'ipc' ? errorICPCh : errorTCPCh
     const ctx = { options }
 
-    if (typeof callback === 'function') {
-      args[lastIndex] = function (...args) {
-        return finishCh.runStores(ctx, callback, this, ...args)
-      }
-    }
-
     return startCh.runStores(ctx, () => {
-      setupListeners(this, protocol, ctx, finishCh, errorCh)
+      const cleanup = setupListeners(this, protocol, ctx, finishCh, errorCh)
 
-      const emit = this.emit
+      const originalEmit = this.emit
       let pendingReadyEvents = 2
       // Named `emit`/arity-1 mirrors the socket method so the per-socket wrap
       // skips its name/length rewrite.
-      this.emit = shimmer.wrapFunction(emit, originalEmit => function emit (eventName) {
+      this.emit = shimmer.wrapFunction(originalEmit, wrappedEmit => function emit (eventName) {
         switch (eventName) {
           case 'ready':
           case 'connect':
             if (--pendingReadyEvents === 0) this.emit = originalEmit
             return readyCh.runStores(ctx, () => {
-              return Reflect.apply(originalEmit, this, arguments)
+              return Reflect.apply(wrappedEmit, this, arguments)
             })
           case 'error':
           case 'close':
             this.emit = originalEmit
-            return Reflect.apply(originalEmit, this, arguments)
+            return Reflect.apply(wrappedEmit, this, arguments)
           default:
-            return Reflect.apply(originalEmit, this, arguments)
+            return Reflect.apply(wrappedEmit, this, arguments)
         }
       })
 
       try {
         return connect.apply(this, args)
-      } catch (err) {
-        errorCh.publish(err)
+      } catch (error) {
+        cleanup()
+        this.emit = originalEmit
+        errorCh.publish(error)
+        finishCh.runStores(ctx, () => {})
 
-        throw err
+        throw error
       }
     })
   })
@@ -142,4 +137,6 @@ function setupListeners (socket, protocol, ctx, finishCh, errorCh) {
   for (const event of events) {
     socket.once(event, wrapListener)
   }
+
+  return cleanupOtherListeners
 }