dd-trace 5.8.0 → 5.10.0

package/packages/dd-trace/src/appsec/iast/vulnerabilities-formatter/evidence-redaction/sensitive-analyzers/sql-sensitive-analyzer.js

@@ -68,7 +68,7 @@ module.exports = function extractSensitiveRanges (evidence) {
   try {
     let pattern = patterns[evidence.dialect]
     if (!pattern) {
-      pattern = patterns['ANSI']
+      pattern = patterns.ANSI
     }
     pattern.lastIndex = 0
     const tokens = []

package/packages/dd-trace/src/appsec/iast/vulnerabilities-formatter/utils.js

@@ -13,15 +13,18 @@ const KEYS_REGEX_WITHOUT_SENSITIVE_RANGES = new RegExp(`"(${STRINGIFY_RANGE_KEY}
 
 const sensitiveValueRegex = new RegExp(DEFAULT_IAST_REDACTION_VALUE_PATTERN, 'gmi')
 
-function iterateObject (target, fn, levelKeys = [], depth = 50) {
+function iterateObject (target, fn, levelKeys = [], depth = 10, visited = new Set()) {
   Object.keys(target).forEach((key) => {
     const nextLevelKeys = [...levelKeys, key]
     const val = target[key]
 
-    fn(val, nextLevelKeys, target, key)
+    if (typeof val !== 'object' || !visited.has(val)) {
+      visited.add(val)
+      fn(val, nextLevelKeys, target, key)
 
-    if (val !== null && typeof val === 'object' && depth > 0) {
-      iterateObject(val, fn, nextLevelKeys, depth - 1)
+      if (val !== null && typeof val === 'object' && depth > 0) {
+        iterateObject(val, fn, nextLevelKeys, depth - 1, visited)
+      }
     }
   })
 }

package/packages/dd-trace/src/appsec/waf/waf_context_wrapper.js

@@ -39,12 +39,12 @@ class WAFContextWrapper {
     }
 
     if (Object.keys(inputs).length) {
-      payload['persistent'] = inputs
+      payload.persistent = inputs
       payloadHasData = true
     }
 
     if (ephemeral && Object.keys(ephemeral).length) {
-      payload['ephemeral'] = ephemeral
+      payload.ephemeral = ephemeral
       payloadHasData = true
     }
 

package/packages/dd-trace/src/ci-visibility/exporters/git/git_metadata.js

@@ -1,4 +1,3 @@
-
 const fs = require('fs')
 const path = require('path')
 
@@ -115,6 +114,10 @@ function getCommitsToUpload ({ url, repositoryUrl, latestCommits, isEvpProxy, ev
 
     const commitsToUpload = getCommitsRevList(alreadySeenCommits, commitsToInclude)
 
+    if (commitsToUpload === null) {
+      return callback(new Error('git rev-list failed'))
+    }
+
     callback(null, commitsToUpload)
   })
 }
@@ -253,9 +256,8 @@ function sendGitMetadata (url, { isEvpProxy, evpProxyPrefix }, configRepositoryU
     return callback(new Error('Repository URL is empty'))
   }
 
-  const latestCommits = getLatestCommits()
+  let latestCommits = getLatestCommits()
   log.debug(`There were ${latestCommits.length} commits since last month.`)
-  const [headCommit] = latestCommits
 
   const getOnFinishGetCommitsToUpload = (hasCheckedShallow) => (err, commitsToUpload) => {
     if (err) {
@@ -269,6 +271,7 @@ function sendGitMetadata (url, { isEvpProxy, evpProxyPrefix }, configRepositoryU
 
     // If it has already unshallowed or the clone is not shallow, we move on
     if (hasCheckedShallow || !isShallowRepository()) {
+      const [headCommit] = latestCommits
       return generateAndUploadPackFiles({
         url,
         isEvpProxy,
@@ -281,6 +284,9 @@ function sendGitMetadata (url, { isEvpProxy, evpProxyPrefix }, configRepositoryU
     // Otherwise we unshallow and get commits to upload again
     log.debug('It is shallow clone, unshallowing...')
     unshallowRepository()
+
+    // The latest commits change after unshallowing
+    latestCommits = getLatestCommits()
     getCommitsToUpload({
       url,
       repositoryUrl,

package/packages/dd-trace/src/ci-visibility/intelligent-test-runner/get-skippable-suites.js

@@ -102,7 +102,8 @@ function getSkippableSuites ({
         const { meta: { correlation_id: correlationId } } = parsedResponse
         incrementCountMetric(
           testLevel === 'test'
-            ? TELEMETRY_ITR_SKIPPABLE_TESTS_RESPONSE_TESTS : TELEMETRY_ITR_SKIPPABLE_TESTS_RESPONSE_SUITES,
+            ? TELEMETRY_ITR_SKIPPABLE_TESTS_RESPONSE_TESTS
+            : TELEMETRY_ITR_SKIPPABLE_TESTS_RESPONSE_SUITES,
           {},
           skippableSuites.length
         )

package/packages/dd-trace/src/ci-visibility/test-api-manual/test-api-manual-plugin.js

@@ -10,6 +10,7 @@ class TestApiManualPlugin extends CiPlugin {
   static get id () {
     return 'test-api-manual'
   }
+
   constructor (...args) {
     super(...args)
     this.sourceRoot = process.cwd()

package/packages/dd-trace/src/config.js

@@ -23,13 +23,11 @@ const fromEntries = Object.fromEntries || (entries =>
 
 // eslint-disable-next-line max-len
 const qsRegex = '(?:p(?:ass)?w(?:or)?d|pass(?:_?phrase)?|secret|(?:api_?|private_?|public_?|access_?|secret_?)key(?:_?id)?|token|consumer_?(?:id|key|secret)|sign(?:ed|ature)?|auth(?:entication|orization)?)(?:(?:\\s|%20)*(?:=|%3D)[^&]+|(?:"|%22)(?:\\s|%20)*(?::|%3A)(?:\\s|%20)*(?:"|%22)(?:%2[^2]|%[^2]|[^"%])+(?:"|%22))|bearer(?:\\s|%20)+[a-z0-9\\._\\-]+|token(?::|%3A)[a-z0-9]{13}|gh[opsu]_[0-9a-zA-Z]{36}|ey[I-L](?:[\\w=-]|%3D)+\\.ey[I-L](?:[\\w=-]|%3D)+(?:\\.(?:[\\w.+\\/=-]|%3D|%2F|%2B)+)?|[\\-]{5}BEGIN(?:[a-z\\s]|%20)+PRIVATE(?:\\s|%20)KEY[\\-]{5}[^\\-]+[\\-]{5}END(?:[a-z\\s]|%20)+PRIVATE(?:\\s|%20)KEY|ssh-rsa(?:\\s|%20)*(?:[a-z0-9\\/\\.+]|%2F|%5C|%2B){100,}'
-const defaultWafObfuscatorKeyRegex = `(?i)(?:p(?:ass)?w(?:or)?d|pass(?:_?phrase)?|secret|(?:api_?|private_?\
-|public_?)key)|token|consumer_?(?:id|key|secret)|sign(?:ed|ature)|bearer|authorization`
-const defaultWafObfuscatorValueRegex =
-`(?i)(?:p(?:ass)?w(?:or)?d|pass(?:_?phrase)?|secret|(?:api_?|private_?|public_?|access_?|secret_?)key(?:_?id)?|to\
-ken|consumer_?(?:id|key|secret)|sign(?:ed|ature)?|auth(?:entication|orization)?)(?:\\s*=[^;]|"\\s*:\\s*"[^"]+")|bearer\
-\\s+[a-z0-9\\._\\-]+|token:[a-z0-9]{13}|gh[opsu]_[0-9a-zA-Z]{36}|ey[I-L][\\w=-]+\\.ey[I-L][\\w=-]+(?:\\.[\\w.+\\/=-]+)?\
-|[\\-]{5}BEGIN[a-z\\s]+PRIVATE\\sKEY[\\-]{5}[^\\-]+[\\-]{5}END[a-z\\s]+PRIVATE\\sKEY|ssh-rsa\\s*[a-z0-9\\/\\.+]{100,}`
+// eslint-disable-next-line max-len
+const defaultWafObfuscatorKeyRegex = '(?i)(?:p(?:ass)?w(?:or)?d|pass(?:_?phrase)?|secret|(?:api_?|private_?|public_?)key)|token|consumer_?(?:id|key|secret)|sign(?:ed|ature)|bearer|authorization'
+// eslint-disable-next-line max-len
+const defaultWafObfuscatorValueRegex = '(?i)(?:p(?:ass)?w(?:or)?d|pass(?:_?phrase)?|secret|(?:api_?|private_?|public_?|access_?|secret_?)key(?:_?id)?|token|consumer_?(?:id|key|secret)|sign(?:ed|ature)?|auth(?:entication|orization)?)(?:\\s*=[^;]|"\\s*:\\s*"[^"]+")|bearer\\s+[a-z0-9\\._\\-]+|token:[a-z0-9]{13}|gh[opsu]_[0-9a-zA-Z]{36}|ey[I-L][\\w=-]+\\.ey[I-L][\\w=-]+(?:\\.[\\w.+\\/=-]+)?|[\\-]{5}BEGIN[a-z\\s]+PRIVATE\\sKEY[\\-]{5}[^\\-]+[\\-]{5}END[a-z\\s]+PRIVATE\\sKEY|ssh-rsa\\s*[a-z0-9\\/\\.+]{100,}'
+const runtimeId = uuid()
 
 function maybeFile (filepath) {
   if (!filepath) return
@@ -132,9 +130,11 @@ class Config {
 
     const DD_SERVICE_MAPPING = coalesce(
       options.serviceMapping,
-      process.env.DD_SERVICE_MAPPING ? fromEntries(
-        process.env.DD_SERVICE_MAPPING.split(',').map(x => x.trim().split(':'))
-      ) : {}
+      process.env.DD_SERVICE_MAPPING
+        ? fromEntries(
+          process.env.DD_SERVICE_MAPPING.split(',').map(x => x.trim().split(':'))
+        )
+        : {}
     )
 
     const DD_API_KEY = coalesce(
@@ -292,7 +292,7 @@ class Config {
       service: this.service,
       env: this.env,
       version: this.version,
-      'runtime-id': uuid()
+      'runtime-id': runtimeId
     })
 
     if (this.isCiVisibility) {
@@ -704,7 +704,7 @@ class Config {
   _isCiVisibility () {
     return coalesce(
       this.options.isCiVisibility,
-      this._defaults['isCiVisibility']
+      this._defaults.isCiVisibility
     )
   }
 
@@ -717,7 +717,8 @@ class Config {
 
   _getHostname () {
     const DD_CIVISIBILITY_AGENTLESS_URL = process.env.DD_CIVISIBILITY_AGENTLESS_URL
-    const url = DD_CIVISIBILITY_AGENTLESS_URL ? new URL(DD_CIVISIBILITY_AGENTLESS_URL)
+    const url = DD_CIVISIBILITY_AGENTLESS_URL
+      ? new URL(DD_CIVISIBILITY_AGENTLESS_URL)
       : getAgentUrl(this._getTraceAgentUrl(), this.options)
     const DD_AGENT_HOST = coalesce(
       this.options.hostname,
@@ -808,7 +809,7 @@ class Config {
     }
     this._setString(calc, 'dogstatsd.hostname', this._getHostname())
     this._setBoolean(calc, 'isGitUploadEnabled',
-      calc['isIntelligentTestRunnerEnabled'] && !isFalse(this._isCiVisibilityGitUploadEnabled()))
+      calc.isIntelligentTestRunnerEnabled && !isFalse(this._isCiVisibilityGitUploadEnabled()))
     this._setBoolean(calc, 'spanComputePeerService', this._getSpanComputePeerService())
     this._setBoolean(calc, 'stats.enabled', this._isTraceStatsComputationEnabled())
   }
@@ -823,6 +824,7 @@ class Config {
       : undefined
 
     tagger.add(tags, options.tracing_tags)
+    if (Object.keys(tags).length) tags['runtime-id'] = runtimeId
 
     this._setUnit(opts, 'sampleRate', options.tracing_sampling_rate)
     this._setBoolean(opts, 'logInjection', options.log_injection_enabled)

package/packages/dd-trace/src/datastreams/pathway.js

@@ -22,7 +22,7 @@ function computeHash (service, env, edgeTags, parentHash) {
     return cache.get(key)
   }
   const currentHash = shaHash(`${service}${env}` + edgeTags.join(''))
-  const buf = Buffer.concat([ currentHash, parentHash ], 16)
+  const buf = Buffer.concat([currentHash, parentHash], 16)
   const val = shaHash(buf.toString())
   cache.set(key, val)
   return val

package/packages/dd-trace/src/datastreams/processor.js

@@ -273,12 +273,12 @@ class DataStreamsProcessor {
     const edgeLatencyNs = nowNs - edgeStartNs
     const pathwayLatencyNs = nowNs - pathwayStartNs
     const dataStreamsContext = {
-      hash: hash,
-      edgeStartNs: edgeStartNs,
-      pathwayStartNs: pathwayStartNs,
+      hash,
+      edgeStartNs,
+      pathwayStartNs,
       previousDirection: direction,
-      closestOppositeDirectionHash: closestOppositeDirectionHash,
-      closestOppositeDirectionEdgeStart: closestOppositeDirectionEdgeStart
+      closestOppositeDirectionHash,
+      closestOppositeDirectionEdgeStart
     }
     if (direction === 'direction:out') {
       // Add the header for this now, as the callee doesn't have access to context when producing
@@ -289,12 +289,12 @@ class DataStreamsProcessor {
     }
     const checkpoint = {
       currentTimestamp: nowNs,
-      parentHash: parentHash,
-      hash: hash,
-      edgeTags: edgeTags,
-      edgeLatencyNs: edgeLatencyNs,
-      pathwayLatencyNs: pathwayLatencyNs,
-      payloadSize: payloadSize
+      parentHash,
+      hash,
+      edgeTags,
+      edgeLatencyNs,
+      pathwayLatencyNs,
+      payloadSize
     }
     this.recordCheckpoint(checkpoint, span)
     return dataStreamsContext
@@ -320,7 +320,7 @@ class DataStreamsProcessor {
     // TimeBuckets
     const serializedBuckets = []
 
-    for (const [ timeNs, bucket ] of this.buckets.entries()) {
+    for (const [timeNs, bucket] of this.buckets.entries()) {
       const points = []
 
       // bucket: StatsBucket
@@ -354,9 +354,9 @@ class DataStreamsProcessor {
 }
 
 module.exports = {
-  DataStreamsProcessor: DataStreamsProcessor,
-  StatsPoint: StatsPoint,
-  StatsBucket: StatsBucket,
+  DataStreamsProcessor,
+  StatsPoint,
+  StatsBucket,
   Backlog,
   TimeBuckets,
   getMessageSize,

package/packages/dd-trace/src/encode/agentless-ci-visibility.js

@@ -328,8 +328,8 @@ class AgentlessCiVisibilityEncoder extends AgentEncoder {
       version: ENCODING_VERSION,
       metadata: {
         '*': {
-          'language': 'javascript',
-          'library_version': ddTraceVersion
+          language: 'javascript',
+          library_version: ddTraceVersion
         }
       },
       events: []

package/packages/dd-trace/src/encode/coverage-ci-visibility.js

@@ -108,7 +108,7 @@ class CoverageCIVisibilityEncoder extends AgentEncoder {
       'coverage1',
       buffer,
       {
-        filename: `coverage1.msgpack`,
+        filename: 'coverage1.msgpack',
         contentType: 'application/msgpack'
       }
     )

package/packages/dd-trace/src/exporters/common/request.js

@@ -6,6 +6,7 @@
 const { Readable } = require('stream')
 const http = require('http')
 const https = require('https')
+// eslint-disable-next-line n/no-deprecated-api
 const { parse: urlParse } = require('url')
 const zlib = require('zlib')
 

package/packages/dd-trace/src/exporters/span-stats/writer.js

@@ -1,4 +1,3 @@
-
 const { SpanStatsEncoder } = require('../../encode/span-stats')
 
 const pkg = require('../../../../../package.json')

package/packages/dd-trace/src/external-logger/src/index.js

@@ -51,11 +51,11 @@ class ExternalLogger {
 
     const payload = {
       ...log,
-      'timestamp': Date.now(),
-      'hostname': log.hostname || this.hostname,
-      'ddsource': log.ddsource || this.ddsource,
-      'service': log.service || this.service,
-      'ddtags': logTags || undefined
+      timestamp: Date.now(),
+      hostname: log.hostname || this.hostname,
+      ddsource: log.ddsource || this.ddsource,
+      service: log.service || this.service,
+      ddtags: logTags || undefined
     }
 
     this.enqueue(payload)

package/packages/dd-trace/src/opentelemetry/span.js

@@ -161,9 +161,11 @@ class Span {
   get resource () {
     return this._parentTracer.resource
   }
+
   get instrumentationLibrary () {
     return this._parentTracer.instrumentationLibrary
   }
+
   get _spanProcessor () {
     return this._parentTracer.getActiveSpanProcessor()
   }

package/packages/dd-trace/src/opentracing/propagation/text_map.js

@@ -321,7 +321,7 @@ class TextMapPropagator {
     }
     const matches = headerValue.trim().match(traceparentExpr)
     if (matches.length) {
-      const [ version, traceId, spanId, flags, tail ] = matches.slice(1)
+      const [version, traceId, spanId, flags, tail] = matches.slice(1)
       const traceparent = { version }
       const tracestate = TraceState.fromString(carrier.tracestate)
       if (invalidSegment.test(traceId)) return null

package/packages/dd-trace/src/opentracing/span.js

@@ -210,7 +210,7 @@ class DatadogSpan {
           // Wrap the value as a string if it's not already a string
           sanitizedAttributes[key] = typeof maybeScalar === 'string' ? maybeScalar : String(maybeScalar)
         } else {
-          log.warn(`Dropping span link attribute. It is not of an allowed type`)
+          log.warn('Dropping span link attribute. It is not of an allowed type')
         }
       }
     }

package/packages/dd-trace/src/plugins/apollo.js

@@ -25,7 +25,9 @@ class ApolloBasePlugin extends TracingPlugin {
   }
 
   end (ctx) {
-    ctx?.currentStore?.span.finish()
+    // Only synchronous operations would have `result` or `error` on `end`.
+    if (!ctx.hasOwnProperty('result') && !ctx.hasOwnProperty('error')) return
+    ctx?.currentStore?.span?.finish()
   }
 
   asyncStart (ctx) {

package/packages/dd-trace/src/plugins/ci_plugin.js

@@ -42,7 +42,7 @@ module.exports = class CiPlugin extends Plugin {
       }
       this.tracer._exporter.getLibraryConfiguration(this.testConfiguration, (err, libraryConfig) => {
         if (err) {
-          log.error(`Intelligent Test Runner configuration could not be fetched. ${err.message}`)
+          log.error(`Library configuration could not be fetched. ${err.message}`)
         } else {
           this.libraryConfig = libraryConfig
         }
@@ -123,6 +123,7 @@ module.exports = class CiPlugin extends Plugin {
       this.tracer._exporter.getKnownTests(this.testConfiguration, (err, knownTests) => {
         if (err) {
           log.error(`Known tests could not be fetched. ${err.message}`)
+          this.libraryConfig.isEarlyFlakeDetectionEnabled = false
         }
         onDone({ err, knownTests })
       })

package/packages/dd-trace/src/plugins/composite.js

@@ -14,10 +14,9 @@ class CompositePlugin extends Plugin {
   configure (config) {
     super.configure(config)
     for (const name in this.constructor.plugins) {
-      const pluginConfig = config[name] === false ? false : {
-        ...config,
-        ...config[name]
-      }
+      const pluginConfig = config[name] === false
+        ? false
+        : { ...config, ...config[name] }
 
       this[name].configure(pluginConfig)
     }

package/packages/dd-trace/src/plugins/database.js

@@ -20,6 +20,7 @@ class DatabasePlugin extends StoragePlugin {
       encodedDdpv: ''
     }
   }
+
   encodingServiceTags (serviceTag, encodeATag, spanConfig) {
     if (serviceTag !== spanConfig) {
       this.serviceTags[serviceTag] = spanConfig

package/packages/dd-trace/src/plugins/index.js

@@ -18,66 +18,66 @@ module.exports = {
   get '@opensearch-project/opensearch' () { return require('../../../datadog-plugin-opensearch/src') },
   get '@redis/client' () { return require('../../../datadog-plugin-redis/src') },
   get '@smithy/smithy-client' () { return require('../../../datadog-plugin-aws-sdk/src') },
-  get 'aerospike' () { return require('../../../datadog-plugin-aerospike/src') },
-  get 'amqp10' () { return require('../../../datadog-plugin-amqp10/src') },
-  get 'amqplib' () { return require('../../../datadog-plugin-amqplib/src') },
+  get aerospike () { return require('../../../datadog-plugin-aerospike/src') },
+  get amqp10 () { return require('../../../datadog-plugin-amqp10/src') },
+  get amqplib () { return require('../../../datadog-plugin-amqplib/src') },
   get 'aws-sdk' () { return require('../../../datadog-plugin-aws-sdk/src') },
-  get 'bunyan' () { return require('../../../datadog-plugin-bunyan/src') },
+  get bunyan () { return require('../../../datadog-plugin-bunyan/src') },
   get 'cassandra-driver' () { return require('../../../datadog-plugin-cassandra-driver/src') },
-  get 'child_process' () { return require('../../../datadog-plugin-child_process/src') },
-  get 'connect' () { return require('../../../datadog-plugin-connect/src') },
-  get 'couchbase' () { return require('../../../datadog-plugin-couchbase/src') },
-  get 'cypress' () { return require('../../../datadog-plugin-cypress/src') },
-  get 'dns' () { return require('../../../datadog-plugin-dns/src') },
-  get 'elasticsearch' () { return require('../../../datadog-plugin-elasticsearch/src') },
-  get 'express' () { return require('../../../datadog-plugin-express/src') },
-  get 'fastify' () { return require('../../../datadog-plugin-fastify/src') },
+  get child_process () { return require('../../../datadog-plugin-child_process/src') },
+  get connect () { return require('../../../datadog-plugin-connect/src') },
+  get couchbase () { return require('../../../datadog-plugin-couchbase/src') },
+  get cypress () { return require('../../../datadog-plugin-cypress/src') },
+  get dns () { return require('../../../datadog-plugin-dns/src') },
+  get elasticsearch () { return require('../../../datadog-plugin-elasticsearch/src') },
+  get express () { return require('../../../datadog-plugin-express/src') },
+  get fastify () { return require('../../../datadog-plugin-fastify/src') },
   get 'find-my-way' () { return require('../../../datadog-plugin-find-my-way/src') },
-  get 'graphql' () { return require('../../../datadog-plugin-graphql/src') },
-  get 'grpc' () { return require('../../../datadog-plugin-grpc/src') },
-  get 'hapi' () { return require('../../../datadog-plugin-hapi/src') },
-  get 'http' () { return require('../../../datadog-plugin-http/src') },
-  get 'http2' () { return require('../../../datadog-plugin-http2/src') },
-  get 'https' () { return require('../../../datadog-plugin-http/src') },
-  get 'ioredis' () { return require('../../../datadog-plugin-ioredis/src') },
+  get graphql () { return require('../../../datadog-plugin-graphql/src') },
+  get grpc () { return require('../../../datadog-plugin-grpc/src') },
+  get hapi () { return require('../../../datadog-plugin-hapi/src') },
+  get http () { return require('../../../datadog-plugin-http/src') },
+  get http2 () { return require('../../../datadog-plugin-http2/src') },
+  get https () { return require('../../../datadog-plugin-http/src') },
+  get ioredis () { return require('../../../datadog-plugin-ioredis/src') },
   get 'jest-circus' () { return require('../../../datadog-plugin-jest/src') },
   get 'jest-config' () { return require('../../../datadog-plugin-jest/src') },
   get 'jest-environment-node' () { return require('../../../datadog-plugin-jest/src') },
   get 'jest-environment-jsdom' () { return require('../../../datadog-plugin-jest/src') },
   get 'jest-jasmine2' () { return require('../../../datadog-plugin-jest/src') },
   get 'jest-worker' () { return require('../../../datadog-plugin-jest/src') },
-  get 'koa' () { return require('../../../datadog-plugin-koa/src') },
+  get koa () { return require('../../../datadog-plugin-koa/src') },
   get 'koa-router' () { return require('../../../datadog-plugin-koa/src') },
-  get 'kafkajs' () { return require('../../../datadog-plugin-kafkajs/src') },
-  get 'mariadb' () { return require('../../../datadog-plugin-mariadb/src') },
-  get 'memcached' () { return require('../../../datadog-plugin-memcached/src') },
+  get kafkajs () { return require('../../../datadog-plugin-kafkajs/src') },
+  get mariadb () { return require('../../../datadog-plugin-mariadb/src') },
+  get memcached () { return require('../../../datadog-plugin-memcached/src') },
   get 'microgateway-core' () { return require('../../../datadog-plugin-microgateway-core/src') },
-  get 'mocha' () { return require('../../../datadog-plugin-mocha/src') },
+  get mocha () { return require('../../../datadog-plugin-mocha/src') },
   get 'mocha-each' () { return require('../../../datadog-plugin-mocha/src') },
-  get 'moleculer' () { return require('../../../datadog-plugin-moleculer/src') },
-  get 'mongodb' () { return require('../../../datadog-plugin-mongodb-core/src') },
+  get moleculer () { return require('../../../datadog-plugin-moleculer/src') },
+  get mongodb () { return require('../../../datadog-plugin-mongodb-core/src') },
   get 'mongodb-core' () { return require('../../../datadog-plugin-mongodb-core/src') },
-  get 'mysql' () { return require('../../../datadog-plugin-mysql/src') },
-  get 'mysql2' () { return require('../../../datadog-plugin-mysql2/src') },
-  get 'net' () { return require('../../../datadog-plugin-net/src') },
-  get 'next' () { return require('../../../datadog-plugin-next/src') },
+  get mysql () { return require('../../../datadog-plugin-mysql/src') },
+  get mysql2 () { return require('../../../datadog-plugin-mysql2/src') },
+  get net () { return require('../../../datadog-plugin-net/src') },
+  get next () { return require('../../../datadog-plugin-next/src') },
   get 'node:dns' () { return require('../../../datadog-plugin-dns/src') },
   get 'node:http' () { return require('../../../datadog-plugin-http/src') },
   get 'node:http2' () { return require('../../../datadog-plugin-http2/src') },
   get 'node:https' () { return require('../../../datadog-plugin-http/src') },
   get 'node:net' () { return require('../../../datadog-plugin-net/src') },
-  get 'oracledb' () { return require('../../../datadog-plugin-oracledb/src') },
-  get 'openai' () { return require('../../../datadog-plugin-openai/src') },
-  get 'paperplane' () { return require('../../../datadog-plugin-paperplane/src') },
-  get 'pg' () { return require('../../../datadog-plugin-pg/src') },
-  get 'pino' () { return require('../../../datadog-plugin-pino/src') },
+  get oracledb () { return require('../../../datadog-plugin-oracledb/src') },
+  get openai () { return require('../../../datadog-plugin-openai/src') },
+  get paperplane () { return require('../../../datadog-plugin-paperplane/src') },
+  get pg () { return require('../../../datadog-plugin-pg/src') },
+  get pino () { return require('../../../datadog-plugin-pino/src') },
   get 'pino-pretty' () { return require('../../../datadog-plugin-pino/src') },
-  get 'playwright' () { return require('../../../datadog-plugin-playwright/src') },
-  get 'redis' () { return require('../../../datadog-plugin-redis/src') },
-  get 'restify' () { return require('../../../datadog-plugin-restify/src') },
-  get 'rhea' () { return require('../../../datadog-plugin-rhea/src') },
-  get 'router' () { return require('../../../datadog-plugin-router/src') },
-  get 'sharedb' () { return require('../../../datadog-plugin-sharedb/src') },
-  get 'tedious' () { return require('../../../datadog-plugin-tedious/src') },
-  get 'winston' () { return require('../../../datadog-plugin-winston/src') }
+  get playwright () { return require('../../../datadog-plugin-playwright/src') },
+  get redis () { return require('../../../datadog-plugin-redis/src') },
+  get restify () { return require('../../../datadog-plugin-restify/src') },
+  get rhea () { return require('../../../datadog-plugin-rhea/src') },
+  get router () { return require('../../../datadog-plugin-router/src') },
+  get sharedb () { return require('../../../datadog-plugin-sharedb/src') },
+  get tedious () { return require('../../../datadog-plugin-tedious/src') },
+  get winston () { return require('../../../datadog-plugin-winston/src') }
 }

package/packages/dd-trace/src/plugins/plugin.js

@@ -84,7 +84,7 @@ module.exports = class Plugin {
 
     if (!store || !store.span) return
 
-    if (!store.span._spanContext._tags['error']) {
+    if (!store.span._spanContext._tags.error) {
       store.span.setTag('error', error || 1)
     }
   }

package/packages/dd-trace/src/plugins/tracing.js

@@ -94,7 +94,7 @@ class TracingPlugin extends Plugin {
   }
 
   addError (error, span = this.activeSpan) {
-    if (!span._spanContext._tags['error']) {
+    if (!span._spanContext._tags.error) {
       // Errors may be wrapped in a context.
       error = (error && error.error) || error
       span.setTag('error', error || 1)