dd-trace 5.52.0 → 5.54.0

package/packages/dd-trace/src/msgpack/encoder.js

@@ -49,14 +49,14 @@ class MsgpackEncoder {
     const offset = bytes.length
 
     bytes.reserve(1)
-    bytes.buffer[offset] = 0xc0
+    bytes.buffer[offset] = 0xC0
   }
 
   encodeBoolean (bytes, value) {
     const offset = bytes.length
 
     bytes.reserve(1)
-    bytes.buffer[offset] = value ? 0xc3 : 0xc2
+    bytes.buffer[offset] = value ? 0xC3 : 0xC2
   }
 
   encodeString (bytes, value) {
@@ -75,7 +75,7 @@ class MsgpackEncoder {
     const offset = bytes.length
 
     bytes.reserve(5)
-    bytes.buffer[offset] = 0xdd
+    bytes.buffer[offset] = 0xDD
     bytes.buffer[offset + 1] = length >> 24
     bytes.buffer[offset + 2] = length >> 16
     bytes.buffer[offset + 3] = length >> 8
@@ -105,7 +105,7 @@ class MsgpackEncoder {
     const offset = bytes.length
 
     bytes.reserve(5)
-    bytes.buffer[offset] = 0xdf
+    bytes.buffer[offset] = 0xDF
     bytes.buffer[offset + 1] = keysLength >> 24
     bytes.buffer[offset + 2] = keysLength >> 16
     bytes.buffer[offset + 3] = keysLength >> 8
@@ -122,16 +122,16 @@ class MsgpackEncoder {
 
     if (value.byteLength < 256) {
       bytes.reserve(2)
-      bytes.buffer[offset] = 0xc4
+      bytes.buffer[offset] = 0xC4
       bytes.buffer[offset + 1] = value.byteLength
-    } else if (value.byteLength < 65536) {
+    } else if (value.byteLength < 65_536) {
       bytes.reserve(3)
-      bytes.buffer[offset] = 0xc5
+      bytes.buffer[offset] = 0xC5
       bytes.buffer[offset + 1] = value.byteLength >> 8
       bytes.buffer[offset + 2] = value.byteLength
     } else {
       bytes.reserve(5)
-      bytes.buffer[offset] = 0xc6
+      bytes.buffer[offset] = 0xC6
       bytes.buffer[offset + 1] = value.byteLength >> 24
       bytes.buffer[offset + 2] = value.byteLength >> 16
       bytes.buffer[offset + 3] = value.byteLength >> 8
@@ -145,7 +145,7 @@ class MsgpackEncoder {
     const offset = bytes.length
 
     bytes.reserve(5)
-    bytes.buffer[offset] = 0xce
+    bytes.buffer[offset] = 0xCE
     bytes.buffer[offset + 1] = value >> 24
     bytes.buffer[offset + 2] = value >> 16
     bytes.buffer[offset + 3] = value >> 8
@@ -156,7 +156,7 @@ class MsgpackEncoder {
     const offset = bytes.length
 
     bytes.reserve(3)
-    bytes.buffer[offset] = 0xcd
+    bytes.buffer[offset] = 0xCD
     bytes.buffer[offset + 1] = value >> 8
     bytes.buffer[offset + 2] = value
   }
@@ -167,7 +167,7 @@ class MsgpackEncoder {
     const lo = value >>> 0
 
     bytes.reserve(9)
-    bytes.buffer[offset] = 0xcf
+    bytes.buffer[offset] = 0xCF
     bytes.buffer[offset + 1] = hi >> 24
     bytes.buffer[offset + 2] = hi >> 16
     bytes.buffer[offset + 3] = hi >> 8
@@ -201,16 +201,16 @@ class MsgpackEncoder {
       bytes.buffer[offset] = value
     } else if (value >= -0x80) {
       bytes.reserve(2)
-      bytes.buffer[offset] = 0xd0
+      bytes.buffer[offset] = 0xD0
       bytes.buffer[offset + 1] = value
-    } else if (value >= -0x8000) {
+    } else if (value >= -0x80_00) {
       bytes.reserve(3)
-      bytes.buffer[offset] = 0xd1
+      bytes.buffer[offset] = 0xD1
       bytes.buffer[offset + 1] = value >> 8
       bytes.buffer[offset + 2] = value
-    } else if (value >= -0x80000000) {
+    } else if (value >= -0x80_00_00_00) {
       bytes.reserve(5)
-      bytes.buffer[offset] = 0xd2
+      bytes.buffer[offset] = 0xD2
       bytes.buffer[offset + 1] = value >> 24
       bytes.buffer[offset + 2] = value >> 16
       bytes.buffer[offset + 3] = value >> 8
@@ -220,7 +220,7 @@ class MsgpackEncoder {
       const lo = value >>> 0
 
       bytes.reserve(9)
-      bytes.buffer[offset] = 0xd3
+      bytes.buffer[offset] = 0xD3
       bytes.buffer[offset + 1] = hi >> 24
       bytes.buffer[offset + 2] = hi >> 16
       bytes.buffer[offset + 3] = hi >> 8
@@ -235,21 +235,21 @@ class MsgpackEncoder {
   encodeUnsigned (bytes, value) {
     const offset = bytes.length
 
-    if (value <= 0x7f) {
+    if (value <= 0x7F) {
       bytes.reserve(1)
       bytes.buffer[offset] = value
-    } else if (value <= 0xff) {
+    } else if (value <= 0xFF) {
       bytes.reserve(2)
-      bytes.buffer[offset] = 0xcc
+      bytes.buffer[offset] = 0xCC
       bytes.buffer[offset + 1] = value
-    } else if (value <= 0xffff) {
+    } else if (value <= 0xFF_FF) {
       bytes.reserve(3)
-      bytes.buffer[offset] = 0xcd
+      bytes.buffer[offset] = 0xCD
       bytes.buffer[offset + 1] = value >> 8
       bytes.buffer[offset + 2] = value
-    } else if (value <= 0xffffffff) {
+    } else if (value <= 0xFF_FF_FF_FF) {
       bytes.reserve(5)
-      bytes.buffer[offset] = 0xce
+      bytes.buffer[offset] = 0xCE
       bytes.buffer[offset + 1] = value >> 24
       bytes.buffer[offset + 2] = value >> 16
       bytes.buffer[offset + 3] = value >> 8
@@ -259,7 +259,7 @@ class MsgpackEncoder {
       const lo = value >>> 0
 
       bytes.reserve(9)
-      bytes.buffer[offset] = 0xcf
+      bytes.buffer[offset] = 0xCF
       bytes.buffer[offset + 1] = hi >> 24
       bytes.buffer[offset + 2] = hi >> 16
       bytes.buffer[offset + 3] = hi >> 8
@@ -278,10 +278,10 @@ class MsgpackEncoder {
     bytes.reserve(9)
 
     if (value >= 0n) {
-      bytes.buffer[offset] = 0xcf
+      bytes.buffer[offset] = 0xCF
       bytes.view.setBigUint64(offset + 1, value)
     } else {
-      bytes.buffer[offset] = 0xd3
+      bytes.buffer[offset] = 0xD3
       bytes.view.setBigInt64(offset + 1, value)
     }
   }
@@ -301,7 +301,7 @@ class MsgpackEncoder {
     const offset = bytes.length
 
     bytes.reserve(9)
-    bytes.buffer[offset] = 0xcb
+    bytes.buffer[offset] = 0xCB
     bytes.view.setFloat64(offset + 1, value)
   }
 }

package/packages/dd-trace/src/noop/dogstatsd.js

@@ -3,15 +3,15 @@
  * @implements {DogStatsD}
  */
 module.exports = class NoopDogStatsDClient {
-  increment () { }
+  increment () {}
 
-  decrement () { }
+  decrement () {}
 
-  gauge () { }
+  gauge () {}
 
-  distribution () { }
+  distribution () {}
 
-  histogram () { }
+  histogram () {}
 
-  flush () { }
+  flush () {}
 }

package/packages/dd-trace/src/noop/span.js

@@ -30,21 +30,19 @@ class NoopSpan {
   _createContext (parent) {
     const spanId = id()
 
-    if (parent) {
-      return new NoopSpanContext({
+    return parent
+      ? new NoopSpanContext({
         noop: this,
         traceId: parent._traceId,
         spanId,
         parentId: parent._spanId,
         baggageItems: Object.assign({}, parent._baggageItems)
       })
-    } else {
-      return new NoopSpanContext({
+      : new NoopSpanContext({
         noop: this,
         traceId: spanId,
         spanId
       })
-    }
   }
 }
 

package/packages/dd-trace/src/noop/tracer.js

@@ -27,8 +27,7 @@ class NoopTracer {
     return ''
   }
 
-  setUrl () {
-  }
+  setUrl () {}
 
   startSpan (name, options) {
     return this._span

package/packages/dd-trace/src/opentelemetry/span_processor.js

@@ -5,8 +5,8 @@ class NoopSpanProcessor {
     return Promise.resolve()
   }
 
-  onStart (span, context) { }
-  onEnd (span) { }
+  onStart (span, context) {}
+  onEnd (span) {}
 
   shutdown () {
     return Promise.resolve()

package/packages/dd-trace/src/opentelemetry/tracer.js

@@ -71,7 +71,11 @@ class Tracer {
 
         // Update meta and samplingPriority based on extracted values
         Object.assign(meta, otherPropagatedTags)
-        samplingPriority = TextMapPropagator._getSamplingPriority(traceFlag, parseInt(samplingPriorityTs, 10), origin)
+        samplingPriority = TextMapPropagator._getSamplingPriority(
+          traceFlag,
+          Number.parseInt(samplingPriorityTs, 10),
+          origin
+        )
       } else {
         log.debug(`no dd list member in tracestate from incoming request: ${ts}`)
       }
@@ -144,10 +148,7 @@ class Tracer {
 
       // Set initial span attributes. The attributes object may have been mutated
       // by the sampler, so we sanitize the merged attributes before setting them.
-      sanitizeAttributes(
-        // Object.assign(attributes, samplingResult.attributes)
-        attributes
-      )
+      sanitizeAttributes(attributes)
     )
   }
 

package/packages/dd-trace/src/opentracing/propagation/log.js

@@ -14,12 +14,10 @@ class LogPropagator {
     carrier.dd = {}
 
     if (spanContext) {
-      if (this._config.traceId128BitGenerationEnabled &&
-        this._config.traceId128BitLoggingEnabled && spanContext._trace.tags['_dd.p.tid']) {
-        carrier.dd.trace_id = spanContext.toTraceId(true)
-      } else {
-        carrier.dd.trace_id = spanContext.toTraceId()
-      }
+      carrier.dd.trace_id = this._config.traceId128BitGenerationEnabled &&
+        this._config.traceId128BitLoggingEnabled && spanContext._trace.tags['_dd.p.tid']
+        ? spanContext.toTraceId(true)
+        : spanContext.toTraceId()
 
       carrier.dd.span_id = spanContext.toSpanId()
     }
@@ -35,8 +33,8 @@ class LogPropagator {
     }
 
     if (carrier.dd.trace_id.length === 32) {
-      const hi = carrier.dd.trace_id.substring(0, 16)
-      const lo = carrier.dd.trace_id.substring(16, 32)
+      const hi = carrier.dd.trace_id.slice(0, 16)
+      const lo = carrier.dd.trace_id.slice(16, 32)
       const spanContext = new DatadogSpanContext({
         traceId: id(lo, 16),
         spanId: id(carrier.dd.span_id, 10)

package/packages/dd-trace/src/opentracing/propagation/text_map.js

@@ -31,21 +31,21 @@ const b3HeaderKey = 'b3'
 const sqsdHeaderHey = 'x-aws-sqsd-attr-_datadog'
 const b3HeaderExpr = /^(([0-9a-f]{16}){1,2}-[0-9a-f]{16}(-[01d](-[0-9a-f]{16})?)?|[01d])$/i
 const baggageExpr = new RegExp(`^${baggagePrefix}(.+)$`)
-const tagKeyExpr = /^_dd\.p\.[\x21-\x2b\x2d-\x7e]+$/ // ASCII minus spaces and commas
-const tagValueExpr = /^[\x20-\x2b\x2d-\x7e]*$/ // ASCII minus commas
+const tagKeyExpr = /^_dd\.p\.[\x21-\x2B\x2D-\x7E]+$/ // ASCII minus spaces and commas
+const tagValueExpr = /^[\x20-\x2B\x2D-\x7E]*$/ // ASCII minus commas
 const traceparentExpr = /^([a-f0-9]{2})-([a-f0-9]{32})-([a-f0-9]{16})-([a-f0-9]{2})(-.*)?$/i
 const traceparentKey = 'traceparent'
 const tracestateKey = 'tracestate'
 const ddKeys = [traceKey, spanKey, samplingKey, originKey]
 const b3Keys = [b3TraceKey, b3SpanKey, b3ParentKey, b3SampledKey, b3FlagsKey, b3HeaderKey]
 const w3cKeys = [traceparentKey, tracestateKey]
-const logKeys = ddKeys.concat(b3Keys, w3cKeys)
+const logKeys = [...ddKeys, ...b3Keys, ...w3cKeys]
 // Origin value in tracestate replaces '~', ',' and ';' with '_"
-const tracestateOriginFilter = /[^\x20-\x2b\x2d-\x3a\x3c-\x7d]/g
+const tracestateOriginFilter = /[^\x20-\x2B\x2D-\x3A\x3C-\x7D]/g
 // Tag keys in tracestate replace ' ', ',' and '=' with '_'
-const tracestateTagKeyFilter = /[^\x21-\x2b\x2d-\x3c\x3e-\x7e]/g
+const tracestateTagKeyFilter = /[^\x21-\x2B\x2D-\x3C\x3E-\x7E]/g
 // Tag values in tracestate replace ',', '~' and ';' with '_'
-const tracestateTagValueFilter = /[^\x20-\x2b\x2d-\x3a\x3c-\x7d]/g
+const tracestateTagValueFilter = /[^\x20-\x2B\x2D-\x3A\x3C-\x7D]/g
 const invalidSegment = /^0+$/
 const zeroTraceId = '0000000000000000'
 const hex16 = /^[0-9A-Fa-f]{16}$/
@@ -146,7 +146,7 @@ class TextMapPropagator {
         baggage += item
       }
 
-      baggage = baggage.slice(0, baggage.length - 1)
+      baggage = baggage.slice(0, -1)
       if (baggage) carrier.baggage = baggage
     }
   }
@@ -240,7 +240,7 @@ class TextMapPropagator {
       if (typeof origin === 'string') {
         const originValue = origin
           .replace(tracestateOriginFilter, '_')
-          .replace(/[\x3d]/g, '~')
+          .replace(/[\x3D]/g, '~')
 
         state.set('o', originValue)
       }
@@ -254,7 +254,7 @@ class TextMapPropagator {
         const tagValue = tags[key]
           .toString()
           .replace(tracestateTagValueFilter, '_')
-          .replace(/[\x3d]/g, '~')
+          .replace(/[\x3D]/g, '~')
 
         state.set(tagKey, tagValue)
       }
@@ -316,12 +316,10 @@ class TextMapPropagator {
           extractedContext = this._extractB3SingleContext(carrier)
           break
         case 'b3':
-          if (this._config.tracePropagationStyle.otelPropagators) {
+          extractedContext = this._config.tracePropagationStyle.otelPropagators
             // TODO: should match "b3 single header" in next major
-            extractedContext = this._extractB3SingleContext(carrier)
-          } else {
-            extractedContext = this._extractB3MultiContext(carrier)
-          }
+            ? this._extractB3SingleContext(carrier)
+            : this._extractB3MultiContext(carrier)
           break
         case 'b3multi':
           extractedContext = this._extractB3MultiContext(carrier)
@@ -442,7 +440,7 @@ class TextMapPropagator {
     let parsed
     try {
       parsed = JSON.parse(headerValue)
-    } catch (e) {
+    } catch {
       return null
     }
     return this._extractDatadogContext(parsed)
@@ -471,7 +469,7 @@ class TextMapPropagator {
         traceId: id(traceId, 16),
         spanId: id(spanId, 16),
         isRemote: true,
-        sampling: { priority: parseInt(flags, 10) & 1 ? 1 : 0 },
+        sampling: { priority: Number.parseInt(flags, 10) & 1 ? 1 : 0 },
         traceparent,
         tracestate
       })
@@ -486,7 +484,7 @@ class TextMapPropagator {
               break
             }
             case 's': {
-              const priority = parseInt(value, 10)
+              const priority = Number.parseInt(value, 10)
               if (!Number.isInteger(priority)) continue
               if (
                 (spanContext._sampling.priority === 1 && priority > 0) ||
@@ -500,7 +498,7 @@ class TextMapPropagator {
               spanContext._trace.origin = value
               break
             case 't.dm': {
-              const mechanism = Math.abs(parseInt(value, 10))
+              const mechanism = Math.abs(Number.parseInt(value, 10))
               if (Number.isInteger(mechanism)) {
                 spanContext._sampling.mechanism = mechanism
                 spanContext._trace.tags['_dd.p.dm'] = `-${mechanism}`
@@ -510,7 +508,7 @@ class TextMapPropagator {
             default: {
               if (!key.startsWith('t.')) continue
               const subKey = key.slice(2) // e.g. t.tid -> tid
-              const transformedValue = value.replace(/[\x7e]/gm, '=')
+              const transformedValue = value.replace(/[\x7E]/gm, '=')
 
               // If subkey is tid  then do nothing because trace header tid should always be preserved
               if (subKey === 'tid') {
@@ -590,7 +588,7 @@ class TextMapPropagator {
       }
 
       if (parts[2]) {
-        b3[b3SampledKey] = parts[2] !== '0' ? '1' : '0'
+        b3[b3SampledKey] = parts[2] === '0' ? '0' : '1'
 
         if (parts[2] === 'd') {
           b3[b3FlagsKey] = '1'
@@ -633,6 +631,9 @@ class TextMapPropagator {
     if (!carrier || !carrier.baggage) return
     if (!spanContext) removeAllBaggageItems()
     const baggages = carrier.baggage.split(',')
+    const keysToSpanTag = this._config.baggageTagKeys === '*'
+      ? undefined
+      : new Set(this._config.baggageTagKeys.split(','))
     for (const keyValue of baggages) {
       if (!keyValue.includes('=')) {
         if (spanContext) spanContext._baggageItems = {}
@@ -647,8 +648,11 @@ class TextMapPropagator {
       }
       // the current code assumes precedence of ot-baggage- (legacy opentracing baggage) over baggage
       if (spanContext) {
-        if (key in spanContext._baggageItems) return
+        if (Object.hasOwn(spanContext._baggageItems, key)) continue
         spanContext._baggageItems[key] = value
+        if (this._config.baggageTagKeys === '*' || keysToSpanTag.has(key)) {
+          spanContext._trace.tags['baggage.' + key] = value
+        }
       } else {
         setBaggageItem(key, value)
       }
@@ -656,7 +660,7 @@ class TextMapPropagator {
   }
 
   _extractSamplingPriority (carrier, spanContext) {
-    const priority = parseInt(carrier[samplingKey], 10)
+    const priority = Number.parseInt(carrier[samplingKey], 10)
 
     if (Number.isInteger(priority)) {
       spanContext._sampling.priority = priority
@@ -703,7 +707,7 @@ class TextMapPropagator {
 
     if (buffer.length !== 16) return
 
-    const tid = traceId.substring(0, 16)
+    const tid = traceId.slice(0, 16)
 
     if (tid === zeroTraceId) return
 

package/packages/dd-trace/src/opentracing/propagation/tracestate.js

@@ -17,10 +17,14 @@ function fromString (Type, regex, value) {
 }
 
 function toString (map, pairSeparator, fieldSeparator) {
-  return Array.from(map.entries())
-    .reverse()
-    .map((pair) => pair.join(pairSeparator))
-    .join(fieldSeparator)
+  let result = ''
+  for (const [key, value] of map) {
+    if (result) {
+      result = `${fieldSeparator}${result}`
+    }
+    result = `${key}${pairSeparator}${value}${result}`
+  }
+  return result
 }
 
 class TraceStateData extends Map {

package/packages/dd-trace/src/opentracing/span.js

@@ -4,7 +4,6 @@
 const { performance } = require('perf_hooks')
 const now = performance.now.bind(performance)
 const dateNow = Date.now
-const satisfies = require('semifies')
 const SpanContext = require('./span_context')
 const id = require('../id')
 const tagger = require('../tagger')
@@ -26,7 +25,7 @@ const unfinishedRegistry = createRegistry('unfinished')
 const finishedRegistry = createRegistry('finished')
 
 const OTEL_ENABLED = !!process.env.DD_TRACE_OTEL_ENABLED
-const ALLOWED = ['string', 'number', 'boolean']
+const ALLOWED = new Set(['string', 'number', 'boolean'])
 
 const integrationCounters = {
   spans_created: {},
@@ -129,7 +128,7 @@ class DatadogSpan {
     const spanContext = this.context()
     const resourceName = spanContext._tags['resource.name'] || ''
     const resource = resourceName.length > 100
-      ? `${resourceName.substring(0, 97)}...`
+      ? `${resourceName.slice(0, 97)}...`
       : resourceName
     const json = JSON.stringify({
       traceId: spanContext._traceId,
@@ -198,7 +197,7 @@ class DatadogSpan {
 
   addLink (context, attributes) {
     this._links.push({
-      context: context._ddContext ? context._ddContext : context,
+      context: context._ddContext ?? context,
       attributes: this._sanitizeAttributes(attributes)
     })
   }
@@ -235,10 +234,8 @@ class DatadogSpan {
       return
     }
 
-    if (DD_TRACE_EXPERIMENTAL_STATE_TRACKING === 'true') {
-      if (!this._spanContext._tags['service.name']) {
-        log.error('Finishing invalid span: %s', this)
-      }
+    if (DD_TRACE_EXPERIMENTAL_STATE_TRACKING === 'true' && !this._spanContext._tags['service.name']) {
+      log.error('Finishing invalid span: %s', this)
     }
 
     getIntegrationCounter('spans_finished', this._integrationName).inc()
@@ -256,7 +253,7 @@ class DatadogSpan {
       finishedRegistry.register(this, this._name)
     }
 
-    finishTime = parseFloat(finishTime) || this._getTime()
+    finishTime = Number.parseFloat(finishTime) || this._getTime()
 
     this._duration = finishTime - this._startTime
     this._spanContext._trace.finished.push(this)
@@ -275,7 +272,7 @@ class DatadogSpan {
         }
       } else {
         const maybeScalar = maybeArray
-        if (ALLOWED.includes(typeof maybeScalar)) {
+        if (ALLOWED.has(typeof maybeScalar)) {
           // Wrap the value as a string if it's not already a string
           sanitizedAttributes[key] = typeof maybeScalar === 'string' ? maybeScalar : String(maybeScalar)
         } else {
@@ -299,14 +296,14 @@ class DatadogSpan {
       if (Array.isArray(value)) {
         const newArray = []
         for (const subkey in value) {
-          if (ALLOWED.includes(typeof value[subkey])) {
+          if (ALLOWED.has(typeof value[subkey])) {
             newArray.push(value[subkey])
           } else {
             log.warn('Dropping span event attribute. It is not of an allowed type')
           }
         }
         sanitizedAttributes[key] = newArray
-      } else if (ALLOWED.includes(typeof value)) {
+      } else if (ALLOWED.has(typeof value)) {
         sanitizedAttributes[key] = value
       } else {
         log.warn('Dropping span event attribute. It is not of an allowed type')
@@ -388,8 +385,6 @@ class DatadogSpan {
 }
 
 function createRegistry (type) {
-  if (!satisfies(process.version, '>=14.6')) return
-
   return new global.FinalizationRegistry(name => {
     runtimeMetrics.decrement(`runtime.node.spans.${type}`)
     runtimeMetrics.decrement(`runtime.node.spans.${type}.by.name`, [`span_name:${name}`])

package/packages/dd-trace/src/opentracing/tracer.js

@@ -107,6 +107,12 @@ class DatadogTracer {
   }
 }
 
+/**
+ * Get the span context from a span or a span context.
+ *
+ * @param {Span|SpanContext} spanContext
+ * @returns {SpanContext}
+ */
 function getContext (spanContext) {
   if (spanContext instanceof Span) {
     spanContext = spanContext.context()
@@ -122,17 +128,14 @@ function getContext (spanContext) {
 function getParent (references = []) {
   let parent = null
 
-  for (let i = 0; i < references.length; i++) {
-    const ref = references[i]
+  for (const ref of references) {
     const type = ref.type()
 
     if (type === REFERENCE_CHILD_OF) {
       parent = ref.referencedContext()
       break
-    } else if (type === REFERENCE_FOLLOWS_FROM) {
-      if (!parent) {
-        parent = ref.referencedContext()
-      }
+    } else if (type === REFERENCE_FOLLOWS_FROM && !parent) {
+      parent = ref.referencedContext()
     }
   }
 

package/packages/dd-trace/src/payload-tagging/index.js

@@ -22,7 +22,7 @@ function maybeJSONParseValue (value) {
 
   try {
     return JSON.parse(value)
-  } catch (e) {
+  } catch {
     return value
   }
 }

package/packages/dd-trace/src/payload-tagging/tagging.js

@@ -1,13 +1,13 @@
 const { PAYLOAD_TAGGING_MAX_TAGS } = require('../constants')
 
-const redactedKeys = [
+const redactedKeys = new Set([
   'authorization', 'x-authorization', 'password', 'token'
-]
+])
 const truncated = 'truncated'
 const redacted = 'redacted'
 
 function escapeKey (key) {
-  return key.replaceAll('.', '\\.')
+  return key.replaceAll('.', String.raw`\.`)
 }
 
 /**
@@ -56,18 +56,18 @@ function tagsFromObject (object, opts) {
 
     if (['number', 'boolean'].includes(typeof object) || Buffer.isBuffer(object)) {
       tagCount += 1
-      result[prefix] = object.toString().substring(0, 5000)
+      result[prefix] = object.toString().slice(0, 5000)
       return
     }
 
     if (typeof object === 'string') {
       tagCount += 1
-      result[prefix] = object.substring(0, 5000)
+      result[prefix] = object.slice(0, 5000)
     }
 
     if (typeof object === 'object') {
       for (const [key, value] of Object.entries(object)) {
-        if (redactedKeys.includes(key.toLowerCase())) {
+        if (redactedKeys.has(key.toLowerCase())) {
           tagCount += 1
           result[`${prefix}.${escapeKey(key)}`] = redacted
         } else {

package/packages/dd-trace/src/pkg.js

@@ -22,7 +22,7 @@ function findPkg () {
 
   try {
     return JSON.parse(fs.readFileSync(filePath, 'utf8'))
-  } catch (e) {
+  } catch {
     return {}
   }
 }