dd-trace 5.51.0 → 5.52.0

package/packages/datadog-plugin-fs/src/index.js

@@ -10,9 +10,10 @@ class FsPlugin extends TracingPlugin {
     return super.configure(...args)
   }
 
-  start ({ operation, ...params }) {
+  bindStart (ctx) {
     if (!this.activeSpan) return this.skip()
 
+    const { operation, ...params } = ctx
     const lowerOp = operation.toLowerCase()
     const flag = params.flag || params.flags || (params.options && (params.options.flag || params.options.flags))
     const defaultFlag = ((lowerOp.includes('open') || lowerOp.includes('read')) && 'r') ||
@@ -38,7 +39,13 @@ class FsPlugin extends TracingPlugin {
         'file.src': params.src || params.oldPath || params.existingPath || params.target,
         'file.uid': uid || ''
       }
-    })
+    }, ctx)
+
+    return ctx.currentStore
+  }
+
+  bindFinish (ctx) {
+    return ctx.parentStore
   }
 }
 

package/packages/datadog-plugin-jest/src/index.js

@@ -346,6 +346,7 @@ class JestPlugin extends CiPlugin {
       testStartLine,
       attemptToFixPassed,
       failedAllTests,
+      attemptToFixFailed,
       isAtrRetry
     }) => {
       const span = storage('legacy').getStore().span
@@ -355,6 +356,8 @@ class JestPlugin extends CiPlugin {
       }
       if (attemptToFixPassed) {
         span.setTag(TEST_MANAGEMENT_ATTEMPT_TO_FIX_PASSED, 'true')
+      } else if (attemptToFixFailed) {
+        span.setTag(TEST_MANAGEMENT_ATTEMPT_TO_FIX_PASSED, 'false')
       }
       if (failedAllTests) {
         span.setTag(TEST_HAS_FAILED_ALL_RETRIES, 'true')

package/packages/datadog-plugin-kafkajs/src/batch-consumer.js

@@ -1,5 +1,6 @@
 const ConsumerPlugin = require('../../dd-trace/src/plugins/consumer')
 const { getMessageSize } = require('../../dd-trace/src/datastreams')
+const { convertToTextMap } = require('./utils')
 
 class KafkajsBatchConsumerPlugin extends ConsumerPlugin {
   static get id () { return 'kafkajs' }
@@ -10,7 +11,7 @@ class KafkajsBatchConsumerPlugin extends ConsumerPlugin {
     for (const message of messages) {
       if (!message || !message.headers) continue
       const payloadSize = getMessageSize(message)
-      this.tracer.decodeDataStreamsContext(message.headers)
+      this.tracer.decodeDataStreamsContext(convertToTextMap(message.headers))
       const edgeTags = ['direction:in', `group:${groupId}`, `topic:${topic}`, 'type:kafka']
       if (clusterId) {
         edgeTags.push(`kafka_cluster_id:${clusterId}`)

package/packages/datadog-plugin-kafkajs/src/consumer.js

@@ -3,7 +3,7 @@
 const dc = require('dc-polyfill')
 const { getMessageSize } = require('../../dd-trace/src/datastreams')
 const ConsumerPlugin = require('../../dd-trace/src/plugins/consumer')
-
+const { convertToTextMap } = require('./utils')
 const afterStartCh = dc.channel('dd-trace:kafkajs:consumer:afterStart')
 const beforeFinishCh = dc.channel('dd-trace:kafkajs:consumer:beforeFinish')
 
@@ -15,7 +15,7 @@ class KafkajsConsumerPlugin extends ConsumerPlugin {
 
   constructor () {
     super(...arguments)
-    this.addSub('apm:kafkajs:consume:commit', message => this.commit(message))
+    this.addSub(`apm:${this.constructor.id}:consume:commit`, message => this.commit(message))
   }
 
   /**
@@ -65,15 +65,18 @@ class KafkajsConsumerPlugin extends ConsumerPlugin {
   }
 
   start ({ topic, partition, message, groupId, clusterId }) {
-    const childOf = extract(this.tracer, message.headers)
+    let childOf
+    const headers = convertToTextMap(message?.headers)
+    if (headers) {
+      childOf = this.tracer.extract('text_map', headers)
+    }
     const span = this.startSpan({
       childOf,
       resource: topic,
       type: 'worker',
       meta: {
-        component: 'kafkajs',
+        component: this.constructor.id,
         'kafka.topic': topic,
-        'kafka.message.offset': message.offset,
         'kafka.cluster_id': clusterId,
         [MESSAGING_DESTINATION_KEY]: topic
       },
@@ -81,9 +84,11 @@ class KafkajsConsumerPlugin extends ConsumerPlugin {
         'kafka.partition': partition
       }
     })
-    if (this.config.dsmEnabled && message?.headers) {
+    if (message?.offset) span.setTag('kafka.message.offset', message?.offset)
+
+    if (this.config.dsmEnabled && headers) {
       const payloadSize = getMessageSize(message)
-      this.tracer.decodeDataStreamsContext(message.headers)
+      this.tracer.decodeDataStreamsContext(headers)
       const edgeTags = ['direction:in', `group:${groupId}`, `topic:${topic}`, 'type:kafka']
       if (clusterId) {
         edgeTags.push(`kafka_cluster_id:${clusterId}`)
@@ -105,18 +110,4 @@ class KafkajsConsumerPlugin extends ConsumerPlugin {
   }
 }
 
-function extract (tracer, bufferMap) {
-  if (!bufferMap) return null
-
-  const textMap = {}
-
-  for (const key of Object.keys(bufferMap)) {
-    if (bufferMap[key] === null || bufferMap[key] === undefined) continue
-
-    textMap[key] = bufferMap[key].toString()
-  }
-
-  return tracer.extract('text_map', textMap)
-}
-
 module.exports = KafkajsConsumerPlugin

package/packages/datadog-plugin-kafkajs/src/producer.js

@@ -13,7 +13,7 @@ class KafkajsProducerPlugin extends ProducerPlugin {
 
   constructor () {
     super(...arguments)
-    this.addSub('apm:kafkajs:produce:commit', message => this.commit(message))
+    this.addSub(`apm:${this.constructor.id}:produce:commit`, message => this.commit(message))
   }
 
   /**
@@ -54,6 +54,7 @@ class KafkajsProducerPlugin extends ProducerPlugin {
    */
   commit (commitList) {
     if (!this.config.dsmEnabled) return
+    if (!commitList || !Array.isArray(commitList)) return
     const keys = [
       'type',
       'partition',
@@ -70,7 +71,7 @@ class KafkajsProducerPlugin extends ProducerPlugin {
     const span = this.startSpan({
       resource: topic,
       meta: {
-        component: 'kafkajs',
+        component: this.constructor.id,
         'kafka.topic': topic,
         'kafka.cluster_id': clusterId,
         [MESSAGING_DESTINATION_KEY]: topic
@@ -84,6 +85,9 @@ class KafkajsProducerPlugin extends ProducerPlugin {
     }
     for (const message of messages) {
       if (message !== null && typeof message === 'object') {
+        if (!message.headers) {
+          message.headers = {}
+        }
         this.tracer.inject(span, 'text_map', message.headers)
         if (this.config.dsmEnabled) {
           const payloadSize = getMessageSize(message)

package/packages/datadog-plugin-kafkajs/src/utils.js

@@ -0,0 +1,27 @@
+'use strict'
+
+function convertToTextMap (bufferMap) {
+  if (!bufferMap) return null
+
+  // rdKafka returns an array of header maps
+  if (bufferMap instanceof Array) {
+    const headers = {}
+    for (const headerMap of bufferMap) {
+      for (const key of Object.keys(headerMap)) {
+        headers[key] = headerMap[key].toString()
+      }
+    }
+    return headers
+  }
+
+  const textMap = {}
+  for (const key of Object.keys(bufferMap)) {
+    if (bufferMap[key] === null || bufferMap[key] === undefined) continue
+    textMap[key] = bufferMap[key].toString()
+  }
+  return textMap
+}
+
+module.exports = {
+  convertToTextMap
+}

package/packages/datadog-plugin-langchain/src/index.js

@@ -2,7 +2,6 @@
 
 const langChainTracingPlugins = require('./tracing')
 const langChainLLMObsPlugins = require('../../dd-trace/src/llmobs/plugins/langchain')
-// const LangChainLLMObsPlugin = require('../../dd-trace/src/llmobs/plugins/langchain')
 const CompositePlugin = require('../../dd-trace/src/plugins/composite')
 
 const plugins = {}

package/packages/datadog-plugin-mocha/src/index.js

@@ -208,6 +208,7 @@ class MochaPlugin extends CiPlugin {
       isLastRetry,
       hasFailedAllRetries,
       attemptToFixPassed,
+      attemptToFixFailed,
       isAttemptToFixRetry,
       isAtrRetry
     }) => {
@@ -229,6 +230,8 @@ class MochaPlugin extends CiPlugin {
         }
         if (attemptToFixPassed) {
           span.setTag(TEST_MANAGEMENT_ATTEMPT_TO_FIX_PASSED, 'true')
+        } else if (attemptToFixFailed) {
+          span.setTag(TEST_MANAGEMENT_ATTEMPT_TO_FIX_PASSED, 'false')
         }
         if (isAttemptToFixRetry) {
           span.setTag(TEST_IS_RETRY, 'true')

package/packages/datadog-plugin-net/src/ipc.js

@@ -6,15 +6,17 @@ class NetIPCPlugin extends ClientPlugin {
   static get id () { return 'net' }
   static get operation () { return 'ipc' }
 
-  start ({ options }) {
+  bindStart (ctx) {
     this.startSpan('ipc.connect', {
       service: this.config.service,
-      resource: options.path,
+      resource: ctx.options.path,
       kind: 'client',
       meta: {
-        'ipc.path': options.path
+        'ipc.path': ctx.options.path
       }
-    })
+    }, ctx)
+
+    return ctx.currentStore
   }
 }
 

package/packages/datadog-plugin-net/src/tcp.js

@@ -10,20 +10,24 @@ class NetTCPPlugin extends ClientPlugin {
   constructor (...args) {
     super(...args)
 
-    this.addTraceSub('connection', ({ socket }) => {
-      const span = this.activeSpan
+    this.addTraceBind('ready', (ctx) => {
+      return ctx.parentStore
+    })
+
+    this.addTraceSub('connection', (ctx) => {
+      const span = ctx.currentStore.span
 
       span.addTags({
-        'tcp.local.address': socket.localAddress,
-        'tcp.local.port': socket.localPort
+        'tcp.local.address': ctx.socket.localAddress,
+        'tcp.local.port': ctx.socket.localPort
       })
     })
   }
 
-  start ({ options }) {
-    const host = options.host || 'localhost'
-    const port = options.port || 0
-    const family = options.family || 4
+  bindStart (ctx) {
+    const host = ctx.options.host || 'localhost'
+    const port = ctx.options.port || 0
+    const family = ctx.options.family || 4
 
     this.startSpan('tcp.connect', {
       service: this.config.service,
@@ -40,7 +44,9 @@ class NetTCPPlugin extends ClientPlugin {
         'tcp.local.port': 0,
         [CLIENT_PORT_KEY]: port
       }
-    })
+    }, ctx)
+
+    return ctx.currentStore
   }
 }
 

package/packages/datadog-plugin-pg/src/index.js

@@ -8,7 +8,7 @@ class PGPlugin extends DatabasePlugin {
   static get operation () { return 'query' }
   static get system () { return 'postgres' }
 
-  start ({ params = {}, query, processId }) {
+  start ({ params = {}, query, processId, stream }) {
     const service = this.serviceName({ pluginConfig: this.config, params })
     const originalStatement = this.maybeTruncate(query.text)
 
@@ -27,6 +27,10 @@ class PGPlugin extends DatabasePlugin {
       }
     })
 
+    if (stream) {
+      span.setTag('db.stream', 1)
+    }
+
     query.__ddInjectableQuery = this.injectDbmQuery(span, query.text, service, !!query.name)
   }
 }

package/packages/datadog-plugin-playwright/src/index.js

@@ -267,6 +267,7 @@ class PlaywrightPlugin extends CiPlugin {
       isAttemptToFixRetry,
       hasFailedAllRetries,
       hasPassedAttemptToFixRetries,
+      hasFailedAttemptToFixRetries,
       isAtrRetry,
       onDone
     }) => {
@@ -311,6 +312,8 @@ class PlaywrightPlugin extends CiPlugin {
       }
       if (hasPassedAttemptToFixRetries) {
         span.setTag(TEST_MANAGEMENT_ATTEMPT_TO_FIX_PASSED, 'true')
+      } else if (hasFailedAttemptToFixRetries) {
+        span.setTag(TEST_MANAGEMENT_ATTEMPT_TO_FIX_PASSED, 'false')
       }
       if (isDisabled) {
         span.setTag(TEST_MANAGEMENT_IS_DISABLED, 'true')

package/packages/datadog-plugin-vitest/src/index.js

@@ -155,7 +155,7 @@ class VitestPlugin extends CiPlugin {
       }
     })
 
-    this.addSub('ci:vitest:test:finish-time', ({ status, task, attemptToFixPassed }) => {
+    this.addSub('ci:vitest:test:finish-time', ({ status, task, attemptToFixPassed, attemptToFixFailed }) => {
       const store = storage('legacy').getStore()
       const span = store?.span
 
@@ -166,6 +166,8 @@ class VitestPlugin extends CiPlugin {
 
         if (attemptToFixPassed) {
           span.setTag(TEST_MANAGEMENT_ATTEMPT_TO_FIX_PASSED, 'true')
+        } else if (attemptToFixFailed) {
+          span.setTag(TEST_MANAGEMENT_ATTEMPT_TO_FIX_PASSED, 'false')
         }
 
         this.taskToFinishTime.set(task, span._getTime())
@@ -186,7 +188,14 @@ class VitestPlugin extends CiPlugin {
       }
     })
 
-    this.addSub('ci:vitest:test:error', ({ duration, error, shouldSetProbe, promises, hasFailedAllRetries }) => {
+    this.addSub('ci:vitest:test:error', ({
+      duration,
+      error,
+      shouldSetProbe,
+      promises,
+      hasFailedAllRetries,
+      attemptToFixFailed
+    }) => {
       const store = storage('legacy').getStore()
       const span = store?.span
 
@@ -211,6 +220,9 @@ class VitestPlugin extends CiPlugin {
         if (hasFailedAllRetries) {
           span.setTag(TEST_HAS_FAILED_ALL_RETRIES, 'true')
         }
+        if (attemptToFixFailed) {
+          span.setTag(TEST_MANAGEMENT_ATTEMPT_TO_FIX_PASSED, 'false')
+        }
         if (duration) {
           span.finish(span._startTime + duration - MILLISECONDS_TO_SUBTRACT_FROM_FAILED_TEST_DURATION) // milliseconds
         } else {
@@ -337,7 +349,7 @@ class VitestPlugin extends CiPlugin {
         this.testModuleSpan.setTag('error', error)
         this.testSessionSpan.setTag('error', error)
       }
-      if (testCodeCoverageLinesTotal) {
+      if (testCodeCoverageLinesTotal !== undefined) {
         this.testModuleSpan.setTag(TEST_CODE_COVERAGE_LINES_PCT, testCodeCoverageLinesTotal)
         this.testSessionSpan.setTag(TEST_CODE_COVERAGE_LINES_PCT, testCodeCoverageLinesTotal)
       }

package/packages/dd-trace/src/appsec/api_security_sampler.js

@@ -4,10 +4,13 @@ const TTLCache = require('@isaacs/ttlcache')
 const web = require('../plugins/util/web')
 const log = require('../log')
 const { AUTO_REJECT, USER_REJECT } = require('../../../../ext/priority')
+const { keepTrace } = require('../priority_sampler')
+const { ASM } = require('../standalone/product')
 
 const MAX_SIZE = 4096
 
 let enabled
+let asmStandaloneEnabled
 
 /**
  * @type {TTLCache}
@@ -20,11 +23,12 @@ class NoopTTLCache {
   has (_key) { return false }
 }
 
-function configure ({ apiSecurity }) {
-  enabled = apiSecurity.enabled
-  sampledRequests = apiSecurity.sampleDelay === 0
+function configure ({ appsec, apmTracingEnabled }) {
+  enabled = appsec.apiSecurity.enabled
+  asmStandaloneEnabled = apmTracingEnabled === false
+  sampledRequests = appsec.apiSecurity.sampleDelay === 0
     ? new NoopTTLCache()
-    : new TTLCache({ max: MAX_SIZE, ttl: apiSecurity.sampleDelay * 1000 })
+    : new TTLCache({ max: MAX_SIZE, ttl: appsec.apiSecurity.sampleDelay * 1000 })
 }
 
 function disable () {
@@ -41,14 +45,18 @@ function sampleRequest (req, res, force = false) {
   const rootSpan = web.root(req)
   if (!rootSpan) return false
 
-  let priority = getSpanPriority(rootSpan)
-  if (!priority) {
-    rootSpan._prioritySampler?.sample(rootSpan)
-    priority = getSpanPriority(rootSpan)
-  }
-
-  if (priority === AUTO_REJECT || priority === USER_REJECT) {
-    return false
+  if (asmStandaloneEnabled) {
+    keepTrace(rootSpan, ASM)
+  } else {
+    let priority = getSpanPriority(rootSpan)
+    if (!priority) {
+      rootSpan._prioritySampler?.sample(rootSpan)
+      priority = getSpanPriority(rootSpan)
+    }
+
+    if (priority === AUTO_REJECT || priority === USER_REJECT) {
+      return false
+    }
   }
 
   if (force) {

package/packages/dd-trace/src/appsec/iast/taint-tracking/rewriter.js

@@ -19,9 +19,11 @@ let config
 const hardcodedSecretCh = dc.channel('datadog:secrets:result')
 let rewriter
 let unwrapCompile = () => {}
-let getPrepareStackTrace, cacheRewrittenSourceMap
+let getPrepareStackTrace
+let cacheRewrittenSourceMap
 let kSymbolPrepareStackTrace
-let esmRewriterEnabled = false
+
+function noop () {}
 
 function isFlagPresent (flag) {
   return process.env.NODE_OPTIONS?.includes(flag) ||
@@ -155,7 +157,7 @@ function shimPrepareStackTrace () {
     return
   }
   const pstDescriptor = Object.getOwnPropertyDescriptor(global.Error, 'prepareStackTrace')
-  if (!pstDescriptor || pstDescriptor.configurable) {
+  if (pstDescriptor?.configurable || pstDescriptor?.writable) {
     Object.defineProperty(global.Error, 'prepareStackTrace', getPrepareStackTraceAccessor())
   }
   shimmedPrepareStackTrace = true
@@ -181,16 +183,17 @@ function isEsmConfigured () {
   const hasLoaderArg = isFlagPresent('--loader') || isFlagPresent('--experimental-loader')
   if (hasLoaderArg) return true
 
-  const initializeLoaded = Object.keys(require.cache).find(file => file.includes('import-in-the-middle/hook.js'))
-  return !!initializeLoaded
+  // Fast path for common case when enabled
+  if (require.cache[`${process.cwd()}/node_modules/import-in-the-middle/hook.js`]) {
+    return true
+  }
+  return Object.keys(require.cache).some(file => file.endsWith('import-in-the-middle/hook.js'))
 }
 
-function enableEsmRewriter (telemetryVerbosity) {
-  if (isMainThread && Module.register && !esmRewriterEnabled && isEsmConfigured()) {
+let enableEsmRewriter = function (telemetryVerbosity) {
+  if (isMainThread && Module.register && isEsmConfigured()) {
     shimPrepareStackTrace()
 
-    esmRewriterEnabled = true
-
     const { port1, port2 } = new MessageChannel()
 
     port1.on('message', (message) => {
@@ -229,6 +232,8 @@ function enableEsmRewriter (telemetryVerbosity) {
     }
 
     cacheRewrittenSourceMap = require('@datadog/wasm-js-rewriter/js/source-map').cacheRewrittenSourceMap
+
+    enableEsmRewriter = noop
   }
 }
 

package/packages/dd-trace/src/appsec/index.js

@@ -59,7 +59,7 @@ function enable (_config) {
 
     Reporter.setRateLimit(_config.appsec.rateLimit)
 
-    apiSecuritySampler.configure(_config.appsec)
+    apiSecuritySampler.configure(_config)
 
     UserTracking.setCollectionMode(_config.appsec.eventTracking.mode, false)
 

package/packages/dd-trace/src/baggage.js

@@ -0,0 +1,36 @@
+'use strict'
+
+const { storage } = require('../../datadog-core')
+const baggageStorage = storage('baggage')
+
+function setBaggageItem (key, value) {
+  storage('baggage').enterWith({ ...baggageStorage.getStore(), [key]: value })
+  return storage('baggage').getStore()
+}
+
+function getBaggageItem (key) {
+  return storage('baggage').getStore()?.[key]
+}
+
+function getAllBaggageItems () {
+  return storage('baggage').getStore()
+}
+
+function removeBaggageItem (keyToRemove) {
+  const { [keyToRemove]: _, ...newBaggage } = storage('baggage').getStore()
+  storage('baggage').enterWith(newBaggage)
+  return newBaggage
+}
+
+function removeAllBaggageItems () {
+  storage('baggage').enterWith({})
+  return storage('baggage').getStore()
+}
+
+module.exports = {
+  setBaggageItem,
+  getBaggageItem,
+  getAllBaggageItems,
+  removeBaggageItem,
+  removeAllBaggageItems
+}

package/packages/dd-trace/src/ci-visibility/test-management/get-test-management-tests.js

@@ -7,7 +7,8 @@ function getTestManagementTests ({
   evpProxyPrefix,
   isGzipCompatible,
   repositoryUrl,
-  commitMessage
+  commitMessage,
+  sha
 }, done) {
   const options = {
     path: '/api/v2/test/libraries/test-management/tests',
@@ -41,7 +42,8 @@ function getTestManagementTests ({
       type: 'ci_app_libraries_tests_request',
       attributes: {
         repository_url: repositoryUrl,
-        commit_message: commitMessage
+        commit_message: commitMessage,
+        sha
       }
     }
   })

package/packages/dd-trace/src/config.js

@@ -481,7 +481,8 @@ class Config {
     this._setValue(defaults, 'clientIpEnabled', false)
     this._setValue(defaults, 'clientIpHeader', null)
     this._setValue(defaults, 'crashtracking.enabled', true)
-    this._setValue(defaults, 'codeOriginForSpans.enabled', false)
+    this._setValue(defaults, 'codeOriginForSpans.enabled', true)
+    this._setValue(defaults, 'codeOriginForSpans.experimental.exit_spans.enabled', false)
     this._setValue(defaults, 'dbmPropagationMode', 'disabled')
     this._setValue(defaults, 'dogstatsd.hostname', '127.0.0.1')
     this._setValue(defaults, 'dogstatsd.port', '8125')
@@ -660,6 +661,7 @@ class Config {
       DD_APPSEC_WAF_TIMEOUT,
       DD_CRASHTRACKING_ENABLED,
       DD_CODE_ORIGIN_FOR_SPANS_ENABLED,
+      DD_CODE_ORIGIN_FOR_SPANS_EXPERIMENTAL_EXIT_SPANS_ENABLED,
       DD_DATA_STREAMS_ENABLED,
       DD_DBM_PROPAGATION_MODE,
       DD_DOGSTATSD_HOSTNAME,
@@ -825,6 +827,11 @@ class Config {
       !this._isInServerlessEnvironment()
     ))
     this._setBoolean(env, 'codeOriginForSpans.enabled', DD_CODE_ORIGIN_FOR_SPANS_ENABLED)
+    this._setBoolean(
+      env,
+      'codeOriginForSpans.experimental.exit_spans.enabled',
+      DD_CODE_ORIGIN_FOR_SPANS_EXPERIMENTAL_EXIT_SPANS_ENABLED
+    )
     this._setString(env, 'dbmPropagationMode', DD_DBM_PROPAGATION_MODE)
     this._setString(env, 'dogstatsd.hostname', DD_DOGSTATSD_HOST || DD_DOGSTATSD_HOSTNAME)
     this._setString(env, 'dogstatsd.port', DD_DOGSTATSD_PORT)
@@ -1029,6 +1036,11 @@ class Config {
     this._setValue(opts, 'baggageMaxBytes', options.baggageMaxBytes)
     this._setValue(opts, 'baggageMaxItems', options.baggageMaxItems)
     this._setBoolean(opts, 'codeOriginForSpans.enabled', options.codeOriginForSpans?.enabled)
+    this._setBoolean(
+      opts,
+      'codeOriginForSpans.experimental.exit_spans.enabled',
+      options.codeOriginForSpans?.experimental?.exit_spans?.enabled
+    )
     this._setString(opts, 'dbmPropagationMode', options.dbmPropagationMode)
     if (options.dogstatsd) {
       this._setString(opts, 'dogstatsd.hostname', options.dogstatsd.hostname)

package/packages/dd-trace/src/debugger/devtools_client/breakpoints.js

@@ -175,11 +175,13 @@ async function updateBreakpoint (breakpoint, probe) {
 
 function start () {
   sessionStarted = true
+  log.debug('[debugger:devtools_client] Starting debugger')
   return session.post('Debugger.enable')
 }
 
 function stop () {
   sessionStarted = false
+  log.debug('[debugger:devtools_client] Stopping debugger')
   return session.post('Debugger.disable')
 }
 

package/packages/dd-trace/src/debugger/devtools_client/state.js

@@ -88,7 +88,7 @@ module.exports = {
       }
     }
 
-    return maxMatchLength > -1 ? bestMatch : null
+    return maxMatchLength !== -1 ? bestMatch : null
   },
 
   getStackFromCallFrames (callFrames) {