dd-trace 3.19.0 → 3.21.0

package/packages/dd-trace/src/plugins/util/ci.js

@@ -20,7 +20,9 @@ const {
   CI_STAGE_NAME,
   CI_ENV_VARS,
   GIT_COMMIT_COMMITTER_NAME,
-  GIT_COMMIT_COMMITTER_EMAIL
+  GIT_COMMIT_COMMITTER_EMAIL,
+  CI_NODE_LABELS,
+  CI_NODE_NAME
 } = require('./tags')
 
 // Receives a string with the form 'John Doe <john.doe@gmail.com>'
@@ -108,7 +110,9 @@ module.exports = {
         GIT_COMMIT: JENKINS_GIT_COMMIT,
         GIT_URL: JENKINS_GIT_REPOSITORY_URL,
         GIT_URL_1: JENKINS_GIT_REPOSITORY_URL_1,
-        DD_CUSTOM_TRACE_ID
+        DD_CUSTOM_TRACE_ID,
+        NODE_NAME,
+        NODE_LABELS
       } = env
 
       tags = {
@@ -119,7 +123,18 @@ module.exports = {
         [GIT_COMMIT_SHA]: JENKINS_GIT_COMMIT,
         [GIT_REPOSITORY_URL]: JENKINS_GIT_REPOSITORY_URL || JENKINS_GIT_REPOSITORY_URL_1,
         [CI_WORKSPACE_PATH]: WORKSPACE,
-        [CI_ENV_VARS]: JSON.stringify({ DD_CUSTOM_TRACE_ID })
+        [CI_ENV_VARS]: JSON.stringify({ DD_CUSTOM_TRACE_ID }),
+        [CI_NODE_NAME]: NODE_NAME
+      }
+
+      if (NODE_LABELS) {
+        let nodeLabels
+        try {
+          nodeLabels = JSON.stringify(NODE_LABELS.split(' '))
+          tags[CI_NODE_LABELS] = nodeLabels
+        } catch (e) {
+          // ignore errors
+        }
       }
 
       const isTag = JENKINS_GIT_BRANCH && JENKINS_GIT_BRANCH.includes('tags/')
@@ -159,7 +174,9 @@ module.exports = {
         CI_COMMIT_TIMESTAMP,
         CI_COMMIT_AUTHOR,
         CI_PROJECT_URL: GITLAB_PROJECT_URL,
-        CI_JOB_ID: GITLAB_CI_JOB_ID
+        CI_JOB_ID: GITLAB_CI_JOB_ID,
+        CI_RUNNER_ID,
+        CI_RUNNER_TAGS
       } = env
 
       const { name, email } = parseEmailAndName(CI_COMMIT_AUTHOR)
@@ -186,7 +203,9 @@ module.exports = {
           CI_PROJECT_URL: GITLAB_PROJECT_URL,
           CI_PIPELINE_ID: GITLAB_PIPELINE_ID,
           CI_JOB_ID: GITLAB_CI_JOB_ID
-        })
+        }),
+        [CI_NODE_LABELS]: CI_RUNNER_TAGS,
+        [CI_NODE_NAME]: CI_RUNNER_ID
       }
     }
 
@@ -448,9 +467,17 @@ module.exports = {
         BUILDKITE_BUILD_CHECKOUT_PATH,
         BUILDKITE_BUILD_AUTHOR,
         BUILDKITE_BUILD_AUTHOR_EMAIL,
-        BUILDKITE_MESSAGE
+        BUILDKITE_MESSAGE,
+        BUILDKITE_AGENT_ID
       } = env
 
+      const extraTags = Object.keys(env).filter(envVar =>
+        envVar.startsWith('BUILDKITE_AGENT_META_DATA_')
+      ).map((metadataKey) => {
+        const key = metadataKey.replace('BUILDKITE_AGENT_META_DATA_', '').toLowerCase()
+        return `${key}:${env[metadataKey]}`
+      })
+
       tags = {
         [CI_PROVIDER_NAME]: 'buildkite',
         [CI_PIPELINE_ID]: BUILDKITE_BUILD_ID,
@@ -469,7 +496,9 @@ module.exports = {
         [CI_ENV_VARS]: JSON.stringify({
           BUILDKITE_BUILD_ID,
           BUILDKITE_JOB_ID
-        })
+        }),
+        [CI_NODE_NAME]: BUILDKITE_AGENT_ID,
+        [CI_NODE_LABELS]: JSON.stringify(extraTags)
       }
     }
 
@@ -546,6 +575,32 @@ module.exports = {
       }
     }
 
+    if (env.CF_BUILD_ID) {
+      const {
+        CF_BUILD_ID,
+        CF_PIPELINE_NAME,
+        CF_BUILD_URL,
+        CF_STEP_NAME,
+        CF_BRANCH
+      } = env
+      tags = {
+        [CI_PROVIDER_NAME]: 'codefresh',
+        [CI_PIPELINE_ID]: CF_BUILD_ID,
+        [CI_PIPELINE_NAME]: CF_PIPELINE_NAME,
+        [CI_PIPELINE_URL]: CF_BUILD_URL,
+        [CI_JOB_NAME]: CF_STEP_NAME,
+        [CI_ENV_VARS]: JSON.stringify({
+          CF_BUILD_ID
+        })
+      }
+
+      const isTag = CF_BRANCH && CF_BRANCH.includes('tags/')
+      const refKey = isTag ? GIT_TAG : GIT_BRANCH
+      const ref = normalizeRef(CF_BRANCH)
+
+      tags[refKey] = ref
+    }
+
     normalizeTag(tags, CI_WORKSPACE_PATH, resolveTilde)
     normalizeTag(tags, GIT_REPOSITORY_URL, filterSensitiveInfoFromRepository)
     normalizeTag(tags, GIT_BRANCH, normalizeRef)

package/packages/dd-trace/src/plugins/util/tags.js

@@ -19,6 +19,8 @@ const CI_WORKSPACE_PATH = 'ci.workspace_path'
 const CI_JOB_URL = 'ci.job.url'
 const CI_JOB_NAME = 'ci.job.name'
 const CI_STAGE_NAME = 'ci.stage.name'
+const CI_NODE_NAME = 'ci.node.name'
+const CI_NODE_LABELS = 'ci.node.labels'
 
 const CI_ENV_VARS = '_dd.ci.env_vars'
 
@@ -43,5 +45,7 @@ module.exports = {
   CI_JOB_URL,
   CI_JOB_NAME,
   CI_STAGE_NAME,
-  CI_ENV_VARS
+  CI_ENV_VARS,
+  CI_NODE_NAME,
+  CI_NODE_LABELS
 }

package/packages/dd-trace/src/plugins/util/test.js

@@ -50,12 +50,10 @@ const CI_APP_ORIGIN = 'ciapp-test'
 const JEST_TEST_RUNNER = 'test.jest.test_runner'
 
 const TEST_ITR_TESTS_SKIPPED = '_dd.ci.itr.tests_skipped'
-const TEST_SESSION_ITR_SKIPPING_ENABLED = 'test_session.itr.tests_skipping.enabled'
-const TEST_SESSION_CODE_COVERAGE_ENABLED = 'test_session.code_coverage.enabled'
-const TEST_MODULE_ITR_SKIPPING_ENABLED = 'test_module.itr.tests_skipping.enabled'
-const TEST_MODULE_CODE_COVERAGE_ENABLED = 'test_module.code_coverage.enabled'
+const TEST_ITR_SKIPPING_ENABLED = 'test.itr.tests_skipping.enabled'
+const TEST_CODE_COVERAGE_ENABLED = 'test.code_coverage.enabled'
 
-const TEST_CODE_COVERAGE_LINES_TOTAL = 'test.codecov_lines_total'
+const TEST_CODE_COVERAGE_LINES_PCT = 'test.code_coverage.lines_pct'
 
 // jest worker variables
 const JEST_WORKER_TRACE_PAYLOAD_CODE = 60
@@ -97,17 +95,16 @@ module.exports = {
   TEST_SUITE_ID,
   TEST_ITR_TESTS_SKIPPED,
   TEST_MODULE,
-  TEST_SESSION_ITR_SKIPPING_ENABLED,
-  TEST_SESSION_CODE_COVERAGE_ENABLED,
-  TEST_MODULE_ITR_SKIPPING_ENABLED,
-  TEST_MODULE_CODE_COVERAGE_ENABLED,
-  TEST_CODE_COVERAGE_LINES_TOTAL,
+  TEST_ITR_SKIPPING_ENABLED,
+  TEST_CODE_COVERAGE_ENABLED,
+  TEST_CODE_COVERAGE_LINES_PCT,
   addIntelligentTestRunnerSpanTags,
   getCoveredFilenamesFromCoverage,
   resetCoverage,
   mergeCoverage,
   fromCoverageMapToCoverage,
-  getTestLineStart
+  getTestLineStart,
+  getCallSites
 }
 
 // Returns pkg manager and its version, separated by '-', e.g. npm-8.15.0 or yarn-1.22.19
@@ -316,17 +313,17 @@ function addIntelligentTestRunnerSpanTags (
   { isSuitesSkipped, isSuitesSkippingEnabled, isCodeCoverageEnabled, testCodeCoverageLinesTotal }
 ) {
   testSessionSpan.setTag(TEST_ITR_TESTS_SKIPPED, isSuitesSkipped ? 'true' : 'false')
-  testSessionSpan.setTag(TEST_SESSION_ITR_SKIPPING_ENABLED, isSuitesSkippingEnabled ? 'true' : 'false')
-  testSessionSpan.setTag(TEST_SESSION_CODE_COVERAGE_ENABLED, isCodeCoverageEnabled ? 'true' : 'false')
+  testSessionSpan.setTag(TEST_ITR_SKIPPING_ENABLED, isSuitesSkippingEnabled ? 'true' : 'false')
+  testSessionSpan.setTag(TEST_CODE_COVERAGE_ENABLED, isCodeCoverageEnabled ? 'true' : 'false')
 
   testModuleSpan.setTag(TEST_ITR_TESTS_SKIPPED, isSuitesSkipped ? 'true' : 'false')
-  testModuleSpan.setTag(TEST_MODULE_ITR_SKIPPING_ENABLED, isSuitesSkippingEnabled ? 'true' : 'false')
-  testModuleSpan.setTag(TEST_MODULE_CODE_COVERAGE_ENABLED, isCodeCoverageEnabled ? 'true' : 'false')
+  testModuleSpan.setTag(TEST_ITR_SKIPPING_ENABLED, isSuitesSkippingEnabled ? 'true' : 'false')
+  testModuleSpan.setTag(TEST_CODE_COVERAGE_ENABLED, isCodeCoverageEnabled ? 'true' : 'false')
 
   // If suites have been skipped we don't want to report the total coverage, as it will be wrong
   if (testCodeCoverageLinesTotal !== undefined && !isSuitesSkipped) {
-    testSessionSpan.setTag(TEST_CODE_COVERAGE_LINES_TOTAL, testCodeCoverageLinesTotal)
-    testModuleSpan.setTag(TEST_CODE_COVERAGE_LINES_TOTAL, testCodeCoverageLinesTotal)
+    testSessionSpan.setTag(TEST_CODE_COVERAGE_LINES_PCT, testCodeCoverageLinesTotal)
+    testModuleSpan.setTag(TEST_CODE_COVERAGE_LINES_PCT, testCodeCoverageLinesTotal)
   }
 }
 
@@ -399,3 +396,23 @@ function getTestLineStart (err, testSuitePath) {
     return null
   }
 }
+
+// From https://github.com/felixge/node-stack-trace/blob/ba06dcdb50d465cd440d84a563836e293b360427/index.js#L1
+function getCallSites () {
+  const oldLimit = Error.stackTraceLimit
+  Error.stackTraceLimit = Infinity
+
+  const dummy = {}
+
+  const v8Handler = Error.prepareStackTrace
+  Error.prepareStackTrace = function (_, v8StackTrace) {
+    return v8StackTrace
+  }
+  Error.captureStackTrace(dummy)
+
+  const v8StackTrace = dummy.stack
+  Error.prepareStackTrace = v8Handler
+  Error.stackTraceLimit = oldLimit
+
+  return v8StackTrace
+}

package/packages/dd-trace/src/profiling/constants.js

@@ -9,7 +9,6 @@ const snapshotKinds = Object.freeze({
 const oomExportStrategies = Object.freeze({
   PROCESS: 'process',
   ASYNC_CALLBACK: 'async',
-  INTERRUPT_CALLBACK: 'interrupt',
   LOGS: 'logs'
 })
 

package/packages/dd-trace/src/profiling/profilers/space.js

@@ -3,9 +3,7 @@
 const { oomExportStrategies } = require('../constants')
 
 function strategiesToCallbackMode (strategies, callbackMode) {
-  const hasInterrupt = strategies.includes(oomExportStrategies.INTERRUPT_CALLBACK) ? callbackMode.Interrupt : 0
-  const hasCallback = strategies.includes(oomExportStrategies.ASYNC_CALLBACK) ? callbackMode.Async : 0
-  return hasInterrupt | hasCallback
+  return strategies.includes(oomExportStrategies.ASYNC_CALLBACK) ? callbackMode.Async : 0
 }
 
 class NativeSpaceProfiler {

package/packages/dd-trace/src/proxy.js

@@ -30,6 +30,10 @@ class Tracer extends NoopProxy {
         remoteConfig.enable(config)
       }
 
+      if (config.isGCPFunction) {
+        require('./serverless').maybeStartServerlessMiniAgent()
+      }
+
       if (config.profiling.enabled) {
         // do not stop tracer initialization if the profiler fails to be imported
         try {

package/packages/dd-trace/src/serverless.js

@@ -0,0 +1,25 @@
+'use strict'
+
+function maybeStartServerlessMiniAgent () {
+  let rustBinaryPath =
+    '/workspace/node_modules/@datadog/sma/datadog-serverless-agent-linux-amd64/datadog-serverless-trace-mini-agent'
+  if (process.env.DD_MINI_AGENT_PATH !== undefined) {
+    rustBinaryPath = process.env.DD_MINI_AGENT_PATH
+  }
+  const log = require('./log')
+  const fs = require('fs')
+
+  // trying to spawn with an invalid path will return a non-descriptive error, so we want to catch
+  // invalid paths and log our own error.
+  if (!fs.existsSync(rustBinaryPath)) {
+    log.error('Serverless Mini Agent did not start. Could not find mini agent binary.')
+    return
+  }
+  try {
+    require('child_process').spawn(rustBinaryPath, { stdio: 'inherit' })
+  } catch (err) {
+    log.error(`Error spawning mini agent process: ${err}`)
+  }
+}
+
+module.exports = { maybeStartServerlessMiniAgent }

package/packages/dd-trace/src/span_processor.js

@@ -3,6 +3,7 @@
 const log = require('./log')
 const format = require('./format')
 const SpanSampler = require('./span_sampler')
+const GitMetadataTagger = require('./git_metadata_tagger')
 
 const { SpanStatsProcessor } = require('./span_stats')
 
@@ -18,6 +19,7 @@ class SpanProcessor {
 
     this._stats = new SpanStatsProcessor(config)
     this._spanSampler = new SpanSampler(config.sampler)
+    this._gitMetadataTagger = new GitMetadataTagger(config)
   }
 
   process (span) {
@@ -32,6 +34,7 @@ class SpanProcessor {
     if (started.length === finished.length || finished.length >= flushMinSpans) {
       this._prioritySampler.sample(spanContext)
       this._spanSampler.sample(spanContext)
+      this._gitMetadataTagger.tagGitMetadata(spanContext)
 
       for (const span of started) {
         if (span._duration !== undefined) {

package/packages/dd-trace/src/telemetry/send-data.js

@@ -1,5 +1,17 @@
 const request = require('../exporters/common/request')
 let seqId = 0
+
+function getPayload (payload) {
+  // Some telemetry endpoints payloads accept collections of elements such as the 'logs' endpoint.
+  // 'logs' request type payload is meant to send library logs to Datadog’s backend.
+  if (Array.isArray(payload)) {
+    return payload
+  } else {
+    const { logger, tags, serviceMapping, ...trimmedPayload } = payload
+    return trimmedPayload
+  }
+}
+
 function sendData (config, application, host, reqType, payload = {}) {
   const {
     hostname,
@@ -7,8 +19,6 @@ function sendData (config, application, host, reqType, payload = {}) {
     url
   } = config
 
-  const { logger, tags, serviceMapping, ...trimmedPayload } = payload
-
   const options = {
     url,
     hostname,
@@ -27,7 +37,7 @@ function sendData (config, application, host, reqType, payload = {}) {
     tracer_time: Math.floor(Date.now() / 1000),
     runtime_id: config.tags['runtime-id'],
     seq_id: ++seqId,
-    payload: trimmedPayload,
+    payload: getPayload(payload),
     application,
     host
   })

package/packages/dd-trace/src/tracer.js

@@ -7,6 +7,7 @@ const { storage } = require('../../datadog-core')
 const { isError } = require('./util')
 const { setStartupLogConfig } = require('./startup-log')
 const { ERROR_MESSAGE, ERROR_TYPE, ERROR_STACK } = require('../../dd-trace/src/constants')
+const { MAJOR } = require('../../../version')
 
 const SPAN_TYPE = tags.SPAN_TYPE
 const RESOURCE_NAME = tags.RESOURCE_NAME
@@ -26,7 +27,7 @@ class DatadogTracer extends Tracer {
       childOf: this.scope().active()
     }, options)
 
-    if (!options.childOf && options.orphanable === false) {
+    if (!options.childOf && options.orphanable === false && MAJOR < 4) {
       return fn(null, () => {})
     }
 
@@ -81,7 +82,7 @@ class DatadogTracer extends Tracer {
         optionsObj = optionsObj.apply(this, arguments)
       }
 
-      if (optionsObj && optionsObj.orphanable === false && !tracer.scope().active()) {
+      if (optionsObj && optionsObj.orphanable === false && !tracer.scope().active() && MAJOR < 4) {
         return fn.apply(this, arguments)
       }
 

package/version.js

@@ -0,0 +1,9 @@
+'use strict'
+
+const matches = require('./package.json').version.match(/^(\d+)\.(\d+)\.(\d+)/)
+
+module.exports = {
+  MAJOR: parseInt(matches[1]),
+  MINOR: parseInt(matches[2]),
+  PATCH: parseInt(matches[3])
+}

package/packages/dd-trace/src/plugins/inbound.js

@@ -1,7 +0,0 @@
-'use strict'
-
-const TracingPlugin = require('./tracing')
-
-class InboundPlugin extends TracingPlugin {}
-
-module.exports = InboundPlugin

package/packages/dd-trace/src/service-naming/index.js

@@ -1,41 +0,0 @@
-const { schemaDefinitions } = require('./schemas')
-
-const kindMap = {
-  messaging: {
-    client: 'controlPlane',
-    consumer: 'inbound',
-    producer: 'outbound'
-  }
-}
-
-class SchemaManager {
-  constructor () {
-    this.schemas = schemaDefinitions
-    this.config = { spanAttributeSchema: 'v0' }
-  }
-
-  get schema () {
-    return this.schemas[this.version]
-  }
-
-  get version () {
-    return this.config.spanAttributeSchema
-  }
-
-  opName (type, kind, plugin, opNameArgs) {
-    return this.schema.getOpName(type, kindMap[type][kind], plugin, opNameArgs)
-  }
-
-  serviceName (type, kind, plugin, serviceNameArgs) {
-    return this.schema.getServiceName(type, kindMap[type][kind], plugin, serviceNameArgs)
-  }
-
-  configure (config = {}) {
-    this.config = config
-    Object.values(this.schemas).forEach(schemaDef => {
-      schemaDef.configure(config)
-    })
-  }
-}
-
-module.exports = new SchemaManager()

package/packages/dd-trace/src/service-naming/schemas/definition.js

@@ -1,28 +0,0 @@
-class SchemaDefinition {
-  constructor (schema) {
-    this.schema = schema
-  }
-
-  getSchemaItem (type, subType, plugin) {
-    const schema = this.schema
-    if (schema && schema[type] && schema[type][subType] && schema[type][subType][plugin]) {
-      return schema[type][subType][plugin]
-    }
-  }
-
-  getOpName (type, subType, plugin, opNameArgs) {
-    const item = this.getSchemaItem(type, subType, plugin)
-    return item.opName(opNameArgs)
-  }
-
-  getServiceName (type, subType, plugin, serviceNameArgs) {
-    const item = this.getSchemaItem(type, subType, plugin)
-    return item.serviceName(this.service, serviceNameArgs)
-  }
-
-  configure ({ service }) {
-    this.service = service
-  }
-}
-
-module.exports = SchemaDefinition

package/packages/dd-trace/src/service-naming/schemas/index.js

@@ -1,6 +0,0 @@
-const v0 = require('./v0')
-const v1 = require('./v1')
-
-module.exports = {
-  schemaDefinitions: { v0, v1 }
-}

package/packages/dd-trace/src/service-naming/schemas/v0.js

@@ -1,66 +0,0 @@
-const SchemaDefinition = require('./definition')
-
-function amqpServiceName (service) {
-  return `${service}-amqp`
-}
-
-const schema = {
-  messaging: {
-    outbound: {
-      amqplib: {
-        opName: () => 'amqp.command',
-        serviceName: amqpServiceName
-      },
-      amqp10: {
-        opName: () => 'amqp.send',
-        serviceName: amqpServiceName
-      },
-      'google-cloud-pubsub': {
-        opName: () => 'pubsub.request',
-        serviceName: service => `${service}-pubsub`
-      },
-      kafkajs: {
-        opName: () => 'kafka.produce',
-        serviceName: service => `${service}-kafka`
-      },
-      rhea: {
-        opName: () => 'amqp.send',
-        serviceName: service => `${service}-amqp-producer`
-      }
-    },
-    inbound: {
-      amqplib: {
-        opName: () => 'amqp.command',
-        serviceName: amqpServiceName
-      },
-      amqp10: {
-        opName: () => 'amqp.receive',
-        serviceName: amqpServiceName
-      },
-      'google-cloud-pubsub': {
-        opName: () => 'pubsub.receive',
-        serviceName: service => service
-      },
-      kafkajs: {
-        opName: () => 'kafka.consume',
-        serviceName: service => `${service}-kafka`
-      },
-      rhea: {
-        opName: () => 'amqp.receive',
-        serviceName: service => service
-      }
-    },
-    controlPlane: {
-      amqplib: {
-        opName: () => 'amqp.command',
-        serviceName: amqpServiceName
-      },
-      'google-cloud-pubsub': {
-        opName: () => 'pubsub.request',
-        serviceName: service => `${service}-pubsub`
-      }
-    }
-  }
-}
-
-module.exports = new SchemaDefinition(schema)

package/packages/dd-trace/src/service-naming/schemas/v1.js

@@ -1,58 +0,0 @@
-const SchemaDefinition = require('./definition')
-
-function identityService (service) {
-  return service
-}
-
-const amqpInbound = {
-  opName: () => 'amqp.process',
-  serviceName: identityService
-}
-
-const amqpOutbound = {
-  opName: () => 'amqp.send',
-  serviceName: identityService
-}
-
-const schema = {
-  messaging: {
-    outbound: {
-      amqplib: amqpOutbound,
-      amqp10: amqpOutbound,
-      'google-cloud-pubsub': {
-        opName: () => 'gcp.pubsub.send',
-        serviceName: identityService
-      },
-      kafkajs: {
-        opName: () => 'kafka.send',
-        serviceName: identityService
-      },
-      rhea: amqpOutbound
-    },
-    inbound: {
-      amqplib: amqpInbound,
-      amqp10: amqpInbound,
-      'google-cloud-pubsub': {
-        opName: () => 'gcp.pubsub.process',
-        serviceName: identityService
-      },
-      kafkajs: {
-        opName: () => 'kafka.process',
-        serviceName: identityService
-      },
-      rhea: amqpInbound
-    },
-    controlPlane: {
-      amqplib: {
-        opName: () => 'amqp.command',
-        serviceName: identityService
-      },
-      'google-cloud-pubsub': {
-        opName: () => 'gcp.pubsub.request',
-        serviceName: identityService
-      }
-    }
-  }
-}
-
-module.exports = new SchemaDefinition(schema)